Commit graph

33304 commits

Author SHA1 Message Date
Kevin Millikin e99fb4fc26 dart2js: Use the NoInline annotation on getInterceptor in the JS runtime.
This also requires fixing NoInline to work for the JS runtime.
Previously it was ignored.

R=karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//1315083002 .
2015-08-26 10:56:14 +02:00
William Hesse 4c8049780c Switch dartium.deps to use the googlesource.com mirror of github/dart-lang repos.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1308403006 .
2015-08-26 10:32:17 +02:00
Daniel Andersson cab0033667 Add safepointing to the GC
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//1292353004 .
2015-08-25 18:20:27 -07:00
Stephen Adams 6f197ac7ff cps_ir can't handle resource_http_test
TBR=het@google.com

Review URL: https://codereview.chromium.org//1313883005 .
2015-08-25 18:03:39 -07:00
Siva Annamalai 84a3560d0e Add '*.intermediate' to .gitignore
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1304413005 .
2015-08-25 15:58:19 -07:00
Regis Crelier a799659bcf Use correct scope to lookup saved async context variable.
Stop inserting aliases in all intermediary scopes for explicitly captured
variables.
Use proper lookup function in async code to access async completer variable.
Add asserts verifying async variables existence.

R=hausner@google.com

Review URL: https://codereview.chromium.org//1314993002 .
2015-08-25 15:46:17 -07:00
Daniel Andersson 44d4d84be8 On Windows, set current thread in TLS to NULL before deleting the thread.
This mimics the behavior of the pthreads destructor protocol:
"At thread exit, if a key value has a non-NULL destructor pointer, and the thread has a non-NULL value associated with that key, the value of the key is set to NULL, and then the function pointed to is called with the previously associated value as its sole argument."

BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//1309563004 .
2015-08-25 15:34:52 -07:00
Regis Crelier e9614a6308 Add missing support in disassembler for recently introduced new variable
decriptor kind.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1316813002 .
2015-08-25 14:57:55 -07:00
Srdjan Mitrovic 5985718945 Clean up default parameter computation in parser
BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1316763002 .
2015-08-25 14:54:48 -07:00
Siva Annamalai 810823f8d5 Use the zone in ApiNativeScope for allocating objects in the ApiMessageReader instead of passing in an allocator.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1319583003 .
2015-08-25 14:48:41 -07:00
Harry Terkelsen 1bdd43c233 Disable resource_http_test in Dartium and DRT
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//1315643003 .
2015-08-25 14:39:49 -07:00
Paul Berry 9d6898104e Fix warning in element_handle.dart.
Commit 4bd6b4b048 added the abstract
method appendToWithoutDelimiters() to ParameterElement, which is
implemented in ParameterElementMixin.  However, one derived class was
not updated to make use of the new mixin: ParameterElementHandle.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1308713004 .
2015-08-25 13:27:25 -07:00
Todd Turnidge d6060d2ddd Don't allow variables to overwrite the frame edge.
Make the variables demand a bit more room in general.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1307323003 .
2015-08-25 12:52:16 -07:00
Stan Manilov fe402c50ea sdk/dartanalyzer now detects an available build
Similar to CL 1276333002; this allows the dartanalyzer script to pick an
available build, rather than failing if ReleaseIA32 is not available.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1314893003 .
2015-08-25 20:48:14 +02:00
Brian Wilkerson 271bc1f776 Convert completion API to be future based
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1318543002 .
2015-08-25 11:01:13 -07:00
Harry Terkelsen bc0deb66d7 dart2js: fetch http Resources
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1308143002 .
2015-08-25 10:46:27 -07:00
Brian Wilkerson 4bd6b4b048 Fix display of parameter lists in servers Element structure (issue 24194)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1313113002 .
2015-08-25 09:23:26 -07:00
Brian Wilkerson 0061447293 Implements instance member inference. Records the correct return type for synthetic function elements representing initializers.
R=leafp@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1306313002 .
2015-08-25 07:48:49 -07:00
Kevin Millikin 90039f64ae dart2js CPS: simple inlining of static invocations.
Inline static functions whose bodies are a single Dart expression that
just calls a foreign (native) function.  This eliminates a lot of
overhead from the code in the JavaScript runtime library.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//1318453003 .
2015-08-25 13:31:46 +02:00
Michael Thomsen 8c346abeef Mentioning null-aware in 1.12 changelog
BUG=none
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1305273005 .
2015-08-25 11:34:34 +02:00
Johnni Winther 6b156993db Use Name instead of Selector in SemanticSendVisitor
BUG=
R=floitsch@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//1314573002.
2015-08-25 10:03:32 +02:00
Johnni Winther 4ed23aff42 Remove SendResolver.computeSendStructure.
BUG=
R=floitsch@google.com

Committed: 4013a9aae5

Reverted: 73a49a5ddb

Review URL: https://codereview.chromium.org//1306143002.
2015-08-25 09:32:26 +02:00
Srdjan Mitrovic 304dc3486f Make default_parameter_values a ZoneGrowableArray instead of an array in new space
BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1307943008 .
2015-08-24 17:22:44 -07:00
Paul Berry b547acc883 Band-aid fix for issue #24191.
This is sufficient to avoid throwing an exception in the resolver,
which in turn will prevent the analysis server from going into an
infinite analysis loop.

I'll work on a more complete fix (which infers the proper type in all
cases) for the next release.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1307353002 .
2015-08-24 16:05:05 -07:00
Regis Crelier 8b825b3f73 Simplify and improve canonicalization of signature types.
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1311773006 .
2015-08-24 14:53:33 -07:00
Srdjan Mitrovic fcea0077cc Minor cleanup in preparation for removal of allocation in new space, and removal of an 'optimization'
BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1310383002 .
2015-08-24 13:40:32 -07:00
Todd Turnidge 8ed37776d4 If the isolate is in the process of resuming, do not report it as paused.
This may be causing bug #24176.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1313713003 .
2015-08-24 13:38:33 -07:00
Todd Turnidge af72ed3afc Fix bug in isolate_lifecycle_test.
Closes #24174

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1305353004 .
2015-08-24 12:55:54 -07:00
John McCutchan 8e1d5f181c Fix profiler test failure on simulator
BUG=

Review URL: https://codereview.chromium.org//1307283002 .
2015-08-24 12:02:31 -07:00
Todd Turnidge bc28a64f20 Allow script insets to scroll.
Closes #23959

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1309223002 .
2015-08-24 11:35:01 -07:00
John McCutchan d61c0ebc04 Chain samples together to collect long stack traces in profiler
- Add continuation_index field to profiler sample.
- Add bit to tell if a sample is the head of a chain.
- Add bit to tell if a sample has a chained sample.
- Each sample holds 8 frames.
- Collect up to 8 frames (1 sample) by default.
- Refactor stack walker code to support chaining during stack walking.
- Add unit test collecting 20 stack frames.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1270003002 .
2015-08-24 11:29:44 -07:00
John McCutchan 2bde865138 Fix NotifyPauseOnStart and NotifyPauseOnExit dead lock
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1312793004 .
2015-08-24 10:47:40 -07:00
Ryan Macnak 85ef528eaa Fix two typos in Observatory.
BUG=http://dartbug.com/24181
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1311083003 .
2015-08-24 10:02:49 -07:00
keertip 41a12640a4 update dartdoc rev in deps
BUG=
R=pquitslund@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//1311023002 .
2015-08-24 08:46:12 -07:00
Devon Carew a910b6ca70 analyzer version to 0.26.1+1
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1310093003 .
2015-08-24 08:08:53 -07:00
Johnni Winther 73a49a5ddb Revert "Remove SendResolver.computeSendStructure."
This reverts commit 4013a9aae5.

BUG=

Review URL: https://codereview.chromium.org//1311123002.
2015-08-24 13:46:28 +02:00
Johnni Winther 4013a9aae5 Remove SendResolver.computeSendStructure.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1306143002.
2015-08-24 11:31:23 +02:00
Karl Klose 999ec11985 dart2js cps: Handle native functions, getters, and setters.
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1288013002 .
2015-08-24 11:01:54 +02:00
Karl Klose 6820b95c1c dart2js cps: update test expectations.
TBR=kmillikin@google.com

Review URL: https://codereview.chromium.org//1303333003 .
2015-08-24 10:59:15 +02:00
Konstantin Shcheglov 581e20d2f6 Disable incremental resolution for not BlockFunctionBody(s).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1310073002 .
2015-08-22 10:04:53 -07:00
Stephen Adams 5d575f307c dart2js cps: Generate fast checks for 'is String' and 'is bool'.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1301363002 .
2015-08-21 17:41:21 -07:00
Ivan Posva 41840f3740 - Really delete InterruptableThreadState.
R=koda@google.com

Review URL: https://codereview.chromium.org//1308973003 .
2015-08-21 15:59:34 -07:00
Vijay Menon a95f44a0f1 Bump dev_compiler to 0.1.6
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//1310513003 .
2015-08-21 15:11:10 -07:00
John McCutchan a9be61a358 Static analysis fixes and debug prints for wedging test
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1302313003 .
2015-08-21 14:31:33 -07:00
Regis Crelier 26031ab6b0 Avoid numerous type allocations by caching the canonical type of a class, which
is used as the receiver type for non-static methods of this class, be it a
generic, non-generic, or signature class.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1309613002 .
2015-08-21 13:37:07 -07:00
Ivan Posva 62b6ac0aa4 - Fix .gitignore on Windows.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1309913002 .
2015-08-21 13:16:57 -07:00
Daniel Andersson 028c995295 Keep StoreBuffer::global_mutex_ and global_empty_ alive.
At Dart::CleanUp time, there may still be threads around that access their store buffer, so we need to keep these around until @zanderso lands the clean shutdown CL.

We should stop leaking them once we cleanly stop all threads at VM shutdown (see issue 23844).

BUG=https://github.com/dart-lang/sdk/issues/24169
R=iposva@google.com

Review URL: https://codereview.chromium.org//1305123003 .
2015-08-21 13:09:16 -07:00
Konstantin Shcheglov aea1e572a1 Sort top-level constants before other top-level variables.
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//1306083003 .
2015-08-21 12:19:48 -07:00
Srdjan Mitrovic 2b6219fd5a Addressed review comments from previous CLs; adding more Symbols::FromConcat
BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1308013002 .
2015-08-21 11:16:30 -07:00
Todd Turnidge 7e8bb130f2 Add an IsolateRunnable event to the service protocol. Improve service docs.
Closes #24140

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1293383011 .
2015-08-21 10:25:38 -07:00