Bob Nystrom
9d4be00986
Migrate block 44.
...
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2985243002 .
2017-08-02 13:45:45 -07:00
Bob Nystrom
cc8ae6b723
Add some more validation of things in expect that should not be used.
...
Also add some helper functions in expect.
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2989743002 .
2017-07-26 16:52:18 -07:00
Erik Ernst
5c213ab929
Changed expect.dart typeAssertionsEnabled to pass strong mode tests.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2973933002 .
2017-07-07 14:24:26 +02:00
Erik Ernst
3b05eb9553
Add support to dart2js for option --enable-asserts.
...
R=johnniwinther@google.com , sigmund@google.com , sra@google.com
Review-Url: https://codereview.chromium.org/2879153005 .
2017-07-07 10:59:09 +02:00
Erik Corry
029b1cb948
Spelling fixes e to i.
...
R=kevmoo@google.com
BUG=
Review-Url: https://codereview.chromium.org/2957593002 .
2017-06-24 13:41:39 +02:00
Stephen Adams
85af0259cb
Expect.equals and Expect.identical escape more strings
...
I found it difficult to understand messages with strings that look the
same, e.g. containing zero-width character or different encodings of a
character.
BUG=
R=lrn@google.com
Review-Url: https://codereview.chromium.org/2750763002 .
2017-04-06 15:38:50 -07:00
Bob Nystrom
60a966605d
Remove uses of unittest in the HTML tests where possible.
...
This finishes going through the dev_compiler HTML tests and switches
out unittest for minitest wherever possible.
In the process, it gets another 10 tests strong mode clean, and gets
several more passing, and more not skipped. With this CL, we're running
another 50 more HTML tests (though some are expected to fail, mostly
because of #27578 ).
R=jacobr@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2419863002 .
2016-10-14 13:44:19 -07:00
Bob Nystrom
ae5a566f98
Move minitest.dart into the expect package.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/2416853003 .
2016-10-13 14:15:21 -07:00
Bob Nystrom
2305865365
Start cleaning up the HTML tests.
...
My initial goal was just to move some of the HTML tests off unittest,
but that ended up slurping in some other changes as well. I haven't
finished going through all of the tests, but this puts the
infrastructure in place and fixes a batch of them. I'll do more next.
Changes:
- Add a "minitest" package. This shims just enough of the unittest/test
API to make it easy to swap it out for unittest without having to
rework the entire test.
- Go through the HTML tests from A-J and change them to use minitest
when possible. The ones that aren't possible use asynchrony.
Minitest doesn't support async tests (yet, maybe).
- Triage those tests and enable ones that are passing. Mark them failing
if failing. Filed a couple of tracking bugs for the common issues,
but for other cases, I just left a comment.
- In the process of this, I went ahead and make some of the affected
tests strong mode clean if they weren't already and it was easy.
- Synchronize changes between dev_compiler's fork of expect and
pkg/expect. We'll want to unfork those at some point. D-:
This gets dev_compiler from 1985 tests to 2042.
R=jacobr@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2413073002 .
2016-10-13 08:47:27 -07:00
Lasse R.H. Nielsen
bd4c7a8a07
Add Base64 codec to dart:convert.
...
This is a simple converter that only accepts and produces plain base-64 strings
with the default alphabet and no whitespace.
R=floitsch@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//1370073002 .
2015-09-29 13:49:53 +02:00
Lasse R.H. Nielsen
d3013cfd35
Fix typos of "function".
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1210483002 .
2015-06-24 12:36:34 +02:00
floitsch@google.com
a2bf14ba1d
Support @NoInlining in the ssa-builder.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//912223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43798 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-16 11:50:37 +00:00
herhut@google.com
44541ff62b
Support [AssumeDynamic] and [TrustTypeAnnotations] in the inferrer.
...
BUG=
R=floitsch@google.com , johnniwinther@google.com
Review URL: https://codereview.chromium.org//875163004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43550 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 11:38:46 +00:00
johnniwinther@google.com
9d9b462cc5
Add test annotations to package:expect
...
BUG=
R=floitsch@google.com , herhut@google.com
Review URL: https://codereview.chromium.org//903753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43510 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 16:29:26 +00:00
lrn@google.com
fab20ad449
Change Expect.stringEquals to give more information about the difference, so it's possible to find it in a long string.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//710283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41656 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-11 09:16:14 +00:00
lrn@google.com
f48916d0fb
Make Expect.throws not accept arguments that fail to be called.
...
Expect.throws calls its first argument, f, with no arguments.
If f isn't callable in this way, the act of calling would throw, and this throw would be considered as makeing the Expect.throws succeeede.
Now we check the argument first, and call it outside the try/catch if it's not callable. This was already caught in checked mode, but we shouldn't accept a false positive in unchecked mode either.
R=zerny@google.com
Review URL: https://codereview.chromium.org//692463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41392 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-29 10:06:35 +00:00
kevmoo@google.com
97835dc3a6
pkg/unittest: added LICENSE
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//135343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31750 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 18:07:45 +00:00
dgrove@google.com
18ca7d0036
Re-land r29957 (add versions and constraints for packages and samples), with
...
SDK constraints bumped from 1.0.0 to 0.8.10+6 .
R=ricow@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//62473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29986 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 18:28:22 +00:00
ajohnsen@google.com
61f6c51990
Revert "add versions and constraints for packages and samples"
...
This is currently blocking us from testing samples.
BUG=
R=kasperl@google.com
Review URL: https://codereview.chromium.org//59513007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29960 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 09:09:18 +00:00
jmesserly@google.com
02638c5760
add versions and constraints for packages and samples
...
- all packages at 0.9.0, except "analyzer" which had a version already
- dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0"
- sdk constraint ">=1.0.0 <2.0.0"
R=sigmund@google.com
Review URL: https://codereview.chromium.org//59763006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29957 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 03:27:58 +00:00
lrn@google.com
544e7061a0
Remove leftover debug-prints in Expect.
...
Review URL: https://codereview.chromium.org//15741028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23461 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 09:32:48 +00:00
lrn@google.com
969a5f27b8
Fix bug in Expect package's string compare.
...
Review URL: https://codereview.chromium.org//15745024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23455 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 07:56:20 +00:00
lrn@google.com
faa7227cec
Make new StreamController be async by default.
...
Change all instances, except some tests, to be sync still.
Rename Multiplex to Broadcast everywhere.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16125005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23453 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 06:07:39 +00:00
floitsch@google.com
8fd6d0aafd
Remove Expect from core library.
...
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
floitsch@google.com
5dc8107c53
Revert "Remove Expect from core library."
...
This reverts commit 19755.
Review URL: https://codereview.chromium.org//12743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com
12dbd2fd70
Remove Expect from core library.
...
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00