Commit graph

7 commits

Author SHA1 Message Date
Bob Nystrom cc1f6a7a35 Don't treat unparseable files as presubmit dartfmt errors.
If the file has a syntax error, it can't be formatted. We don't want to
block submission on that since we do have lots of files in the repo
that deliberately contain syntax errors.

R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2987883002 .
2017-07-25 17:05:11 -07:00
Terry Lucas 0afa1428a1 Added checks for tests.
PRESUBMIT will check:
  1. a new test can NOT be added to Dart 1.0 the new test can only be added to DDC.
  2. a existing Dart 1.0 test changed must have its corresponding DDC test updated too (if it exists).

Presubmit errors may appear as:

** Presubmit ERRORS **
Error: If you change a Dart 1.0 test, you must also update the DDC test:
1. Dart 1.0 test changed: tests/corelib/symbol_map_helper.dart
1. DDC  test must change: tests/corelib_2/symbol_map_helper.dart
2. Dart 1.0 test changed: tests/language/compiler_annotations.dart
2. DDC  test must change: tests/language_2/compiler_annotations.dart

R=jacobr@google.com, rnystrom@google.com

Error: New Dart 1.0 test can not be added the test must be added as a DDC test:
Fix tests:
1. New Dart 1.0  test: tests/corelib/new_test.dart
1. Should be DDC test: tests/corelib_2/new_test.dart
2. New Dart 1.0  test: tests/language/new_test.dart
2. Should be DDC test: tests/language_2/new_test.dart
Review-Url: https://codereview.chromium.org/2982043002 .
2017-07-18 08:20:40 -07:00
Jacob Richman 774f261165 Print the correct path to dartfmt in the presubmit error message.
BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2795653005 .
2017-04-04 16:13:31 -07:00
Jacob Richman 409150339f Add presubmit check that runs dartfmt
BUG=
R=johnmccutchan@google.com, whesse@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2761653003 .
2017-03-21 16:18:48 -07:00
ricow@google.com 14a2204215 Remove presubmit suppression.
dart-status is back in shape

R=kustermann@google.com

Review URL: https://codereview.chromium.org//22875028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26423 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 11:02:39 +00:00
ricow@google.com c104c70ad7 Disable status tree check until we figure out what is wrong with dart-status.appspot.com
R=kustermann@google.com, ngeoffray@google.com

Review URL: https://codereview.chromium.org//23270003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26257 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 07:38:19 +00:00
ricow@google.com bfeb07b702 Add gcl presubmit script to the dart src tree.
Currently I just added a tree status check but we can extend this over time.
Review URL: https://chromiumcodereview.appspot.com//10891021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11575 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 06:11:22 +00:00