Commit graph

16 commits

Author SHA1 Message Date
asiva e33d023fa0 [BUILD] - Format gn files, this is being done to ensure the unfork CL
doesn't show these formatting changes as diffs.

Change-Id: I69ccbf4adabc66d88371cece785a2c1bce60f133
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138962
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-03-10 21:56:11 +00:00
Alexander Markov 65254a4518 [nnbd/corelib] Fix performance regressions due to casts in 'get current' in iterators
Fixes https://github.com/dart-lang/sdk/issues/40877

Change-Id: I6ae70ba53bccf6634953adcba6e92554236d82ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138327
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2020-03-04 21:07:16 +00:00
asiva 75de086f1d [VM/Libraries] Fix all errors reported by CFE when the option
performNnbdChecks is turned on.

Bug:40424
Change-Id: I97a283c4a2d54f570def04d938baa9a4ced08667
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137250
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-03-02 23:03:51 +00:00
Lasse Reichstein Holst Nielsen 043d08a6b1 Don't use an error message as a name in checkNotNullable.
One message is enough.

Change-Id: I0d1b6d98af9f5815f810edc4bd13f46a676ddfda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137780
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2020-02-28 09:39:06 +00:00
Lasse R.H. Nielsen 14983d6c0a Add null-checking helper function for NNBD libraries.
Change-Id: I4d53ac27fd347c2d81b1d68d023e1da5abd9e3ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136631
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2020-02-27 12:22:28 +00:00
Mark Zhou 4d839404c9 Updating iterable.current comments and behavior to be consistent.
Change-Id: I57226491571272aa483aec8b5e14dc00c55511ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132812
Commit-Queue: Mark Zhou <markzipan@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-01-24 17:35:39 +00:00
Lasse Reichstein Holst Nielsen 95511b314c Stop using List() constructor in NNBD code.
The List constructor has been disallowed in NNBD code, so the NNBD SDK
should not be using it.

This changes all uses, not just in the already migrated libraries.
(Also found some bad typing in the `RegExpMatch` class along the way).

Change-Id: Ic61bd64427c0961c23aaf7ce59af5c2c271890ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132282
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-01-24 15:59:29 +00:00
Nicholas Shahan 99c5ec5c75 [dart:_internal] Update signature of extractTypeArguments()
Object -> Object? in the NNBD fork.

Change-Id: Id17827327f77d61266f1a478abb735348dbc7312
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130564
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-01-08 16:23:59 +00:00
Nicholas Shahan bef857b6cb Fix dart:collection analysis errors in NNBD fork
Change-Id: Id4a5e5b100ca1c429070263555ab730622644d19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127161
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2019-12-05 18:20:09 +00:00
Johnni Winther 5013ce6e5d [cfe] Use correct types and errors in late lowering
Change-Id: I6e7dcbd96e151a69fc67a6cd5e5af1620760b02a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126647
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2019-12-02 15:00:18 +00:00
Mark Zhou 5b72c1c669 [dartdevc] Migrating internal_patch to nnbd.
Change-Id: I1ec8cde975ca7ea60c2730ca5b3afa113d783e7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125581
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2019-11-19 01:03:53 +00:00
Nicholas Shahan c3607e3d48 [dart:_internal] Fix some analyzer errors in the NNBD fork
Change-Id: Ie2ea74469c9308a619a3fb2af381c10dff2e249a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125547
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2019-11-18 22:41:25 +00:00
Robert Nystrom c06674e558 Apply review feedback from:
https://dart-review.googlesource.com/c/sdk/+/123600.

Change-Id: I97ae1137f63d99cb3b444f04584abc4a6c08832b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124170
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2019-11-05 23:46:35 +00:00
Robert Nystrom b8cd8eee5d Migrate dart:internal to NNBD.
Also caught a couple of mistakes I made in dart:collection which got
picked up by this because some classes in here use classes from there.

Change-Id: I799db57baf4ea97e8ad4700008918acf03956aff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123600
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2019-11-05 19:21:23 +00:00
Lasse R.H. Nielsen e88057fe04 Add non-NNBD language version marker on all sdk_nnbd files.
Change-Id: I2ab3d4b1efe0f3c79f4b770e79476153380220f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118040
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2019-09-19 19:44:37 +00:00
Paul Berry 004d49bd6b Make a fork of sdk/lib for use by NNBD.
Change-Id: I7f5892d66f9e7bd08ca064fb2df329794a56faf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116527
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2019-09-10 19:20:12 +00:00