Commit graph

87586 commits

Author SHA1 Message Date
turnidge@google.com 44720be924 Mark MessageQueue_WaitNotify flaky again.
Review URL: http://codereview.chromium.org//8349014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@528 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 20:55:54 +00:00
turnidge@google.com c20b9d4183 Add a sleep at the end of MessageQueue_WaitNotify to give the spawned
thread time to properly exit.
Review URL: http://codereview.chromium.org//8345013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@526 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 20:38:36 +00:00
turnidge@google.com bbedbbbc49 Turn the MessageQueue_WaitNotify test back on.
My expectation is that this will turn the mac release tests red.  I
will then follow up with a possible fix.

Can't reproduce the problem locally, so using the buildbot as my testbed :-/.
Review URL: http://codereview.chromium.org//8344014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@524 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 20:18:06 +00:00
rnystrom@google.com e10d67a9bd Move layout tests to new API.
Review URL: http://codereview.chromium.org//8337004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@522 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 18:44:41 +00:00
mmendez@google.com c7b078560a Adds static type checking to the foreach loop.
Notice that the specification only states that the object being iterated over needs to implement Iterator<T> iterator() so this patch adheres to that.

BUG=http://code.google.com/p/dart/issues/detail?id=78 -

Review URL: http://codereview.chromium.org//8322014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@521 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 18:36:34 +00:00
iposva@google.com ed7a54dc74 - Flaky on all architectures.
Review URL: http://codereview.chromium.org//8345005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@520 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 18:26:21 +00:00
iposva@google.com d4e000eda7 - Update vm.status file while we figure out crashes.
Review URL: http://codereview.chromium.org//8342005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@518 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 18:20:15 +00:00
johnlenz@google.com c3cb970918 Fixed alignment of named parameters in the presents of captured scopes
Review URL: http://codereview.chromium.org//8347002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@517 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 18:00:04 +00:00
turnidge@google.com 0e98d4ae64 Allow embedders to provide custom message delivery for an isolate.
==============

Added Dart_SetPostMessageCallback and Dart_SetClosePortCallback.
These allow the embedder to provide custom message/port behavior
for their application. The vm provides standard implementations
that work with the standard run loop.

Added Dart_HandleMessage, which processes one message on the
current isolate. Embedders can use this to write their own
message processing loops. Rewrote code to use this internally.

Added Isolate::StandardRunLoop() to share code between
Dart_RunLoop and lib/isolate.cc

Changed the interface to PortMap::PostMessage. PostMessage is
now agnostic to message delivery mechanism. Note that PortMap is
now out of the "ReceiveMessage" business entirely. Moved
MessageQueue and friends out to message_queue.cc/h.

Moved the monitor from the Isolate into the MessageQueue. No
need for outsiders to mess. Added MessageQueue::Wait. Moved
monitor locking from PortMap into MessageQueue itself, which was
easier for me to reason about. Wrote some tests.

Removed PortMessage::Handle. The code turned into Dart_HandleMessage.

Regularized the nomenclature around ports. Type is now always
Dart_Port instead of intptr_t. Variables end in _port instead of
_id. Use the term "dest" instead of "target" or "send".

Added a family of new tests to port_test.

Added EXPECT_NE to the test framework.
Review URL: http://codereview.chromium.org//8297004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@516 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 17:54:07 +00:00
antonm@google.com 27823d8ac2 Add a support for layout tests.
Review URL: http://codereview.chromium.org//8337020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@514 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 17:27:46 +00:00
johnlenz@google.com 0880d2fec3 Fix build now that the test passes.
Review URL: http://codereview.chromium.org//8347001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@512 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 17:13:07 +00:00
johnlenz@google.com 7af448f4fe By pass object boxing for all js primitives.
Review URL: http://codereview.chromium.org//8323001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@510 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 16:18:12 +00:00
ngeoffray@google.com c0665b7f29 Remove print from MathVMTest and update status file to refer to dom 'print' bug.
Review URL: http://codereview.chromium.org//8339018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@509 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 15:10:03 +00:00
ngeoffray@google.com ac91a5a8da Fix build failures due to forgotten change in the Array -> List transition.
Review URL: http://codereview.chromium.org//8333017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@508 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 10:54:45 +00:00
ngeoffray@google.com 70c01beb9b Clean up (most) uses of Array. Still more to come in the VM corelib code base.
Review URL: http://codereview.chromium.org//8321024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@507 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 10:02:59 +00:00
ngeoffray@google.com 7a76e86b18 Fix test to use developer mode. DartC does not have to check arguments to native methods.
Review URL: http://codereview.chromium.org//8334015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@506 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 09:23:14 +00:00
karlklose@google.com 5bb2f9da7f DartC: Replace Array by List in the type-checker.
Review URL: http://codereview.chromium.org//8317004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@505 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 08:18:31 +00:00
regis@google.com 14b2f4f150 Temporary workaround for issue 5474672.
Review URL: http://codereview.chromium.org//8341007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@504 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 04:32:01 +00:00
regis@google.com ee3fdf27e4 Replace calls to Class::IsParameterized() by either
Class::NumTypeParameters() > 0
or by
  Class::NumTypeArguments() > 0.
Review URL: http://codereview.chromium.org//8329005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@503 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 00:59:54 +00:00
rnystrom@google.com 44170deb77 Clean up util tests to use new style.
Review URL: http://codereview.chromium.org//8337002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@502 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-18 00:37:01 +00:00
nweiz@google.com 9e293343cc Another fix to the web-test pattern.
Review URL: http://codereview.chromium.org//8297007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@501 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 23:59:01 +00:00
hausner@google.com ab37c41e1d Interpolated strings are never considered compile time const
Review URL: http://codereview.chromium.org//8318031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@500 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 23:51:28 +00:00
cshapiro@google.com 4f6c98ea40 Add a const qualifier to string handles which are not reassigned.
Review URL: http://codereview.chromium.org//8339002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@499 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 23:49:48 +00:00
hausner@google.com abdb2d6281 Fix mysterious build breakage that nobody can explain.
Review URL: http://codereview.chromium.org//8339003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@498 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 23:41:32 +00:00
rnystrom@google.com 97d0ea9c71 Move test(), group(), and expect() to top level.
Instead of being methods on UnitTestSuite, they will automatically create
one if there isn't already one, then run it. This lets you define tests just
like:

main() {
  test('not crazy', () {
    expect(sky) == blue;
  });
}

Review URL: http://codereview.chromium.org//8302012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@490 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 23:02:29 +00:00
regis@google.com 74420600b1 Verify method overrides in checked mode only (fix issue 69).
Review URL: http://codereview.chromium.org//8319020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@489 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 23:00:09 +00:00
johnlenz@google.com eadf5e05a2 Add a command-line option for generating source maps.
Review URL: http://codereview.chromium.org//8287001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@486 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 20:58:35 +00:00
regis@google.com 7c2f02849c Merge the 3 different closure nodes into a single node.
Review URL: http://codereview.chromium.org//8294013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@485 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 20:22:42 +00:00
dcarlson@google.com 0266184ec1 Create minimal TextMate mode for Dart.
R=knorton@google.com,rnystrom@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8321007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@484 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 20:19:51 +00:00
vsm@google.com cc71ad71ed Test fix: remove extraneous print
TEST=corelib/ListInsertRangeTest

Review URL: http://codereview.chromium.org//8294020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@483 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 20:18:45 +00:00
terry@google.com 770a1c9d60 Remove the --disable-type-optimizations when --optimize is used.
BUG=
TEST=

Review URL: http://codereview.chromium.org//8316015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@482 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 20:10:00 +00:00
srdjan@google.com 76f932ce14 Add test for blacklisting extension/implementation of classes and interfaces. Added a few tests, please comment which additional ones need to be added.
Review URL: http://codereview.chromium.org//8320002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@481 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 19:43:42 +00:00
johnlenz@google.com 69a08abbbd Namespace named parameters to avoid conflicts
Review URL: http://codereview.chromium.org//8301002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@480 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 19:31:09 +00:00
regis@google.com 4d24678892 Set type argument vector at compile time in type of closure parameters; this
require the introduction of a signature type cached in signature functions.
Support printing of the name of an instantiated signature type, e.g. print
'(int) => int' instead of '<T>(T) => T<int>'.
Avoid cycles when printing the name of illegal types during error reporting by
checking that the type is not being finalized.
Review URL: http://codereview.chromium.org//8289027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@479 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 19:03:32 +00:00
floitsch@google.com 1eade445f6 Update status file with bug-number.
Review URL: http://codereview.chromium.org//8317013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@476 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 18:28:22 +00:00
floitsch@google.com 3282ad880d Skip layout_tests until I have figured out what is wrong.
TBR=ahe

R=ahe@google.com

Review URL: http://codereview.chromium.org//8319006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@474 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 17:32:23 +00:00
floitsch@google.com 9ea0d01b92 Fix fix.
TBR=ngeoffray

R=ngeoffray@google.com

Review URL: http://codereview.chromium.org//8317009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@473 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 17:09:22 +00:00
floitsch@google.com a1d6af4e16 Disable DoubleCompareTest in release mode.
TBR=ngeoffray

R=ngeoffray@google.com

Review URL: http://codereview.chromium.org//8318012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@472 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 16:42:20 +00:00
johnlenz@google.com 857683a0f1 Addresses issue 10.
Review URL: http://codereview.chromium.org//8304012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@471 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 16:14:53 +00:00
floitsch@google.com 0a226d3b67 Implement compareTo on DartC.
BUG=5427706

Review URL: http://codereview.chromium.org//8317008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@470 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 16:07:17 +00:00
jbrosenberg@google.com eee6552316 Disambiguate non-incremental mode from optimized mode in dartc
Review URL: http://codereview.chromium.org//8289008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@469 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 15:30:03 +00:00
zundel@google.com 20a34d063b This adds checks for compile-time constants in places
where the spec demands it:

  - initializing toplevel finals
  - initializing static final class members
  - initializing named parameters to functions

Review URL: http://codereview.chromium.org//8231031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@468 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 14:12:33 +00:00
kasperl@google.com 7c038b73a6 Landing http://codereview.chromium.org/8258017/ on behalf of
Ola Martin Bini. Changed reviewed by vsm@google.com.
Review URL: http://codereview.chromium.org//8306026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@467 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 13:52:54 +00:00
srdjan@google.com bb75f90553 Fix 5442338: Return true if the pc descriptor verifier skips verification because of too many descriptors to check.
Review URL: http://codereview.chromium.org//8318002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@466 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 12:29:49 +00:00
srdjan@google.com 934409878a Fix for bug 5442338 (crash in deoptimization): when optimized code calls deoptimization stub, check if the function was already deoptimized previously before attempting to restore unoptimized code.
Add test case when optimized code of a deoptimized function is several time on stack, and deoptimization occurs after the function was already deoptimized.
Review URL: http://codereview.chromium.org//8311017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@465 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-17 11:27:22 +00:00
knorton@google.com 0b647b51c0 Convert cache property from array to object.
This fixes hangs on Safari where it attempts to stringify the array.
Review URL: http://codereview.chromium.org/8301007/

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@463 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-15 01:32:09 +00:00
rnystrom@google.com 18640b3396 Get rid of "==" in Expectation.
Review URL: http://codereview.chromium.org//8297009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@462 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 23:21:44 +00:00
regis@google.com dc895f3138 Rename class AssertError to AssertionError in the VM (fix issue 119).
Move VM specific tests to the correct tests directory.
Enable asserts in the VM when type checks are enabled.
Review URL: http://codereview.chromium.org//8294005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@460 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 22:02:50 +00:00
mattsh@google.com adf76c310c future and completer
BUG=
TEST=

Review URL: http://codereview.chromium.org//8271014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@459 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 22:00:13 +00:00
johnlenz@google.com 95578019c0 Changes "is" and equality checks to strictly check for primitive types, fix a couple of
places we were converting primitives to Object types by "this" coersions.

Fixes issue 79.
Review URL: http://codereview.chromium.org//8286001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@456 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 21:27:14 +00:00