Commit graph

54848 commits

Author SHA1 Message Date
Sigmund Cherem 05207c5c87 Remerge changelog: it seems I merged the log with 2.0.0-dev.41, not with the tip
of the dev channel.

TBR

Change-Id: Iab49de4007a6fe677417d1b83cd48114a8d73310
Reviewed-on: https://dart-review.googlesource.com/48090
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-23 20:14:10 +00:00
Alexander Aprelev a1ce8cb420 Update corelib_2/bigint_from_test status.
Bug: https://github.com/dart-lang/sdk/issues/32619
Change-Id: I81bde9c9121ff4f47821d3fb6ee34520bb767e92
Reviewed-on: https://dart-review.googlesource.com/48087
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2018-03-23 20:06:20 +00:00
Emily Fortuna 36e3dd0ca1 Fix for not adding unnecessary arguments for $signature functions https://github.com/dart-lang/sdk/issues/32480
Fix for: https://github.com/dart-lang/sdk/issues/32480

Change-Id: I546205415514e60c691af0ffff5522d92aef4247
Reviewed-on: https://dart-review.googlesource.com/47662
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-23 19:46:46 +00:00
Sigmund Cherem 2ef5bbf853 Add entries to changelog
Change-Id: I7f5994fbaf3ca91beb4bae7892cc79075c9cc61e
Reviewed-on: https://dart-review.googlesource.com/48089
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-23 19:22:16 +00:00
Sigmund Cherem 474e678f47 Fix csp bots: update .status file for recently fixed tests (I incorrectly didn't
update the $csp section)

Change-Id: I1ac4a799b68f51a1ef8089504b2a0cc5c7cb45db
Reviewed-on: https://dart-review.googlesource.com/48088
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-23 19:21:39 +00:00
Sigmund Cherem 34bb60bbc5 Library specification format: replace 'environment_overrides' with 'supported'.
Change-Id: Ic8172f4574a35ac31910ac0d5934c0d63db40a23
Reviewed-on: https://dart-review.googlesource.com/48060
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-23 18:28:59 +00:00
Konstantin Shcheglov 5be7955bb5 Expose 'Extract Widget' refactoring from Analysis Server.
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1250
Change-Id: Ieb91e876b4199440e7f3811c39a523b040ca14f0
Reviewed-on: https://dart-review.googlesource.com/48086
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-23 18:28:09 +00:00
Dan Rubel 6180f12ccf Update parsing as/is expressions to use computeType
This introduces a new TypeInfo.ensureType method which recovers
when a type is required but there is no type.

Change-Id: Ie9080864f814329bc7a7dcdf73440fd184e9e0f8
Reviewed-on: https://dart-review.googlesource.com/47944
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-03-23 17:58:59 +00:00
Konstantin Shcheglov 96b76aa4fb Revert "Revert "Create new AnalysisSession instance on changes.""
This reverts commit 1caf7b7ecd.

R=brianwilkerson@google.com

Change-Id: I52c9628afe5d3df94801dc793217c9adf4ea82fe
Reviewed-on: https://dart-review.googlesource.com/48085
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-23 17:07:59 +00:00
Kevin Moore 0b2684e629 Update DEPS to include pkg:http_retry v0.1.1
Closes https://github.com/dart-lang/sdk/issues/32655

Change-Id: I391059e4e4bee9052523c347e413299000f7a2f5
Reviewed-on: https://dart-review.googlesource.com/48084
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-03-23 16:37:55 +00:00
Brian Wilkerson 71c782a104 One more change to get the analyzer_cli tests to all pass under preview-dart-2
Change-Id: I5913e5db484d6c285d4efd503200728c1166b787
Reviewed-on: https://dart-review.googlesource.com/48083
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-23 16:13:31 +00:00
Ben Konyi 2187286251 [ VM / Dart 2 ] Fixed Mixin_PrivateSuperResolutionCrossLibraryShould fail which was expecting a NoSuchMethod error instead of a compilation error in strong-mode.
Fixes part of issue 32190.

Change-Id: Iab0d304b4c77deb57c449788797300d38087466b
Reviewed-on: https://dart-review.googlesource.com/47946
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2018-03-23 15:43:09 +00:00
Ben Konyi e11fcdc266 [ VM ] Added issue number to FunctionSourceFingerprint failure status entry.
Context: https://github.com/dart-lang/sdk/issues/30756

Change-Id: I4fc914cfecb2656a87f68170a79e85a0055c903e
Reviewed-on: https://dart-review.googlesource.com/47920
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-03-23 15:27:52 +00:00
Dan Rubel 20b9b541ae Improve recovery when parsing type arguments
Change-Id: I4eea9a7ddff809a7cf0c3ea430f408449228514f
Reviewed-on: https://dart-review.googlesource.com/48024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-03-23 15:05:00 +00:00
Dan Rubel 721e29e552 Cleanup statement parsing and tests
Change-Id: I107ce5f3b6ebac123198b9a3a471f0a52cdcf1e3
Reviewed-on: https://dart-review.googlesource.com/48020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-03-23 14:54:39 +00:00
Brian Wilkerson bd6f28f4c7 Make analyzer_cli closer to Dart 2 clean
Change-Id: I2f9b9e5bf87b65e871699c16633b1bfcf7605de5
Reviewed-on: https://dart-review.googlesource.com/48061
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-23 13:14:07 +00:00
William Hesse 1c913801a6 Add third_party packages to dart2js testing shards
The http_server in the test.py scripts uses package_resolver, which
uses 10 packages from third_party/pkg and third_party/pkg_tested.

Change-Id: I1e9ca660b9bd0a6270bcc8e4121da6a3bf9713bd
Reviewed-on: https://dart-review.googlesource.com/47781
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-23 12:56:06 +00:00
Jens Johansen f9c7a4a22d Allow to output full component via computeDelta
This CL allows users of the incremental compiler to ask for a computeDelta
call to include the full Component in the output,
basically turning the incremental compiler into a batch compiler.

This CL furthermore changes the frontend_server (in pkg/vm) to use this
functionality.

This change - used in flutter - takes the time it takes to run
`flutter test` in `packages/flutter` from ~8 minutes 30 seconds to
~2 minutes 30 seconds (on my machine).

Change-Id: Ia185d28da1f97b0be5dad8814cd01a8f13482724
Reviewed-on: https://dart-review.googlesource.com/47020
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-03-23 12:07:56 +00:00
Paul Berry 1ac627a026 Set the file offset for Let node in implicit tearoff of call
Fixes #32629.

Change-Id: I96e12aa2c575853868846ce438b786172ec8faa5
Reviewed-on: https://dart-review.googlesource.com/48080
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2018-03-23 11:50:56 +00:00
Dmitry Stefantsov dacf9d4e18 Add tests for noSuchMethod forwarders
Change-Id: I22cf843faf886ae877b351017a7a8e5ab25f7f0a
Reviewed-on: https://dart-review.googlesource.com/47881
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
2018-03-23 11:26:36 +00:00
Johnni Winther c930c2bb72 Improve coverage of id_equivalence tests
- and readability of error case output of equivalence tests.

Change-Id: I7883544e9d9064db1a30ecd8923de0e80c031567
Reviewed-on: https://dart-review.googlesource.com/47224
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-23 10:28:34 +00:00
Peter von der Ahé e21b54159f Tests incremental compilation of parts in packages.
Change-Id: Ic432bc255df1fe356f281779132a92391e3a0c6c
Reviewed-on: https://dart-review.googlesource.com/48100
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2018-03-23 09:30:25 +00:00
Alexandre Ardhuin 9b2803f048 allow linter to enable previewDart2
Closes #32644
https://github.com/dart-lang/sdk/pull/32644

GitOrigin-RevId: 825c65da08d902c3fcd8984b055702a2e261ca72
Change-Id: Ia214040cb1918db130b41d4c50f1d3082ca734b6
Reviewed-on: https://dart-review.googlesource.com/47980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-23 04:34:55 +00:00
Kevin Moore 970b03986d Update homebrew formula to fail with dartium on dev releases
Closes https://github.com/dart-lang/sdk/issues/32642

Change-Id: I221ec3cca7c6965a0feef1dd380160221e1b5fb2
Reviewed-on: https://dart-review.googlesource.com/48000
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
2018-03-23 01:45:34 +00:00
Sigmund Cherem 07d2c9f287 Add server category for dart2js
Change-Id: I077da86aff4420aba1323e98d6cde08ac871f6f1
Reviewed-on: https://dart-review.googlesource.com/47721
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-23 00:40:55 +00:00
Konstantin Shcheglov ea1d1d7621 Support for extracting methods with parameters.
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1250
Change-Id: I906e14feba246a7704fbbcdaa358730be5916a47
Reviewed-on: https://dart-review.googlesource.com/47945
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-23 00:26:45 +00:00
Brian Wilkerson be867d5fa4 Update analyzer_plugin to be Dart 2 safe
Change-Id: I0fb4f7274deb92c47518594a1bbcfc39dca5aeff
Reviewed-on: https://dart-review.googlesource.com/47942
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-23 00:19:45 +00:00
Sigmund Cherem b66971a45d Fix config specific imports to dart.io and dart.mirrors in dart2js
This uses the environment_overrides section that I'm adding to the libraries
specification files.

Change-Id: I95c175533f21320dd44eab9988afe2644ed0c9d3
Reviewed-on: https://dart-review.googlesource.com/47406
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-23 00:02:54 +00:00
Sigmund Cherem 81d1f20943 Copy libraries.json to the generated SDK
Change-Id: Iea4636d150dcf6023c9b5cc59646f10e518bfc04
Reviewed-on: https://dart-review.googlesource.com/48025
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-22 23:07:55 +00:00
Alexander Markov af1436931b [CFE] Fix for insertion of duplicate NSM forwarders
Change-Id: I4e7d5708f134a06b9b3a4dfa7066a8de36268624
Reviewed-on: https://dart-review.googlesource.com/48023
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
2018-03-22 22:39:59 +00:00
Alexander Markov 48644d5f6a [CFE] Fix crash when trying to add NSM forwarder for a field
Change-Id: Icbd1271285d6c8c714c2e4de5f531d4357c04c13
Reviewed-on: https://dart-review.googlesource.com/48021
Reviewed-by: Samir Jindel <sjindel@google.com>
2018-03-22 22:15:48 +00:00
Sigmund Cherem 898260a998 Split dependency on dart:html from dart:js
This change is needed to be able to introduce a new platform "dart2js_server"
that represents compiling to dart2js for non-browser targets (like nodejs). Some
users (like Dart Sass) depend on this feature.

The old front-end made this work by using "--categories=all", this change should
make it possible to compile with "--categories=Server".

Change-Id: I41bf25ab19016154206c419a48884bdc4afbd444
Reviewed-on: https://dart-review.googlesource.com/47700
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-22 22:15:05 +00:00
Sigmund Cherem ef919c5eb3 fix commit queue: update nSM test expectation on ddc too.
TBR=sjindel@google.com

Change-Id: Ia6cf344d1071b5c70979605df45f7c21974ad7b7
Reviewed-on: https://dart-review.googlesource.com/48022
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-22 21:51:00 +00:00
Samir Jindel d014fce4de Update dartkp NSM expectations.
Change-Id: I28cc42a05b25e25184cf4fda1742c016179ac9ef
Reviewed-on: https://dart-review.googlesource.com/47962
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-03-22 20:26:43 +00:00
Konstantin Shcheglov 6bd38cc912 Analysis Server API for 'Extract Widget' refactoring.
R=brianwilkerson@google.com

Change-Id: Ie6b7c349d304785ab6829770ebd3504c0affe8df
Reviewed-on: https://dart-review.googlesource.com/47943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-22 20:25:29 +00:00
Dan Rubel 123e59c189 Improve for loop recovery
Change-Id: Ibc116156fb7e3a4d8cd2ba90e369f2d8f3cb04d1
Reviewed-on: https://dart-review.googlesource.com/47906
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-03-22 19:56:14 +00:00
Samir Jindel 790b7b98fb [kernel] Update more NSM expectations.
Change-Id: I016098763f40b4d5286264a6de9241e3fb11a30d
Reviewed-on: https://dart-review.googlesource.com/47961
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-22 19:54:59 +00:00
Konstantin Shcheglov 696be0ae46 Initial support for extracting methods.
No support for method arguments and multiple invocations yet.

R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1250
Change-Id: I11b817676e254b2a456d97d60d2ab45893a65e68
Reviewed-on: https://dart-review.googlesource.com/47940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-03-22 19:51:58 +00:00
Samir Jindel 8d669c9d4e [kernel] Update NSM-forwarding test expectations.
Change-Id: Ib212a109a8115e2e387526f61c07840be5c35b76
Reviewed-on: https://dart-review.googlesource.com/47960
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-22 19:49:09 +00:00
Ben Konyi edf039d510 [ VM / Dart 2 ] Made StackMapGC test strong-mode clean. Fixes part of 32190.
Change-Id: I09d519a950c1e3c825c89a1f5e22292cedc6c14a
Reviewed-on: https://dart-review.googlesource.com/47941
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2018-03-22 19:36:04 +00:00
Ryan Macnak 77239ee1db [fuchsia] Replace use of deprecated fdio_get_vmo with fdio_get_vmo_clone.
Change-Id: I8961ed49c6e9269c3cb8699037717d7007e630a8
Reviewed-on: https://dart-review.googlesource.com/47905
Reviewed-by: Zach Anderson <zra@google.com>
2018-03-22 19:26:08 +00:00
Samir Jindel 95e9e890a9 [kernel/vm] Implement NSM-forwarding in the VM.
Change-Id: I43ce98235a7fdb43f99f433ef8dd10a6ed08fbbb
Reviewed-on: https://dart-review.googlesource.com/47621
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-03-22 19:14:04 +00:00
Dan Rubel 7450e2ad60 Fix parsing of invalid interpolation in string literal
Change-Id: I7151cee5f97a5a43314885326e4806a0314af544
Reviewed-on: https://dart-review.googlesource.com/47582
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-03-22 18:50:13 +00:00
Janice Collins cd03f35a0b Prepare for analyzer 0.31.2-alpha.1, front_end 0.1.0-alpha.11, and kernel 0.3.0-alpha.11.
This CL looks a little weird because a previous CL,
https://dart-review.googlesource.com/46126 partially updated
the yaml files but the packages were never published.

Bug: dartbug.com/32509
Change-Id: I2ab19b6165fcd9d748defb6eeeb5efff2925df6c
Reviewed-on: https://dart-review.googlesource.com/47904
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-03-22 18:25:54 +00:00
Ryan Macnak 38b0825a55 [kernel] Add target for Flutter on Fuchsia.
Change-Id: I7ab8e989e1e2038565e1d04a1c8f8ce880328ed8
Reviewed-on: https://dart-review.googlesource.com/47500
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-03-22 18:21:09 +00:00
Sigmund Cherem 2fd9969c96 extend unstable API to pass in the location of the libraries-specification
For now I'm just passing null, in a future CL I will pass a valid library
specification uri. This is needed in order to provide a library specification
that fasta will use to determine the result of a config-specific import.

Change-Id: I5e6babb0eb11bd1037262ea1260bc67188ef4649
Reviewed-on: https://dart-review.googlesource.com/47405
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-22 18:03:04 +00:00
Konstantin Shcheglov 1caf7b7ecd Revert "Create new AnalysisSession instance on changes."
This reverts commit 8eb9f3db80.

New sessions, and corresponding InconsistentAnalysisException, cause
breakages in dartwing and pageloader3.

I plan restoring this in a week from now.

R=brianwilkerson@google.com

Change-Id: I88cbb0b6a50138fabed6798aa844c29f0e2a7b24
Reviewed-on: https://dart-review.googlesource.com/47901
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-03-22 17:58:19 +00:00
Konstantin Shcheglov c90ca298ed Provide a message for InconsistentAnalysisException.
R=brianwilkerson@google.com

Change-Id: I1498c70c1c9d7cd43760ca2c620a3fb819a0c823
Reviewed-on: https://dart-review.googlesource.com/47903
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-22 17:54:59 +00:00
Sigmund Cherem b6944e3165 Make use of environment overrides in fasta's implementation of config specific imports
Note: this CL has a base-cl that extends the library specification format.
Change-Id: Ice999c550baecac5140b6157b0ea3e60d94cd1a6
Reviewed-on: https://dart-review.googlesource.com/47404
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-22 17:48:19 +00:00
Brian Wilkerson 26c06cdd82 Clean up Dart 2 type issues related to YAML support
Change-Id: Ic29054afca9773286aa899eecede287f7ecbca9a
Reviewed-on: https://dart-review.googlesource.com/47680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-22 17:06:40 +00:00