Change-Id: I79e86ef8681b0b169b0b40da26a5834eaace66a3
Reviewed-on: https://dart-review.googlesource.com/47580
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
* fix for `invariant_booleans` when analyzing for loops with no condition
* new `avoid_types_as_parameter_names` lint
* new `avoid_renaming_method_parameters` lint
Change-Id: Iaafceba24f1b049a132464b78588d57e621c85d4
Reviewed-on: https://dart-review.googlesource.com/47300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This will force pub-build to continue using the old dart2js frontend until we
fix the uses of package-root
Change-Id: I3e8d73b4c0586e3af77d665b407f2bb3bf94029d
Reviewed-on: https://dart-review.googlesource.com/46573
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
* new `avoid_relative_lib_imports` lint
* new `unnecessary_parenthesis` lint
* fix to `prefer_const_literals_to_create_immutables` to handle undefined classes gracefully
* updates to `prefer_const_declarations` to support optional `new` and `const`
* `prefer_const_declarations` updated to check locals
* fixes to `invariant_booleans`
* bumped SDK lower bound to `2.0.0-dev`
* build and workflow improvements: rule template fixes; formatting and header validation
* miscellaneous documentation fixes
Change-Id: I999891b61c19e602eded4b43449f7d6d96f102e7
Reviewed-on: https://dart-review.googlesource.com/46305
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
There was only 1 change since the last roll.
Change-Id: I44a8ef56bc16d4bc4616480025125f1ca64beff8
Reviewed-on: https://dart-review.googlesource.com/46221
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Change-Id: I9de7d0c936b31f1365fc6cd9099a87fa42798aaf
Reviewed-on: https://dart-review.googlesource.com/46001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Last roll was >1yr ago.
Change-Id: I9b641b9cff4b8b53887fe0ad1615bb9085ae9717
Reviewed-on: https://dart-review.googlesource.com/44381
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This is for consistency; v0.15.1 and v0.16.0 behave identically when
using the analyzer built in to the SDK.
Change-Id: I50d4bab8eade1cbc9f6537712805fa868af3f573
Reviewed-on: https://dart-review.googlesource.com/40468
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Roll in versions of third_party packages which have been updated to
use StreamTransformerBase and forward compatible method signatures
on classes implementing Stream.
Change-Id: Ie366174bf09f9268a7f1476387c124cb3ea474f6
Reviewed-on: https://dart-review.googlesource.com/38680
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
This is a branch of co19 tests where the tests have been
made strong mode compliant. A co19_2_analyzer.status file
has been added with the current statuses of the tests when
run on dartanalyzer --strong. We expect more Dart 2 configurations
to start running these tests and adding status files.
Change-Id: I22077272707620b92dd1092c38bbb4f3d5964493
Reviewed-on: https://dart-review.googlesource.com/37743
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This brings package:http_io into third_party/pkg_tested so that its
migrated tests will run on sdk commits.
Change-Id: I516152747cdaeb1e874a900cb8ad57d84594ed6c
Reviewed-on: https://dart-review.googlesource.com/36842
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Change-Id: I45874e2826bb347637997f773c0ac1cf05a7af27
Reviewed-on: https://dart-review.googlesource.com/34383
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
This is needed for fuzzy arrow and assert-closure fixes.
Change-Id: I34884e89094f2b88b12fbfdfcddc6cbcd4683bb4
Reviewed-on: https://dart-review.googlesource.com/34221
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
* added support for external constructors in `avoid_unused_constructor_parameters`
* added code reference resolution docs for `comment_references`
Bug:
Change-Id: I844d7a50de557afe35cf9580ad06f31308359e0a
Reviewed-on: https://dart-review.googlesource.com/34220
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This required some changes to analysis_server, since analysis_server
used to have its own version of pumpEventQueue(). Since
pumpEventQueue() is now provided by the test package, I've removed
analysis_server's version, and I've updated some of the call sites to
pass in "times: 5000" to replicate the old analysis_server behavior.
This also required some changes to analyzer, since the fail() method
is now marked as @alwaysThrows, so no code may follow it without
producing a dead code hint.
Change-Id: Ie5ef3a5cc685c18da02de699e59f63f3bb8865f7
Reviewed-on: https://dart-review.googlesource.com/32683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
