We also need to update the prebuilt SDK to keep it in sync with this
change so the presubmit doesn't get wonky. But, in this case, it should
be fine. The change affects a rare case that I don't think occurs in
the SDK: a multi-line string inside a string interpolation, inside
another string. If that does occur, it's easy to just change that code.
Change-Id: Icdfdfb0b2e1359005d88d983e9a3cf05b0e91e48
Reviewed-on: https://dart-review.googlesource.com/65280
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Cq-Include-Trybots:luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: I37f3b78180133c31f6267b76c3eeb16f8c00325a
Reviewed-on: https://dart-review.googlesource.com/63623
Reviewed-by: Erik Ernst <eernst@google.com>
* fix to `avoid_positional_boolean_parameters` to ignore overridden methods
* fix to `prefer_is_empty` to not evaluate constants beyond int literals
* new lint: `null_closures`
* new lint: `lines_longer_than_80_chars`
Change-Id: Id11694d65091de6f26f521d62f3c5fb1921f58af
Reviewed-on: https://dart-review.googlesource.com/63271
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
#33659
Change-Id: I94fccf4bbce2f0140bf0d6efa953d44b290df856
Reviewed-on: https://dart-review.googlesource.com/62840
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Change-Id: I42a5c41394226f6ddc9c0608c6d688ae683ffdea
Reviewed-on: https://dart-review.googlesource.com/62680
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* fixed an issue in `const` error handling
* updated `linter` binary to use `previewDart2`
Change-Id: Ic46df8fc248c241b9ecc71e180ae3adb2238546a
Reviewed-on: https://dart-review.googlesource.com/62641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Update Changelog to add this info, and to prepare for releasing -dev.65.0
Change-Id: Iaa6c0d917acb1132227352b422ef3939cda2a9f4
Reviewed-on: https://dart-review.googlesource.com/61926
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Closes#33187
Brings in the latest version of pub. There is still an issue with
invaliding old snapshots, but this version works better than the current
synced version.
Change-Id: I5c98b0277ea769baa83c3fee7ebfff2034ba9920
Reviewed-on: https://dart-review.googlesource.com/61983
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
https://github.com/dart-lang/dartdoc/releases/tag/v0.20.1
Updates dartdoc and its dependency "quiver" to new versions (dartdoc
ran into a type problem with the older quiver).
Because of the quiver change this could affect more than just dartdoc.
Change-Id: I9b0bbb3d4b222f605d7ac5cafc641b5da0c02d20
Reviewed-on: https://dart-review.googlesource.com/61912
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
New version avoids literals that are not exact in JavaScript.
Change-Id: I38fa0d6132b9006f361b01e3e691b5a672584e98
Reviewed-on: https://dart-review.googlesource.com/61741
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This fixes precompiling snapshots when running pub get/upgrade which
broke when the VM removed support for "--preview-dart-2".
Change-Id: I70fe2241f85cf5e8cdf447387df92ea47d398c57
Reviewed-on: https://dart-review.googlesource.com/61440
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
* new `unnecessary_const` lint
* new `unnecessary_new` lint
* fixed errors in `use_to_and_as_if_applicable`
* new `file_names` lint
Change-Id: Ic461249050277ea81ade7a90b92506c6041ac480
Reviewed-on: https://dart-review.googlesource.com/61280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* updated `unnecessary_statements` to ignore getters (as they may be side-effecting).
Change-Id: I2019d1c2c49224525ac066a8f44c6da301dbfd91
Reviewed-on: https://dart-review.googlesource.com/60180
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* fixed `void_checks` to handle arguments not resolved to a parameter
* fixed exceptions produced by `prefer_const_literals_to_create_immutables`
Change-Id: Ia25fe8e432ee7717cfe289bce4515481e801c4f8
Reviewed-on: https://dart-review.googlesource.com/59201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Change-Id: If1705ac18715876fc5c1325dab4c3dda42b8d2b9
Reviewed-on: https://dart-review.googlesource.com/56580
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
* `unrelated_type_equality_checks` now allows comparison between `Int64` or `Int32` and `int`
* `unnecessary_parenthesis` improved to handle cascades _in_ cascades
Change-Id: I588893132e04a706e9fc93a7a16a07005465eb1f
Reviewed-on: https://dart-review.googlesource.com/55914
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Change-Id: I6843981cda8e0dc7936271bcc019ab9571b15d67
Reviewed-on: https://dart-review.googlesource.com/55321
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
This should be safe to do without rolling the prebuilt SDK since it
makes no changes to existing formatted code.
Change-Id: I3420698b5dac94ab04ee7908940ace70936a3e5b
Reviewed-on: https://dart-review.googlesource.com/55269
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
It hasn't been updated in nearly 2 years. This update adds support for
more modern C++'s.
Change-Id: Ie3cbf95db6073d838a3a4cdbb72c3f50e0777c01
Reviewed-on: https://dart-review.googlesource.com/55265
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
* migration of rules to use analyzer package `NodeLintRule` and `UnitLintRule` yielding significant performance gains all around
* specific performance improvements for `prefer_final_fields` (~6x)
* addressed no such method calls in `void_checks`
* improved lint reporting for various lints
Change-Id: I63896a5367e27241ef596408aea44830c8067c75
Reviewed-on: https://dart-review.googlesource.com/53861
Reviewed-by: Devon Carew <devoncarew@google.com>
Bug: #33030
Change-Id: I7155482cbba12e9e5501feebac8ff31c6d8071ff
Reviewed-on: https://dart-review.googlesource.com/54140
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Bug: None
Change-Id: I5627ac27907acfa5e304e47720758383a2e6376a
Reviewed-on: https://dart-review.googlesource.com/53166
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This has no formatting changes, so is safe to roll without coordinating
with a new prebuilt SDK.
Change-Id: If8b966a7fd402909f82aa016ee9958672a275e8b
Reviewed-on: https://dart-review.googlesource.com/53161
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
