Commit graph

22 commits

Author SHA1 Message Date
Michael Thomsen f7af5c5256 Deprecate dartanalyzer command
Change-Id: I8d2fb8a5dbac0f81c8cad770ccfb2e3bbf2b0880
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219702
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2021-11-09 13:23:42 +00:00
asiva bc7220a4fd [VM] Turn dart2 on by default on the command line VM
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations

Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-06-18 22:31:32 +00:00
Devon Carew eeec6466b6 Convert the command-line analyzer to a dart 2 snapshot.
Change-Id: Ieb5cd8971494a8a6ffc07c0fd4dde07cfb6f5373
Reviewed-on: https://dart-review.googlesource.com/56034
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-05-22 15:44:04 +00:00
Jacob Richman b5d53b5348 Fix spew when running presubmit which triggers dartfmt.bat on windows. We should also backport this change to the sdks in tools/sdk or roll a new version of the tools/sdk
Error span you otherwise get with each dartfmt invocation:

find: ‘>     bin [’: No such file or directory

Note that the error doesn't occur all times dartfmt is run, only when it is
run from the directory triggered by the presubmit.

BUG=
R=rnystrom@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2759333004 .
2017-03-28 08:30:10 -07:00
William Hesse 9941b665bf Tools not running from snapshots should use /.packages
Stray .package files in their source can otherwise cause errors.

BUG=
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2374453002 .
2016-09-26 18:47:32 +02:00
William Hesse 61eee9ee52 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Committed: 5d3e356ca7

Review URL: https://codereview.chromium.org/1746743002 .

Reverted: 6d238ba197
2016-09-16 15:03:18 +02:00
William Hesse 6d238ba197 Revert "Use checked-in .package file for building and testing"
This reverts commit 5d3e356ca7.

BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2340813004 .
2016-09-15 15:46:49 +02:00
William Hesse 5d3e356ca7 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1746743002 .
2016-09-15 14:50:30 +02:00
Johnni Winther 40108f661d Update Windows build output path in .bat files
R=asiva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2035313004 .
2016-06-07 10:43:13 +02:00
John McDole 8720ec869d Fix windows + gitbash (#25712)
* work with gitbash

* gitbash

* gitbash

* gitbash

* gitbash
2016-05-02 12:47:48 +02:00
William Hesse 73dfc7afe0 Change to X64 default build in tool scripts in sdk/bin
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1535553003 .
2015-12-17 14:49:19 +01:00
pq 9ae1265ff5 analyzer_cli move to SDK.
Tracking bug: https://github.com/dart-lang/sdk/issues/24731

Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/

Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994

BUG=24731
R=whesse@google.com

Review URL: https://codereview.chromium.org/1459683003 .
2015-11-19 14:52:54 -08:00
pq 2c5e890fc7 Build fixes.
Long tail of fixes related to moving out of `pkg_tested`.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1162423002
2015-06-03 14:03:15 -07:00
pquitslund@google.com 4c03f25626 Analyzer build updates to use analyzer_cli.
The associated change to add analyzer_cli to DEPS is here:
https://codereview.chromium.org/1093173004/

R=brianwilkerson@google.com, paulberry@google.com, ricow@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//1100553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45321 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-21 20:59:31 +00:00
paulberry@google.com b9116653bd Modify dartanalyzer scripts to look more like dart2js scripts.
The dartanalyzer script (and its Windows companion, dartanalyzer.bat)
now support:

- Executing from snapshot if present, otherwise from source (needed
  for buildbot tests).
- Passing in the appropriate package root when executind from source.
- Passing in VM tuning parameters to speed up analysis.
- Passing through extra DART_VM_OPTIONS to the VM.

Also, the old editor/tools/analyzer script has been removed and
the test infrastructure now uses sdk/bin/dartanalyzer, in the
same way that it works for dart2js.

R=ahe@google.com, johnniwinther@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//628363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41150 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 14:21:37 +00:00
ricow@google.com d0e8a0b8a6 Add dart-sdk argument when calling the dart based analyzer in the created sdk
I am not even sure why we need to pass in this argument, but the tool requires this or it will exit with "Usage: dartanalyzer: no Dart SDK found."

This is a fix so that we can get a release out, I will leave it to the analyzer people to figure out if this is needed after all.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//273863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35889 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-08 08:18:48 +00:00
danrubel@google.com 521aef0d96 Replace Java based analyzer with Dart based analyzer when building SDK
* include analyzer dart files and snapshot in SDK
* modified bin/dartanalyzer to call dart based analyzer
* removed jar files in utils directory

BUG=dartbug.com/18289
R=ricow@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//240723006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35604 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-30 23:09:14 +00:00
aprelev@gmail.com a35c219ccb Fix dartanalyzer.bat so it works when there are spaces in the path to dart sdk.
BUG=dartbug.com/10859
R=devoncarew@google.com

Review URL: https://codereview.chromium.org//15767003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23199 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 02:44:30 +00:00
devoncarew@google.com d5a63cce7c Fixes to the sdk dartanalyzer.bat script.
Review URL: https://codereview.chromium.org//13925018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21535 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-16 03:50:16 +00:00
devoncarew@google.com 15f2818c43 Add the new dart analyzer to the SDK.
Review URL: https://codereview.chromium.org//14110004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21479 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 17:05:52 +00:00
devoncarew@google.com d7b8047611 Rename the sdk/bin/dartanalyzer* scripts to dartanalyzer_developer*, and update
the test framework to call the new scripts. This rename will allow us to add
two new scripts to this directory, dartanalyzer and dartanalyzer.bat. These scripts
will be the ones we include in the sdk.
Review URL: https://codereview.chromium.org//13760010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21213 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-10 16:01:21 +00:00
devoncarew@google.com c5c15b0881 Rename the name of the new analyzer jar file from new_analyzer.jar to
dartanalyzer.jar (which I think will be the preferred name for it in
the SDK).

Update the test framework for these renames.
Review URL: https://codereview.chromium.org//12618010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20994 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:33:23 +00:00
Renamed from sdk/bin/analyzer.bat (Browse further)