The jsshell is used rarely for benchmarking and testing.
Make download of it conditional, at least until it is uploaded
and moved to CPID, to help migration to python3.
To download the shell in a checkout, add
"checkout_javascript_engines": True
to the "custom_vars" in a .gclient solution.
Change-Id: I693a4b402ffebca28d94c124624c4bd897315818
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195261
Reviewed-by: Alexander Thomas <athom@google.com>
Add a `retry` library to replace `http_retry`. We will be able to remove
`http_retry` from the SDK after `http` is published and the usage is
migrated in `pub`.
Change-Id: Id39674d08388ada6406c85d1263494c3d7cbe720
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195168
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2021-04-13 sgrekhov@unipro.ru Fixes 1073. Wait for isolate start before pausing it (1074)
2021-04-12 irina.arkhipets@gmail.com MMore fixes for 1057: test expectation corrected, Issue tags added.
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try
Change-Id: I6ed26b930881df5bbac16b3aa6b4f41cddaf8452
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195070
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-04-12 irina.arkhipets@gmail.comFixes#1071: test expectation corrected.
2021-04-09 sgrekhov@unipro.ruFixes#1072. Remove excessive @compile-error
2021-04-08 sgrekhov@unipro.ru Allow both 254 and 255 result codes on Windows
2021-04-08 irina.arkhipets@gmail.comFixes#1070: tests expectations corrected.
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Iccec27cb0050da7979b471d6a1bd63cbc4656220
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194785
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
The reverts the change to flatted nested conditional expressions since
audience reaction to that was pretty negative.
See: https://github.com/dart-lang/dart_style/pull/1019
Change-Id: Ie9e4460f75c5b7e99e5a6d60e9c38b50ba0bc44a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194883
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2021-03-25 sgrekhov@unipro.ru 1037. A couple of tests that still use nonfunction-type-aliases removed from co19_2 repository
2021-03-24 sgrekhov@unipro.ru 1023. Change SplayTreeMap and SplayTreeSet tests according to the new behavior
Change-Id: Ia8ea48c30b05765bc03cd5a9ee8bb8ad9336e6ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193300
Reviewed-by: Erik Ernst <eernst@google.com>
Apply new lints, cleanup violations, and ignore in `lib/src/js_ast` to
avoid adding additional diffs with the version it was forked from.
Change-Id: I1def25865bf195120c594223ebdc0f59139e75b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192241
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2021-03-24 sgrekhov@unipro.ru extension-methods experimental flag removed from co19_2 tests
2021-03-24 sgrekhov@unipro.ru 1028. Tests that use nonfunction-type-aliases removed from co19_2 repository
2021-03-23 sgrekhov@unipro.ru 1021. Remove expecting errors on web configurations for some negative numbers
2021-03-23 sgrekhov@unipro.ru 1028. Remove triple shift operator from co19_2 repository
2021-03-23 sgrekhov@unipro.ru 1028. Remove triple shift tests from co19_2 repository
2021-03-22 irina.arkhipets@gmail.com Fixes 1015: removed test because triple-shift feature is not supported in this branch.
2021-03-18 sgrekhov@unipro.ru Fixes 1014. Expect compile error on dart2js as [web]
2021-03-17 sgrekhov@unipro.ru Fixes 1014. Expect compile error on dart2js for big numbers
2021-03-17 sgrekhov@unipro.ru Fixes 1017. Use => for setter returning value tests
2021-03-16 sgrekhov@unipro.ru Fixes 1013. Fix cast failures in Type_Cast/syntax_t01 test
2021-03-16 sgrekhov@unipro.ru Fixes 1012. Fix Additive_Expressions/syntax_t01 test
2021-03-16 sgrekhov@unipro.ru Fixes 1010. Description updated for method_definition tests
2021-03-16 sgrekhov@unipro.ru Fixes 1011. Expect an error if non-function type is called as a function
2021-03-16 sgrekhov@unipro.ru Fixes 1009. Missed experimental flag added
2021-03-16 sgrekhov@unipro.ru Fixes 1008. Calling constructor without new keyword is not an error
2021-03-16 sgrekhov@unipro.ru Fixes 1007. Missed experimental flag added
2021-03-16 sgrekhov@unipro.ru Fixes 1006. Import library first before export it
Cq-Include-Trybots: dart/try:analyzer-linux-release,analyzer-mac-release,analyzer-win-release,dart2js-strong-hostasserts-linux-ia32-d8,dart2js-strong-linux-x64-chrome,dart2js-strong-linux-x64-firefox,dart2js-strong-mac-x64-chrome,dart2js-strong-mac-x64-safari,dart2js-strong-win-x64-chrome,dart2js-strong-win-x64-edge,dart2js-strong-win-x64-firefox,dart2js-strong-win-x64-ie11,ddc-linux-release-chrome,ddc-win-release-chrome,ddk-linux-release-firefox,front-end-linux-release-x64,front-end-mac-release-x64,front-end-win-release-x64,vm-kernel-linux-debug-ia32,vm-kernel-linux-debug-x64,vm-kernel-linux-debug-x64c,vm-kernel-linux-product-x64,vm-kernel-linux-product-x64c,vm-kernel-linux-release-x64,vm-kernel-linux-release-x64c,vm-kernel-mac-debug-x64,vm-kernel-mac-debug-x64c,vm-kernel-mac-product-x64,vm-kernel-mac-product-x64c,vm-kernel-mac-release-x64,vm-kernel-mac-release-x64c,vm-kernel-precomp-linux-release-x64,vm-kernel-win-release-x64,vm-kernel-win-release-x64c
Change-Id: I7dda06f20991d47c5a6e83321c0a18005e645a72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192745
Reviewed-by: William Hesse <whesse@google.com>
This is part of a series of changes to add support for SDK expression eval tests.
Change-Id: Ia96931fdf81324fa131014b49ec2067507c451f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191022
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
This reverts commit 88ee333408.
Reason for revert: Hook added by mistake removed.
Original change's description:
> Revert "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12"
>
> This reverts commit 03e8ddd13c.
>
> Reason for revert: Change to hooks does not work with Windows.
>
> Original change's description:
> > [co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12
> >
> > 2021-03-22 sgrekhov@unipro.ruFixes#1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
> > 2021-03-22 sgrekhov@unipro.ruFixes#1027. Typo fixed
> > 2021-03-22 sgrekhov@unipro.ruFixes#1026. Missed experimental flag added
> > 2021-03-22 sgrekhov@unipro.ru Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems
> > 2021-03-19 sgrekhov@unipro.ru#1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS
> >
> > Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
> > Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303
> > Reviewed-by: William Hesse <whesse@google.com>
> > Commit-Queue: Alexander Thomas <athom@google.com>
>
> TBR=whesse@google.com,athom@google.com
>
> Change-Id: I5f66db541034377f5d68424073282080d13fd34b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try
> Cq-Include-Trybots: dart2js-nnbd-linux-x64-chrome-try
> Cq-Include-Trybots: ddc-nnbd-linux-release-chrome-try
> Cq-Include-Trybots: front-end-nnbd-linux-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-debug-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-release-simarm64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-mac-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-win-release-x64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-debug-x64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-simarm64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-x64-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192380
> Reviewed-by: William Hesse <whesse@google.com>
# Not skipping CQ checks because this is a reland.
Change-Id: Ie54fde2d92d1b2cdb3b70835f1f8c17e3c5ac477
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192384
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit 03e8ddd13c.
Reason for revert: Change to hooks does not work with Windows.
Original change's description:
> [co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12
>
> 2021-03-22 sgrekhov@unipro.ruFixes#1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
> 2021-03-22 sgrekhov@unipro.ruFixes#1027. Typo fixed
> 2021-03-22 sgrekhov@unipro.ruFixes#1026. Missed experimental flag added
> 2021-03-22 sgrekhov@unipro.ru Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems
> 2021-03-19 sgrekhov@unipro.ru#1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS
>
> Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
> Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303
> Reviewed-by: William Hesse <whesse@google.com>
> Commit-Queue: Alexander Thomas <athom@google.com>
TBR=whesse@google.com,athom@google.com
Change-Id: I5f66db541034377f5d68424073282080d13fd34b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try
Cq-Include-Trybots: dart2js-nnbd-linux-x64-chrome-try
Cq-Include-Trybots: ddc-nnbd-linux-release-chrome-try
Cq-Include-Trybots: front-end-nnbd-linux-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-debug-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-release-simarm64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-mac-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-win-release-x64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-debug-x64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-simarm64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192380
Reviewed-by: William Hesse <whesse@google.com>
2021-03-22 sgrekhov@unipro.ruFixes#1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
2021-03-22 sgrekhov@unipro.ruFixes#1027. Typo fixed
2021-03-22 sgrekhov@unipro.ruFixes#1026. Missed experimental flag added
2021-03-22 sgrekhov@unipro.ru Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems
2021-03-19 sgrekhov@unipro.ru#1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Also updated non-migrated libraries to include @dart=2.10.
Change-Id: Idcf4e54f9aa37b9b016133144af594cc932418a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192122
Reviewed-by: Gary Roumanis <grouma@google.com>
EDIT: see discussion below about breaking changes in `prefer_const_literals_to_create_immutables`.
EDIT2: looks like this was fixed upstream in analyzer 👍
Change-Id: I3fca9d074cece9cb60b8e97bdb72aa3bd3b2c2a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191762
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This is part of a series of changes to add support for SDK expression eval tests.
This change:
* Adds SDK dependencies on webkit_inspection_protocol.dart and browser_launcher.dart
* Adds dev dependencies to DDC
Change-Id: I025a1f1b59e00858a33016818b6746c57c9caec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190961
Commit-Queue: Mark Zhou <markzipan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
2021-03-17 sgrekhov@unipro.ruFixes#1017. Use => for setter returning value tests
2021-03-16 irina.arkhipets@gmail.com Issue #996: more tests for Generic functions as type arguments and bounds added.
2021-03-16 sgrekhov@unipro.ruFixes#1005. Description updated for method_definition tests
2021-03-16 sgrekhov@unipro.ruFixes#1011. Expect an error if non-function type is called as a function
2021-03-16 irina.arkhipets@gmail.com Issue #996: tests for Generic functions as type arguments and bounds re-factored, more tests added.
2021-03-15 irina.arkhipets@gmail.com Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-15 irina.arkhipets@gmail.com Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-15 sgrekhov@unipro.ru Missed experiment flag added
2021-03-12 irina.arkhipets@gmail.com Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-12 sgrekhov@unipro.ru#993. Added tests checking that Struct fields cannot have initializers
2021-03-12 sgrekhov@unipro.ru#993. Tests for not external members of Struct subtype added
2021-03-11 sgrekhov@unipro.ru#993. Use package ffi in co19 ffi tests
2021-03-09 sgrekhov@unipro.ruFixes#995. Annotations with type arguments tests added
2021-03-09 irina.arkhipets@gmail.com Issue #997: existing triple-shift tests corrected.
2021-03-09 irina.arkhipets@gmail.com More fixes for #535: split constant evaluation tests because static behavior of the strong and weak mode is different.
2021-03-04 sgrekhov@unipro.ru#993. Array tests added
2021-03-04 sgrekhov@unipro.ru#993. Pointer equality tests added
2021-03-03 sgrekhov@unipro.ru#993. Pointer.elementAt() tests added
2021-03-02 sgrekhov@unipro.ru#993. Pointer.cast() tests added
2021-03-01 sgrekhov@unipro.ru#993. Pointer tests added
2021-03-01 sgrekhov@unipro.ruFixes#936. Change expected result according to the new left top rule
2021-02-26 irina.arkhipets@gmail.comFixed#998: tests checks output streams correctly now.
2021-02-26 sgrekhov@unipro.ru#993. IntPtr tests added
2021-02-26 sgrekhov@unipro.ru#993. More Struct tests added
2021-02-25 irina.arkhipets@gmail.com Tests updated, missing issue tags added.
2021-02-25 sgrekhov@unipro.ru#1003. Isolate test fixed to not to be a racy
2021-02-25 sgrekhov@unipro.ru Issue numbers added
2021-02-24 sgrekhov@unipro.ru Issue number added
2021-02-24 sgrekhov@unipro.ru#988. Typo in error message fixed
2021-02-24 sgrekhov@unipro.ru#988. Fix test expectations
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I718644028b1d2a9fbba0c7efdf2923bb67184fde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191409
Reviewed-by: William Hesse <whesse@google.com>
No formatting changes, so no need to sync the pre-built SDK.
Change-Id: Ide5a58764e865e1226219ce6af9a5cb1444e29b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191463
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
There are no formatting changes aside from adding support for generic
metadata annotations, which are not yet used. Changes are:
- Migrated to null safety.
- Return exit code from FormatCommand.run().
Change-Id: I8892f6551541f673b8e49045665e2371ba40b026
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191182
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Last roll was from 6/18/2020.
Allows to enable "implicit-int-float-conversion" warning in the dart codebase.
Change-Id: Ida1a3a477e5bc45993dc10e0c3db410265a005ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191300
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
The code has been dead for quite some time.
TEST=ci
Change-Id: Iddcb63e14e9e4d95230f006ac05da64f444f0712
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190024
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Change-Id: Iba3cca2a342ab473bd38f6ec6bdbdbd10b5cd90f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190001
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>