Commit graph

572 commits

Author SHA1 Message Date
asiva@google.com 49d1dc7252 Address issue 13719, cleanup the status file to reflect reality.
R=regis@google.com

Review URL: https://codereview.chromium.org//1085363005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45383 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-23 20:42:28 +00:00
kmillikin@google.com 4f7c1d3d54 Clean up handling of constants in the CPS backend.
Before: constant-valued expressions were usually compiled by the JS constant
compiler task, which surprisingly produces a Dart (not JS) constant.

After: use the already computed constant value of a constant-valued
expression.  This is looked up in one of two ways depending on whether the
expression is an identifier or not.  For primitive constants (Booleans,
doubles, integers, strings, and null) simply construct them as they have not
had a value computed.

Also, fix a variety of small bugs.  In some case the fix is disabling an
incorrect code path and bailing out of the compiler.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1057483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45335 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:59:03 +00:00
karlklose@google.com 7dd2608820 Adjust test expectations for dart2js-cps-ir.
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1092013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45236 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 11:45:51 +00:00
kmillikin@google.com 00e4ba52ea CPS implementation of throw and rethrow.
Throw and rethrow are implemented as CPS expressions in tail position.

The CPS translation assumes that all expressions translate to a primitive
that is the value of the expression, and throw is an expression in Dart.
For simplicity of the translation, a non-tail throw Primitive is sometimes
used as a placeholder during the translation and removed immediately
afterward.

Both throw and rethrow are represented in the Tree IR.  In the Dart backend,
throw translates to throw and rethrow translates to rethrow.  In the JS
backend, throw translates to JS throw of a wrapped value.  Rethrow is not
currently implemented for the JS backend, it bails out of the compiler.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//1092023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45235 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-17 11:15:45 +00:00
zra@google.com 86bfd7cb30 Adds a simarmv5te build and test target.
Also:
- Removes command line flags to choose simulated arm version.
  I think we should use build targets instead, like in this change,
  to make building and testing more obvious.
- Skips pkg tests on all simulators.

R=regis@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//1077823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45181 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 20:44:43 +00:00
karlklose@google.com d839c64766 Establish test expectations for dart2js running with the CPS based backend.
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45162 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-15 11:44:02 +00:00
whesse@google.com 6e539eab53 Fix error where upgrading a closed socket to secure will hang.
BUG=dartbug.com/22658
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//990893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44324 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 16:08:09 +00:00
whesse@google.com 07d40f4fe8 Update status for macos RawSecureSocket test that times out.
A high priority bug is filed to fix this issue.
BUG=dartbug.com/22658
R=kustermann@google.com

Review URL: https://codereview.chromium.org//979923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44244 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-04 18:28:41 +00:00
whesse@google.com 454a7263ef Update test status for mips tests.
BUG=dartbug.com/22597
R=ricow@google.com

Review URL: https://codereview.chromium.org//962153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44086 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 10:37:56 +00:00
kevmoo@google.com be8aca929d Move more tests to SkipByDesign
R=whesse@google.com

Review URL: https://codereview.chromium.org//932493004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43977 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-23 21:31:12 +00:00
kevmoo@google.com 4cc4e28411 status files: trying out new SkipSlow flag
and selectively used SkipByDesign in more places

R=whesse@google.com

Review URL: https://codereview.chromium.org//928523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43815 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:21:39 +00:00
kustermann@google.com 615d1a01ac Reland "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..."
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//913753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43678 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 10:01:20 +00:00
koda@google.com 8c24d57e15 Update test status for slow ASAN bot.
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//916473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43664 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:58:35 +00:00
koda@google.com e4a3000c7a Skip OOM tests in broswer until we can make them trigger reliably there.
The VM options are not being passed in the browser.

TBR=whesse@google.com

Review URL: https://codereview.chromium.org//871863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43114 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-23 17:42:27 +00:00
sgjesse@google.com 67badc8d74 Fix incorrect handling of closing stderr on Windows
BUG=http://dartbug.com/22088
R=kustermann@google.com

Review URL: https://codereview.chromium.org//854633005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43060 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-22 09:25:17 +00:00
rmacnak@google.com 2fb0bb020b Reapply "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list."
Broken assumption in Dartium fixed in blink r188698.

R=hausner@google.com

Review URL: https://codereview.chromium.org//862093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43053 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-21 20:44:04 +00:00
rmacnak@google.com ed88ac7f0c Revert "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list."
Broke Dartium.

TBR=hausner@google.com

Review URL: https://codereview.chromium.org//863773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43026 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 20:56:59 +00:00
rmacnak@google.com 045bd762d7 Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list.
An invisible function is hidden from stack traces, will not be enumerated
by mirrors, and cannot be directly invoked by mirrors. Note that private
classes remain accessible.

Fix a few internal dart:io functions that should be private.

Fix bug where mirrors would enumerate top-level invisible functions.

Mark observatory test that was using such private functions through
mirrors as failing.

BUG=http://dartbug.com/15274
R=hausner@google.com

Review URL: https://codereview.chromium.org//816353012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43019 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 18:32:19 +00:00
sgjesse@google.com 5d67ac0f2e Update status file
TBR=lrn@google.com
BUG=http://dartbug.com/22088

Review URL: https://codereview.chromium.org//861573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42977 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-19 08:14:08 +00:00
sgjesse@google.com 027f0fe387 Update status file
Test standalone/io/stdout_stderr_non_blocking_test fails on Windows

R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//857573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42958 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-16 14:17:47 +00:00
whesse@google.com 247ff772d6 Update status files, replace "dartbug.com" with "Issue ".
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//845793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42900 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 10:27:11 +00:00
vegorov@google.com 9fcfaa8468 Support remaping of pair location inside materializations for slow paths.
Move remaping logic into Location::RemapForSlowPath to ensure that it is shared and will not get out of sync again.

BUG=http://dartbug.com/21887
R=fschneider@google.com

Review URL: https://codereview.chromium.org//811823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42396 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 15:18:51 +00:00
koda@google.com 56defa8060 Write-barrier verification on ARM.
Add and use methods on Assembler for writing and verifying object fields.
Enable tests in verified_mem mode for simarm.
Also generalize and use InitializeFieldsNoBarrierUnrolled in one more place.

R=iposva@google.com

Review URL: https://codereview.chromium.org//730343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42208 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 16:15:33 +00:00
regis@google.com 953c735532 Enable more tests on MIPS.
R=zra@google.com

Review URL: https://codereview.chromium.org//778223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42149 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 21:40:05 +00:00
regis@google.com e20569cf8b Reenable a few previously slow tests on MIPS.
R=zra@google.com

Review URL: https://codereview.chromium.org//781123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42141 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 19:32:39 +00:00
regis@google.com 1757888022 Implement mint unboxing on MIPS.
R=zra@google.com

Review URL: https://codereview.chromium.org//777943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42138 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-05 18:27:37 +00:00
koda@google.com c6bf5f2381 Support verified heap pointer writes on x64.
Port of r41607, r41700, and upcoming change:
https://codereview.chromium.org/721233002/

R=iposva@google.com

Review URL: https://codereview.chromium.org//727623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41787 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-17 18:09:42 +00:00
koda@google.com 8479136580 Support verified heap pointer writes on ia32.
With --verified_mem, use VerifiedMemory to duplicate all pointer writes in the heap, and verify that no unaccounted writes occurred.

R=iposva@google.com

Review URL: https://codereview.chromium.org//711833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41700 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-12 23:47:42 +00:00
koda@google.com fded2906b8 Make priority_queue_stress_test pass analyzer.
BUG=21468
R=whesse@google.com

Review URL: https://codereview.chromium.org//701223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41559 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-06 14:17:37 +00:00
whesse@google.com 3da2c473cd Update status for vm and analyzer.
BUG=dartbug.com/21468 dartbug.com/21469
R=ricow@google.com

Review URL: https://codereview.chromium.org//684133006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41418 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-30 12:33:50 +00:00
kustermann@google.com 360dfe4f41 Several bugfixes in dart:io's handing of sockets
This CL includes fixes for the following issues:

a) The event handler created listening socket metadata (values of a hashtable
indexed by filedescriptor) sometimes as SocketData and sometimes as
ListeningSocketData depending whether the socket has been listened to or not.
This was very buggy, in particular because multiple isolates can have a
reference to the same server socket in different states (opened, listened,
closed).

=> This should be fixed by sending the file descriptior typeMask always to the
   eventhandler.

b) A server socket cloned via the ServerSocketReference mechanism, opens a
receive port for sending (fd, address, port) to isolates/... which want to
create a server socket from the reference.
This receive port was not closed properly when calling only close() (and not
listening first).

=> This should be fixed by closing this receiveport on the ServerSocket.close()
   call as well.

c) It was assumed in the event handler that a close command needs to have the
Dart_Port in a hash table. But this is only the case if the user actually
listened to the ServerSocket. Otherwise the event handler does not know about
the server socket. This caused a NULL dereference which resulted in a SEGFAULT.

=> This should be fixed by checking if the Dart_Port is in the hashmap of the
ListeningSocketData or not.

d) Too many bits were considered when extracting token count in C++ code.

The CL includes a regression test which should trigger these issues.

BUG=21384,21383
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//665823007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41276 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-24 08:55:50 +00:00
ricow@google.com b1ecf1649c Revert revision 41241
Issue 21387  seems to have already been fixed in 41240

Review URL: https://codereview.chromium.org//636283008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41242 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-22 05:56:53 +00:00
ricow@google.com 7e26df4bbc Mark standalone/vmservice/websocket_client_test as flaky on the vm
Filed issue 21387 to track this

R=iposva@google.com

Review URL: https://codereview.chromium.org//667383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41241 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-22 05:48:39 +00:00
regis@google.com 47d36bf443 Skip vm standalone tests failing for drt runtime as well.
R=vsm@google.com

Review URL: https://codereview.chromium.org//573043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40347 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 21:13:33 +00:00
scheglov@google.com 778536d97c Issue 19682. New analyzer snapshot that fixes an inline refactoring problem.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19682

Review URL: https://codereview.chromium.org//561373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40193 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 22:47:29 +00:00
kustermann@google.com c86e1ab989 Mark http_client_stays_alive_test as skip on MIPS debug
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//517573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39650 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 12:40:34 +00:00
vegorov@google.com 9f9e250e92 Support Int32 representation for selected binary operations.
BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org//504143003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39595 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 14:49:19 +00:00
koda@google.com e2546942c3 Move service library test into observatory package.
This depends on https://codereview.chromium.org/434883002/

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//445023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38985 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 13:24:55 +00:00
whesse@google.com 19beb61abc Update mips test status.
R=ricow@google.com

Review URL: https://codereview.chromium.org//439283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38861 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 15:19:10 +00:00
koda@google.com 573b104181 Update service lib test status to Fail due to Windows symlink issue.
TBR=johnmccutchan@google.com
BUG=dart:20298

Review URL: https://codereview.chromium.org//437553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38790 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 17:33:28 +00:00
srdjan@google.com 79f2ca4896 Fix issue 20190: Mark Uint32/Int32 typed data load to produce a Mint always on 32-bit architectures, but also to have a deopt_id associates in case we may be able to optimize it to allow Smi as result. No deopt-id needs to be provided/allocated on 64-bit architectures.
R=vegorov@google.com

Review URL: https://codereview.chromium.org//414163003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38635 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-28 18:11:54 +00:00
srdjan@google.com 6cd21978f6 Add test for issue 20190.
R=hausner@google.com

Review URL: https://codereview.chromium.org//420503003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38554 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-24 21:28:47 +00:00
mlippautz@google.com f3a187c63e Reland: Fix tools/full-coverage.dart script and add standalone test.
Test checks coverage data of a given script and differentiates between:
* no coverage data
* no hits (IC=0)
* some hits (IC>0)

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//355453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37627 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 22:27:26 +00:00
mlippautz@google.com b5582cb430 Revert "Fix tools/full-coverage.dart script and add standalone test."
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//343263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37573 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-21 01:07:51 +00:00
mlippautz@google.com 1c63c09102 Fix tools/full-coverage.dart script and add standalone test.
Test checks coverage data of a given script and differentiates between:
* no coverage data
* no hits (IC=0)
* some hits (IC>0)

BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//348473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37571 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-20 23:25:05 +00:00
lrn@google.com c719cb2b33 Mark standalone/io/skip_dart2js_compilations_test as failing on Win.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//329993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37490 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 12:40:11 +00:00
zra@google.com 4a7e022d97 Adds intrinsics for arm64.
Also enables tests that no longer time-out.

R=regis@google.com

Review URL: https://codereview.chromium.org//285403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36330 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 21:35:32 +00:00
ricow@google.com 87736b119b Mark language/megamorphic_no_such_method_test and standalone/io/http_shutdown_test as skip on simarm64
I did _not_ file a new bug since there is already a section with tests that times out on simarm64 without a bug, so I assume this is being worked on.

The cl that triggered this is pretty strange, should not really have an impact:
https://code.google.com/p/dart/source/detail?r=36290

R=lrn@google.com

Review URL: https://codereview.chromium.org//296483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36294 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 12:59:53 +00:00
zra@google.com 2f7cf531a0 Adds javascript overflow checking to arm64.
Also skips a test for timing out on the bot.

R=regis@google.com

Review URL: https://codereview.chromium.org//288993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36232 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 17:38:13 +00:00
zra@google.com 03f2f289b4 Adds Math Min/Max to arm64.
Also fixes bugs and enables tests.

R=regis@google.com

Review URL: https://codereview.chromium.org//284843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36116 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-13 18:10:16 +00:00