Commit graph

13776 commits

Author SHA1 Message Date
Brian Wilkerson f45f21ae42 Remove the now unnecessary flag from test files
R=asiva@google.com, eernst@google.com

Review URL: https://codereview.chromium.org/2540843002 .
2016-12-02 07:43:05 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'.
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
2016-12-01 16:47:33 -08:00
Martin Kustermann 117924ed15 Update kernel status files for precompilation after refactoring
The tests for which dartk is missing a compile-time error will run the precompiler on the result and will therefore have a different status entry (even though it is caused by dartk).

Review URL: https://codereview.chromium.org/2547523002 .
2016-12-01 14:48:24 +01:00
Martin Kustermann ff8951a515 VM: [Kernel] Allocate objects in KernelReader/kernel::FlowGraphBuilder in Heap::kOld if appropriate
If we generate too much surviving objects in Heap::kNew during program reading
time or flow graph construction time we trigger (very aggressive) growth of new
space.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2539173002 .
2016-12-01 13:51:29 +01:00
Martin Kustermann abd77cab64 Refactor kernel-related status files
To make it clear in the status file whether a crash (or other issues) are coming
from the dartk compiler or from the vm, this CL introduces new status file
markers which are the normal markers prefixed with Dartk (e.g. DartkCrash).

Furthermore this CL groups common failures
  * compiler: dartk & dartkp
  * runtime: vm & dart_precompiled
into shared status file blocks, thereby deduplicating failures (which removes around 500 lines).

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2543973002 .
2016-12-01 13:48:35 +01:00
Johnni Winther 489199eff1 Disallow null in spanFromSpannable.
Closes #27938

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2537303004 .
2016-12-01 10:53:56 +01:00
William Hesse 10e535a5ee Update status for dart_style package and dom/shadowroot co19 windows.
BUG=https://github.com/dart-lang/dart_style/issues/562
TBR=rnystrom@google.com

Review URL: https://codereview.chromium.org/2543463003 .
2016-11-30 16:52:17 +01:00
Johnni Winther 33303ffea5 Resolve type arguments to generic methods.
R=eernst@google.com

Review URL: https://codereview.chromium.org/2535373003 .
2016-11-30 12:44:29 +01:00
William Hesse de0c7acfd7 Update status for flaky Windows tests
BUG=https://github.com/dart-lang/sdk/issues/27935
R=eernst@google.com

Review URL: https://codereview.chromium.org/2539033002 .
2016-11-30 11:41:17 +01:00
Asger Feldthaus ecf9acd26c Update vm-kernel status file.
BUG=
R=jensj@google.com

Review URL: https://codereview.chromium.org/2538063002 .
2016-11-30 10:38:21 +01:00
Johnni Winther 40bf5d321e Handle 'dynamic' as type argument in generic calls.
R=eernst@google.com

Review URL: https://codereview.chromium.org/2541473002 .
2016-11-30 09:29:35 +01:00
Johnni Winther 44bdc75827 Support patched generic methods.
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2535213003 .
2016-11-30 09:20:42 +01:00
Johnni Winther 3af747810f More refactoring of enqueuers
- refactor enqueuer/strategy/impact-visitor relations
- make helper methods/fields private

R=het@google.com

Review URL: https://codereview.chromium.org/2535143003 .
2016-11-30 09:12:08 +01:00
Ben Konyi d406779dd8 Changes to language.status to fix broken tests on vm-reload and analyzer.
R=zra@google.com

Review URL: https://codereview.chromium.org/2541513003 .
2016-11-29 16:07:56 -08:00
Ben Konyi 9428946b48 Fixed failing tests (for real this time hopefully) for build #2323
Updated language.status to address failure of regress_27201_test caused by lack of deferred loading support.

BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2542473002 .
2016-11-29 15:13:16 -08:00
Ben Konyi 061cbb170e Updated language.status to address failure of regress_27201_test caused by lack of deferred loading support.
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2542453002 .
2016-11-29 14:32:15 -08:00
Ben Konyi 7e918f5b48 Fixed the conditions of an assert causing the debug VM to crash when trying to load a library from an invalid path. Created copy of a previous deferred_import_t02.dart test from co19 as a regression test until deferred_import_t02.dart is reverted to the previous test.
Fixes #27201

R=zra@google.com

Review URL: https://codereview.chromium.org/2537253002 .
2016-11-29 14:07:19 -08:00
Brian Wilkerson 37bc2efa1f Update status file after enabling read-only access to initializing formals
Review URL: https://codereview.chromium.org/2538803002 .
2016-11-29 09:56:27 -08:00
William Hesse e2a48dbf38 Update status for failing tests
BUG=https://github.com/dart-lang/sdk/issues/27925
R=eernst@google.com

Review URL: https://codereview.chromium.org/2536183002 .
2016-11-29 14:26:27 +01:00
Martin Kustermann 8698589dee VM: [Kernel] Update status file for precompiled (debug) builders
Review URL: https://codereview.chromium.org/2538713002 .
2016-11-29 10:32:53 +01:00
Johnni Winther 258ed14ae3 Decouple WorkItem from Compiler
- Remove Compiler and Enqueuer arguments from WorkItem.run
- Move show progress from WorkItem.run to Compiler.showXProgress methods
- Move Compiler.analyzeElement to Resolution.computeWorldImpact
- Move Compiler.analyze to ResolutionWorkItem Move Compiler.codegen to CodegenWorkItem

R=het@google.com

Review URL: https://codereview.chromium.org/2531303002 .
2016-11-29 09:31:41 +01:00
Johnni Winther fbc69f1e9e Merge QueueFilter with EnqueuerStrategy
R=het@google.com

Review URL: https://codereview.chromium.org/2529273003 .
2016-11-29 09:22:13 +01:00
Johnni Winther 417d4d7a50 Further encapsulate Enqueuer
R=het@google.com

Review URL: https://codereview.chromium.org/2527403002 .
2016-11-29 09:14:09 +01:00
Johnni Winther c102d3f72a Remove direct access to enqueuer through use of WorldImpact
R=het@google.com

Review URL: https://codereview.chromium.org/2527973002 .
2016-11-29 09:05:53 +01:00
Johnni Winther bf13fc1b28 Handle assert with message in type inference
Closes #27882

R=sra@google.com

Review URL: https://codereview.chromium.org/2528043003 .
2016-11-29 08:36:27 +01:00
Matthias Hausner 6e84b56256 Fix dartium test expectations
Fallout from initializing formal access change.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/2535083002 .
2016-11-28 14:04:14 -08:00
Matthias Hausner b48435197a Turn on initializing formal access
Change default value of --initializing_formal_access to true.

BUG=27892
R=regis@google.com

Review URL: https://codereview.chromium.org/2540453002 .
2016-11-28 13:15:15 -08:00
Martin Kustermann f81bcb660a VM: [Kernel] Update status file for precompiled (release) builders
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2537543002 .
2016-11-28 19:23:23 +01:00
William Hesse 0bb0386634 Increase subprocess timeout in standalone/io/test_runner_test.
A passing subtest was sometimes taking more than 10 seconds, and
timing out.

BUG=https://github.com/dart-lang/sdk/issues/20351
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2535773003 .
2016-11-28 17:42:47 +01:00
William Hesse 6f7005ee71 Update status for co19 tests on browsers.
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2538443002 .
2016-11-28 16:32:41 +01:00
Vyacheslav Egorov 8eceda053f VM: [Kernel] Don't add implicit getters for top level fields into the library dictionary.
Tree shaker can't cope with this and produces incorrect snapshots that contains tree shaken classes.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2536683002 .
2016-11-28 15:50:24 +01:00
Lasse Reichstein Holst Nielsen 7957a1c256 Make EfficientLength extend Iterable.
This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2467113003 .

Committed: b08fb1373f
2016-11-28 08:04:04 +01:00
Erik Ernst 1edb84bf8f Removed status entries for initformal tests with dart2js/browser.
Needed after landing https://codereview.chromium.org/2141023002/.

Review URL: https://codereview.chromium.org/2532733002 .
2016-11-25 17:21:24 +01:00
William Hesse c3333f9c40 Update dartium status for issue 26644
BUG=https://github.com/dart-lang/sdk/issues/26644

Review URL: https://codereview.chromium.org/2526283005 .
2016-11-25 14:49:12 +01:00
William Hesse 52cb4500b5 Update co19 status for issue 26644
BUG=https://github.com/dart-lang/sdk/issues/26644

Review URL: https://codereview.chromium.org/2528103003 .
2016-11-25 14:32:01 +01:00
William Hesse 177f9c690f Update MacOS dartium status for co19 tests
BUG=
R=sortie@google.com

Review URL: https://codereview.chromium.org/2534583002 .
2016-11-25 13:51:47 +01:00
William Hesse 30db1d7ab0 Update status for passing co19 tests
BUG=https://github.com/dart-lang/co19/issues/68
BUG=https://github.com/dart-lang/co19/issues/81
R=sortie@google.com

Review URL: https://codereview.chromium.org/2531033002 .
2016-11-25 13:15:02 +01:00
Erik Ernst f234278474 Status updates required after CL 2141023002.
Review URL: https://codereview.chromium.org/2524363004 .
2016-11-25 12:16:49 +01:00
Sergey G. Grekhov 76425f920f Update co19 test suite dependency to commit f05d5aee5930
co19 test suite updated to commit f05d5aee5930bfd487aedf832fbd7b832f502b15 of dart-lang/co19 repository, dated Nov 21 2016.

Status files are updated for this roll.
2016-11-25 12:06:39 +01:00
Asger Feldthaus 963e1ebc55 Do not sort named parameters on FunctionNode.
This was originally done to be consistent with FunctionType,
where the named parameters are sorted, but for FunctionNode
it is not necessary.

It causes issues for natives that expect parameters to be
declared in a certain order. It is also an issue if we
ever want to reuse the kernel format for summaries, where
it is also preferable to present the named parameters in
their original order.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2527933002 .
2016-11-25 11:22:37 +01:00
Erik Ernst 4912fd1501 Make initializing formal access available by default
This CL changes dart2js such that the effect that we used to get with
option '--initializing-formal-access' is now obtained unconditionally,
i.e., that extension is now enabled by default.

dart2js will continue to accept the option, such that scripts passing
the option will not break.

The CL is _not_ intended to be landed at this time, the plan is to
enable the feature in a coordinated manner when all tools are ready.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2141023002 .
2016-11-25 10:15:21 +01:00
Vyacheslav Egorov 73ef820ec1 VM: [Kernel] Relax assertions in SSA construction and in Kernel loading.
- Kernel-to-IL translation leaves behind some unused constants without temp indices assigned.

- Let compile time errors propagate instead of failing with FATAL error in the post load class finalization.

R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org/2528763002 .
2016-11-24 16:19:22 +01:00
William Hesse 81b71e74f8 Revert "Roll co19 tests and status files"
This reverts commit 27883bfbc0.
We will reland this once the status file updates are (nearly) perfect.

BUG=
R=sortie@google.com

Review URL: https://codereview.chromium.org/2530863002 .
2016-11-24 15:19:31 +01:00
William Hesse 27883bfbc0 Roll co19 tests and status files
This updates co19 to commit 2e98931a4d40781110220d4b2d131efa6fc4669d
Merge branch 'co19patch' into rebased_co19_patch

Sort status lines ignoring alphabetical order

Status files updated according lates buildbot run results

Status files updated according the latest Chrome run

dart2js files updated for FF and Chrome on Linux

DEPS and VM status files updated

status file updated according Linux run

Status files updated according latest Dartium run

dart2js status file updated according the last tests run on FF

dart2js status file updated according the last tests run on Chrome and FF

Analyzer and VM status files are updated according last versions of co19 and sdk

BUG=
R=sortie@google.com

Review URL: https://codereview.chromium.org/2528953002 .
2016-11-24 15:01:53 +01:00
Ryan Macnak 12de13d1ae An isolate created with spawn function doesn't necessarily agree with its parent on the library private keys.
(The long-standing issue that spawn function should use snapshots would also fix this.)

Encountered by the analyzer in https://codereview.chromium.org/2492933002/

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2509413002 .
2016-11-23 15:36:01 -08:00
Asger Feldthaus b0ffc26dab Fix vm-kernel status file after merging kernel.
The buildbots run tests against the checked-in version of analyzer,
not the one in the pubspec, which is why the tests behave differently.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org/2524973002 .
2016-11-23 14:19:34 +01:00
Asger Feldthaus ce428a1f20 Complete merge of kernel repo into SDK.
This removes third_party/pkg/kernel and changes dependencies to
refer to pkg/kernel instead.

Some status files are updated to reflect new test outcomes.
2016-11-23 12:46:29 +01:00
Erik Ernst 7809d25b92 Remove the ability in dart2js to turn off syntax-only generic methods.
This CL removes all the checks for 'enableGenericMethodSyntax' in the
implementation, which takes away the ability to turn this feature off
and simplifies the code.

As a result, `ParserOptions` is now empty; we may want to remove it,
but this CL does not do that.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2521073003 .
2016-11-23 12:16:30 +01:00
William Hesse 4bfe727db6 Update status for Firefox 50
BUG=https://github.com/dart-lang/sdk/issues/27873
BUG=https://github.com/dart-lang/sdk/issues/27872
BUG=https://github.com/dart-lang/sdk/issues/27871
BUG=https://github.com/dart-lang/sdk/issues/27867
R=sortie@google.com

Review URL: https://codereview.chromium.org/2526493004 .
2016-11-23 09:49:01 +01:00
Martin Kustermann 656be7a7aa Update status file for kernel
Review URL: https://codereview.chromium.org/2525883002 .
2016-11-23 08:58:18 +01:00