Set<dynamic>.every() and Set<dynamic>.any() require their callback to
have type `(dynamic) -> bool`.
Change-Id: I075728af72dbcda90e343e8af42ef3f4eda2dfbe
Reviewed-on: https://dart-review.googlesource.com/19201
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
The maps used by this test have a reified type argument of `dynamic`,
so the callbacks we pass to `any` and `every` need to be typed
accordingly.
Change-Id: Idd00478cc7667560ad81167db8d4816c8a7fff8d
Reviewed-on: https://dart-review.googlesource.com/19450
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Also add test cases to verify that type argument substitution works
properly for other kinds of super calls.
Change-Id: I7a04c85cd13e83403a0e86efa82f30ae71dc0b15
Reviewed-on: https://dart-review.googlesource.com/19621
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
- Load vmservice_io library only in the service isolate or when an AOT snapshot is being generated
This should account for the following issues:
- https://github.com/dart-lang/sdk/issues/31203 - there should be a vmservice_io_strong.dill file
- https://github.com/dart-lang/sdk/issues/30158 - Consider extracting flutter vmservice_sky into
separate .dill from platform.dill
- https://github.com/dart-lang/sdk/issues/30111 - support compiling vmservice with an external
outline of the sdk
Bug:
Change-Id: If945ec05afe8127e288e8d3b55172c0f7c3d6e7a
Reviewed-on: https://dart-review.googlesource.com/18147
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Chandra <sivachandra@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Handling of integer literals is corrected according to the informal spec
for the fixed-size integers:
https://github.com/dart-lang/sdk/blob/master/docs/language/informal/int64.md
This change allows unsigned 64-bit hexadecimal literals and MIN_INT64
to be used when running on the VM with --limit-ints-to-64-bits option.
Change-Id: Ied7a7688768bcf4ff40ab5b499dd71622d2c3948
Reviewed-on: https://dart-review.googlesource.com/19400
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
List.expand() requires a callback that returns an Iterable.
Change-Id: I969ee15bed5b219a688779317d89f50190b42e06
Reviewed-on: https://dart-review.googlesource.com/19402
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
The multi-test language_2/assertion_initializer_const_error2_test used
to have outcomes caused by a syntax error (arising for all other cases
than `cc02` in this multi-test). This CL moves that comma such that all
subtests have the intended shape, and the test actually tests the
intended property. This causes a rather large number of status file
entries to be adjusted.
Change-Id: I2e176611813e5706e553fb51cda7553f17dfa300
Reviewed-on: https://dart-review.googlesource.com/19191
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
This fixes a number of issues caused by constant evalation reporting
an error, but not correctly propergating that error in AOT mode.
Fixes#31298
Bug:
Change-Id: I43d378e96f033a9bd5bc0d90e1c2cf130d2cce2e
Reviewed-on: https://dart-review.googlesource.com/19183
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
* When building method invocation that requires checking receiver for null
and has type arguments make sure that we duplicate type arguments above the
receiver temporary. Before this fix the stack ended up looking like
`[type_arguments_temp][receiver_temp][receiver]...` and after the fix it
looks like `[type_arguments_temp][receiver_temp][type_arguments][receiver]...`.
* Fix how we generate StaticCall with type arguments: we were adjusting
arguments count by one manually if type arguments were present at each call site
to FlowGraphBuilder::StaticCall. This is very brittle and were leading to
incorrect number of arguments used if caller forgot to adjust. Instead handle
this inside FlowGraphBuilder::StaticCall just like other similar methods do it
(e.g. FlowGraphBuilder::InstanceCall).
Fixes https://github.com/dart-lang/sdk/issues/31297
Bug:
Change-Id: I3713fdde838d159985c68b456f911eab7746824c
Reviewed-on: https://dart-review.googlesource.com/19563
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
The local function test() in testQueryParameters() expects its map to
have type Map<String, String>. Most of the time this happens
automatically by type inference, but when we create the map using `var
map = new Map()` we need to specify the type arguments explicitly.
Change-Id: I2c6c868af776c3fbd25d862ac8a5bfb9147715dc
Reviewed-on: https://dart-review.googlesource.com/19454
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
List.expand() requires a callback that returns an Iterable.
Change-Id: I5a665cf9ea4ee78be876912b31300342ac141bd4
Reviewed-on: https://dart-review.googlesource.com/19451
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
For now only getKernel() uses the new compilation method.
There are several new failing tests because redirection factories
are not serialized/deserialized correctly yet (but I saw kernel
support comming for it), and outlines don't include private fields (
which we want to work around by storing just names).
R=paulberry@google.com, sigmund@google.com
Bug:
Change-Id: I0d964862066ac0ee9e7b5c7b1d3802171a874aef
Reviewed-on: https://dart-review.googlesource.com/19440
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
This both works as a tester for correct canonicalization of status files and can
be used later to check if changes to status files follow the guide lines.
It checks that:
- Comments only exists before a section or after a test path entry.
- That there are no disjunctions in headers.
- That variables and clauses are correctly ordered in section headers.
- That paths are alphabetically ordered in sections.
- That sections are lexicographically ordered with respect to negation.
Bug:
Change-Id: I0f5e2cc16f20bb48ee53a9a55a22aaab710e32ff
Reviewed-on: https://dart-review.googlesource.com/17786
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
This CL starts merging functionality in the analyzer parser adapter
with identical functionality in the analyzer tests.
Change-Id: Ia74f0f67319a4dba67a24a27a65a2c2c32d0a2a4
Reviewed-on: https://dart-review.googlesource.com/19453
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
Note: there special case code to check for duplicate named args when
exactly two named arguments are given. The special case code already
works; this CL fixes the general case.
Change-Id: I36ad6eff8f4377b15a4730a0e35c109605f2b763
Reviewed-on: https://dart-review.googlesource.com/19404
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
The original builder was sharded and ran both normal and checked tests. It
always took around 1 hour and 45 minutes to run.
The builder has been split up into two, one running normal and one running
checked tests and unit test.
The builder dart2js-hostchecked-checked-linux-ia32-d8 should be added to luci.
Bug:
Change-Id: I7fc3045aa6fc0b2e6927e3a3092396339da6e9b3
Reviewed-on: https://dart-review.googlesource.com/17787
Reviewed-by: Alexander Thomas <athom@google.com>
Note that the current recipe runs strong libraries, which I think is no longer
in use and also runs the same unit tests (not in strong mode) as the non-strong
builders. Is that an error or?
Bug:
Change-Id: Ia573747ed00bac617995844be757ebbdb325874e
Reviewed-on: https://dart-review.googlesource.com/18544
Reviewed-by: Alexander Thomas <athom@google.com>
The sets used by this test have a reified type argument of `dynamic`,
so the callbacks we pass to `forEach`, `map`, `where`, etc. need to be
typed accordingly.
Change-Id: I82dd02e021a04acd559c97db740ed2277886ca1b
Reviewed-on: https://dart-review.googlesource.com/19452
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
There's no such thing as "unchecked" mode in Dart 2.0. Strong mode
semantics imply that all types are checked.
Change-Id: I377a181f58e71f087d075ff17d7c751bf8b34b13
Reviewed-on: https://dart-review.googlesource.com/19449
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
The type signature of throwsNSME needs to be specified so that map and
list literals appearing later in the source file have their types
correctly inferred.
Change-Id: Ifa60670dc5fb7d39b6f8f028e1b55152e736554c
Reviewed-on: https://dart-review.googlesource.com/19480
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
The queues used by this test have a reified type argument of
`dynamic`, so the callbacks we pass to `map`, `any`, `every`,
etc. need to be typed accordingly.
Change-Id: I67a7e5b1ac0a768fdd4862350a017abb07877ff9
Reviewed-on: https://dart-review.googlesource.com/19444
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
The maps returned by JSON.decode have reified type Map<dynamic,
dynamic>, so when we iterate through them using forEach, we need to
pass in a callback that doesn't expect the key type to be String.
Change-Id: I93bb13705916c668ab6fc207ffbf4f50554ee979
Reviewed-on: https://dart-review.googlesource.com/19443
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Future<dynamic>.then<S>() requires its argument to have type
`(dynamic) -> FutureOr<S>`.
Change-Id: Ifef1ae85d0e59fa00648eb00e96fb0f752b4dbc4
Reviewed-on: https://dart-review.googlesource.com/19401
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
