Commit graph

479 commits

Author SHA1 Message Date
hausner@google.com 03d1af54b0 Fix crash with cyclic exports
Issue 6060, 6595

R=srdjan@google.com

Review URL: https://codereview.chromium.org//23658007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26957 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 23:09:35 +00:00
srdjan@google.com 7f11fd9dd6 More co19 test triaging.
R=iposva@google.com

Review URL: https://codereview.chromium.org//23534026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26921 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 15:43:19 +00:00
srdjan@google.com c9a5f90276 Triage more co19 tests.
R=iposva@google.com

Review URL: https://codereview.chromium.org//23665005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26886 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 18:26:57 +00:00
zra@google.com 97ca1b9544 Updates status file for failing co19 tests on ARM hardware.
Issue 12868

R=regis@google.com

Review URL: https://codereview.chromium.org//23710007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26825 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 23:03:18 +00:00
hausner@google.com 25c962be80 Move test failure to co19 status file
Test Language/07_Classes/6_Constructors/1_Generative_Constructors_A04_t15 is wrong. Filed co19 issue 547 and updated status files.

R=iposva@google.com

Review URL: https://codereview.chromium.org//23449008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26818 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 21:57:31 +00:00
kustermann@google.com 1b1d0051b9 co19-roll to r559
R=ricow@google.com

Review URL: https://codereview.chromium.org//23505006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26799 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 16:32:47 +00:00
hausner@google.com 3e9467672f Require case expressions to be compile-time constants
Remove legacy semantics in switch statement compilation.

Still to be added: analysis that all case expressions are
of the same type.

R=regis@google.com

Review URL: https://codereview.chromium.org//23640004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26749 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 23:07:59 +00:00
hausner@google.com c2fa1cf490 Add compilation error on named parameters with private names
Remove bogus test cases.

Fixes issue 5743, 3502

R=srdjan@google.com

Review URL: https://codereview.chromium.org//23478005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26719 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 16:41:33 +00:00
kustermann@google.com 66636f0f5d LibTest/async/Timer/Timer_A02_t01 is failing on dart2js-ie as well, moving to general section
R=ricow@google.com

Review URL: https://codereview.chromium.org//22929041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26592 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 10:29:38 +00:00
hausner@google.com 3876a9e23c Remove assertion in compile-time constant map literals
We had a left-over assertion that keys are strings.

Fixes issue 12505.

R=regis@google.com

Review URL: https://codereview.chromium.org//23004015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26549 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 19:45:13 +00:00
hausner@google.com 6b20c0ecaa Detect circular dependencies in compile time constants
Fix issue 1681

R=srdjan@google.com

Review URL: https://codereview.chromium.org//22897019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26491 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 23:55:59 +00:00
iposva@google.com 17fcb92e8b - Copied one too many lines from the checked failures with "co19 issue 498" to the
shared status file.

Review URL: https://codereview.chromium.org//23304011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26406 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 22:56:28 +00:00
iposva@google.com 4aea3ac7c0 - Consolidate co19 issues hit in dart2js and the VM into a single file.
R=srdjan@google.com

Review URL: https://codereview.chromium.org//22877034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26397 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 21:56:35 +00:00
srdjan@google.com f9ec27882a A small co19 issue number fix.
Review URL: https://codereview.chromium.org//23354003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26386 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 20:24:35 +00:00
srdjan@google.com 19ca899cba More updates to co19 status
R=zra@google.com

Review URL: https://codereview.chromium.org//23102005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26381 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 18:58:44 +00:00
floitsch@google.com 86a1f7103a Mark Timer.periodic tests as flaky.
R=ricow@google.com

Review URL: https://codereview.chromium.org//22845005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26354 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 13:51:48 +00:00
ricow@google.com f940bc801e Update runtime status files for co19 with more flaky tests.
Ivan: I did not file a new bug for this since Martin already talked with you guys about this. Do you have a bug where we that we can track all these future/stream/timing based tests to?

R=kustermann@google.com

Review URL: https://codereview.chromium.org//23351003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26353 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 13:35:55 +00:00
lrn@google.com 5343ef8d32 Add documentation to dart:math pow function.
Also add test, and modify implementation to match on the single case where it didn't.

BUG= http://dartdog.com/1952
R=floitsch@google.com

Review URL: https://codereview.chromium.org//22943005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26347 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 12:23:00 +00:00
srdjan@google.com a804fb534b More co19 bug triaging an dbug number updates.
R=regis@google.com

Review URL: https://codereview.chromium.org//22791005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26323 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-19 19:04:04 +00:00
srdjan@google.com eeed026c6c Triaging co19 failures.
R=regis@google.com

Review URL: https://codereview.chromium.org//22796012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26299 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 22:32:03 +00:00
srdjan@google.com 2a37f441e7 Update co19 test status.
R=regis@google.com

Review URL: https://codereview.chromium.org//23103008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26291 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 20:31:45 +00:00
kustermann@google.com 2c4a968f53 Marked more co19 tests flaky on the VM
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//23175004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26264 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 10:38:54 +00:00
kustermann@google.com e0f6bc9741 Disable co19 on all dart2js builders except ie9 again
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//23072020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26263 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 09:51:35 +00:00
kustermann@google.com ba700f9f9d co19-roll to r546
R=ricow@google.com

Review URL: https://codereview.chromium.org//23283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26259 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-16 08:36:40 +00:00
dgrove@google.com e1c1269953 co19/LibTest/core/Stopwatch/start_A01_t03 flaky on Windows .
R=ricow@google.com

Review URL: https://codereview.chromium.org//22875004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26164 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 22:38:37 +00:00
zra@google.com 8ffef7528d Bug fix and status file updates for MIPS HW.
R=regis@google.com

Review URL: https://codereview.chromium.org//22828004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26037 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 21:45:41 +00:00
regis@google.com 9eb12ad303 Implement updated method overriding rules in the vm (issue 11495).
Introduce --error-on-bad-override flag and use it when generating snapshots.
Fix signature checking when patching methods.
Fix errors in patch files.
Fix receiver type of constructors.
Fix finalization of mixin application typedefs.
Update tests and status files.

R=asiva@google.com

Review URL: https://codereview.chromium.org//22685007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26027 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-12 20:28:52 +00:00
cbracken@google.com 43fae66ebf Fixes to get Dart VM compiling on Ubuntu 13.04, Debian Wheezy.
* Convince gcc 4.7.x that len is initialized before use in callers of ReadFileFully()
* Cast RawObject* to intptr_t to avoid strict-aliasing error on gcc 4.7.x
* Replace two calls to strerror_r() with strerror() on Linux. When _GNU_SOURCE is
  defined to be non-zero (as it is on Dart Linux builds), strerror_r() is
  defined to return a char*, which is the correct error string to use. When
  _GNU_SOURCE is zero, the XSI-compliant definition is used and the error
  message is returned in the char* param. Surrounding error logging uses
  strerror() which solves the problem.
* Replace int literals with char literals in test string definition.
* co19 math/tan_A01_t01 passes on Ubuntu 13.04.

Original issues:
https://code.google.com/p/dart/issues/detail?id=12085
https://code.google.com/p/dart/issues/detail?id=8807

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//22381002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25890 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 17:28:04 +00:00
regis@google.com 09bcdc6d6d Fix VM implementation of CastError not to extend TypeError (issue 5280).
Remove non-compliant fields in various Error classes (issue 10144).
Remove implicit constructor when patching in a constructor (issue 12217).
Patch corelib Error classes instead of declaring subclasses.
Update tests and status files.

R=asiva@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//21832003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25782 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-05 18:35:04 +00:00
zra@google.com fa2ad38a31 Enables per-function far-branches for ARM and MIPS.
R=regis@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//21363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25723 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-01 20:51:46 +00:00
regis@google.com 3b7cdf80a0 Update VM to handle malformed types according to revised spec (issues 9055,
12105, 7247).
Update language tests.
Update status files.
Allow map literals to specify a key type that is not a String.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//21049012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25666 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-31 15:20:28 +00:00
srdjan@google.com a4a3db86ac Triage remaining co19 tests for VM. Update also dart2js and dart2dart status where applicable.
R=ahe@google.com, regis@google.com

Review URL: https://codereview.chromium.org//19647015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25429 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 17:43:47 +00:00
srdjan@google.com 4d0774a448 Fix Queue's iterator to allocate an iterator using type parameter. Enable now passing tests.
Review URL: https://codereview.chromium.org//19857010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25417 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-24 15:18:11 +00:00
srdjan@google.com 1e169d3a23 Remove explicit argument type checks in math min and max.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//19638002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25112 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 18:15:47 +00:00
regis@google.com e8a722870b Support type parameters and classes as expression in the vm.
Turn many compile-time errors into runtime errors per latest spec.
Triage affected tests.

R=hausner@google.com

Review URL: https://codereview.chromium.org//18801007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24861 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 19:35:56 +00:00
hausner@google.com 98883150d6 Partial solution to analyze potentially constant expressions
This change adds code that detects if an expression can definitively
never be constant. We use this to analyze the initializer expressions
in const constructors. This check is not entirely water tight, but
together with the checks in canonicalization code catches most
illegal initializer expressions.

The const constructor of class Symbol turns out to be illegal. The
name verification check can't be part of the constructor code.

R=iposva@google.com

Review URL: https://codereview.chromium.org//18649003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24749 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 20:47:14 +00:00
floitsch@google.com 898a3d8867 Relax method override restrictions.
This implements part of issue 11495.

BUG= http://dartbug.com/11495
R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24731
Reverted: https://code.google.com/p/dart/source/detail?r=24733

Review URL: https://codereview.chromium.org//18600007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24736 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 18:02:11 +00:00
floitsch@google.com 438767ca3a Add stackTrace to Error object.
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//18529003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24726 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-03 14:51:30 +00:00
kmillikin@google.com 5f9331e20c Fix a VM bug in the handling of try/catch/finally.
In the case that code in the catch block threw in any fashion, the
finally block was not executed.  Fix this by properly treating the
finally block of try/catch/finally as an exception handler for the
catch block.

R=fschneider@google.com, srdjan@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=430

Review URL: https://codereview.chromium.org//17893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24583 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 12:28:56 +00:00
iposva@google.com 50fc824be9 - Remove arguments definition test from the VM.
- Update tests still referring to it.

R=regis@google.com

Review URL: https://codereview.chromium.org//17977002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24539 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 18:37:53 +00:00
regis@google.com 7370d2a2f6 Minor status file update for ARM.
R=zra@google.com

Review URL: https://codereview.chromium.org//18066005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24533 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 17:12:49 +00:00
zra@google.com 60392c70fd Implements external array access for mips.
R=regis@google.com

Review URL: https://codereview.chromium.org//17907005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24524 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 16:42:39 +00:00
zra@google.com 646e8fe9f6 Fixes status file.
TBR

Review URL: https://codereview.chromium.org//17946002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24492 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 21:37:32 +00:00
zra@google.com 6b33d60322 Fixes co19 status file.
Forgot about windows...

R=regis@google.com

Review URL: https://codereview.chromium.org//17816007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24490 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 21:25:18 +00:00
zra@google.com bc703b348f Updates co19 status file for simarm and simmips.
Also marks corelib/collection_to_string_test as
Pass, Crash for arm hardware, as it crashes
occasionally.

R=regis@google.com

Review URL: https://codereview.chromium.org//17932003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24489 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 20:54:17 +00:00
zra@google.com ce82a777e5 Fixes integer negate intrinsic for arm and mips.
R=regis@google.com

Review URL: https://codereview.chromium.org//17847006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24481 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 17:43:48 +00:00
zra@google.com 364c5406b8 Fixes floating point bug in ARM simulator.
Adjusts status files to match.

R=regis@google.com

Review URL: https://codereview.chromium.org//17742003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24473 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-26 15:48:22 +00:00
iposva@google.com 11632110c6 - Revert r24441 until issues found have been addressed.
Review URL: https://codereview.chromium.org//17769004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24443 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 23:38:45 +00:00
iposva@google.com ddc3e13f8a - Trial balloon for removal of argument definition test.
This change removes the support for the ? operator.

R=asiva@google.com, hausner@google.com

Review URL: https://codereview.chromium.org//17765003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24441 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 23:04:19 +00:00
zra@google.com 99772465b5 Updates status files for arm hardware
R=regis@google.com

Review URL: https://codereview.chromium.org//17732002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24431 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 20:16:02 +00:00