Commit graph

49692 commits

Author SHA1 Message Date
Zachary Anderson
d1b542f8cd Reland: [infra] Roll clang toolchain forward
Build spuriously worked after initial roll due to stale files hanging
around longer than they should have. This CL relands and updates
(hopefully) all the necessary paths.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/3010023002 .
2017-09-01 11:15:40 -07:00
Brian Wilkerson
e8b0a7cbf9 Revert earlier changes to fix bots (TBR)
Review-Url: https://codereview.chromium.org/3010913002 .
2017-09-01 10:43:13 -07:00
Stephen Adams
dbcc7835a7 rank_stacks tweaks
- Cluster stacks on printed prefix instead of entire stack.
- Print records with a stack that is a prefix of another stack (this happens for d8 errors where there is no dart2js stack)

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3007023002 .
2017-09-01 10:26:10 -07:00
Emily Fortuna
b1dd578da7 Don't try to add abstract methods to the codegen work queue to generate bodies
BUG=
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/3012683002 .
2017-09-01 10:21:03 -07:00
Emily Fortuna
4e10f68d2c Updated generic_methods_local_variable_declaration_test status.
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3004263002 .
2017-09-01 10:08:09 -07:00
Johnni Winther
374df045e7 Handle forwarding constructors to unnamed mixin applications
+ handle instance fields from mixins
+ change class sorting to put unnamed mixin applications last

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3005823002 .
2017-09-01 19:07:02 +02:00
Sigmund Cherem
650a2d72a2 Undo status change.
It appears this no longer reproduces (it might have been from a stale drt).

Review-Url: https://codereview.chromium.org/3011853002 .
2017-09-01 10:03:17 -07:00
Ryan Macnak
86f602d020 Initial idle GC logic.
Use the speed of previous scavenges to estimate the time required for the next scavenge. When we receive an initial notification, perform a scavenge if we have allocated enough and we estimate we can complete the scavenge before the deadline.

Expand the time recorded for a scavenge to include safepointing and iterating roots.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/3001423002 .
2017-09-01 09:38:08 -07:00
Konstantin Shcheglov
5517f356c8 Check for null in _getStandardStateLocation().
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/3006023002 .
2017-09-01 09:07:51 -07:00
Terry Lucas
0585e74b63 Fixed analyzer test to use dart2js not dartium
R=paulberry@google.com

Committed: 704de3bb3e
Review-Url: https://codereview.chromium.org/3004153002 .
2017-09-01 09:03:16 -07:00
William Hesse
002917b79c Fix error in commit bae6ab5a7a
"Split the dart_sdk bot script into two runs ..." used sys.argv[2]
instead of sys.argv[1]

BUG=
TBR=terry@google.com

Review-Url: https://codereview.chromium.org/3012713002 .
2017-09-01 17:21:03 +02:00
Janice Collins
51cc9689b3 Remove corelib and corelib_strong and migrate last two remaining tests.
This includes a migration of linked_hash_map_from_iterable_test and
stacktrace_current_test, which were migrated without changes.

BUG=
R=rnystrom@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/3004073002 .
2017-09-01 08:11:15 -07:00
Brian Wilkerson
47162b9174 Fix and triage more tests
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/3005973002 .
2017-09-01 07:52:05 -07:00
William Hesse
bae6ab5a7a Split the dart_sdk bot script into two runs, one with only apidocs.
BUG=
R=terry@google.com, vegorov@google.com

Review-Url: https://codereview.chromium.org/3004233002 .
2017-09-01 16:50:00 +02:00
Johnni Winther
f97a961cbe Support annotations on assignment and postfix operations
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3007903002 .
2017-09-01 16:31:41 +02:00
Peter von der Ahé
b460a25459 Store actual Reference(s) for additional exports.
R=johnniwinther@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/3009953003 .
2017-09-01 16:30:43 +02:00
Samir Jindel
f0941f7c7d Improve the performance of closure-converted code.
Summary:

Previously, we would create a wrapper function in the flowgraph around converted
closures, which would forward all the closure's arguments and unpack the context
argument before calling the real closure function.

Now, we perform the unpacking at the top of the real function to avoid having
any wrapper function.

Previously, captured parameters would still be appear live to the GC even if
they're updated, because after they are copied into the context, all updates to
them are done there.

Now, as in regular closures, we zero-out the parameter variable after copying
it's value into the context, avoiding potential memory leaks.

Test Plan:

Ran the closure conversion test suite.
Ran benchmarks on Golem -- all statistically significant regressions are gone.

BUG=
R=dmitryas@google.com, regis@google.com

Review-Url: https://codereview.chromium.org/3008923002 .
2017-09-01 14:59:40 +02:00
William Hesse
bf6ea50b95 Revert "[infra] Roll clang toolchain forward"
This reverts commit a60fb341f5.
The toolchain.stamp files are missing on buildbots, causing failures.
This occurred on the second run after the commit, indicating that
perhaps the files are no longer created, or something.

BUG=
R=mkroghj@google.com
CC=zra@google.com

Review-Url: https://codereview.chromium.org/3009983002 .
2017-09-01 14:42:35 +02:00
Morten Krogh-Jespersen
9f9aafc337 Updated sanitizeCategory to better account for category names.
R=whesse@google.com

Review-Url: https://codereview.chromium.org/3011813002 .
2017-09-01 13:37:00 +02:00
Zach Anderson
a60fb341f5 [infra] Roll clang toolchain forward
This is to match the version used by Flutter.

R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/3005903002 .
2017-08-31 21:49:02 -07:00
Carlo Bernaschina
4ea98fba56 Allow port and host override in Observatory
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/3009013002 .
2017-08-31 17:37:40 -07:00
William Hesse
e61f6e72ee Revert "Fixed analyzer test to use dart2js not dartium"
This reverts commit 704de3bb3e.
This is needed because we reverted the commit that this was a follow-up to:
4a58918382

It was reverted in a8cab7a205

TBR=terry@google.com
BUG=

Review-Url: https://codereview.chromium.org/3004183002 .
2017-09-01 01:41:25 +02:00
William Hesse
a8cab7a205 Revert "Removed Dartium SDK libs"
This reverts commit 4a58918382.
That commit seems to have broken docgen on the html libraries.

BUG=
TBR=terry@google.com

Review-Url: https://codereview.chromium.org/3004173002 .
2017-09-01 00:47:57 +02:00
Jennifer Messerly
c1e58bfb69 fix #30591, ensure all extension methods are generated
R=leafp@google.com

Review-Url: https://codereview.chromium.org/3011763002 .
2017-08-31 14:19:52 -07:00
Konstantin Shcheglov
9cee3776ac Add the new @notForDart2 annotation and mark several tests.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/3010833002 .
2017-08-31 14:13:02 -07:00
Konstantin Shcheglov
d1988c9c7f Fix for using enums as InterfaceType(s) when resynthesize from Kernel.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/3006983002 .
2017-08-31 14:06:48 -07:00
Konstantin Shcheglov
5e67987ecb Don't treat typedef-typed formal parameters as funtion-type from resynthesize from Kernel.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/3004163002 .
2017-08-31 13:59:24 -07:00
Vijay Menon
e96be63fd5 Fix ddc build_sdk step
R=leafp@google.com

Review-Url: https://codereview.chromium.org/3011753002 .
2017-08-31 13:53:18 -07:00
Leaf Petersen
eb53858ad6 Inheritance manager fix for fuzzy arrows
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/3006643002 .
2017-08-31 12:59:36 -07:00
Konstantin Shcheglov
b617cde778 Resynthesize references to type parameters in default expressions from Kernel.
Update the related tests to take into account the fact that front-end
infers type arguments, but the summaries linker does not.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/3009933002 .
2017-08-31 12:37:26 -07:00
Terry Lucas
704de3bb3e Fixed analyzer test to use dart2js not dartium
TBR=paulberry@google.com

Review-Url: https://codereview.chromium.org/3004153002 .
2017-08-31 12:25:29 -07:00
Leaf Petersen
1c94f7a604 Reland and refactor fuzzy arrow hints.
This restores the functionality from https://codereview.chromium.org/3012593002/, with some small refactors.

The test breakage that caused the revert is fixed in https://codereview.chromium.org/3004143002/ .

Also adds a couple of drive by fuzzy arrow fixes.

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3006893002 .
2017-08-31 12:18:51 -07:00
Konstantin Shcheglov
d704073f40 Resynthesize ?? expressions from Kernel.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/3006973002 .
2017-08-31 12:18:22 -07:00
Leaf Petersen
05af4fb787 Disable fuzzy arrow hints in front_end and dart2js
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3004143002 .
2017-08-31 12:17:47 -07:00
Emily Fortuna
5fb24d38ca Clean up status language2 status file.
BUG=
R=kevmoo@google.com, sra@google.com

Review-Url: https://codereview.chromium.org/3011723002 .
2017-08-31 12:16:31 -07:00
Konstantin Shcheglov
39b921ecce Transitively include outlines of all public members of Class(es).
R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/3004943002 .
2017-08-31 11:35:08 -07:00
Emily Fortuna
ea038bd8e0 Pass in this as a free variable to the closure class
BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3009903002 .
2017-08-31 10:41:19 -07:00
Brian Wilkerson
2ee7750f8a Mark unsafe token access in AstBuilder
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/3012663002 .
2017-08-31 10:29:57 -07:00
P.Y. Laligand
59516d9794 Added an analysis server argument to set the location of the session cache. (#30583) 2017-08-31 10:25:50 -07:00
Brian Wilkerson
e1e8f3b130 Fasta test cleanup
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/3011693002 .
2017-08-31 10:10:37 -07:00
Paul Berry
991ea77f32 Additional test cases related to bug #30568
These test cases verify that when a method calls super, compile-time
arity checks are performed against the actual target of super, rather
than the interface exposed by the base class.

R=lrn@google.com

Review-Url: https://codereview.chromium.org/3005893002 .
2017-08-31 13:10:00 -04:00
Carlo Bernaschina
05367c3db8 Update iOS FileSystemWatcher::WatchPath signature
TBR=zra@google.com

Review-Url: https://codereview.chromium.org/3011703002 .
2017-08-31 09:46:28 -07:00
Peter von der Ahé
bb90bb5b30 Ensure all tests are analyzed.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3012643002 .
2017-08-31 17:10:01 +02:00
Ben Konyi
adfc7a6b72 Migrated test lock 217 to Dart 2.0.
Fairly simple block, with only minor changes made to lib_2/mirrors tests
needed for strong mode compliance.

BUG=

Review-Url: https://codereview.chromium.org/2997283003 .
2017-08-31 07:47:36 -07:00
Peter von der Ahé
24ec5691d0 Don't re-export hidden members.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3004123002 .
2017-08-31 16:45:18 +02:00
Terry Lucas
4a58918382 Removed Dartium SDK libs
First stage remove the libraries that are no longer part of 1.25 and beyond.

R=alanknight@google.com, sigmund@google.com

Committed: a18908461a
Committed: d96561af08
Review-Url: https://codereview.chromium.org/3008563002 .
2017-08-31 07:17:23 -07:00
Ben Konyi
143ea83cf3 Migrated test block 220 to Dart 2.0.
No changes to tests.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/3001373002 .
2017-08-31 07:16:58 -07:00
Peter von der Ahé
f0277b32e8 Revert "Store actual Reference(s) for additional exports."
This reverts commit 234c4a7f49.

Revert "Fix for ScopeBuilder[] - look into setters too."

This reverts commit 7924f4c42f.

Revert "Don't include BuiltinTypeBuilder(s) into additional exports."

This reverts commit e28aac09c4.

The reason for reverting is that the two follow-up commits aren't correct.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3004973002 .
2017-08-31 16:13:50 +02:00
Ben Konyi
002ebba6f4 Migrated test block 216 to Dart 2.0.
No changes made to this block.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995343002 .
2017-08-31 07:02:53 -07:00
Brian Wilkerson
6c67db11cf Fix more of the Fasta tests
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/3004103002 .
2017-08-31 06:34:55 -07:00