This CL adds support to build.py and test.py for building/testing
a VM with the interpreter on x64, e.g.:
$ ./tools/gn.py -m release -a x64 --bytecode
$ ./tools/build.py -m release -a x64 --bytecode runtime
$ ./tools/test.py -m release -a x64 -r vm -c dartkb language_2
Change-Id: I956d23790636609d4a2e71129481fcbd7afef9a0
Reviewed-on: https://dart-review.googlesource.com/65206
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
It explains the intent behind testing `--dart-sdk` vs just
`--dart-sdk-summary` and adds a TODO about how we can improve it.
Change-Id: Ib53027a6509e4df0df52632345c32d9bdfccd991
Reviewed-on: https://dart-review.googlesource.com/64764
Reviewed-by: Bob Nystrom <rnystrom@google.com>
The Dart SDK may change incompatibly and require a corresponding update to
the Flutter Engine when Flutter Enginer rolls its Dart SDK. The flutter
targets on Golem uses a 3-way HEAD of the Dart SDK, the Flutter Engine, and
the Flutter Framework, meaning that it needs to apply the corresponding
update to the Flutter Engine immediately. Otherwise the Flutter targets will
be broken and not successfully run benchmarks until the next Flutter roll.
This change lets the Dart SDK make incompatible changes that affects the
Flutter Engine by checking in the corresponding patch into the Dart SDK
along with the incompatible change. The build step will determine what the
latest roll is by looking up which Dart SDK Hash the Flutter Engine has
pinned. If a patch exists for that hash, then that patch is applied to the
Flutter Engine.
For instance, if the Flutter Engine commit ab12 has pinned the Dart SDK
commit cd34, then it the patch tools/patches/flutter-engine/cd34.patch is
applied. Once the Flutter Engine rolls its Dart Engine, usually by
applying an equivalent patch, the roll commit will start refering to an
non-existent patch and the HEADs will be built together pristine again.
Finally cd32.patch can be removed from new versions of the Dart SDK.
The tools/patches/flutter-engine/apply.sh script is applies such patches in
3-way HEAD builds. The create.sh script is meant to be used by developers
when making incompatible changes to the Dart SDK that affects the Flutter
Engine. The top level tools/3xhead_flutter_hooks.sh script is meant to be
used by the CI as forward compatibility if additional hooks are added in the
future.
Change-Id: Ibf8e125b26dac319ba1c5302c003d7668155336a
Reviewed-on: https://dart-review.googlesource.com/64684
Reviewed-by: Martin Kustermann <kustermann@google.com>
Remove accidental legacy test section from front_end bots.
Remove no-op --strong arg from test matrix.
Change-Id: Icafc7eeb3c25f5816596affeaf8f75a7328fb907
Reviewed-on: https://dart-review.googlesource.com/64520
Reviewed-by: Jonas Termansen <sortie@google.com>
Cq-Include-Trybots:luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: I37f3b78180133c31f6267b76c3eeb16f8c00325a
Reviewed-on: https://dart-review.googlesource.com/63623
Reviewed-by: Erik Ernst <eernst@google.com>
test.py was changed, this makes the gardening scripts use the same default for
strong-mode/no-preview-dart-2
Change-Id: I974e288a95811ed8980f0ffbe2d8a9135fbfb5f0
Reviewed-on: https://dart-review.googlesource.com/63987
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
* uses 6 shards for try bots like the recipes used to do
* add a strong-hostasserts configuration. Currently the test.py flag is called
--host-checked, but all it does is enable assertions (no more checked mode in
Dart2)
Change-Id: I50c565bb210fbb98334b7d84556c3ab98c38b22a
Reviewed-on: https://dart-review.googlesource.com/63682
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Change-Id: I91bf09600d0e5f099737be0363228cad6d0b5329
Reviewed-on: https://dart-review.googlesource.com/63642
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
After reviewing all recipes, we needed a few changes to bring the test matrix to parity:
- we needed to add strong-mode coverage (mostly in d8 at this time)
- we needed to add fast-startup coverage on all browsers
This however includes a bit more coverage than the existing recipes:
- strong-mode coverage in d8 now includes all suites, not just language_2 and corelib_2
- legacy coverage in ie11 includes all suites, not just html and co19
Next steps:
- move the remaining dart2js bots to the test matrix using the existing and new builders
- fix .status files on builders that include more suites (d8-strong + ie11)
- fix .status files on new Dart 2.0 builders
- add new Dart 2.0 builders to the waterfall
- eventually remove Dart1 builders.
Change-Id: Iec0a7fef7176cc81d3ced5e34c8dd63d33b7079e
Reviewed-on: https://dart-review.googlesource.com/61086
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
The builder configurations have been moved to the "builder_configurations" key,
and the "configurations" key will be used for test configurations.
Change-Id: Ic61f1646378a13526dc59b713f272cea51d9781b
Reviewed-on: https://dart-review.googlesource.com/63580
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Currently unimplemented, will allow us to pass the correct configurations
in the test matrix and new recipe when working on the implementation.
Change-Id: I2207e6f9e3d12884ab578a2d258493f8eff861f4
Reviewed-on: https://dart-review.googlesource.com/63582
Reviewed-by: Alexander Thomas <athom@google.com>
TBR=alanknight@google.com
Change-Id: Iea06485fc54cdbcb30f1cc1bf7a10f97335e242a
Reviewed-on: https://dart-review.googlesource.com/63442
Reviewed-by: Alan Knight <alanknight@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
Revert "[gardening] Update arm64 status files."
This reverts commit ff0a1d6b67 as
updating multiplier is better solution than updating status files.
Bug: http://dartbug.com/33659
Change-Id: I064964e1fafe9c77fb24d5e9c324927b75cbacb0
Reviewed-on: https://dart-review.googlesource.com/63340
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
The key "configurations" will be used for named configurations, after
the recipes are updated to use the new "builder_configurations" key.
Change-Id: Ifec6803f3aaee83cbc48c591ac306af3ef951933
Reviewed-on: https://dart-review.googlesource.com/62147
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
* Update README.
* Create 32-bit Windows CIPD package in update.sh.
* Remove architecture specific executable names.
Change-Id: I553b282188bc76e82df0a6e40200e3311fdc6f1d
Reviewed-on: https://dart-review.googlesource.com/62842
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
#33659
Change-Id: I94fccf4bbce2f0140bf0d6efa953d44b290df856
Reviewed-on: https://dart-review.googlesource.com/62840
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Change-Id: I0a35afcb840bf3969e60d3b13c5dffe21a14884f
Reviewed-on: https://dart-review.googlesource.com/62805
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Remove --preview-dart-2 option.
Change-Id: I4ca07e00391ee9a9f7f454d0b56e82898c38250c
Reviewed-on: https://dart-review.googlesource.com/62601
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
When these flags are used, the flags "--use-cfe" and
"--use-fasta-parser" are passed to the dartanalyzer command.
(The compiler -cdart2analyzer runs the dartanalyzer compiler).
The variables $analyzer_use_fasta and $analyzer_use_fasta_parser are
available in status files, and the $fasta variable is set in both
cases.
Change-Id: Ic42033fb8fb3a19431f380abdf949564758c8d7b
BUG: dartbug.com/33510
Reviewed-on: https://dart-review.googlesource.com/62302
Reviewed-by: Devon Carew <devoncarew@google.com>
Updated to pass --dfe to invocations of the
checked-in SDK.
Change-Id: I47e122422926d235f166972669c8c2cb18a89735
Reviewed-on: https://dart-review.googlesource.com/62201
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
- Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed.
Fixes#21919R=vsm@google.com
Change-Id: Ib4c4140350d3cef096954e67010f922df9f2310a
Reviewed-on: https://dart-review.googlesource.com/60702
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>