Terry Lucas
490421d166
Fixed Service Workers and any Promise/Future API with a Dictionary parameter.
...
APIs in dart:html (that take a Dictionary) will receive a Dart Map parameter. The Map parameter
must be converted to a Dictionary before passing to the browser's API. Before this change,
any Promise/Future API with a Map/Dictionary parameter never called the Promise and didn't
return a Dart Future - now it does.
This caused a number of breaks especially in Service Workers (register, etc.). Here is a
complete list of the fixed APIs:
BackgroundFetchManager
Future<BackgroundFetchRegistration> fetch(String id, Object requests, [Map options])
CacheStorage
Future match(/*RequestInfo*/ request, [Map options])
CanMakePayment
Future<List<Client>> matchAll([Map options])
CookieStore
Future getAll([Map options])
Future set(String name, String value, [Map options])
CredentialsContainer
Future get([Map options])
Future create([Map options])
DirectoryEntry
Future<Entry> _getDirectory(String path, {Map options})
Future<Entry> _getFile(String path, {Map options})
ImageCapture
Future setOptions(Map photoSettings)
MediaCapabilities
Future<MediaCapabilitiesInfo> decodingInfo(Map configuration)
Future<MediaCapabilitiesInfo> encodingInfo(Map configuration)
MediaStreamTrack
Future applyConstraints([Map constraints])
Navigator
Future requestKeyboardLock([List<String> keyCodes])
Future requestMidiAccess([Map options])
Future share([Map data])
OffscreenCanvas
Future<Blob> convertToBlob([Map options])
PaymentInstruments
Future set(String instrumentKey, Map details)
Permissions
Future<PermissionStatus> query(Map permission)
Future<PermissionStatus> request(Map permissions)
Future<PermissionStatus> revoke(Map permission)
PushManager
Future permissionState([Map options])
Future<PushSubscription> subscribe([Map options])
RtcPeerConnection
REMOVED: Future createAnswer([options_OR_successCallback,
RtcPeerConnectionErrorCallback failureCallback,
Map mediaConstraints])
REMOVED: Future createOffer([options_OR_successCallback,
RtcPeerConnectionErrorCallback failureCallback,
Map rtcOfferOptions])
REMOVED: Future setLocalDescription(Map description, VoidCallback successCallback,
[RtcPeerConnectionErrorCallback failureCallback])
REMOVED: Future setLocalDescription(Map description, VoidCallback successCallback,
[RtcPeerConnectionErrorCallback failureCallback])
Future<RtcSessionDescription> createAnswer([Map options])
Future<RtcSessionDescription> createOffer([Map options])
Future setLocalDescription(Map description)
Future setRemoteDescription(Map description)
ServiceWorkerContainer
Future<ServiceWorkerRegistration> register(String url, [Map options])
ServiceWorkerRegistration
Future<List<Notification>> getNotifications([Map filter])
Future showNotification(String title, [Map options])
VRDevice
Future requestSession([Map options])
Future supportsSession([Map options])
VRSession
Future requestFrameOfReference(String type, [Map options])
Window
Future fetch(/*RequestInfo*/ input, [Map init])
WorkerGlobalScope
Future fetch(/*RequestInfo*/ input, [Map init])
In addition, exposed Service Worker "self" as a static getter named "instance". The
instance is exposed on four different Service Worker classes and can throw a InstanceTypeError
if the instance isn't of the class expected (WorkerGlobalScope.instance will always work
and not throw):
* SharedWorkerGlobalScope.instance
* DedicatedWorkerGlobalScope.instance
* ServiceWorkerGlobalScope.instance
* WorkerGlobalScope.instance
R=vsm@google.com
Bug: #34202
Change-Id: I641ccbff7cc771465dd32c73db20eba5d6667939
Reviewed-on: https://dart-review.googlesource.com/c/74482
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-10-14 22:48:33 +00:00
Terry Lucas
7b77fa217b
Fixed callbacks typedef to be List instead of a generic typed List.
...
Fixed getLegacyStats - shouldn't have a JSName annotation.
Fixes #33891
R=sigmund@google.com
Change-Id: Ie9761ad4f3c69fc875cdb1f0d096f48d1528671b
Reviewed-on: https://dart-review.googlesource.com/66400
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-07-24 19:14:08 +00:00
Terry Lucas
6d25212302
getStats Future should be strongly typed.
...
TBR=kevmoo@google.com
Change-Id: I4c4a6376f84b346e676245e5984136adfe3074aa
Reviewed-on: https://dart-review.googlesource.com/62128
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-06-25 19:25:04 +00:00
Terry Lucas
8fedfc7f8c
Removed DomName, DosEditable, and experimental annoations they are unused.
...
R=kevmoo@google.com ,vsm@google.com
Fixes #32304
Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-06-18 18:48:03 +00:00
Terry Lucas
dd8988c9b2
- Moved all WebGL rendering/drawing constants to synthesized class WebGL.
...
- Removed obsolete Dartium/_blink code.
R=kevmoo@google.com
Change-Id: I81a6f0d5bfe33592ff8ae9c85db9266e898c2861
Reviewed-on: https://dart-review.googlesource.com/60380
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-06-15 17:08:54 +00:00
Terry Lucas
f479435bca
- Removed custom handling of fill - it was wrong the method is now overloaded.
...
- Associate the JS class SpeechSyntesisVoice with the correct Dart class (DDC).
- Top-level querySelectorAll wasn't generic.
- Handle "static" for attributes in the IDLs.
Fixes #33147
Fixes #33178
Fixes #31886
Fixes #20585
R=vsm@google.com
Change-Id: Ic75a2bfc66670b72342269be259408b610547dab
Reviewed-on: https://dart-review.googlesource.com/59240
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-06-15 02:25:13 +00:00
Terry Lucas
eea2dff20d
Added support for members of type Promise.
...
Fixes #31046
R=sra@google.com
Change-Id: Id1e8d415b91a842bd8e2f50c6064c24aaaed9d98
Reviewed-on: https://dart-review.googlesource.com/59460
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-06-13 18:20:53 +00:00
Terry Lucas
5ec940a2e0
Updated to expose APIs promiseToFuture calls for users.
...
Fixes #33226
R=kevmoo@google.com , sra@google.com
Change-Id: I04995b33e9445d0fcef8d874315f14fd272018d1
Reviewed-on: https://dart-review.googlesource.com/57482
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-06-07 01:40:22 +00:00
Terry Lucas
cf87b84f7d
Support Promise to Future for both DDC and dart2js.
...
APIs in the newer Chrome IDLs support more JS style promises. The Dart web libraries now hookup those promises and return a Dart Future.
Additionally, a new type maplike is exposed in the IDL this is exposed too.
Change-Id: I44175877eb95f4d910586d42c0139fb182483f82
Reviewed-on: https://dart-review.googlesource.com/49800
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-05-23 04:08:14 +00:00
Terry Lucas
34be5de0c7
Fixed _DomRect class to map to both ClientRect and DOMRect for browser backward compat.
...
R=sra@google.com ,sigmund@google.com
Change-Id: I2f5ccae15bcd993ab1e15ab556a25d6e0cd1d450
Reviewed-on: https://dart-review.googlesource.com/50504
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-04-10 21:18:45 +00:00
Terry Lucas
3e6b8717fe
Fixed GamePadList not working in DDC and hide MessagePort.start operation.
...
Fixes https://github.com/dart-lang/sdk/issues/31029
R=vsm@google.com
Change-Id: I757538eec1ebcf42204e7de0807a48a4757f3faf
Reviewed-on: https://dart-review.googlesource.com/49740
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-04-05 15:13:17 +00:00
Terry Lucas
bc75856e54
Update getClientRects, removed xtab, removed bogus entry in dom.json,
...
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.
Fixed all tests using query and queryAll.
Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675
R=kevmoo@google.com
Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-27 20:45:33 +00:00
Terry Lucas
581c512345
Fixed DOMRectList not having a prototype field.
...
TBR=vsm@google.com
Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-20 01:08:47 +00:00
Terry Lucas
ef6273cba0
Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
...
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.
Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#
Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 09:41:04 +00:00
Terry Lucas
9f09ef0af3
- Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and
...
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used). The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.
Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter. The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:
Uncaught TypeError: t1.get$target is not a function
R=vsm@google.com ,gabrielchow@google.com,sra@google.com
Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-23 14:29:45 +00:00
Terry Lucas
d7a8aa155f
Fixed a number of File API methods in DDC.
...
R=vsm@google.com
Change-Id: I77881201f1e89f731476655476eb865e10d581a1
Reviewed-on: https://dart-review.googlesource.com/38164
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-02-05 22:29:00 +00:00
Terry Lucas
0a02050867
Fixed DirectoryReader returned from createReader to exist in DDC.
...
R=vsm@google.com
Change-Id: I6761da70b2f51f235534ee10fa0b7cb7a7a98659
Reviewed-on: https://dart-review.googlesource.com/36020
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-01-19 18:14:05 +00:00
Terry Lucas
476b1e02a9
Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
...
Also, updated status files to correctly fix failures in FF, IE and removed other spurious status entries.
R=alanknight@google.com ,vsm@google.com
Change-Id: Ic965103d892ff4d5d119712e3187e829f57cd022
Reviewed-on: https://dart-review.googlesource.com/31800
Reviewed-by: Terry Lucas <terry@google.com>
2017-12-29 23:51:02 +00:00
Terry Lucas
0af98266ab
Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test."
...
This reverts commit 0c8294e4a0
.
Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2017-12-23 01:59:38 +00:00
Terry Lucas
0c8294e4a0
Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
...
R=alanknight@google.com ,vsm@google.com
Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
2017-12-22 22:57:34 +00:00
Terry Lucas
529add3834
DDC fix to expose classes which are only created inside of the browser.
...
R=vsm@google.com
Change-Id: I27ede73ac84a72ee9b5e8b3b0a706ade82b2aa59
Reviewed-on: https://dart-review.googlesource.com/25500
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2017-12-13 03:03:09 +00:00
Terry Lucas
352f9fd859
Fixed bad indent not flushing emitted files.
...
Removed Dartium code emission.
TBR: alanknight@google.com ,vsm@google.com
Change-Id: Ib027f542b238c90311f6838e67b4b8d27815374c
Reviewed-on: https://dart-review.googlesource.com/3280
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2017-09-05 14:43:08 +00:00
Alan Knight
0700adc633
Fix the go.sh script for a completely new repo.
...
BUG=
Review-Url: https://codereview.chromium.org/2981193002 .
2017-07-18 13:44:08 -07:00
Terry Lucas
621b12f324
Removed DARTIUM codegen for IDLS (sdk/lib/dartium)
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2978213002 .
2017-07-18 11:02:02 -07:00
Terry Lucas
657daa96a8
First step in removing dartium from IDL generation in TIP of master.
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2982143002 .
2017-07-18 08:40:39 -07:00
Alan Knight
789de57cdf
Allow setting unknown CSS properties, e.g. CSS variables
...
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2976213002 .
2017-07-17 14:56:31 -07:00
Terry Lucas
1265b4c674
Fixed readPixels not working in Dartium.
...
BUG=11614
R=alanknight@google.com , jacobr@google.com
Review-Url: https://codereview.chromium.org/2975953002 .
2017-07-11 13:12:51 -07:00
Terry Lucas
8ab1a87aba
Typedefs and IDL file order between platforms could generated different files.
...
TBR=alanknight@google.com ,vsm@google.com
Review-Url: https://codereview.chromium.org/2948493002 .
2017-06-18 11:54:29 -07:00
Terry Lucas
b3a90540f1
Fix sound not playing in Dartium checked mode.
...
Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls.
Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations
with optional arguments that are Promises.
https://github.com/dart-lang/sdk/issues/29810
TBR=alanknight@google.com ,kevmoo@google.com
Review-Url: https://codereview.chromium.org/2940543002 .
2017-06-12 22:50:12 -07:00
Terry Lucas
3cbacefbe3
Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation.
...
R=alanknight@google.com ,sigmund@google.com
Review-Url: https://codereview.chromium.org/2932793002 .
2017-06-08 20:44:30 -07:00
Alan Knight
6f71f9c80b
Revert "[Experiment] Stop suppressing DragEvent"
...
This reverts commit fbbb974670
.
Also updates the cached_patches.dart file.
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2907563003 .
2017-05-25 11:16:10 -07:00
Alan Knight
e6c38ea30f
Remove JS_CONST from CssStyleDeclaration, causes DDC problems
...
BUG=
R=sra@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2896393002 .
2017-05-23 14:48:08 -07:00
Alan Knight
fbbb974670
[Experiment] Stop suppressing DragEvent
...
BUG=
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2898673003 .
2017-05-22 14:10:05 -07:00
Stephen Adams
9c3d439b1e
dart2js + html: getBoundingClientRect() returns a ClientRect
...
Gives better code since the general Rectangle requires getInterceptor
dispatch.
BUG= https://github.com/dart-lang/sdk/issues/29602
R=jacobr@google.com , terry@google.com
Review-Url: https://codereview.chromium.org/2879403002 .
2017-05-16 13:48:04 -07:00
Stephen Adams
89b9c7c8dd
html: AudoTrackList is a List
...
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2884813002 .
2017-05-15 14:44:35 -07:00
Stephen Adams
01ba5f8d74
fix KeyEvent and KeyboardEvent
...
Some keyboard specific properties moved in the IDL from UIEvent to
KeyboardEvent. We has done work to hide them on UIEvent; this needed
to be updated.
TBR=terry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883623004 .
2017-05-12 16:03:01 -07:00
Stephen Adams
ca3d90c4cd
Prevent ExtendableMessageEvent.data from thwarting DOM tree-shaking
...
We can't have the [data] and [source] getters typed as Object.
This causes it to appear that all DOM types are instantiated.
I have modelled the annotations after the same getters from
MessageEvent.
TBR=jacobr@google.com
BUG=
Review-Url: https://codereview.chromium.org/2879763002 .
2017-05-11 19:31:20 -07:00
Stephen Adams
0879884d80
web_audio: rename OfflineAudioContext.suspend
...
Rename member to avoid warning due to incompatible signature of base class method of same name.
TBR=terry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2872023006 .
2017-05-11 18:05:09 -07:00
Stephen Adams
f3734a9fc5
dom: Recognize __getter__ indexers
...
BUG=
R=alanknight@google.com
Review-Url: https://codereview.chromium.org/2879663002 .
2017-05-11 13:59:41 -07:00
Terry Lucas
f27144d7b5
Roll 50: Updated for push to origin/master.
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
Alan Knight
cedd8a6854
Format dart:html and related generated files on output
...
BUG=
R=jacobr@google.com , terry@google.com
Review URL: https://codereview.chromium.org/2858323003 .
2017-05-05 10:09:00 -07:00
Stephen Adams
ea2c9cba39
dart2js_html: Fix for issue 29538 - some returned lists may be null
...
Annotate querySelectorAll as not-null to recover code quality.
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2857143003 .
2017-05-03 14:26:38 -07:00
Erik Corry
aa6353b6da
Dart SDK Spelling b, c, and d.
...
R=kmillikin@google.com
BUG=
Review-Url: https://codereview.chromium.org/2850783002 .
2017-05-01 08:28:10 +02:00
Jacob Richman
119b2d58ce
Format all files under tools and utils directory.
...
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2827793002 .
2017-04-20 09:08:31 -07:00
Stephen Adams
14c7c3c556
Redo "Refined types for most HtmlElement factory constructors"
...
Fix: ShadowElement is not always present.
Original:
Committed: b7b12b564a
Reverted: 963df1e3e1
BUG=
Review-Url: https://codereview.chromium.org/2718713003 .
2017-02-24 14:28:58 -08:00
Stephen Adams
963df1e3e1
Revert "Refined types for most HtmlElement factory constructors"
...
Need to fix ShadowElement
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2710323004 .
2017-02-24 14:15:37 -08:00
Stephen Adams
b7b12b564a
Refined types for most HtmlElement factory constructors
...
The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element.
The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined.
This tends to improve the code generated for idioms like
new DivElement()..classes.add('foo')
var e1 = new DivElement();
e1.children.add(e2);
BUG=
R=alanknight@google.com
Review-Url: https://codereview.chromium.org/2705213003 .
2017-02-24 11:23:06 -08:00
Alan Knight
de05077537
Revert "Add Selection.toString() calling the native method"
...
This reverts commit 01e6e00499
.
BUG=
Review URL: https://codereview.chromium.org/2678593002 .
2017-02-03 17:02:06 -08:00
Alan Knight
01e6e00499
Add Selection.toString() calling the native method
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org/2669103003 .
2017-02-03 10:24:18 -08:00
Kulshekhar Kabra
b42dbe524c
Add documentation for a method ( #28209 )
...
* Add documentation for a method
Adds docs for the `getPropertyValue` method of the `CssStyleDeclaration` class in the `html` package
* Remove unneeded extra line
2017-01-16 09:18:27 +01:00
Terry Lucas
4b497fb319
Fixed checked mode error for resolvePackageUri.
...
TBR=asiva@google.com
Review-Url: https://codereview.chromium.org/2626643003 .
2017-01-10 09:00:16 -08:00
Terry Lucas
559ae993d1
Added VMLibraryHooks setup for Dartium to support resolvePackageUri.
...
BUG=25594
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2611353002 .
2017-01-10 07:25:10 -08:00
Harry Terkelsen
1d749a2fec
record that Gamepad.buttons creates GamepadButtons
...
This also extends the html generator to be able to generate List implementations with nullable element types
Fixes https://github.com/dart-lang/sdk/issues/27073
R=sra@google.com , terry@google.com
Review URL: https://codereview.chromium.org/2242203002 .
2016-08-16 13:56:32 -07:00
Harry Terkelsen
faaff39aa9
Record that MediaStream creates MediaStreamTracks
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2168473002 .
2016-07-19 17:00:04 -07:00
William Hesse
bde8d3efc6
Revert "Don't call _ensureRequestAnimationFrame in Dartium."
...
This reverts commit bf8eeef6a0
.
Revert "Fix animationFrameRequest for dartium."
This reverts commit 3daaf3849f
.
BUG=https://github.com/dart-lang/sdk/issues/26906
Review URL: https://codereview.chromium.org/2159183003 .
2016-07-19 13:56:36 +02:00
Alan Knight
30b489578d
Revert "Reapply zone tasks."
...
This reverts commit 6a7c037aa6
.
BUG=
Review URL: https://codereview.chromium.org/2162643002 .
2016-07-18 13:12:36 -07:00
Terry Lucas
2b1816c869
Added switch to disable generating cached_patches.dart file (Dartium only).
...
The switch --no-cached-patches to be used by Dart enlistment (non-Dartium) and need to
re-gen the sdk/lib files using:
./go.sh --no-cached-patches
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2154863002 .
2016-07-18 05:45:33 -07:00
Alan Knight
e610d803b1
Update test status for webgl extension tests, fix one typo in extension name
...
BUG=
Review URL: https://codereview.chromium.org/2152393002 .
2016-07-15 15:00:15 -07:00
Alan Knight
b9316f9882
Recognize WEBGL extensions on Firefox (copy with regenerated files)
...
Both of the following objects need to map to Dart type 'AngleInstancedArrays'
[object ANGLEInstancedArrays]
[object ANGLE_instanced_arrays]
Fixes https://github.com/dart-lang/sdk/issues/26850
BUG=
patch from issue 2147093002 at patchset 1 (http://crrev.com/2147093002#ps1 )
R=sra@google.com
Review URL: https://codereview.chromium.org/2150003002 .
2016-07-15 12:48:22 -07:00
Florian Loitsch
3daaf3849f
Fix animationFrameRequest for dartium.
...
Review URL: https://codereview.chromium.org/2124863002 .
2016-07-05 19:22:27 +02:00
Florian Loitsch
6a7c037aa6
Reapply zone tasks.
...
This reverts commit 34d3c37233
.
Committed: f746f8f77e
R=lrn@google.com
Review URL: https://codereview.chromium.org/2119243002 .
Reverted: dae3922915
2016-07-05 17:33:09 +02:00
Florian Loitsch
dae3922915
Revert "Reapply zone tasks."
...
This reverts commit f746f8f77e
.
Review URL: https://codereview.chromium.org/2123593002 .
2016-07-04 21:58:15 +02:00
Florian Loitsch
f746f8f77e
Reapply zone tasks.
...
This reverts commit 34d3c37233
.
Review URL: https://codereview.chromium.org/2119243002 .
2016-07-04 19:55:58 +02:00
Florian Loitsch
34d3c37233
Revert zone tasks.
...
Revert "Add tasks to zones."
This reverts commit 85cccde717
.
Revert "Make Dom events run through zone tasks."
This reverts commit 6d1f6b2af6
.
Revert "Add zone task support for request-anim."
This reverts commit 726b9f8dc7
.
Revert "Add zone task support to http-requests."
This reverts commit b40cfcb57f
.
Revert "Update status file for jsshell."
This reverts commit 5e05ee9b5f
.
Review URL: https://codereview.chromium.org/2120063002 .
2016-07-01 22:36:52 -07:00
Florian Loitsch
b40cfcb57f
Add zone task support to http-requests.
...
R=alanknight@google.com , lrn@google.com
Review URL: https://codereview.chromium.org/2042033002 .
2016-07-01 19:44:19 -07:00
Jacob Richman
fd58be1816
Add back in pure_interfaces list that turned out to still be needed. The checked in generated code matches this cl.
...
BUG=
Review URL: https://codereview.chromium.org/2005143004 .
2016-05-24 10:25:31 -07:00
Jacob Richman
f26e522f84
Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1987073002 .
2016-05-18 12:49:09 -07:00
Harry Terkelsen
1745ba77f5
fix all instances of "the the"
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1980573003 .
2016-05-13 12:38:25 -07:00
Alan Knight
5542568adc
Fix MouseEvent.movement to not use old webkit prefix
...
BUG=
Review URL: https://codereview.chromium.org/1921823002 .
2016-04-25 12:35:03 -07:00
Terry Lucas
8f7b8a9d87
Update to new Webkit additions for custom elements
...
TBR=jacobr@google.com ,alanknight@google.com
Review URL: https://codereview.chromium.org/1914643002 .
2016-04-22 12:53:36 -07:00
Jacob Richman
819ed4bb60
Fix strong mode errors in SVG
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1903893003 .
2016-04-21 12:45:08 -07:00
Jacob Richman
b546d05362
TBR. Add back fix to the misleading types for onError. Otherwise, html/worker_test/functional fails due to the browser itself throwing an event of type Error that is not an ErrorEvent.
...
BUG=
Review URL: https://codereview.chromium.org/1908603002 .
2016-04-20 10:41:56 -07:00
Jacob Richman
068252e721
Revert changes to event signatures as they broke one co19 test and this change isn't required due to relaxation in types in EventStreamProvider.dart
...
BUG=
Review URL: https://codereview.chromium.org/1903033002 .
2016-04-19 16:42:16 -07:00
Jacob Richman
864b64fd5e
Strong html
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1894713002 .
2016-04-19 15:08:45 -07:00
Alan Knight
810faa31b9
Don't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D)
...
BUG=
Review URL: https://codereview.chromium.org/1885943002 .
2016-04-16 16:26:14 -07:00
Terry Lucas
74ddf84ffd
Remove MutationEvent bad entries in both removed list and renamed list
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1890983002 .
2016-04-14 13:49:42 -07:00
Alan Knight
a718c8dac9
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Committed: 65fe0a5383
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 15:13:31 -07:00
Alan Knight
3fd7e32b65
Revert "Fix a few strong mode errors in dart:html"
...
This reverts commit 65fe0a5383
.
BUG=
Review URL: https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
Alan Knight
65fe0a5383
Fix a few strong mode errors in dart:html
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
Jacob Richman
08c171d3e5
Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects.""
...
Fix missing case that was breaking co19 tests.
This reverts commit 688eeb555c
.
BUG=
Review URL: https://codereview.chromium.org/1883513004 .
2016-04-12 17:16:06 -07:00
Jacob Richman
688eeb555c
Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects."
...
This reverts commit f382890e1a
.
Reverting while tests are fixed.
BUG=
Review URL: https://codereview.chromium.org/1879093002 .
2016-04-12 11:28:05 -07:00
Jacob Richman
f382890e1a
Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1873933002 .
2016-04-12 10:23:32 -07:00
Terry Lucas
c95b9875ef
Fix registerElement for HTMLElement prototype should not change it's m_type
...
TBR=jacobr@google.com
Review URL: https://codereview.chromium.org/1857343002 .
2016-04-05 11:59:28 -07:00
Jacob Richman
3cb280c5e1
Fast path Location.hash as some apps call it 10000+ times a frame.
...
BUG=
Review URL: https://codereview.chromium.org/1847543003 .
2016-03-31 09:04:10 -07:00
Jacob Richman
c65854d2e4
Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X.
...
BUG=
Review URL: https://codereview.chromium.org/1832713002 .
2016-03-29 18:32:52 -07:00
Terry Lucas
10e70db01c
Speed up interop patch file creation.
...
Made a number of optimizations to reduce load time from 8 secs to 1 sec. The changes involved:
- No longer dynamically generate patch files on startup for dart:* libraries (created from WebKits IDL e.g., html, svg, web_audio, web_gl, indexed_db, web_sql). Instead create a cache of patch files.
- Comparison of @JS refelctedType not by library and symbol name comparison.
- In addition, a VM mirror change see CL https://codereview.chromium.org/1834673003/ gives us the remaining speedup.
This cache of interop patch files, for Dartium only, requires a manual re-gen after go.sh run is:
> cd tools/dom/scripts
> run go.sh
The steps after (for Dartium) are:
1. build Dartium
2. cd tools/dartium
3. run generate_patches.sh
4. build Dartium
R=jacobr@google.com , alanknight@google.com
Review URL: https://codereview.chromium.org/1833373002 .
2016-03-28 08:20:13 -07:00
Alan Knight
ab55f22334
Fix WebGL tex[Sub]Image2D/buffer[Sub]Data, restored Typed/Untyped aliases
...
BUG=
Review URL: https://codereview.chromium.org/1831033002 .
2016-03-24 10:20:11 -07:00
Alan Knight
4fe809c211
Add @creates annotation to VttCue members
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1811213002 .
2016-03-18 07:35:35 -07:00
Alan Knight
051451d7e6
Trying to fix SQLResultSetRowList's subscript operator to do type conversion
...
BUG=
Review URL: https://codereview.chromium.org/1779023002 .
2016-03-09 14:02:30 -08:00
Terry Lucas
af562187bc
Chrome moved clipboardData from Event to ClipboardEvent for security clipboard can only be accessed during a onCut/onCopy/onPaste event.
...
The polyfill class KeyEvent can no longer access clipboardData without listening for the cut, copy or paste event.
TBR=alanknight@google.com ,sigmund@google.com
Review URL: https://codereview.chromium.org/1775923002 .
2016-03-08 05:24:02 -08:00
Terry Lucas
5c3728b067
Fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45
...
TBR=jacobr@google.com ,alanknight@google.com,sigmund@google.com
Review URL: https://codereview.chromium.org/1754523006 .
2016-03-07 07:51:50 -08:00
Terry Lucas
a552c24089
Match version of idl_parser and WebCore so go.sh can be run from a Dart only enlistment.
...
Needed to pull in the tools/idl_parser code for a Dart enlistment populated during a gclient sync.
Added .gitingore to not ignore tools/idl_parse
TBR=jacobr@google.com ,alanknight@google.com
Review URL: https://codereview.chromium.org/1768853002 .
2016-03-06 15:10:36 -08:00
Terry Lucas
c510dc9831
Fixed typedef used globally in IDLs
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1763063003 .
2016-03-05 07:34:51 -08:00
Alan Knight
83e2e2dbb2
Change scripts to avoid generating things that bloat the compiled code
...
BUG=
Review URL: https://codereview.chromium.org/1763213002 .
2016-03-04 15:08:48 -08:00
Kasper Lund
96be0c49fb
Revert "Change scripts to avoid generating things that bloat the compiled code"
...
This reverts commit 4f3abbd5ef
.
2016-03-04 10:06:07 +01:00
Alan Knight
4f3abbd5ef
Change scripts to avoid generating things that bloat the compiled code
...
BUG=
Review URL: https://codereview.chromium.org/1759303003 .
2016-03-03 17:39:50 -08:00
Terry Lucas
e1a33e9981
Moved ChromiumSubscribeUniform to web_gl
...
Fixed to return null if dictionary returned form blink is null
Cleanup up logging/error reporting
TBR=alanknight@google.com ,jacobr@google.com
Committed: 01f6e4ed0f
Review URL: https://codereview.chromium.org/1752983003 .
2016-03-02 08:15:45 -08:00
Terry Lucas
6aff6fb1ba
Fixed Dictionary emitted as interface and dictionary conversion with a null map
...
TBR=alanknight@google.com ,jacobr@google.com
Committed: a61bd2f7b2
Review URL: https://codereview.chromium.org/1752153002 .
2016-03-01 15:55:13 -08:00
Terry Lucas
8cb5ef741f
Fix more things with webgl so it works
...
- dart.idl emitted currently supported operations in Chrome 45 so there were 9 duplicates.
- Support mapping a bunch of webgl types to Dart types.
TBR=jacobr@google.com ,alanknight@google.com
Committed: 3a6e6cafea
Review URL: https://codereview.chromium.org/1748383002 .
2016-03-01 03:34:19 -08:00
Terry Lucas
c7c12c7756
Migrated changed for sdk/lib genernation from integration branch to master.
...
- client* not properly exposed.
- Expose createImageDataFromImageData for backward compat
- Chrome now allow typedefs defined in and IDL to be used and other IDL files (even though the IDL has no include).
TBR=alanknight@google.com ,jacobr@google.com
Review URL: https://codereview.chromium.org/1744093002 .
2016-02-28 11:59:20 -08:00