t log b0220fc898c32d3944cb8c54cf7b78dd8c7cbadb..796f4de76de460e031bf3b20ce60a52e4ed417d9 --date=short --no-merges --format='%ad %ae %s'
2019-07-31 sgrekhov@unipro.ru Add another test for lexical resolution with conflicting extensions in a library
2019-07-31 sgrekhov@unipro.ru Fix typo and missing import added
2019-07-31 irina.arkhipets@gmail.com typo corrected.
2019-07-30 sgrekhov@unipro.ru Test fixed (listEquals -> iterableEquals)
2019-07-30 sgrekhov@unipro.ru Fix description of the current extension member tests and add new ones testing that instance method has higher priority than extension's one
2019-07-30 sgrekhov@unipro.ru More built-in types added to test on clause
2019-07-30 irina.arkhipets@gmail.com generic parameter inference test corrected, two new tests added.
2019-07-30 sgrekhov@unipro.ru Add test with 'call' method and no most specific extension
2019-07-30 sgrekhov@unipro.ru Change test assertion and rename
2019-07-30 sgrekhov@unipro.ru Change test description and add new one testing 'no most specific extension' case
2019-07-29 sgrekhov@unipro.ru Fix scope tests
2019-07-29 sgrekhov@unipro.ru Change all extensions in the test to not to be 'most specific'
2019-07-29 sgrekhov@unipro.ru Use more strong checking of 'this'
2019-07-29 sgrekhov@unipro.ru Check that it is no compile error if an extension declares a member with the same name as a member of the type it is declared on
2019-07-29 irina.arkhipets@gmail.com new test added, it checks that extension type parameter cannot be higher-order.
2019-07-29 irina.arkhipets@gmail.com test extension is appliedes expected.
2019-07-29 sgrekhov@unipro.ru Use correct checkings
2019-07-29 sgrekhov@unipro.ru Use correct functions call
2019-07-29 sgrekhov@unipro.ru Use correct functions call
2019-07-29 irina.arkhipets@gmail.com test expectations corrected.
2019-07-29 sgrekhov@unipro.ru Remove NNBD tests
2019-07-29 sgrekhov@unipro.ru Obsolete text removed from the test description
2019-07-29 sgrekhov@unipro.ru Use correct function type
2019-07-29 sgrekhov@unipro.ru Use correct function type
2019-07-29 sgrekhov@unipro.ru Use string interpolation
2019-07-27 irina.arkhipets@gmail.com got rid of higher order type variables.
2019-07-27 irina.arkhipets@gmail.com test check a parameter of unrelated type now; new test with implicit downcast added.
2019-07-27 irina.arkhipets@gmail.com expected result of the test corrected.
2019-07-27 irina.arkhipets@gmail.com more informative test description added.
2019-07-27 irina.arkhipets@gmail.com typo corrected.
2019-07-27 irina.arkhipets@gmail.com the test checks that an extension from non-platform libraries is not more or less specific than one from another non-platform library.
2019-07-27 irina.arkhipets@gmail.com the test checks that an extension from non-platform libraries is not more or less specific than one from another non-platform library.
2019-07-27 irina.arkhipets@gmail.com the test checks that an extension from non-platform libraries is not more or less specific than one from another non-platform library.
2019-07-26 sgrekhov@unipro.ru Add another tests with a call getter returning a function
2019-07-25 irina.arkhipets@gmail.com positive test case for the conflicting resolutions added, there should not be errors if members are not called directly.
2019-07-25 irina.arkhipets@gmail.com add a reference to the conflicting extensions.
2019-07-24 sgrekhov@unipro.ru Use correct syntax for unnamed extension with type parameters
2019-07-24 sgrekhov@unipro.ru Use correct syntax for unnamed extension with type parameters
2019-07-24 irina.arkhipets@gmail.com type parameters follow extension names now.
2019-07-24 sgrekhov@unipro.ru Use instance variable, not a class for testing
2019-07-24 sgrekhov@unipro.ru Fix typo (boolean -> bool)
2019-07-24 irina.arkhipets@gmail.com typo in the test corrected.
2019-07-24 irina.arkhipets@gmail.com "on" clause added to the tested extensions.
2019-07-23 irina.arkhipets@gmail.com typo in the test corrected.
2019-07-23 irina.arkhipets@gmail.com tests for Semantics of Invocations (Static extension methods)added.
2019-07-23 irina.arkhipets@gmail.com tests for Semantics of Invocations (Static extension methods)added.
2019-07-23 sgrekhov@unipro.ru Semantics of extension members tests added
2019-07-23 sgrekhov@unipro.ru Object methods test added
2019-07-23 irina.arkhipets@gmail.com tests for Static Members and Member Resolution (Static extension methods)
2019-07-22 irina.arkhipets@gmail.com tests for overriding access in extension methods added.
2019-07-22 irina.arkhipets@gmail.com removed needless @compile-error tags.
2019-07-22 irina.arkhipets@gmail.com added "on" clause to the extension declarations.
2019-07-22 sgrekhov@unipro.ru Static extension methods. Member conflict resolution tests added
2019-07-22 irina.arkhipets@gmail.com getter calls corrected.
2019-07-22 irina.arkhipets@gmail.com expected results of the test cases corrected.
2019-07-22 sgrekhov@unipro.ru Typo fixed
2019-07-22 sgrekhov@unipro.ru Remove wrong type argument
2019-07-22 irina.arkhipets@gmail.com typo in the getter corrected.
2019-07-22 sgrekhov@unipro.ru Typo fixed (Void -> void)
2019-07-22 sgrekhov@unipro.ru Typo fixed
2019-07-19 sgrekhov@unipro.ru Static extension methods. Member conflict resolution test added
2019-07-18 sgrekhov@unipro.ru Extension static methods acess fixed
2019-07-18 sgrekhov@unipro.ru Tearoff tests added and fixed
2019-07-18 sgrekhov@unipro.ru More tearoff tests
2019-07-17 sgrekhov@unipro.ru Tearoff tests added and small fixes
2019-07-15 irina.arkhipets@gmail.com added tests for overriding access in the static extension methods.
2019-07-15 sgrekhov@unipro.ru The call member tests added
2019-07-12 irina.arkhipets@gmail.com tests for extension conflict resolution added.
2019-07-10 irina.arkhipets@gmail.com tests for extension conflict resolution added.
2019-07-04 irina.arkhipets@gmail.com tests for static extension methods added: extension conflict resolution.
2019-07-04 sgrekhov@unipro.ru More extension member resolution tests
2019-07-03 sgrekhov@unipro.ru Typo in test fixed
2019-07-02 sgrekhov@unipro.ru Extension member resolution tests added
2019-07-02 sgrekhov@unipro.ru Covariant parameters test added
2019-07-02 sgrekhov@unipro.ru Typo in multitest fixed
2019-07-01 irina.arkhipets@gmail.com tests for static extension methods added (generic parameter interfaces and extension conflict resolution)
2019-07-01 sgrekhov@unipro.ru Fixes Test for scope completed
2019-07-01 sgrekhov@unipro.ru Fixes Another tests for Scope added
2019-06-28 sgrekhov@unipro.ru Test scope added
2019-06-28 sgrekhov@unipro.ru Ommited extension name test added
2019-06-27 irina.arkhipets@gmail.com tests for generic parameter inference added.
2019-06-27 sgrekhov@unipro.ru Tests for syntax scope added
2019-06-26 irina.arkhipets@gmail.com tests for the issues 32903, 34560 added, some typos fixed.
2019-06-26 sgrekhov@unipro.ru Issue number added to flaky test
2019-06-26 sgrekhov@unipro.ru Member declaration tests added
2019-06-24 sgrekhov@unipro.ru More tests for Static extension methods syntax
2019-06-24 sgrekhov@unipro.ru Added tests for Static extension methods syntax
2019-06-24 irina.arkhipets@gmail.com moved tests for triple-shift into LanguageFeatures/Triple-shift directory.
2019-06-21 sgrekhov@unipro.ru Name and value are mandatory for Cookie now. Also value check added
2019-06-19 sgrekhov@unipro.ru Add more NNBD static semantics tests
2019-06-18 sgrekhov@unipro.ru RGBA and UNSIGNED_BYTE constants were moved to WebGL class. Use them
2019-06-18 sgrekhov@unipro.ru Use approxEquals for math functions with tolerance 1-e15
2019-06-18 sgrekhov@unipro.ru Old multitest syntax replaced by new one
2019-06-17 sgrekhov@unipro.ru Initial commit. Tests for NNBD static errors
2019-06-17 sgrekhov@unipro.ru Revert "Initial commit. Tests for NNBD static errors"
2019-06-17 sgrekhov@unipro.ru Initial commit. Tests for NNBD static errors
2019-06-17 irina.arkhipets@gmail.com added static tests for non-function type aliases with simple bounds. Useless @compile-error tags removed.
2019-06-17 irina.arkhipets@gmail.com added dynamic tests for non-function type aliases with simple bounds.
2019-06-14 sgrekhov@unipro.ru Remove invalid use null from Language tests
Change-Id: I83d5ded8bc97a1b0bf3e8f19af401ae5283411f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111722
Reviewed-by: Alexander Thomas <athom@google.com>
This change also copies the platform-appropriate tflite shared object into $SDK/bin/snapshots so that tflite_native running inside the analysis server snapshot will be able to resolve it correctly.
ariaye@ariaye1:~/sdk/sdk$ ./tools/build.py -a x64 -mrelease create_sdk
ariaye@ariaye1:~/sdk/sdk$ ls out/DebugX64/dart-sdk/bin/snapshots/
analysis_server.dart.snapshot dart2js.dart.snapshot dartanalyzer.dart.snapshot dartdevc.dart.snapshot dartdoc.dart.snapshot dartfmt.dart.snapshot kernel-service.dart.snapshot kernel_worker.dart.snapshot libtensorflowlite_c-linux64.so libtensorflowlite_c-mac64.so libtensorflowlite_c-win64.dll pub.dart.snapshot resources
Change-Id: I474a3b676f99feaa84dba9c7723dc867a7a01f52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111669
Reviewed-by: Samir Jindel <sjindel@google.com>
This is a reland of b71d2d9996
Original change's description:
> [llvm] Add initial scaffolding
>
> This change adds the gclient and GN changes needed to build
> an executable using LLVM in the Dart tree as well as a basic
> testing framework based on llvm-lit.
>
> Change-Id: I9009a98ff95043cc3754966f31697ba7f1712310
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106434
> Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Change-Id: I73cd24455c373bcc4d0f5675af6a3b1e0f947f67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110683
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
I also went ahead and updated the CIPD dart/language_model version to the latest model version.
Change-Id: I4522209150a90acfba210885316e78381c2aee45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
Local test run after running `gclient sync`:
ariaye@ariaye1:~/sdk/sdk$ dart pkg/analysis_server/test/services/completion/dart/language_model_test.dart
00:00 +0: calculates lookback
INFO: Initialized TensorFlow Lite runtime.
00:00 +1: predict with defaults
00:01 +2: predict with confidence scores
00:03 +3: predict when no previous tokens
00:04 +4: All tests passed!
Change-Id: I4181bea09cf8fec74d03bba4f83cd26dac818f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Adds micro benchmarks to measure low level (1) C memory reads and writes from Dart and (2) calls from Dart into C. This CL also adds a macro benchmark to measure overall performance using BoringSSL to digest data. The shared libraries are precompiled for Linux and live in cipd packages. The benchmarks run on all hardware architectures (with the exception of Linux'es hardfp on Arm32: https://github.com/dart-lang/sdk/issues/36309).
Issue: https://github.com/dart-lang/sdk/issues/36247
Change-Id: I8dfb30cc66a26a2942bb09194c5eb0da0b6ca1b5
Cq-Include-Trybots: luci.dart.try:benchmark-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108724
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
The tag 0.9.7+12 was never published on pub. The tag 0.9.7+12-pub is
what is published. The version published on pub contains some internal
style fixes and removes unused code.
Change-Id: Ic196316e83ada99f02f461feeae9215ee3db3701
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109307
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
Commit-Queue: Gary Roumanis <grouma@google.com>
Benchmarks are checked in as benchmarks/<Benchmark>/dart/<Benchmark>.dart.
This scheme is compatible with our existing benchmarking infrastructure
and will aid migrating the benchmarks with minimal breakage.
This change adds an Example benchmark to show how it is done.
The benchmarks directory is now added to the Dart benchmarking builds.
Change-Id: I25971ba3b219194fa9cfea6b938372d877477e28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108414
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: I4c315a0c61a4c5bf8144aaf4d85ab5ae95dec315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108400
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
This reverts commit 524fdc13a9.
Reason for revert: I still broke flutter somehow. I got the same error. Looking into it now.
Original change's description:
> Reland "[llvm] Add initial scaffolding"
>
> This is a reland of b71d2d9996
>
> Original change's description:
> > [llvm] Add initial scaffolding
> >
> > This change adds the gclient and GN changes needed to build
> > an executable using LLVM in the Dart tree as well as a basic
> > testing framework based on llvm-lit.
> >
> > Change-Id: I9009a98ff95043cc3754966f31697ba7f1712310
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106434
> > Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
> > Reviewed-by: Alexander Thomas <athom@google.com>
> > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
>
> Change-Id: Ib3cd3299ed463133616c666285f9a58fa387b5bd
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107829
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
TBR=vegorov@google.com,kustermann@google.com,athom@google.com,phosek@google.com,ajcbik@google.com,jakehehrlich@google.com
Change-Id: I8b18549ec4a030518633ec7f75d2fd2ceea87256
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107837
Reviewed-by: Jake Ehrlich <jakehehrlich@google.com>
Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
This is a reland of b71d2d9996
Original change's description:
> [llvm] Add initial scaffolding
>
> This change adds the gclient and GN changes needed to build
> an executable using LLVM in the Dart tree as well as a basic
> testing framework based on llvm-lit.
>
> Change-Id: I9009a98ff95043cc3754966f31697ba7f1712310
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106434
> Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Change-Id: Ib3cd3299ed463133616c666285f9a58fa387b5bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107829
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
This reverts commit b71d2d9996.
Reason for revert: Somehow this broke flutter because gclient doesn't seem to have generated the needed file
Original change's description:
> [llvm] Add initial scaffolding
>
> This change adds the gclient and GN changes needed to build
> an executable using LLVM in the Dart tree as well as a basic
> testing framework based on llvm-lit.
>
> Change-Id: I9009a98ff95043cc3754966f31697ba7f1712310
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106434
> Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
TBR=vegorov@google.com,kustermann@google.com,athom@google.com,phosek@google.com,ajcbik@google.com,jakehehrlich@google.com
Change-Id: I877abfe211dc6c3efd94cc2350d028bf54df9d9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107688
Reviewed-by: Jake Ehrlich <jakehehrlich@google.com>
Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
This change adds the gclient and GN changes needed to build
an executable using LLVM in the Dart tree as well as a basic
testing framework based on llvm-lit.
Change-Id: I9009a98ff95043cc3754966f31697ba7f1712310
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106434
Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
These methods all were returning Uint8List, yet they were only
declared to return List<int>. This forced callers to either defensively
wrap the return values in Uint8List, or to assume the contravariant
return value:
* Utf8Codec.encode()
* BytesBuilder.takeBytes()
* BytesBuilder.toBytes()
* File.readAsBytes()
* File.readAsBytesSync()
* RandomAccessFile.read()
* RandomAccessFile.readSync()
* Uint8List.sublist()
Since it's related, this change also updates the following sublist()
methods to declare that they return the a sublist of the same type as
the source list:
* Int8List
* Uint8ClampedList
* Int16List
* Uint16List
* Int32List
* Uint32List
* Int64List
* Uint64List
* Float32List
* Float64List
* Float32x4List
* Int32x4List
* Float64x2List
Bug: https://github.com/dart-lang/sdk/issues/36900
Bug: https://github.com/dart-lang/sdk/issues/31547
Bug: https://github.com/dart-lang/sdk/issues/27818
Bug: https://github.com/dart-lang/sdk/issues/35521
Change-Id: Ic3bc1db0d64de36fb68b1d8d98037eed1464f978
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101742
Commit-Queue: Todd Volkert <tvolkert@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
New versions of pedantic now offer imports to versioned includes. This will
allow us to update packages in the SDK independently when new lints are added in
future versions.
Issue: #37218
Change-Id: I43a4a9ba6730ed107a87f4060d47bb50d837de49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106184
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Change-Id: Ia6ebf5ad65c5e9d3690e122de399db4c0bc60fda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105640
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
It's a small change but does include some formatting differences, so
should be coordinated with rolling the pre-built SDK in case those
differences affect code in the SDK.
Change-Id: I6d7e049547f8b4d7e3a14c2424db6286ad76ec35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105360
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
This adds support for BabelJS to test.py's dart2js compiler
configuration. When --babel is specified directly or through a named
configuration, test.py will run an additional step after dart2js that
post-processes the javascript output by running it through BabelJS with
the specified Babel configuration. BabelJS is added to the DEPS in its
standalone form. d8 is used to run BabelJS standalone to avoid adding
a dependency on NodeJS. d8 can only write to stdout but not to files or
stderr, which makes it necessary to change the test_runner to handle
commands that expect their output to be piped to a file.
Changes:
* Add --babel option to test.py.
* Add babel option to pkg/smith.
* Switch IE11 builder to use babel transformation.
* Fix option list comparison bugs in pkg/smith.
* Change dart2js compiler configuration to generate files using the
test name rather than just "out.js" (update test that relied on this).
* Remove runtime_configuration dependency on test_suite.
* Remove obsolete blocks adding --preview-dart-2 dart2js arguments.
* Make dart2js' compiler configuration more like DDC's.
* Remove createCommand method that is no longer used.
* Remove support for "OtherResources" which was only used for
dart:isolate tests on dart2js and DDC.
* Skip co19_2 tests that are slow to transform with babel.
* Simplify the timeout handling in the test runner with Future.timeout.
Change-Id: I32e4917b2a57ecbe684538e40d744f0101c552a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/90402
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Rename old "Pub client" headline for consistency with older entries
Add headline for linter in CHANGELOG.md
Change-Id: I118127a6aab564f5d498441f30957e8851e69d6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103527
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
This also bumps the protobuf version.
Change-Id: I3e2d4f8fddcac5f7ac213fbad5a36804d917e34c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101296
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This is useful for downstream projects which automatically update their DEPS based on dart DEPS.
Change-Id: I3275e53de9e0e0d46a67e3fe5c2868b8c12f851c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100790
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
This work pulls in v8 support for these features with
appropriate changes for Dart and closes
https://github.com/dart-lang/sdk/issues/34935.
This adds support for the following features:
* Interpreting patterns as Unicode patterns instead of
BMP patterns
* the dotAll flag (`/s`) for changing the behavior
of '.' to also match line terminators
* Escapes for character classes described by Unicode
property groups (e.g., \p{Greek} to match all Greek
characters, or \P{Greek} for all non-Greek characters).
The following TC39 proposals describe some of the added features:
* https://github.com/tc39/proposal-regexp-dotall-flag
* https://github.com/tc39/proposal-regexp-unicode-property-escapes
These additional changes are included:
* Extends named capture group names to include the full
range of identifier characters supported by ECMAScript,
not just ASCII.
* Changing the RegExp interface to return RegExpMatch
objects, not Match objects, so that downcasting is
not necessary to use named capture groups from Dart
**Note**: The changes to the RegExp interface are a
breaking change for implementers of the RegExp interface.
Current users of the RegExp interface (i.e., code using Dart
RegExp objects) will not be affected.
Change-Id: Ie62e6082a0e2fedc1680ef2576ce0c6db80fc19a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100641
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
This reverts commit 5ebb640a67.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> [vm] Finish adding support for ECMAScript 2018 features.
>
> This work pulls in v8 support for these features with
> appropriate changes for Dart and closes
> https://github.com/dart-lang/sdk/issues/34935.
>
> This adds support for the following features:
>
> * Interpreting patterns as Unicode patterns instead of
> BMP patterns
> * the dotAll flag (`/s`) for changing the behavior
> of '.' to also match line terminators
> * Escapes for character classes described by Unicode
> property groups (e.g., \p{Greek} to match all Greek
> characters, or \P{Greek} for all non-Greek characters).
>
> The following TC39 proposals describe some of the added features:
>
> * https://github.com/tc39/proposal-regexp-dotall-flag
> * https://github.com/tc39/proposal-regexp-unicode-property-escapes
>
> These additional changes are included:
>
> * Extends named capture group names to include the full
> range of identifier characters supported by ECMAScript,
> not just ASCII.
> * Changing the RegExp interface to return RegExpMatch
> objects, not Match objects, so that downcasting is
> not necessary to use named capture groups from Dart
>
> **Note**: The changes to the RegExp interface are a
> breaking change for implementers of the RegExp interface.
> Current users of the RegExp interface (i.e., code using Dart
> RegExp objects) will not be affected.
>
> Change-Id: I0709ed0a8d5db36680e32bbad585594857b9ace4
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95651
> Commit-Queue: Stevie Strickland <sstrickl@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
TBR=lrn@google.com,kustermann@google.com,jmesserly@google.com,johnniwinther@google.com,sstrickl@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I1eda0fee4fd9e94df095944049833a67b07277e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100560
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
This work pulls in v8 support for these features with
appropriate changes for Dart and closes
https://github.com/dart-lang/sdk/issues/34935.
This adds support for the following features:
* Interpreting patterns as Unicode patterns instead of
BMP patterns
* the dotAll flag (`/s`) for changing the behavior
of '.' to also match line terminators
* Escapes for character classes described by Unicode
property groups (e.g., \p{Greek} to match all Greek
characters, or \P{Greek} for all non-Greek characters).
The following TC39 proposals describe some of the added features:
* https://github.com/tc39/proposal-regexp-dotall-flag
* https://github.com/tc39/proposal-regexp-unicode-property-escapes
These additional changes are included:
* Extends named capture group names to include the full
range of identifier characters supported by ECMAScript,
not just ASCII.
* Changing the RegExp interface to return RegExpMatch
objects, not Match objects, so that downcasting is
not necessary to use named capture groups from Dart
**Note**: The changes to the RegExp interface are a
breaking change for implementers of the RegExp interface.
Current users of the RegExp interface (i.e., code using Dart
RegExp objects) will not be affected.
Change-Id: I0709ed0a8d5db36680e32bbad585594857b9ace4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95651
Commit-Queue: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: Ia67e81b3b18ee6de560acf518059849e1953f6f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99541
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
