Commit graph

7633 commits

Author SHA1 Message Date
Johnni Winther
40108f661d Update Windows build output path in .bat files
R=asiva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2035313004 .
2016-06-07 10:43:13 +02:00
John McCutchan
6fd8fd7987 Rework standalone to use a synchronous loader that does not invoke Dart code
- [x] The first caller of the tag handler blocks, recursive callers queue work and exit.
- [x] Use a NativeMessageHandler to receive I/O results from the service isolate.
- [x] Preserve load error message format.
- [x] Move packages map into service isolate.
- [x] Wire up Todd's native URI code.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1998963003 .
2016-06-06 14:15:01 -07:00
Stephen Adams
b37747934e Specialize Symbol.hashCode
Patch internal.Symbol.hashCode and specialize JS version to avoid
recomputing String.hashCode

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2038853003 .
2016-06-03 15:10:51 -07:00
Florian Loitsch
2820f231c6 Don't toString messages in native Js sendports.
Fixes #26595
BUG= http://dartbug.com/26595
R=lrn@google.com

Review URL: https://codereview.chromium.org/2033063002 .
2016-06-02 14:39:25 +02:00
Florian Loitsch
d3579131c8 Avoid runtime type errors in checked mode for ChunkedConverters.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2035473003 .
2016-06-02 13:41:29 +02:00
Florian Loitsch
e1bf3506d1 Make linked-list non-circular.
This bug was introduced when making the collection library strong-mode clean.

Fixes #26522
BUG= http://dartbug.com/26522
R=lrn@google.com

Review URL: https://codereview.chromium.org/2015513006 .
2016-06-01 14:19:37 +02:00
Alexandre Ardhuin
1e356e1881 Update http.dart (#26524)
Fix #26518 (part 2)
2016-05-30 14:18:36 +02:00
Jacob Richman
6cb121f847 Make sort method generic. This eliminates a large number of dynamic calls that slow down sorting under ddc.
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/2008373002 .
2016-05-25 12:33:41 -07:00
Alan Knight
088dd409fc Add types on internal DateTime accessors
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2008163002 .
2016-05-24 17:36:33 -07:00
Alexandre Ardhuin
9b9e97d5ba Update http.dart (#26520)
Fix #26518
2016-05-24 19:53:23 +02:00
Lasse R.H. Nielsen
fbf64bb7a5 Make Iterable.toList more efficient if the length is known.
Add more tests. Fix (some) bugs found by tests.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1999793002.
2016-05-23 10:00:19 +02:00
Terry Lucas
94456a2433 Optimization for patch file generation
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1999803002 .
2016-05-20 07:48:08 -07:00
Florian Loitsch
2203c54cbb Fix documentation for LinkedHashSet.
Fixes #26496
BUG= http://dartbug.com/26496

Review URL: https://codereview.chromium.org/1999783002 .
2016-05-20 14:36:38 +02:00
Florian Loitsch
ac0a5ef431 Fix documentation for identity sets/maps.
Fixes #26503
BUG= http://dartbug.com/26503
R=lrn@google.com

Review URL: https://codereview.chromium.org/2002593002 .
2016-05-20 14:29:14 +02:00
Lasse R.H. Nielsen
3a1a7c3968 Make Uri.parse("data:...") go through UriData.parse.
It's safer to not try to do part normalization on data: URI content,
and it's likely to be faster to parse it only once.

This should also reduce the work done when parsing data: URIs using
Uri.parse.

BUG= https://github.com/dart-lang/sdk/issues/26280
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1994623002.
2016-05-19 11:27:05 +02:00
Jacob Richman
f26e522f84 Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1987073002 .
2016-05-18 12:49:09 -07:00
Lasse R.H. Nielsen
5d6e8bcda1 Make Iterable.generate use ListIterable as base implementation.
This makes it work the same as a List like the documentation claims.

Update documentation of Future.doWhile, and a few other documentation fixes.

BUG= http://dartbug.com/26358
BUG= http://dartbug.com/26462
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1992713002.
2016-05-18 13:52:10 +02:00
John McCutchan
84e1fe5cb5 Add an intrinsified early out path for Dart timeline calls
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1985813002 .
2016-05-17 09:45:28 -07:00
Florian Loitsch
1be2f87236 Fix Iterable.where documentation by updating its signature.
Fixes #26459
BUG= http://dartbug.com/26459

Review URL: https://codereview.chromium.org/1986243002 .
2016-05-17 17:57:12 +02:00
Florian Loitsch
38bd7d586d Fix typo in doc.
Fixes #26457
BUG= http://dartbug.com/26457

Review URL: https://codereview.chromium.org/1983103002 .
2016-05-17 17:18:09 +02:00
Florian Loitsch
86fd2b62d1 Fix remaining strong-mode warnings and errors in dart:io.
R=lrn@google.com

Committed: 493c70d2b0

Reverted: 49fe254ea2

Review URL: https://codereview.chromium.org/1971643003 .
2016-05-17 12:55:11 +02:00
Florian Loitsch
1e3b98278a Make DoubleLinkedQueueEntry subclassable again.
Also, add back the `remove` function that was accidentally removed.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1973903005 .
2016-05-17 12:54:12 +02:00
Harry Terkelsen
1745ba77f5 fix all instances of "the the"
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1980573003 .
2016-05-13 12:38:25 -07:00
Greg Littlefield
cd8124cdcf JS: Use direct function invocation when possible for calls with 4 or 5 args (#26268)
* Use direct function invocation when possible for calls with 4 or 5 args

* Add test for Function.apply called with 0-5 arguments
2016-05-13 10:13:46 -07:00
Harry Terkelsen
75797c0fef make linked_hash_map strong mode clean
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1965893008 .
2016-05-12 13:27:41 -07:00
Florian Loitsch
49fe254ea2 Revert "Fix remaining strong-mode warnings and errors in dart:io."
This reverts commit 493c70d2b0.

Review URL: https://codereview.chromium.org/1974043002 .
2016-05-12 18:17:08 +02:00
Florian Loitsch
ef6eaee42f Make DateTime comparable only to DateTime.
R=leafp@google.com

Review URL: https://codereview.chromium.org/1972533003 .
2016-05-12 18:06:22 +02:00
Alexandre Ardhuin
5f2c5b94ca Fix bad link (#26446) 2016-05-12 16:54:23 +02:00
Florian Loitsch
493c70d2b0 Fix remaining strong-mode warnings and errors in dart:io.
R=lrn@google.com

Review URL: https://codereview.chromium.org/1971643003 .
2016-05-12 16:50:20 +02:00
Florian Loitsch
e3c3f099ea Fix strong mode errors in dart:io.
Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Committed: 5216f1d67d

Reverted: 7503ecc8fd

Review URL: https://codereview.chromium.org/1904553006 .
2016-05-12 13:17:31 +02:00
Florian Loitsch
7503ecc8fd Revert "Fix strong mode errors in dart:io."
This reverts commit 5216f1d67d.

BUG=

Review URL: https://codereview.chromium.org/1966373002 .
2016-05-11 21:44:09 +02:00
Florian Loitsch
e19addf23e Make dart:collection strong-mode clean.
R=leafp@google.com

Review URL: https://codereview.chromium.org/1937103002 .
2016-05-11 16:28:43 +02:00
Florian Loitsch
fe1fda0766 Make dart:convert strong mode clean.
Also removes the ChunkedConverter.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1964953003 .
2016-05-11 16:15:31 +02:00
Florian Loitsch
b828752fd7 Make dart:math strong mode clean.
R=leafp@google.com

Review URL: https://codereview.chromium.org/1961993002 .
2016-05-11 16:00:58 +02:00
Florian Loitsch
5216f1d67d Fix strong mode errors in dart:io.
Still a lot of strong mode warnings left.

R=fschneider@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org/1904553006 .
2016-05-11 14:30:32 +02:00
Florian Loitsch
5612898e23 Fix return-type for error-handlers in streams.
R=lrn@google.com

Review URL: https://codereview.chromium.org/1958143002 .
2016-05-11 14:27:16 +02:00
Lasse R.H. Nielsen
63b71b4c24 Make _Future._chainForeignFuture not cause an assert.
If the foreign future completes with a future, the following call to
_Future._completeWithValue would hit an assert in checked mode
(value is! Future). This change makes the _Future._completeWithValue flatten
incoming nesting futures before completing the _Future, ensuring that a
_Future never has a Future as value.

An alternative is to throw if the value of a future is another future.
That's what the assert does in checked mode, but we shouldn't be able to hit
an assert.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1966523003 .
2016-05-11 13:10:46 +02:00
Stephen Adams
73c236a3a4 Revert "Library changes to align with DDC."
TBR=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org/1970653002 .
2016-05-10 19:42:51 -07:00
Stephen Adams
260eb5534a Library changes to align with DDC.
Mostly adding a few types and formatting changes since DDC uses dartfmt.

R=floitsch@google.com, vsm@google.com

Committed: 308cb34a7c

Reverted: facb3eb9dc

Review URL: https://codereview.chromium.org/1952183002 .
2016-05-10 18:38:19 -07:00
Stephen Adams
facb3eb9dc Revert "Library changes to align with DDC."
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org/1969643002 .
2016-05-10 17:42:02 -07:00
Stephen Adams
308cb34a7c Library changes to align with DDC.
Mostly adding a few types and formatting changes since DDC uses dartfmt.

R=floitsch@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/1952183002 .
2016-05-10 17:36:16 -07:00
John McCutchan
4c97892885 Fix dart2js build
BUG=

Review URL: https://codereview.chromium.org/1965053003 .
2016-05-10 15:11:04 -07:00
John McCutchan
11f4a36e84 Fix dart2js build
BUG=

Review URL: https://codereview.chromium.org/1968733002 .
2016-05-10 14:59:28 -07:00
John McCutchan
62f9135490 Dart Timeline improvements
- [x] Add _getThreadCpuClock to dart:developer.
- [x] Report CPU usage for Dart synchronous timeline blocks.
- [x] GetEnvironmentValue for 'dart.vm.product' will return "true" or "false" depending on whether or not we are running in product mode.
- [x] Early out of Dart timeline calls if we are running in product mode.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1966833002 .
2016-05-10 14:31:33 -07:00
Florian Loitsch
c67133d3ab Fix typo in Map.values getter.
Fixes #26424.
BUG= http://dartbug.com/26424

Review URL: https://codereview.chromium.org/1960123002 .
2016-05-09 14:57:37 +02:00
John C. Bland II
02651a9949 Thank you :)
Thank you :)
2016-05-07 21:51:19 +02:00
Stephen Adams
2266452244 Remove unused imports.
BUG=

Review URL: https://codereview.chromium.org/1955193002 .
2016-05-06 16:43:39 -07:00
Natalie Weizenbaum
e41fb4cafd Fix some WebSocket strong-mode errors and warnings.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1952103002 .
2016-05-05 10:19:57 -07:00
Florian Loitsch
2d8aac23bc Make Future.catchError return a typed Future.
R=leafp@google.com

Review URL: https://codereview.chromium.org/1936343002 .
2016-05-03 12:13:46 +02:00
Leaf Petersen
bd323f27cd Fix async test failures. Remove test accidentally duplicated into the
non-error path.

TBR=floitsch@google.com

BUG=

Review URL: https://codereview.chromium.org/1936313003 .
2016-05-02 11:59:50 -07:00