Søren Gjesse
c05c8c6606
Revert change to Platform.excutable and add Platform.resolvedExecutable
...
The change to Platform.excutable in
e03ab17437
was a breaking change and it
has been reverted.
A new getter Platform.resolvedExecutable has been added to provide the
the fully qualified path of the executable.
BUG=https://github.com/dart-lang/sdk/issues/16994
R=lrn@google.com , kustermann@google.com , len@google.com
Review URL: https://codereview.chromium.org//1180623006 .
2015-06-15 10:13:21 +02:00
Ivan Posva
7158d5fc26
Landing https://codereview.chromium.org/1171223003/ for Chinmay.
...
BUG=
Review URL: https://codereview.chromium.org//1174343006 .
2015-06-13 06:36:24 -07:00
Ryan Macnak
bac8bc4b18
Fix accessing dart:_ libraries via exports.
...
R=hausner@google.com
Review URL: https://codereview.chromium.org//1185733003 .
2015-06-12 16:50:27 -07:00
Ryan Macnak
b8bad6725c
Expand the class id to 32 bits and size field to 16 bits on 64-bit platforms.
...
Remove misleading suffix from disassembly of some ia32 immediate ops.
R=asiva@google.com , srdjan@google.com
Review URL: https://codereview.chromium.org//1174173007 .
2015-06-12 16:42:40 -07:00
Daniel Andersson
1009d587de
Assert no allocation during heap iteration; fix unsafe iteration in ObjectGraph.
...
BUG=https://github.com/dart-lang/sdk/issues/21620
R=asiva@google.com
Review URL: https://codereview.chromium.org//1181943002 .
2015-06-12 10:44:06 -07:00
Florian Schneider
19bb19d716
Fix bug in Dart_GetTypeOfExternalTypedData.
...
This API function would return true for typed data view objects, even
if the view has a non-external data object underneath.
It is used e.g. by Builtin_LoadSource. This function copies the data
object for internal typed-data objects.
When it wrongly be identifies a view as external, it consequently results
in crash/undefined behavior because GC may interfere with this internal
data pointer.
BUG=
R=asiva@google.com , koda@google.com
Review URL: https://codereview.chromium.org//1182123002 .
2015-06-12 18:41:07 +02:00
Soren Gjesse
82535a6e91
Resolve the executable path on Mac OS when sym-linked
...
Don't try to test sym-linked files on Windows as Junctions only support
directories.
This helps to locate the Dart SDK (if any) from the path of the dart
executable. On Linux the use of /proc/self/exe already takes care of this.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//1178643007 .
2015-06-12 09:26:47 +02:00
Siva Annamalai
298a2f467f
Add an assertion to ensure that the return type and types of parameters are canonical or a TypeParameter.
...
BUG=
R=regis@google.com
Review URL: https://codereview.chromium.org//1182673002 .
2015-06-11 18:09:41 -07:00
Regis Crelier
9edc6e5a6d
Detect zero receiver of modInverse (may not converge and time out
...
in that case).
See #23502
Review URL: https://codereview.chromium.org//1177063002 .
2015-06-10 16:40:24 -07:00
Regis Crelier
f6f338ce67
Implement modInverse (bigint version does not support even modulus yet).
...
Added tests.
See #23502
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1174513004 .
2015-06-10 15:01:46 -07:00
Ryan Macnak
f2b59c3ed9
Make guard_cid and nullable_cid half words.
...
Add missing half-word instructions for ia32/x64.
46.0kB -> 38.4kB (-16.5%) of Field in hello world
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1176703002 .
2015-06-10 14:14:50 -07:00
Srdjan Mitrovic
acadc9017c
Inline instanceOf and 'as' operations; fix a bug in code emission
...
BUG=
R=regis@google.com
Review URL: https://codereview.chromium.org//1175803003 .
2015-06-10 13:17:51 -07:00
Srdjan Mitrovic
d9860cb6bc
Fix printing of stack overflow stacktraces
...
BUG=23614
R=asiva@google.com
Review URL: https://codereview.chromium.org//1174083002 .
2015-06-10 11:28:21 -07:00
Florian Schneider
09b59b6c16
Fix checked mode service test.
...
The object pool is not an Instance, but a VM object now.
TBR=johnmccutchan@google.com ,
Review URL: https://codereview.chromium.org//1174943002 .
2015-06-10 13:24:09 +02:00
Florian Schneider
fee4c530e1
Fix 64-bit build
...
Remove invalid cast from uword to uword.
TBR=srdjan@google.com
Review URL: https://codereview.chromium.org//1174673003 .
2015-06-10 13:08:49 +02:00
Anders Johnsen
ed72caa3cd
Revert and fix more of the mac change.
...
BUG=
Review URL: https://codereview.chromium.org//1175603003 .
2015-06-10 12:31:31 +02:00
Florian Schneider
265a54411a
Object pool with support for untagged entries.
...
This adds meta-information to object pool entries to allow storing
untagged immediates or code addresses (ExternalLabel) directly.
This eliminates the need to generate extra code to preserve the LSB
when storing immediates as smis (x64, arm64).
BUG=
Review URL: https://codereview.chromium.org//1175523002 .
2015-06-10 11:41:22 +02:00
Anders Johnsen
bd25e641f2
Revert execvpe on Mac and fix usage of strerror_r.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1174903002 .
2015-06-10 11:13:29 +02:00
Anders Johnsen
bbdc57ebf6
Clean up process spawning.
...
Pass environment as argument to execvpe and use _exit instead of exit
(so fork/vfork can be used interchangeable).
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1156313004 .
2015-06-10 10:42:54 +02:00
Ryan Macnak
a16abcdf5a
Shrink some fields and add some bounds checks.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//1149943009 .
2015-06-09 10:47:25 -07:00
Daniel Andersson
a410c0f993
Thread-local store buffers, v2
...
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//1168483003 .
2015-06-09 09:33:36 -07:00
Søren Gjesse
d5a34bd6d2
Resolve the executable path on Mac OS when sym-linked
...
Also resolve its directory if symlinked.
This helps to locate the Dart SDK (if any) from the path of the dart
executable. On Linux the use of /proc/self/exe already takes care of this.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//1160793004
2015-06-09 16:13:00 +02:00
Siva Annamalai
c67f93099f
Fix for issue 23598, add a Dart_CreateLibrarySnapshot entrypoint to the API.
...
BUG=23598
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1168223002 .
2015-06-08 18:05:16 -07:00
Ryan Macnak
304382c1b4
Add TypedData instance kinds.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1157003003 .
2015-06-08 17:30:11 -07:00
John McCutchan
82d3caefc7
Fix code display in Observatory
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1164413002
2015-06-08 14:55:26 -07:00
Ivan Posva
f5e3f94019
Fix http://dartbug.com/23578 :
...
- Complete revamp of isolate-specific flags.
- Associate flags with the isolate on creation.
- Dart_CreateIsolate and associate callback do take an
extra flags argument.
- Make sure to clear IC data array when clearing code.
BUG=23578
Review URL: https://codereview.chromium.org//1162033005
2015-06-07 17:57:34 +02:00
Siva Annamalai
da0363172a
Fix for issue 192 in domokit/mojo
...
Serialize Mint objects as is and at the receving side convert them to Smi or Mints depending on the target architecture.
BUG= 192 from domokit/mojo
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1151573022
2015-06-05 14:45:17 -07:00
Todd Turnidge
676fcddbff
@Int no longer exists
2015-06-04 14:07:03 -07:00
Seth Ladd
8e3bc82c85
Tweak to markdown for link in service protocol spec
2015-06-04 12:47:09 -07:00
Ryan Macnak
6545e8539e
Fix isAssignableTo in VM mirrors to use subtype (<:) rather than moreSpecificThan (<<).
...
BUG=http://dartbug.com/22852
R=gbracha@google.com
Review URL: https://codereview.chromium.org//1156583005
2015-06-04 12:25:59 -07:00
Todd Turnidge
d5dc5ccc56
Add feedback link.
...
BUG=
R=sethladd@google.com
Review URL: https://codereview.chromium.org//1159983007
2015-06-04 10:19:40 -07:00
Todd Turnidge
996f012707
2nd attempt at adding streamListen/streamCancel to the service protocol.
...
This time I am committing the protocol changes first and saving the
Observatory changes for a second cl.
------
We currently support 5 streams: Isolate, Debug, GC, _Echo, and _Graph.
Only generate events when at least one client is listening to the
corresponding event stream.
Only send events to the clients that actually request them.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1166433008
2015-06-04 09:57:22 -07:00
Todd Turnidge
1b59b9ea06
Service cleanups...
...
- Allow for multiple breakpoints in the service protocol.
The info isn't actually provided or used yet.
- Drop index for list elements returned by the protocol. Flatten structure.
- Drop index for context elements. Keep sub-structure so we
can choose to add extra slot info later.
- Errors now have ids and kinds.
- exception and stacktrace move from @Error to Error.
- All heap Objects now include class/size.
- Changed BoundedType.type and TypeRef.type to different names.
Turns out we already have a "type" property that conflicts.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1152753005
2015-06-04 09:09:22 -07:00
Lasse R.H. Nielsen
de68aaa595
Clean up JSON parsing code.
...
Fixes some hard-to-find bugs and warnings.
Improves the layout of all the constants.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//1150033013
2015-06-04 14:55:32 +02:00
Srdjan Mitrovic
b666398745
Fix fix (again)
...
BUG=
Review URL: https://codereview.chromium.org//1153413006
2015-06-03 17:13:27 -07:00
Srdjan Mitrovic
1c18123cea
Fix analyzer run on bot
...
BUG=
Review URL: https://codereview.chromium.org//1162023007
2015-06-03 16:52:20 -07:00
Regis Crelier
a5669190ab
Fixed breakpoint handling at return statement with inlined finally clauses.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1170483002
2015-06-03 15:25:42 -07:00
Ryan Macnak
e13679d393
Fix the profiler.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1152553010
2015-06-03 14:02:07 -07:00
Srdjan Mitrovic
7b04897743
Fix fix
...
BUG=
Review URL: https://codereview.chromium.org//1166523005
2015-06-03 12:39:59 -07:00
Srdjan Mitrovic
12da412110
Fix build
...
BUG=
Review URL: https://codereview.chromium.org//1160623004
2015-06-03 11:22:46 -07:00
Srdjan Mitrovic
c0824e7725
Fix 23563: double unary- operator unstable for NANs
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//1160453003
2015-06-03 11:00:28 -07:00
Regis Crelier
4bf6db0c25
Adjust context level when required before executing inlined finally clauses.
...
Add regression test.
BUG=23537
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1154823003
2015-06-03 10:31:48 -07:00
Todd Turnidge
4a3b6fe160
Rework the format of the FlagList response.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1149403007
2015-06-03 10:09:15 -07:00
Todd Turnidge
bf17319a3c
Update gypi.
...
BUG=
Review URL: https://codereview.chromium.org//1169513003
2015-06-03 09:13:33 -07:00
Todd Turnidge
6c2ebfcc60
Switch to using SourceLocation universally in service protocol.
...
Add <location-link> and <location-inset> to provide links and insets
for a location.
Make Frame, Message, and SourceLocation first class in service lib.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1150303004
2015-06-03 09:02:40 -07:00
Florian Schneider
63209c93d3
Fix result cid of CompactLinkedHashMap._index native getter.
...
This field can be null when a hash map is deserialized from a snapshot where
the index is regenerated.
BUG=
R=iposva@google.com , koda@google.com
Review URL: https://codereview.chromium.org//1159393003
2015-06-03 17:01:31 +02:00
Lasse R.H. Nielsen
5a843ebbf3
Add "checked" parameter to Isolate.spawnUri.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//1154673004
2015-06-03 12:32:52 +02:00
Srdjan Mitrovic
defec9c960
--check_function_fingerprints is available only in dart_no_snapshot, i.e., it was not tested. Make it default true, catch failure at build time then
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//1166813002
2015-06-02 16:36:54 -07:00
Ivan Posva
63558e911e
- Make sure to properly check for errors from sysctlbyname.
...
BUG=
Review URL: https://codereview.chromium.org//1150173004
2015-06-02 23:22:24 +02:00
Ryan Macnak
a754930be6
Remove unused field map_ from LinkedHashMap::Iterator.
...
TBR=koda@google.com
Review URL: https://codereview.chromium.org//1162363003
2015-06-02 12:33:28 -07:00