This fixes a serious (but somewhat rare) bug where a line comment in a
switch expression might eat subsequent cases. See:
https://github.com/dart-lang/dart_style/issues/1404
There are no other formatting changes.
Change-Id: I7a1cb751c76abcd0507113635aab3f866a798364
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354063
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
The benchmarks were using a range of antipatterns that did not do what
the authors thought they did. It seems that the authors thought the
warmup method has to run for a while and do the full warmup, but the
truth is that the harness will do that for you by running the warmup
function in a timed loop. Instead these patterns just wasted time by
making the warmup more expensive and complex than needed.
This change just removes the warmup overrides since none of them do
anything positive. This change prepares us for future improvements to
the benchmark harness.
Fixes: b/324874055
Change-Id: Ib7c282123a2151614bc95a105a30e67221f11315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352022
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
This update the checked-in SDK to a version that includes
fe52b9bfe5
which adds support for `dart:_macros` and `package:macros`.
This is needed in order to move shared macro code from to
pkg/_fe_analyzer_shared/ (a temporary location) to `dart:_macros` and
used from the CFE and analyzer through `package:macros`.
Change-Id: Icba4e19ff654b8a664269c12ac555912eccf42bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353401
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
This reverts commit 8d703d1371.
Reason for revert: HHH bot is broken
Original change's description:
> [deps] rev http, markdown, web_socket_channel
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> http (f0a02f9..d8b237d):
> d8b237d 2024-02-15 Kevin Moore [http] Migrate to the latest pkg:web, require Dart 3.3 (dart-lang/http#1132)
> 5179d1c 2024-02-01 dependabot[bot] Bump actions/cache from 3.3.2 to 4.0.0 (dart-lang/http#1125)
> 0b803e8 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/http#1124)
> 82e0424 2024-01-29 Brian Quinlan Use preferred flutter version constraints (dart-lang/http#1119)
> ccefa7c 2024-01-17 Brian Quinlan Support `BaseResponseWithUrl` in `package:cupertino_http` and `package:cronet_http` (dart-lang/http#1110)
> e7a8e25 2024-01-16 Brian Quinlan Add `BaseResponseWithUrl.url` (dart-lang/http#1109)
> c8f17a6 2024-01-12 Brian Quinlan Add a contributing guide (dart-lang/http#1115)
> ebd86b9 2024-01-12 Brian Quinlan Add the ability to get response headers as a `Map<String, List<String>>` (dart-lang/http#1114)
> 5c75da6 2024-01-12 Brian Quinlan Add tests for sending "cookie" and receiving "set-cookie" headers (dart-lang/http#1113)
> c2a6d64 2024-01-12 Alex Li [cronet_http] ⬇️ Downgrade `minSdkVersion` to 21 (dart-lang/http#1104)
> 661f5d6 2024-01-08 Brian Quinlan Use `package:http_image_provider` in all `Client` implementation examples (dart-lang/http#1089)
> 473a892 2024-01-04 Brian Quinlan Remove the "play-services-cronet" dependency in the example app when building `package:cronet_http_embedded` (dart-lang/http#1103)
> e79ebe1 2024-01-03 Moritz Fix `labeler.yml` (dart-lang/http#1099)
> 73b0b1c 2024-01-01 dependabot[bot] Bump actions/labeler from 4.3.0 to 5.0.0 (dart-lang/http#1096)
> 15ec3ba 2023-12-21 Brian Quinlan Prepare to publish `package:cronet_http` as 1.0.0 (dart-lang/http#1087)
> 26e55c3 2023-12-21 Brian Quinlan cronet_http: require android API level 28 (dart-lang/http#1088)
> b10f448 2023-12-22 Alex Li [cronet_http] Enables CI for `cronet_http_embedded` (dart-lang/http#1070)
> a5b8eec 2023-12-18 Brian Quinlan Prepare to publish cupertino 1.2.0 (dart-lang/http#1080)
> c114aa0 2023-12-15 Brian Quinlan Add a fake response for PNG images (dart-lang/http#1081)
> db2cb76 2023-12-14 Kevin Moore Run web tests with wasm with dev Dart sdk (dart-lang/http#1078)
> 36f98e9 2023-12-12 Brian Quinlan Fix a bug where BrowserClient was listed as requiring Flutter (dart-lang/http#1077)
> db7f165 2023-12-07 Brian Quinlan Provide an example of configuring IOClient with an HttpClient. (dart-lang/http#1074)
> cd748b6 2023-12-04 Brian Quinlan Document that runWithClient must be called for every isolate (dart-lang/http#1069)
> f585947 2023-12-04 Brian Quinlan Test persistentConnection with large request bodies (dart-lang/http#984)
> 7c05dde 2023-12-04 Brian Quinlan Add documentation for "no_default_http_client" (dart-lang/http#1068)
> d8983fa 2023-12-04 Brian Quinlan Add support for setting headers for all requests (dart-lang/http#1060)
> c90496e 2023-12-04 Brian Quinlan Document how to use replacement `Client` implementations (dart-lang/http#1063)
> c8536e4 2023-12-01 Kevin Moore [http_client_conformance_tests] Updates to support wasm compilation (dart-lang/http#1064)
> 5dd5140 2023-12-01 dependabot[bot] Bump actions/setup-java from 3 to 4 (dart-lang/http#1065)
> 064f510 2023-11-30 Devon Carew misc cleanup of yaml files (dart-lang/http#1061)
> 22f52e2 2023-11-30 Brian Quinlan Update pubspec.yaml to 0.4.2 (dart-lang/http#1059)
> 40a46d8 2023-11-29 Brian Quinlan Fix a bug where cronet_http sends incorrect HTTP request methods (dart-lang/http#1058)
> c125ed5 2023-11-27 Kevin Moore [http] Allow pkg:web v0.3.0 (dart-lang/http#1055)
> 9fb4cfa 2023-11-22 Kevin Moore Update lints to latest, etc (dart-lang/http#1048)
> 5e84d9f 2023-11-21 Kevin Moore Update platform-specific imports for wasm (dart-lang/http#1051)
> 8c9feb5 2023-11-21 Kevin Moore [http] Fix type cast for dart2wasm (dart-lang/http#1050)
> a2f0b25 2023-11-21 Kevin Moore [http] use pkg:web, require Dart 3.2 (dart-lang/http#1049)
>
> markdown (c2b8429..6efe141):
> 6efe141 2024-02-14 Kevin Moore Migrate example to pkg:web, update minimum required Dart version (dart-lang/markdown#582)
>
> web_socket_channel (5241175..3db86bc):
> 3db86bc 2024-02-15 Kevin Moore Require Dart 3.3 and the latest pkg:web (dart-lang/web_socket_channel#326)
> 1c4a923 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/web_socket_channel#323)
> 041aa3c 2024-01-08 Devon Carew adjust the HtmlWebSocketChannel ctor parameter type; rev to 2.4.3 (dart-lang/web_socket_channel#320)
> 0e8bedc 2024-01-04 Tyler Dunn Allow pkg:web v0.3.0 (dart-lang/web_socket_channel#306)
> 62370cc 2024-01-01 dependabot[bot] Bump actions/stale from 8.0.0 to 9.0.0 (dart-lang/web_socket_channel#312)
> 2a0563f 2023-12-18 Kevin Moore Prepare release v2.4.1 (dart-lang/web_socket_channel#301)
> 906c944 2023-12-14 Kevin Moore CI: test dev SDK with dart2wasm (dart-lang/web_socket_channel#304)
> a316c53 2023-12-13 Kevin Moore Rename helper extensions to not collide with pkg:web unreleased (dart-lang/web_socket_channel#303)
> 547184a 2023-12-11 Kevin Moore blast_repo fixes (dart-lang/web_socket_channel#302)
> 969bc6c 2023-12-09 Ömer Sinan Ağacan Fix JS value to Dart conversion when receiving from a web socket (dart-lang/web_socket_channel#298)
> df096a9 2023-11-30 Ömer Sinan Ağacan Remove removed lints (dart-lang/web_socket_channel#299)
> 67bf9a3 2023-11-23 Nate Bosch Drop some use of ! (dart-lang/web_socket_channel#296)
> d4a8d70 2023-11-22 Kevin Moore Small tweak (dart-lang/web_socket_channel#295)
> 9e80b8d 2023-11-22 Kevin Moore migrate to pkg web (dart-lang/web_socket_channel#294)
>
> Change-Id: I87c4baa07efc5fc2bb283c7b32e69ad69c5a02aa
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352960
> Reviewed-by: Kevin Moore <kevmoo@google.com>
> Commit-Queue: Devon Carew <devoncarew@google.com>
Change-Id: I8723a343908227e39604cba7827c0f99912a10f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352967
Reviewed-by: Siva Annamalai <asiva@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`.
http (f0a02f9..d8b237d):
d8b237d 2024-02-15 Kevin Moore [http] Migrate to the latest pkg:web, require Dart 3.3 (dart-lang/http#1132)
5179d1c 2024-02-01 dependabot[bot] Bump actions/cache from 3.3.2 to 4.0.0 (dart-lang/http#1125)
0b803e8 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/http#1124)
82e0424 2024-01-29 Brian Quinlan Use preferred flutter version constraints (dart-lang/http#1119)
ccefa7c 2024-01-17 Brian Quinlan Support `BaseResponseWithUrl` in `package:cupertino_http` and `package:cronet_http` (dart-lang/http#1110)
e7a8e25 2024-01-16 Brian Quinlan Add `BaseResponseWithUrl.url` (dart-lang/http#1109)
c8f17a6 2024-01-12 Brian Quinlan Add a contributing guide (dart-lang/http#1115)
ebd86b9 2024-01-12 Brian Quinlan Add the ability to get response headers as a `Map<String, List<String>>` (dart-lang/http#1114)
5c75da6 2024-01-12 Brian Quinlan Add tests for sending "cookie" and receiving "set-cookie" headers (dart-lang/http#1113)
c2a6d64 2024-01-12 Alex Li [cronet_http] ⬇️ Downgrade `minSdkVersion` to 21 (dart-lang/http#1104)
661f5d6 2024-01-08 Brian Quinlan Use `package:http_image_provider` in all `Client` implementation examples (dart-lang/http#1089)
473a892 2024-01-04 Brian Quinlan Remove the "play-services-cronet" dependency in the example app when building `package:cronet_http_embedded` (dart-lang/http#1103)
e79ebe1 2024-01-03 Moritz Fix `labeler.yml` (dart-lang/http#1099)
73b0b1c 2024-01-01 dependabot[bot] Bump actions/labeler from 4.3.0 to 5.0.0 (dart-lang/http#1096)
15ec3ba 2023-12-21 Brian Quinlan Prepare to publish `package:cronet_http` as 1.0.0 (dart-lang/http#1087)
26e55c3 2023-12-21 Brian Quinlan cronet_http: require android API level 28 (dart-lang/http#1088)
b10f448 2023-12-22 Alex Li [cronet_http] Enables CI for `cronet_http_embedded` (dart-lang/http#1070)
a5b8eec 2023-12-18 Brian Quinlan Prepare to publish cupertino 1.2.0 (dart-lang/http#1080)
c114aa0 2023-12-15 Brian Quinlan Add a fake response for PNG images (dart-lang/http#1081)
db2cb76 2023-12-14 Kevin Moore Run web tests with wasm with dev Dart sdk (dart-lang/http#1078)
36f98e9 2023-12-12 Brian Quinlan Fix a bug where BrowserClient was listed as requiring Flutter (dart-lang/http#1077)
db7f165 2023-12-07 Brian Quinlan Provide an example of configuring IOClient with an HttpClient. (dart-lang/http#1074)
cd748b6 2023-12-04 Brian Quinlan Document that runWithClient must be called for every isolate (dart-lang/http#1069)
f585947 2023-12-04 Brian Quinlan Test persistentConnection with large request bodies (dart-lang/http#984)
7c05dde 2023-12-04 Brian Quinlan Add documentation for "no_default_http_client" (dart-lang/http#1068)
d8983fa 2023-12-04 Brian Quinlan Add support for setting headers for all requests (dart-lang/http#1060)
c90496e 2023-12-04 Brian Quinlan Document how to use replacement `Client` implementations (dart-lang/http#1063)
c8536e4 2023-12-01 Kevin Moore [http_client_conformance_tests] Updates to support wasm compilation (dart-lang/http#1064)
5dd5140 2023-12-01 dependabot[bot] Bump actions/setup-java from 3 to 4 (dart-lang/http#1065)
064f510 2023-11-30 Devon Carew misc cleanup of yaml files (dart-lang/http#1061)
22f52e2 2023-11-30 Brian Quinlan Update pubspec.yaml to 0.4.2 (dart-lang/http#1059)
40a46d8 2023-11-29 Brian Quinlan Fix a bug where cronet_http sends incorrect HTTP request methods (dart-lang/http#1058)
c125ed5 2023-11-27 Kevin Moore [http] Allow pkg:web v0.3.0 (dart-lang/http#1055)
9fb4cfa 2023-11-22 Kevin Moore Update lints to latest, etc (dart-lang/http#1048)
5e84d9f 2023-11-21 Kevin Moore Update platform-specific imports for wasm (dart-lang/http#1051)
8c9feb5 2023-11-21 Kevin Moore [http] Fix type cast for dart2wasm (dart-lang/http#1050)
a2f0b25 2023-11-21 Kevin Moore [http] use pkg:web, require Dart 3.2 (dart-lang/http#1049)
markdown (c2b8429..6efe141):
6efe141 2024-02-14 Kevin Moore Migrate example to pkg:web, update minimum required Dart version (dart-lang/markdown#582)
web_socket_channel (5241175..3db86bc):
3db86bc 2024-02-15 Kevin Moore Require Dart 3.3 and the latest pkg:web (dart-lang/web_socket_channel#326)
1c4a923 2024-02-01 dependabot[bot] Bump dart-lang/setup-dart from 1.6.0 to 1.6.2 (dart-lang/web_socket_channel#323)
041aa3c 2024-01-08 Devon Carew adjust the HtmlWebSocketChannel ctor parameter type; rev to 2.4.3 (dart-lang/web_socket_channel#320)
0e8bedc 2024-01-04 Tyler Dunn Allow pkg:web v0.3.0 (dart-lang/web_socket_channel#306)
62370cc 2024-01-01 dependabot[bot] Bump actions/stale from 8.0.0 to 9.0.0 (dart-lang/web_socket_channel#312)
2a0563f 2023-12-18 Kevin Moore Prepare release v2.4.1 (dart-lang/web_socket_channel#301)
906c944 2023-12-14 Kevin Moore CI: test dev SDK with dart2wasm (dart-lang/web_socket_channel#304)
a316c53 2023-12-13 Kevin Moore Rename helper extensions to not collide with pkg:web unreleased (dart-lang/web_socket_channel#303)
547184a 2023-12-11 Kevin Moore blast_repo fixes (dart-lang/web_socket_channel#302)
969bc6c 2023-12-09 Ömer Sinan Ağacan Fix JS value to Dart conversion when receiving from a web socket (dart-lang/web_socket_channel#298)
df096a9 2023-11-30 Ömer Sinan Ağacan Remove removed lints (dart-lang/web_socket_channel#299)
67bf9a3 2023-11-23 Nate Bosch Drop some use of ! (dart-lang/web_socket_channel#296)
d4a8d70 2023-11-22 Kevin Moore Small tweak (dart-lang/web_socket_channel#295)
9e80b8d 2023-11-22 Kevin Moore migrate to pkg web (dart-lang/web_socket_channel#294)
Change-Id: I87c4baa07efc5fc2bb283c7b32e69ad69c5a02aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352960
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
The only real breaking change since the last roll should
be the IDL update.
Change-Id: I1cdcf2f6acae52d7b644025e9d0e05a5c1ca7609
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352941
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
The newer version will contain optimizations that remove `array.len`
instructions of arrays that have a known length
Change-Id: I52a302fdfdc757e082c762c89cbcb68123025795
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352524
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
We're expecting to do multiple breaking changes to native_assets_cli
and native_assets_builder in the foreseeable future. So lets not break
the roller script for DEPS.
Change-Id: I6829de8d11e381fa2c56a974400ac636ec9e84cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350925
Reviewed-by: Moritz Sümmermann <mosum@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
This will be paired with a hotfix to land in google3. Updating the
DEPS to use the latest version of package:web will be done in a
future commit.
Change-Id: Ia09b34e14250c9b2c2586d1dc369e9ccbab8b331
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349960
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Bug: b/297175436
Change-Id: Ib0766cd3be8bc48476b7bf52ff1e73563e90c6fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352021
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Switch to the new secure cipd packages. Temporarily check out all of the
versions in their existing locations to ease this transition as a first
step.
Bug: b/324389547
Change-Id: I6b534da02c87b83bb742a8853d31bcaf796bc537
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350924
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
(The automated infra to create new D8 versions has some issues atm)
Change-Id: I5a43566f763eb3d9efeba0f0cab0357a802b33b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/351061
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: William Hesse <whesse@google.com>
The only change here is support for the `macro` keyword which is gated
by the "macros" experiment flag.
Change-Id: I354820fc1847ef2391d2df92b634f7252bfc1000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/348722
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
`package:ffi` has moved from dart-lang/ffi to dart-lang/native.
Stop pulling in dart-lang/ffi and update the revision for
dart-lang/native to include a revision with `package:ffi`
`tools/generate_package_config.dart` should automatically update
the toplevel `.dart_tool/package_config.json` to point to the new
checkout location the Dart SDK.
Also rolls breaking change in native_assets_cli:
https://github.com/dart-lang/native/pull/885
And rolls the move of the test projects:
https://github.com/dart-lang/native/pull/938
Change-Id: Ibc1c88026487bece2580a7d3d4ceb7ee50cd76d0
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-mac-release-try,pkg-mac-release-arm64-try,pkg-win-release-try,pkg-win-release-arm64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346761
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Moritz Sümmermann <mosum@google.com>
