Commit graph

552 commits

Author SHA1 Message Date
lrn@google.com
bbfe7b02dc Reapply "Make Comparable generic."
Avoid concurrent modification in dart2js.
Avoid crash in VM by not using self-referential type bound.

Review URL: https://codereview.chromium.org//12288040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18667 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 10:29:44 +00:00
kasperl@google.com
d4feeb4910 Revert "Make Comparable generic."
This reverts commit dd714db881a0ad63eaa1e5491e93dd8843eb5929.

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//12298027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18657 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 08:06:03 +00:00
lrn@google.com
a0f22b77be Make Comparable generic.
It's now allowed to write "class X implements Comparable<X>" to make
X comparable only to X's. The argument type of Comparable<T>.compareTo
is now T.

Review URL: https://codereview.chromium.org//12255055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18655 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 07:52:24 +00:00
lrn@google.com
03f5a66836 Recommit changing List.skip/take/revert returns Iterable and remove mappedBy.
This reverts r18591.

Review URL: https://codereview.chromium.org//12295009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18615 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-18 10:35:51 +00:00
rnystrom@google.com
0e0473d33a Unbreak pub:
Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."

This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.

Revert "Remove deprecated mappedBy."

This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.

BUG=dartbug.com/8560

Review URL: https://codereview.chromium.org//12286004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18591 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 18:38:42 +00:00
floitsch@google.com
0672317bec Remove deprecated mappedBy.
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576

Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:57:18 +00:00
floitsch@google.com
ad839e6957 Revert "Remove deprecated mappedBy."
This reverts commit 18575.

Review URL: https://codereview.chromium.org//12207205

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:23:22 +00:00
floitsch@google.com
b37100770b Remove deprecated mappedBy.
Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:18:17 +00:00
lrn@google.com
ecbf4478c2 Reapply "New implementation of {,Linked}Hash{Set,Map}."
Review URL: https://codereview.chromium.org//12212211

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18573 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:07:22 +00:00
lrn@google.com
b7f36d0d11 Make List.skip, List.take and List.reversed return Iterables, not Lists.
Removes ListView. It was premature optimization to have classes that combined any sequence of reverse, skip and take instead of just wrapping iterables.

Review URL: https://codereview.chromium.org//12262037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18570 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 10:43:21 +00:00
dgrove@google.com
278d7b0c74 Update documentation links to point to the correct URLs.
Review URL: https://codereview.chromium.org//12252055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18552 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:27:10 +00:00
vsm@google.com
e2ef36a751 Fix dart.js to handle query strings
Still needs an automated test, but this passes my local ones.

BUG=http://code.google.com/p/dart/issues/detail?id=8408

Review URL: https://codereview.chromium.org//12212203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18549 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 23:38:20 +00:00
efortuna@google.com
7120208746 Fix test status for analyzer test.
BUG=

Review URL: https://codereview.chromium.org//12252045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18544 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 22:03:28 +00:00
pquitslund@google.com
c5fba36a7a Test status fix to properly exclude analyzer tests from dart2js builds.
Review URL: https://codereview.chromium.org//12263045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18538 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 19:51:22 +00:00
pquitslund@google.com
fc2c75acda Fresh drop of analyzer-experimental.
Among other things, 
  * adds resolver and tests (in progress)
  * more tests in general (e.g., ast_test.dart and element_test.dart)
  * fixes getter/setter name generation
Review URL: https://codereview.chromium.org//12253009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18535 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 19:28:02 +00:00
amouravski@google.com
904cde1cca Added a readme to the browser package, so people know what's up.
Review URL: https://codereview.chromium.org//12212138

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18532 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 19:11:48 +00:00
alanknight@google.com
84b4fc6a80 Fix modification of map while iterating in SimpleJsonFormat
Review URL: https://codereview.chromium.org//12210151

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18527 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 18:30:21 +00:00
alanknight@google.com
a3061ab600 Stop using deprecated charCodeAt in Intl
Review URL: https://codereview.chromium.org//12262030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18526 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 18:23:43 +00:00
floitsch@google.com
02a5b031fe Change Future.delayed to take a Duration.
Review URL: https://codereview.chromium.org//12224081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18471 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 19:31:22 +00:00
nweiz@google.com
3a4523a461 Fix the expected error messages for scheduled tests.
TBR
BUG=8511

Review URL: https://codereview.chromium.org//12223122

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18430 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 02:11:00 +00:00
nweiz@google.com
1301af8746 Add built-in timeouts to scheduled_test.
Unlike r18363, this mocks out the Timer class to provide more deterministic
behavior when running tests on slow computers.

BUG=8511

Review URL: https://codereview.chromium.org//12251012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18429 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 02:03:56 +00:00
gram@google.com
d805b1b5c6 Remove deprecated functions.
See https://code.google.com/p/dart/issues/detail?id=8136
Review URL: https://codereview.chromium.org//12217148

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18425 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 01:07:28 +00:00
gram@google.com
59df9eecd7 Our nice new mismatched type error messages are garbled by minification.
Changing the unittest test to use a RegExp for verification instead of
a string literal.
Review URL: https://codereview.chromium.org//12221157

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18424 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 01:07:08 +00:00
nweiz@google.com
247d10c77c Pump the event queue manually rather than using a timer.
Hopefully this will be less flaky than timer-based tests.

Review URL: https://codereview.chromium.org//12224128

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18420 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 00:20:03 +00:00
amouravski@google.com
9cbede1d32 Added documentation links to all of the pkg packages hosted on api.dartlang.org.
Review URL: https://codereview.chromium.org//12218119

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18414 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 23:38:30 +00:00
gram@google.com
8e92719e2e Work around dart2js' broken implementation of runtimeType.
Review URL: https://codereview.chromium.org//12226131

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18411 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 23:15:03 +00:00
gram@google.com
a8874f5796 TBR: Revert unittest test that makes use of function names as dart2js does not support this.
Review URL: https://codereview.chromium.org//12218127

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18405 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 22:04:38 +00:00
gram@google.com
21ad5a0a84 Fix break in checked mode.
Review URL: https://codereview.chromium.org//12212147

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18404 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 21:25:57 +00:00
gram@google.com
851302ec89 Unit test improvements:
When doing equality tests, if two items have a different type but the same toString() represenation it can be hard to figure out the difference; we now include type info.
See https://code.google.com/p/dart/issues/detail?id=6816

If callbacks are not anonymous we include their names in error messages.

Throws matchers will fail now on arguments that are not Functions or Futures.
See https://code.google.com/p/dart/issues/detail?id=6761

Fix initial comment on how to use unittest; see issue https://code.google.com/p/dart/issues/detail?id=7835

The verbose flag to expect worked to show contents of Iterables but not Maps; fixed that.
Review URL: https://codereview.chromium.org//12217142

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18401 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 21:08:33 +00:00
gram@google.com
dad3b5ae60 Improve matcher descriptions that match against objects, and thus fix a bug
in mocking library. 

See https://code.google.com/p/dart/issues/detail?id=7039
Review URL: https://codereview.chromium.org//12207123

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18386 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 17:22:19 +00:00
nweiz@google.com
f9e5ae9887 Revert "Add built-in timeouts to scheduled_test."
This reverts r18363.

Review URL: https://codereview.chromium.org//12226103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18366 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 01:54:36 +00:00
alanknight@google.com
94c3ee853d Status file workaround for serialization flakiness for the moment
Review URL: https://codereview.chromium.org//12248010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18364 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 01:51:22 +00:00
nweiz@google.com
8186b2e7ae Add built-in timeouts to scheduled_test.
Review URL: https://codereview.chromium.org//12218102

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18363 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 01:18:45 +00:00
nweiz@google.com
a9b616c161 Re-submit r18349.
This should hopefully guard against the race condition introduced by extremely
slow CPU time.

Review URL: https://codereview.chromium.org//12217122

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18361 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 00:52:46 +00:00
gram@google.com
845e951d44 setUp/tearDown functions can now be asynchronous.
See https://code.google.com/p/dart/issues/detail?id=7670
As part of this change:
- you can now provide an ID in calls to expectAsyncN; if a callback gets called too many times the ID will now be included in the message
- each test case is responsible for kicking off the next test case once it is complete. This is cleaner than the old code which had various tests scattered around that would kick off the next test case.
Review URL: https://codereview.chromium.org//12213079

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18360 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 00:34:41 +00:00
nweiz@google.com
4bbc4dadb8 Roll back r18349.
This was exhibiting flaky failures on the VM bots.

Review URL: https://codereview.chromium.org//12208116

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18359 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 00:24:56 +00:00
alanknight@google.com
9fef95b7cc Some fixes to work better with the services framework
Review URL: https://codereview.chromium.org//12136002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18357 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 23:38:22 +00:00
nweiz@google.com
f547a4b770 Fix a couple ScheduleError error messages.
Review URL: https://codereview.chromium.org//12210098

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18350 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 23:00:38 +00:00
nweiz@google.com
9772358aa4 Make the scheduled_test schedule keep track of multiple errors.
Review URL: https://codereview.chromium.org//12208096

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18349 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 22:56:00 +00:00
gram@google.com
4bb8fb3d67 If two Maps are compared with an equals() matcher and they have the same length,
show the first key missing from 'actual' that is in 'expected'.

See https://code.google.com/p/dart/issues/detail?id=6814
Review URL: https://codereview.chromium.org//12210100

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18347 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 22:46:19 +00:00
floitsch@google.com
3f7146707d Rework Timer interface.
Review URL: https://codereview.chromium.org//12213092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18326 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 19:22:16 +00:00
nweiz@google.com
f64f23b992 Disable the scheduled test tests on the browser bots.
Review URL: https://codereview.chromium.org//12223063

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18297 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-09 02:15:18 +00:00
gram@google.com
a6af513345 Fix HTML enhanced config.
See https://code.google.com/p/dart/issues/detail?id=8335
Review URL: https://codereview.chromium.org//12210093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18294 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-09 01:07:43 +00:00
nweiz@google.com
41ecfcd834 Skip the scheduled test tests on dart2js.
TBR

Review URL: https://codereview.chromium.org//12208094

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18288 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-08 23:29:42 +00:00
nweiz@google.com
8f3ec6b6d3 Add a scheduled test library.
Review URL: https://codereview.chromium.org//12209073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18285 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-08 23:07:57 +00:00
gram@google.com
779c5e6a91 Updated contains and isEmpty matches to use iterables.
Original patch submitted by Matt Butler.
CR at https://codereview.chromium.org/12224053/
Addresses issue https://code.google.com/p/dart/issues/detail?id=8159

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18269 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-08 19:53:01 +00:00
sigmund@google.com
0a139954d0 Remove old location of test_controller.js
Dartium references to the old location have been updated to the new location,
now we can safely remove the file.

Review URL: https://codereview.chromium.org//12212049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18194 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 23:50:27 +00:00
amouravski@google.com
48163b3c35 Changed README to README.md so it looks better on pub.dartlang.org.
Review URL: https://codereview.chromium.org//12224038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18193 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 23:15:52 +00:00
sigmund@google.com
3da8ef3392 Add test controller copy again
(partially reverts effect of r18184)

Review URL: https://codereview.chromium.org//12225060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18186 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 21:02:22 +00:00
sigmund@google.com
376c46005e Move test_controller.js inside unitest/lib so it can be used in external tests
too.

Review URL: https://codereview.chromium.org//12217045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18184 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 19:33:55 +00:00