Commit graph

493 commits

Author SHA1 Message Date
scheglov@google.com 240b4138ce Translate Java enums to Dart constants.
1. Restore "this.field" field formal initializers.

2. Tweaks for several Java places - mostly to the constructors; but also duplicate HintCode messages (in Dart we cannot get values of constant values final fields).

3. Translate field that are not written to Dart final fields and also to field initializers, even if there are no property for them.

4. And constant enums.

5. pkg/code_transformers/test/resolver_test has to be skipped, I cannot fix it myself.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//214253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34474 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 15:37:37 +00:00
scheglov@google.com eedaae10e6 Optimizations for hashCode.
This improves Dart-based analyzer performance.

dart2js:   12500 -> 11600 ms, about 900 ms or 7%.
blueshift: 23500 -> 21500 ms, about 2000 ms or 8%.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//207853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 18:18:14 +00:00
scheglov@google.com d12545d5fa New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//207023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34227 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 05:09:57 +00:00
brianwilkerson@google.com 3185364c4e Partial fix for AST cloning. This change won't get made by the translator, but you might want to just copy it into the CL with translator changes in order to reduce the number of times we have to increment the version number.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//205243008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34202 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 20:33:50 +00:00
scheglov@google.com 5edf555a9a New analyzer snapshot.
R=blois@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//197213036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34188 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 17:38:28 +00:00
jwren@google.com e5ae9bf8ff Update package version for analyzer.dart for the args pub package
R=scheglov@google.com

Review URL: https://codereview.chromium.org//205183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34136 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 20:47:06 +00:00
sigmund@google.com 56334078ae Fix analyzer and code_transformers versions
R=blois@google.com

Review URL: https://codereview.chromium.org//195893046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34127 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 18:15:44 +00:00
scheglov@google.com d160c5b259 Forgotten change in analyzer.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//200613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33711 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 19:44:39 +00:00
scheglov@google.com 206c643c4e Analyzer snapshot with disabled 'this.field' generation.
This should help to workaround https://code.google.com/p/dart/issues/detail?id=17483 is Spark.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//200583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33708 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 18:22:14 +00:00
scheglov@google.com b058e9b442 New analyzer snapshot.
It includes optimization that Jaime made today.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//198453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33636 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 06:34:29 +00:00
scheglov@google.com 844751f9ed Support for DartBlockBody, DartExpressionBody, DartOmit in java2dart.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189433006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33468 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:53:28 +00:00
scheglov@google.com a674327095 Translate private Java members to private Dart members.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33453 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 20:59:57 +00:00
scheglov@google.com 151c4c3a7d Improved 'has' properties translation.
New analyzer snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33399 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:18:26 +00:00
scheglov@google.com 12558a8511 New analzyer snapshot.
Replace isInstanceOf() with a predicate.

Tweaks for other packages.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//186153005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33304 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 21:50:40 +00:00
scheglov@google.com 1f8c20a04d Update and analyzer snapshot with AST -> Ast rename.
R=brianwilkerson@google.com, rnystrom@google.com, blois@google.com, karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//185603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33296 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 20:02:28 +00:00
scheglov@google.com 79e687be71 Add timing info for file IO into Dart based analyzer.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//179123010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33191 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-01 19:47:36 +00:00
scheglov@google.com 7f73657ad6 New analyzer snapshot.
No 'isInstanceOf' changes yet.
Just current state with changes required to adopt to the API changes in Java.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//184893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33176 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 22:52:15 +00:00
scheglov@google.com a2ff040825 Option to disable Angular in Dart-based Analyzer.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//175793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32936 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 22:32:28 +00:00
scheglov@google.com 27fcf8df64 Issue 16827. Add 'set length' to NodeList.
https://code.google.com/p/dart/issues/detail?id=16827

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//170723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32746 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 17:06:50 +00:00
kevmoo@google.com e1fd7ede07 pkg/analyzer: update dependencies
Missing new versions of unittest and args

R=scheglov@google.com

Review URL: https://codereview.chromium.org//168943005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32732 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 21:55:04 +00:00
scheglov@google.com bd4d6033ba New analyzer snapshot.
1. Rename WorkManagerPriority -> SourcePriority.

2. Replace CharSequence with String.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//156763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32373 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 18:09:20 +00:00
scheglov@google.com a85da5e2d8 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//131233009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32362 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 15:31:22 +00:00
scheglov@google.com becf22691a New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//147903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32135 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 20:03:33 +00:00
scheglov@google.com 37b6debef7 New analyzer snapshot.
There are some problems with JDT and line comments.
Interesting, that it works almost everywhere, and also worked coupld weeks ago.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//137143010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32052 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 04:24:41 +00:00
scheglov@google.com 3ad3ff9a2e New analyzer snapshot.
Extracts SdkLibrariesReader_LibraryBuilder into sdk.dart library.
https://code.google.com/p/dart/issues/detail?id=14791

R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//135653008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31939 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-18 00:05:43 +00:00
scheglov@google.com 38d028e67f Issue 8742. Preserve leading line comments during java2dart translation.
https://code.google.com/p/dart/issues/detail?id=8742

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//137863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31790 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 16:28:59 +00:00
scheglov@google.com 7a418f273f Add copyright header to generated analyzer files.
R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//136143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31743 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 16:01:36 +00:00
scheglov@google.com 9efe9ba519 New analyzer snapshot.
Mostly to remove unnecessary casts.
But also includes your latest changed for Alan.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//134533007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31717 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 22:27:52 +00:00
scheglov@google.com 217d980fcd Analyzer snapshot.
Rewrite TimeCounter to use Stopwatch.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//128443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31623 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 20:27:55 +00:00
scheglov@google.com 9841d6b210 Remove debug output and copy java_io.dart into resources.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//115523004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31496 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 18:24:11 +00:00
scheglov@google.com fb931a0028 New analyzer snapshot.
Without Angular.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//123763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31440 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 16:31:28 +00:00
scheglov@google.com 59b87d2dc3 Implement hashCode for classes with equals().
These problems were reported by dart2js.

R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//93433007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31068 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-11 16:32:56 +00:00
scheglov@google.com 965c254725 New analyzer snapshot.
1. Fixes for converting properties for fields:
  1.1. Only if neither getter not setter are overridden. Note that we ignore the fact that it _might_ be overridden in some subclass that we don't see.
       Without this assumption almost nothing can be a field.
  2.2. Create final fields when possible.
2. Generate field formal parameters where possible.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//109853003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31043 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 21:39:47 +00:00
nweiz@google.com 113bd79bc6 Make pkg/path 1.0.0 and upgrade dependencies appropriately.
All existing packages that use pkg/path (other than pkg/stack_trace,
which has already been updated) are compatible with both the pre-1.0
and post-1.0 path API, so I've marked their version constraints as
">=0.9.0 <2.0.0". I've also incremented their patch versions and I
intend to release new versions as soon as this CL lands.

R=alanknight@google.com, efortuna@google.com, jmesserly@google.com, rnystrom@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//110873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31005 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 00:24:01 +00:00
scheglov@google.com fb66f5d516 New analyzer snapshot.
Mainly to add support for the new options.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//107833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30960 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-06 19:43:15 +00:00
scheglov@google.com 0cd8cd4006 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//103233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30862 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 17:57:44 +00:00
scheglov@google.com 9d8ce37bfe New analyzer snapshot.
Also insert empty lines between class and unit members.
Remove some more extra parentheses.

R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//68233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30203 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 19:33:57 +00:00
dgrove@google.com 18ca7d0036 Re-land r29957 (add versions and constraints for packages and samples), with
SDK constraints bumped from 1.0.0 to 0.8.10+6 .

R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//62473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29986 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 18:28:22 +00:00
ajohnsen@google.com 61f6c51990 Revert "add versions and constraints for packages and samples"
This is currently blocking us from testing samples.

BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org//59513007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29960 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 09:09:18 +00:00
jmesserly@google.com 02638c5760 add versions and constraints for packages and samples
- all packages at 0.9.0, except "analyzer" which had a version already
- dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0"
- sdk constraint ">=1.0.0 <2.0.0"

R=sigmund@google.com

Review URL: https://codereview.chromium.org//59763006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29957 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 03:27:58 +00:00
scheglov@google.com d4359631f7 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//51043010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29765 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:24:33 +00:00
scheglov@google.com 9039835b60 New analyzer snapshot.
R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//49383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29384 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 19:46:48 +00:00
scheglov@google.com 7ac0b7d0bd Rename analyzer_experimental to analyzer.
R=jmesserly@google.com, pquitslund@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//45573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29302 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 23:59:38 +00:00