Last usage was removed
Change-Id: Ib8c6d67f22c514c8f706c2c4a683c7022a05ea87
Reviewed-on: https://dart-review.googlesource.com/49000
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Change-Id: I79e86ef8681b0b169b0b40da26a5834eaace66a3
Reviewed-on: https://dart-review.googlesource.com/47580
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
This brings package:http_io into third_party/pkg_tested so that its
migrated tests will run on sdk commits.
Change-Id: I516152747cdaeb1e874a900cb8ad57d84594ed6c
Reviewed-on: https://dart-review.googlesource.com/36842
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This removes scheduled_test which is important for rolling other
packages. In return, it brings in two new packages, test_descriptor and
test_process.
There are no changes in the formatter's actual output. All of the
differences are in tests or internal dependencies, so I don't think we
need to worry about coordinating this with the PRESUBMIT version of
dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
Change-Id: I1c81e157c32326801985615abc353f2239fe2470
Reviewed-on: https://dart-review.googlesource.com/32664
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
This reverts commit 8b8d9b08e1.
Reason for revert: Github mirrors need to be created *before* landing.
Original change's description:
> Update dart_style to 1.0.9 and bring in its new dependencies.
>
> This removes the dependency on scheduled_test which is important for
> rolling other packages. In return, it brings in two new packages,
> test_descriptor and test_process.
>
> There are no changes in the formatter's actual output. All of the
> differences are in tests or internal dependencies, so I don't think we
> need to worry about coordinating this with the PRESUBMIT version of
> dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
>
> Change-Id: I1d6426303055a4400a0ca3d16965a3e05ab39cf7
> Reviewed-on: https://dart-review.googlesource.com/32445
> Reviewed-by: Kevin Moore <kevmoo@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
TBR=kevmoo@google.com,rnystrom@google.com
Change-Id: I3af883a6f41339e3cc79096e0f61639c11af1e20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/32640
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This removes the dependency on scheduled_test which is important for
rolling other packages. In return, it brings in two new packages,
test_descriptor and test_process.
There are no changes in the formatter's actual output. All of the
differences are in tests or internal dependencies, so I don't think we
need to worry about coordinating this with the PRESUBMIT version of
dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
Change-Id: I1d6426303055a4400a0ca3d16965a3e05ab39cf7
Reviewed-on: https://dart-review.googlesource.com/32445
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
There is no actual implementation here yet (that's your job :) ), but there is:
- An external method in dart:_internal, extractTypeArguments().
- Empty patch methods for that for the VM, dart2js, and DDC. These need to have implementations
filled in.
- A "dart_internal" package to expose a subset of the API. It gives you:
extractListTypeArgument()
extractMapTypeArguments()
We'll bring this into Google, but not publish it externally unless we find we really need to.
- A test for the behavior. It probably has bugs since I can't run it.
See: https://github.com/dart-lang/sdk/issues/31371
Change-Id: I7d9f9a3a36f8e8be106440375c80d584898c83cb
Reviewed-on: https://dart-review.googlesource.com/26467
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
This CL introduces compileToKernel() function in package:vm/kernel_front_end
as the replacement for kernelForProgram() from package:front_end/kernel_generator.
The new function will be used to customize kernel Programs for VM need.
For example, it will perform additional AOT-specific global transformations.
In future, compileToKernel() will be used from Flutter and precompiler2.
Also, this CL cleans up Target.strongModeSdk as it is no longer used.
Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: Ib9c2b5d0af955475292df8e456073a5f0e6a64be
Reviewed-on: https://dart-review.googlesource.com/25080
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
This required munging a bit of test.dart code too to tease out some
dependencies, but the changes are minor. I considered moving all of
test.dart out into a package and making the status file library a
public one that other packages in the repo could import but this seemed
like the less intrusive change.
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2984203002 .
This is the result of:
- taking the diff of the branch closure_conversion to master in the kernel
repository
- updating the file paths
- applying the diff to the Dart SDK
- fixing conflicts between the changes to pkg/kernel in the Dart SDK and the master branch in the kernel repository
R=asgerf@google.com
Review-Url: https://codereview.chromium.org/2561723003 .
This removes third_party/pkg/kernel and changes dependencies to
refer to pkg/kernel instead.
Some status files are updated to reflect new test outcomes.
This required some small changes to the API contract.
Note that the tests use supermixins. I'm assuming that supermixin
functionality will be available on all platforms by the time this is
needed. If not, I will be happy to rewrite them.
R=scheglov@google.com, sigmund@google.com
Review URL: https://codereview.chromium.org/2471283002 .