Change-Id: If0747db4bd02d31814b407970b11d16519329625
Reviewed-on: https://dart-review.googlesource.com/c/79661
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Also updated the package references in a number of pubspecs to
more closely align with the package versions that are in the SDK
Change-Id: I061951587befa4211ac7455cf1179911eb07efc0
Reviewed-on: https://dart-review.googlesource.com/c/79920
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
This deletes:
tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib
It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)
I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)
"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."
- Ray Bradbury, Fahrenheit 451
Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
This reverts commit 787194e738.
Reason for revert: Broke windows bots.
Original change's description:
> [infra] Upgrade gsutil to a new version (#31065)
>
> Change-Id: Ie78c6295a5b11cc12adc07a65f716638bcc71495
> Reviewed-on: https://dart-review.googlesource.com/c/79208
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Martin Kustermann <kustermann@google.com>
TBR=kustermann@google.com,athom@google.com
Change-Id: I75c0a2731f80e969fdcd06a6ca2ed72a0407dfbc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/79214
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* Use 64bit d8 on Windows & Mac.
* Default to 64bit d8 on Linux.
Change-Id: Ia03275e48ed0e30bcb2a7b390e7007e34e92cfc5
Reviewed-on: https://dart-review.googlesource.com/c/78640
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
* co19_2 tests enabled for vm-kernel CQ builders.
Change-Id: I5ccc27d1110c22960e550b060a7e140bc1ac68b1
Reviewed-on: https://dart-review.googlesource.com/c/76820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* miscellaneous mixin support fixes
* update to `sort_constructors_first` to apply to all members
* update `unnecessary_this` to work on field initializers
Change-Id: If0578fb3dd67d8f746044e8bbc21e166cd43e4ef
Reviewed-on: https://dart-review.googlesource.com/c/77984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Change-Id: I91fe0da8595ddf07c5b0a345ac9417730b6f964f
Reviewed-on: https://dart-review.googlesource.com/77542
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
* fix cast exceptions related to mixin support
Change-Id: I26361e41f9dee940c462558b6d8251a93f351ecb
Reviewed-on: https://dart-review.googlesource.com/77227
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
There is a race with downloading the prebuilt Dart SDK from CIPD
introduced by:
647e1e79eb
If the prebuilt Dart SDK isn't there, then generate_buildfiles.py will
fail. Instead check whether generate_buildfiles.py should be run
right before we try to build.
Change-Id: I1e25e5280075f9d1c7d96877602617ddfb40291e
Reviewed-on: https://dart-review.googlesource.com/77160
Reviewed-by: Jonas Termansen <sortie@google.com>
* fixes to better support mixins
Change-Id: Ibc67ec7b98d8bc478b0343335e40974b385da152
Reviewed-on: https://dart-review.googlesource.com/76565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
* updated `unawaited_futures` to ignore assignments within cascades
* new lint: `sort_dependencies`
Change-Id: Iec39fce58d4c6230613f947ed6fc99fec516c722
Reviewed-on: https://dart-review.googlesource.com/75942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This is safe to do without also rebuilding the checked in SDK because
it doesn't affect any existing formatted code.
Change-Id: I615c1145c2343da54b7a532ff3f5d077e63cb7ed
Reviewed-on: https://dart-review.googlesource.com/75563
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
* new lint: `prefer_mixin`
* new lint: `avoid_implementing_value_types`
Change-Id: Iaba2d1dd50511db935cf050ba49e7d10746be8cb
Reviewed-on: https://dart-review.googlesource.com/74880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
* new lint: `flutter_style_todos`
* improved handling of constant expressions with generic type params
* NPE fix for `invariant_booleans`
* Google lints example moved to `package:pedantic`
* improved docs for `unawaited_futures`
Change-Id: Ie0eb779f8cb98aaa67674ecfd17baf12445a5934
Reviewed-on: https://dart-review.googlesource.com/74340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Change-Id: Ib37f2f5fd6aec3b86677b5f1c51f6ec6147069a7
Reviewed-on: https://dart-review.googlesource.com/74280
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Change-Id: I72b493a65ef5c854b122d76d80549d30141157fd
Reviewed-on: https://dart-review.googlesource.com/71243
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Change-Id: Iff7d207cda2a88c0f51135a56aec78eed0935d0a
Reviewed-on: https://dart-review.googlesource.com/69461
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* relaxed `void_checks` (allowing `T Function()` to be assigned to `void Function()`)
* test and build improvements
* introduced Effective Dart rule set
* Google ruleset updates
* (internal cleanup): move cli main into `lib/`
* fixed false positives in `lines_longer_than_80_chars`
* new lint: `prefer_void_to_null`
Change-Id: I374197f09701041fd0b507062a3ad903f731656a
Reviewed-on: https://dart-review.googlesource.com/69382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This reverts commit f99b9b80ff.
Reason for revert: Rolls in a version of co19_2 that contains two files whose name differs only by case and whose content is not the same. This breaks "gclient sync" on machines with case-insensitive filesystems (e.g. macs).
Original change's description:
> [co19] co19_2 tests roll (DEPS and .status files update)
>
> Closes#33894
>
> Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
> Change-Id: If1fd4c78cb1c7948602d9a26276cce75cf3133d4
> Reviewed-on: https://dart-review.googlesource.com/68860
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
TBR=whesse@google.com,athom@google.com,eernst@google.com,sgrekhov@unipro.ru
Change-Id: Icd6d8d763c8baff2b82bd15c6b28c56591b7431e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Reviewed-on: https://dart-review.googlesource.com/69340
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Closes#33894
Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: If1fd4c78cb1c7948602d9a26276cce75cf3133d4
Reviewed-on: https://dart-review.googlesource.com/68860
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Closes#33878
Change-Id: Id4687f59c31adb1338643f86909bc5b6b7afb88a
Reviewed-on: https://dart-review.googlesource.com/68040
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This may impact other parts of the SDK who share dartdoc's dependencies.
Change-Id: I5ec19aabcca78c373386dff3c194108b6586841f
Reviewed-on: https://dart-review.googlesource.com/66702
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
These where the last two uses of sunflower in the repo. Sunflower sources have
been deleted from the public github repo. We can alternatively copy them here,
but for these tests it doesn't really matter what code we use.
A benefit of using swarm: this will test compiling swarm, so we detect breakages
early (and not when they hit the perf bots). A drawback of using swarm: it is
bigger and these tests will take longer. For dump-info that might be a good
thing, though.
TBR
Change-Id: Ie976cf4250f5f7ce17147ba8b166e7a6bd429425
Reviewed-on: https://dart-review.googlesource.com/65784
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
* roll-back to explicit uses of `new` and `const` to be compatible w/ VMs running `--no-preview-dart-2`
# 0.1.57
* fix to `lines_longer_than_80_chars` to handle CRLF endings
* doc improvements
* set max SDK version to <3.0.0
* fix to `non_constant_identifier_names` to better handle invalid code
* new lint: `curly_braces_in_flow_control_structures`
Change-Id: I1fd3c9b3892f377c634057451ea0938347ef4e9a
Reviewed-on: https://dart-review.googlesource.com/65573
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>