* Migrate to python3; drop python support.
* Update Windows toolchain support.
* Remove some unused methods.
* Python 2.7 is still needed on Windows.
* Update gsutil to a version that supports python3.
Fixes: https://github.com/dart-lang/sdk/issues/28793
TEST=Manually tested common user journeys.
Change-Id: I663a22b237a548bb82dc2e601e399e3bc3649211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192182
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
The jsshell is used rarely for benchmarking and testing.
Make download of it conditional, at least until it is uploaded
and moved to CPID, to help migration to python3.
To download the shell in a checkout, add
"checkout_javascript_engines": True
to the "custom_vars" in a .gclient solution.
Change-Id: I693a4b402ffebca28d94c124624c4bd897315818
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195261
Reviewed-by: Alexander Thomas <athom@google.com>
Add a `retry` library to replace `http_retry`. We will be able to remove
`http_retry` from the SDK after `http` is published and the usage is
migrated in `pub`.
Change-Id: Id39674d08388ada6406c85d1263494c3d7cbe720
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195168
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2021-04-13 sgrekhov@unipro.ru Fixes 1073. Wait for isolate start before pausing it (1074)
2021-04-12 irina.arkhipets@gmail.com MMore fixes for 1057: test expectation corrected, Issue tags added.
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try
Change-Id: I6ed26b930881df5bbac16b3aa6b4f41cddaf8452
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195070
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-04-12 irina.arkhipets@gmail.comFixes#1071: test expectation corrected.
2021-04-09 sgrekhov@unipro.ruFixes#1072. Remove excessive @compile-error
2021-04-08 sgrekhov@unipro.ru Allow both 254 and 255 result codes on Windows
2021-04-08 irina.arkhipets@gmail.comFixes#1070: tests expectations corrected.
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Iccec27cb0050da7979b471d6a1bd63cbc4656220
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194785
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
The reverts the change to flatted nested conditional expressions since
audience reaction to that was pretty negative.
See: https://github.com/dart-lang/dart_style/pull/1019
Change-Id: Ie9e4460f75c5b7e99e5a6d60e9c38b50ba0bc44a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194883
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2021-03-25 sgrekhov@unipro.ru 1037. A couple of tests that still use nonfunction-type-aliases removed from co19_2 repository
2021-03-24 sgrekhov@unipro.ru 1023. Change SplayTreeMap and SplayTreeSet tests according to the new behavior
Change-Id: Ia8ea48c30b05765bc03cd5a9ee8bb8ad9336e6ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193300
Reviewed-by: Erik Ernst <eernst@google.com>
Apply new lints, cleanup violations, and ignore in `lib/src/js_ast` to
avoid adding additional diffs with the version it was forked from.
Change-Id: I1def25865bf195120c594223ebdc0f59139e75b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192241
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2021-03-24 sgrekhov@unipro.ru extension-methods experimental flag removed from co19_2 tests
2021-03-24 sgrekhov@unipro.ru 1028. Tests that use nonfunction-type-aliases removed from co19_2 repository
2021-03-23 sgrekhov@unipro.ru 1021. Remove expecting errors on web configurations for some negative numbers
2021-03-23 sgrekhov@unipro.ru 1028. Remove triple shift operator from co19_2 repository
2021-03-23 sgrekhov@unipro.ru 1028. Remove triple shift tests from co19_2 repository
2021-03-22 irina.arkhipets@gmail.com Fixes 1015: removed test because triple-shift feature is not supported in this branch.
2021-03-18 sgrekhov@unipro.ru Fixes 1014. Expect compile error on dart2js as [web]
2021-03-17 sgrekhov@unipro.ru Fixes 1014. Expect compile error on dart2js for big numbers
2021-03-17 sgrekhov@unipro.ru Fixes 1017. Use => for setter returning value tests
2021-03-16 sgrekhov@unipro.ru Fixes 1013. Fix cast failures in Type_Cast/syntax_t01 test
2021-03-16 sgrekhov@unipro.ru Fixes 1012. Fix Additive_Expressions/syntax_t01 test
2021-03-16 sgrekhov@unipro.ru Fixes 1010. Description updated for method_definition tests
2021-03-16 sgrekhov@unipro.ru Fixes 1011. Expect an error if non-function type is called as a function
2021-03-16 sgrekhov@unipro.ru Fixes 1009. Missed experimental flag added
2021-03-16 sgrekhov@unipro.ru Fixes 1008. Calling constructor without new keyword is not an error
2021-03-16 sgrekhov@unipro.ru Fixes 1007. Missed experimental flag added
2021-03-16 sgrekhov@unipro.ru Fixes 1006. Import library first before export it
Cq-Include-Trybots: dart/try:analyzer-linux-release,analyzer-mac-release,analyzer-win-release,dart2js-strong-hostasserts-linux-ia32-d8,dart2js-strong-linux-x64-chrome,dart2js-strong-linux-x64-firefox,dart2js-strong-mac-x64-chrome,dart2js-strong-mac-x64-safari,dart2js-strong-win-x64-chrome,dart2js-strong-win-x64-edge,dart2js-strong-win-x64-firefox,dart2js-strong-win-x64-ie11,ddc-linux-release-chrome,ddc-win-release-chrome,ddk-linux-release-firefox,front-end-linux-release-x64,front-end-mac-release-x64,front-end-win-release-x64,vm-kernel-linux-debug-ia32,vm-kernel-linux-debug-x64,vm-kernel-linux-debug-x64c,vm-kernel-linux-product-x64,vm-kernel-linux-product-x64c,vm-kernel-linux-release-x64,vm-kernel-linux-release-x64c,vm-kernel-mac-debug-x64,vm-kernel-mac-debug-x64c,vm-kernel-mac-product-x64,vm-kernel-mac-product-x64c,vm-kernel-mac-release-x64,vm-kernel-mac-release-x64c,vm-kernel-precomp-linux-release-x64,vm-kernel-win-release-x64,vm-kernel-win-release-x64c
Change-Id: I7dda06f20991d47c5a6e83321c0a18005e645a72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192745
Reviewed-by: William Hesse <whesse@google.com>
This is part of a series of changes to add support for SDK expression eval tests.
Change-Id: Ia96931fdf81324fa131014b49ec2067507c451f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191022
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
This reverts commit 88ee333408.
Reason for revert: Hook added by mistake removed.
Original change's description:
> Revert "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12"
>
> This reverts commit 03e8ddd13c.
>
> Reason for revert: Change to hooks does not work with Windows.
>
> Original change's description:
> > [co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12
> >
> > 2021-03-22 sgrekhov@unipro.ruFixes#1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
> > 2021-03-22 sgrekhov@unipro.ruFixes#1027. Typo fixed
> > 2021-03-22 sgrekhov@unipro.ruFixes#1026. Missed experimental flag added
> > 2021-03-22 sgrekhov@unipro.ru Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems
> > 2021-03-19 sgrekhov@unipro.ru#1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS
> >
> > Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
> > Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303
> > Reviewed-by: William Hesse <whesse@google.com>
> > Commit-Queue: Alexander Thomas <athom@google.com>
>
> TBR=whesse@google.com,athom@google.com
>
> Change-Id: I5f66db541034377f5d68424073282080d13fd34b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try
> Cq-Include-Trybots: dart2js-nnbd-linux-x64-chrome-try
> Cq-Include-Trybots: ddc-nnbd-linux-release-chrome-try
> Cq-Include-Trybots: front-end-nnbd-linux-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-debug-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-release-simarm64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-mac-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-win-release-x64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-debug-x64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-simarm64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-x64-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192380
> Reviewed-by: William Hesse <whesse@google.com>
# Not skipping CQ checks because this is a reland.
Change-Id: Ie54fde2d92d1b2cdb3b70835f1f8c17e3c5ac477
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192384
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit 03e8ddd13c.
Reason for revert: Change to hooks does not work with Windows.
Original change's description:
> [co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12
>
> 2021-03-22 sgrekhov@unipro.ruFixes#1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
> 2021-03-22 sgrekhov@unipro.ruFixes#1027. Typo fixed
> 2021-03-22 sgrekhov@unipro.ruFixes#1026. Missed experimental flag added
> 2021-03-22 sgrekhov@unipro.ru Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems
> 2021-03-19 sgrekhov@unipro.ru#1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS
>
> Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
> Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303
> Reviewed-by: William Hesse <whesse@google.com>
> Commit-Queue: Alexander Thomas <athom@google.com>
TBR=whesse@google.com,athom@google.com
Change-Id: I5f66db541034377f5d68424073282080d13fd34b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try
Cq-Include-Trybots: dart2js-nnbd-linux-x64-chrome-try
Cq-Include-Trybots: ddc-nnbd-linux-release-chrome-try
Cq-Include-Trybots: front-end-nnbd-linux-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-debug-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-release-simarm64-try
Cq-Include-Trybots: vm-kernel-nnbd-linux-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-mac-release-x64-try
Cq-Include-Trybots: vm-kernel-nnbd-win-release-x64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-debug-x64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-simarm64-try
Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192380
Reviewed-by: William Hesse <whesse@google.com>
2021-03-22 sgrekhov@unipro.ruFixes#1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
2021-03-22 sgrekhov@unipro.ruFixes#1027. Typo fixed
2021-03-22 sgrekhov@unipro.ruFixes#1026. Missed experimental flag added
2021-03-22 sgrekhov@unipro.ru Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems
2021-03-19 sgrekhov@unipro.ru#1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Also updated non-migrated libraries to include @dart=2.10.
Change-Id: Idcf4e54f9aa37b9b016133144af594cc932418a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192122
Reviewed-by: Gary Roumanis <grouma@google.com>
EDIT: see discussion below about breaking changes in `prefer_const_literals_to_create_immutables`.
EDIT2: looks like this was fixed upstream in analyzer 👍
Change-Id: I3fca9d074cece9cb60b8e97bdb72aa3bd3b2c2a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191762
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This is part of a series of changes to add support for SDK expression eval tests.
This change:
* Adds SDK dependencies on webkit_inspection_protocol.dart and browser_launcher.dart
* Adds dev dependencies to DDC
Change-Id: I025a1f1b59e00858a33016818b6746c57c9caec4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190961
Commit-Queue: Mark Zhou <markzipan@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
2021-03-17 sgrekhov@unipro.ruFixes#1017. Use => for setter returning value tests
2021-03-16 irina.arkhipets@gmail.com Issue #996: more tests for Generic functions as type arguments and bounds added.
2021-03-16 sgrekhov@unipro.ruFixes#1005. Description updated for method_definition tests
2021-03-16 sgrekhov@unipro.ruFixes#1011. Expect an error if non-function type is called as a function
2021-03-16 irina.arkhipets@gmail.com Issue #996: tests for Generic functions as type arguments and bounds re-factored, more tests added.
2021-03-15 irina.arkhipets@gmail.com Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-15 irina.arkhipets@gmail.com Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-15 sgrekhov@unipro.ru Missed experiment flag added
2021-03-12 irina.arkhipets@gmail.com Issue #996: tests for Generic functions as type arguments and bounds added.
2021-03-12 sgrekhov@unipro.ru#993. Added tests checking that Struct fields cannot have initializers
2021-03-12 sgrekhov@unipro.ru#993. Tests for not external members of Struct subtype added
2021-03-11 sgrekhov@unipro.ru#993. Use package ffi in co19 ffi tests
2021-03-09 sgrekhov@unipro.ruFixes#995. Annotations with type arguments tests added
2021-03-09 irina.arkhipets@gmail.com Issue #997: existing triple-shift tests corrected.
2021-03-09 irina.arkhipets@gmail.com More fixes for #535: split constant evaluation tests because static behavior of the strong and weak mode is different.
2021-03-04 sgrekhov@unipro.ru#993. Array tests added
2021-03-04 sgrekhov@unipro.ru#993. Pointer equality tests added
2021-03-03 sgrekhov@unipro.ru#993. Pointer.elementAt() tests added
2021-03-02 sgrekhov@unipro.ru#993. Pointer.cast() tests added
2021-03-01 sgrekhov@unipro.ru#993. Pointer tests added
2021-03-01 sgrekhov@unipro.ruFixes#936. Change expected result according to the new left top rule
2021-02-26 irina.arkhipets@gmail.comFixed#998: tests checks output streams correctly now.
2021-02-26 sgrekhov@unipro.ru#993. IntPtr tests added
2021-02-26 sgrekhov@unipro.ru#993. More Struct tests added
2021-02-25 irina.arkhipets@gmail.com Tests updated, missing issue tags added.
2021-02-25 sgrekhov@unipro.ru#1003. Isolate test fixed to not to be a racy
2021-02-25 sgrekhov@unipro.ru Issue numbers added
2021-02-24 sgrekhov@unipro.ru Issue number added
2021-02-24 sgrekhov@unipro.ru#988. Typo in error message fixed
2021-02-24 sgrekhov@unipro.ru#988. Fix test expectations
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I718644028b1d2a9fbba0c7efdf2923bb67184fde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191409
Reviewed-by: William Hesse <whesse@google.com>
No formatting changes, so no need to sync the pre-built SDK.
Change-Id: Ide5a58764e865e1226219ce6af9a5cb1444e29b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191463
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
There are no formatting changes aside from adding support for generic
metadata annotations, which are not yet used. Changes are:
- Migrated to null safety.
- Return exit code from FormatCommand.run().
Change-Id: I8892f6551541f673b8e49045665e2371ba40b026
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191182
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Last roll was from 6/18/2020.
Allows to enable "implicit-int-float-conversion" warning in the dart codebase.
Change-Id: Ida1a3a477e5bc45993dc10e0c3db410265a005ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191300
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
The code has been dead for quite some time.
TEST=ci
Change-Id: Iddcb63e14e9e4d95230f006ac05da64f444f0712
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190024
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Change-Id: Iba3cca2a342ab473bd38f6ec6bdbdbd10b5cd90f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190001
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Pulls a pre-built DevTools into the SDK and provides an update script to
pull DevTools, rebuild at a particular revision, and upload the new
build to CIPD.
Change-Id: Ice7a9b6bfeea333bc2769dadaeba6eb11fc033d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187161
Reviewed-by: Siva Annamalai <asiva@google.com>
2021-02-25 sgrekhov@unipro.ru 1003. Isolate test fixed to not to be a racy
2020-12-24 sgrekhov@unipro.ru Fixes 496. Change tested date to 1 second instead of 1 day to reduce probability to change timezone on DST
2020-11-11 sgrekhov@unipro.ru Fixes 964. Fix path to the library which test runs
2020-10-08 sgrekhov@unipro.ru Fixes 541. Expect not null stack trace
2020-09-22 sgrekhov@unipro.ru Fixes 940. spawnUri_A05_t01 test fixed to not to be racy
2020-09-11 sgrekhov@unipro.ru Fixes 933. Compile time error fixed
2020-09-01 sgrekhov@unipro.ru Fixes 927. Expect error once on explicit extension invocation
2020-08-24 sgrekhov@unipro.ru Fix FileSystemMoveEventTests to not to fail if there is no Move event
2020-08-24 sgrekhov@unipro.ru Fix FileSystemMoveTests to not to fail if there is no Move event
Change-Id: Ieb94b218f707e0e88c61c45696ee9bba9e3db4b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187460
Reviewed-by: Jonas Termansen <sortie@google.com>
Switch to syncing by revision to allow for syncing to google3 before
publishing.
Change-Id: I9db7b02b5602d185ae1b3dda47a95ea906ac261e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186422
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
2021-02-22 whesse@google.com Fix syntax error in test expectation in ffi test (#1002)
2021-02-20 irina.arkhipets@gmail.com#1000: Missing Issue tags added.
2021-02-20 irina.arkhipets@gmail.com Issue #1000: tests updated according to the recent result analysis
2021-02-20 sgrekhov@unipro.ru Roll failures fixed
2021-02-19 sgrekhov@unipro.ru#999. Missed experiment flags added
2021-02-19 sgrekhov@unipro.ru#993. 32 and 64-bit integer tests added
2021-02-19 sgrekhov@unipro.ru#993. Change test to expect compile error if struct subclass created by the constructor
2021-02-19 sgrekhov@unipro.ru#993. Remove tests that run "nm" command
2021-02-18 sgrekhov@unipro.ru#993. More ffi tests added
2021-02-18 irina.arkhipets@gmail.com Instantiate-to-bounds tests apdated according to the SDK Issues 44223, 42446 evaluation.
2021-02-17 irina.arkhipets@gmail.com Issue #535: nnbd-strong requirement added to the tests, more tests for constant evaluation and canonicalization added.
2021-02-17 sgrekhov@unipro.ru Some of type aliases tests fixed
2021-02-17 sgrekhov@unipro.ru#993. More Struct tests added
2021-02-16 irina.arkhipets@gmail.com Issue #535: more tests for constant evaluation and canonicalization added.
2021-02-12 irina.arkhipets@gmail.comFixes#994: test expectesions updated according to the recent SDK changes.
2021-02-12 sgrekhov@unipro.ru#993. More Struct tests added
2021-02-12 irina.arkhipets@gmail.com Merge remote-tracking branch 'origin/master'
2021-02-12 sgrekhov@unipro.ru#993. NativeType and Struct tests added
2021-02-11 irina.arkhipets@gmail.comFixes#991: tests updated according to the recent SDK changes.
2021-02-08 sgrekhov@unipro.ru#993. sizeOf() tests added
2021-02-05 sgrekhov@unipro.ru#993. More tests for DynamicLibrary added
2021-02-04 sgrekhov@unipro.ru#993. DynamicLibrary constructors tests added
2021-02-03 sgrekhov@unipro.ru#993. co19 ffi tests. Initial commit
2021-02-02 sgrekhov@unipro.ruFixes#992. Boolean conditional evaluation tests added
2021-02-01 irina.arkhipets@gmail.comFixes#990: tests updated according to the recent SDK changes.
2021-01-28 irina.arkhipets@gmail.comFixes#979: I-2-b tests updated according to the recent changes for dart-lang/language#1133
2021-01-28 irina.arkhipets@gmail.comFixes#984: I-2-b tests updated according to the recent changes for dart-lang/language#1133
2021-01-27 sgrekhov@unipro.ruFixes#989. Runtime type equality operator tests added
2021-01-26 irina.arkhipets@gmail.comFixes#988: Static warning checks corrected.
2021-01-25 sgrekhov@unipro.ruFixes#987. Local variables and inference tests added
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-mac-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-mac-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-ia32-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-ia32-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-debug-x64-try,vm-kernel-nnbd-win-release-ia32-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I78ba37f9c74d2afc360ef5fbd51d01ab75239fd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/186146
Reviewed-by: Jonas Termansen <sortie@google.com>
Change-Id: I7eee376c991b9b9683e340dfecccdcb7668f4415
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185494
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
G3 has been migrated (go/dart-ffi-1.0-g3-migration), so now we can roll
the package version which has all the deprecated methods removed.
Rolling `package:ffi` forward also means it is no longer using
`sizeOf<T>()` generically. So the problems in the CFE expect files
disappear.
Change-Id: I33c7c06c6b7b34178908b175f08f3fc0f275be41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185141
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
Will allow for tests to be enabled in google3 as pub or portions of pub
are used to run VM tests.
Previously the test harness was configured to look for a URI with a data: scheme to determine if it was being run via pub run test (pub generates its own harness and spawns the test from that). We were parsing the test URI out of this data URI, which wouldn't work correctly in google3.
This change assumes that if Platform.script.scheme == 'data', the test is being run via pub from the root directory of the package. In that case, we can assume there is a 'test' directory and simply use 'test/$scriptName'as the path for the testee process.
TEST=N/A
Change-Id: I589605ebc7001adc9d8595ca8347c0af329b9c28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184541
Reviewed-by: Gary Roumanis <grouma@google.com>
paired with this so the sdk roll can succeed.
TEST=Fixes static errors
Change-Id: Ia4e325936ea81d0d51fbf6dd939b732860d22100
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183760
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This is needed to update clang dependency as there are errors being revealed in current zlib with updated clang.
Change-Id: I916be87dec5195f159ae002d3207788b3bf9bda7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183042
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
zlib dependency had to be updated to pick up fixes for errors revealed with updated clang.
Change-Id: I30a65faf532782dcb595c26e21c81c521bd0d074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182667
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
TEST=Presubmit tests and local builds
Change-Id: I1b15d60eced0cf3f422548eda75706609f6640cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182624
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Change-Id: Iae78aa9e2dabd00af5356c387b6b00292b8e4241
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182506
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This version changes all `Object` url arguments to `Uri` for better
static help. This is a significant breaking change.
Change-Id: I7152e0983ebcf4a111972b192253c6f778060d6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179260
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Included commits:
```
git log --format="%C(auto) %h %s" 0402c467547daa5886352cb315338ae54552d21c..0e657414a472e74ca5dd76ae0db50cc060251dec
0e657414 Show outdated and discontinued in listing in get (#2844)
f842ae22 Include a deprecation notice in .packages (#2845)
```
Change-Id: Iaf03c5ea0380c16332ce65f2c4b3bf935873d30c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180841
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2021-01-24 irina.arkhipets@gmail.com Issue #983: Static warning checks corrected.
2021-01-22 irina.arkhipets@gmail.com Issue #983: triple-shift folders re-named correctly, typo in the library paths updated for 2 tests.
2021-01-21 sgrekhov@unipro.ruFixes#985. LateInitializationError removed
2021-01-20 sgrekhov@unipro.ruFixes#982. Add tests for The future value type of an asynchronous non-generator function part of NNBD spec
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD type-normalization tests for weak mode added.
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD type-aliases tests for weak mode added.
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tripple-shift tests for weak mode added.
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added for the override checkings.
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added (Leatest-greatest-closures).
2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added (Leatest-greatest-closures).
2021-01-18 sgrekhov@unipro.ruFixes#981. Add tests for Return statements part of NNBD spec
2021-01-18 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode corrected according to the current Spec changes.
2021-01-14 irina.arkhipets@gmail.com Issue #462: Additional comments regarding the constant evaluation issues added to weak mode tests.
2021-01-14 sgrekhov@unipro.ruFixes#980. Remove warnings expectations for overriding default values of optional parameters tests
2021-01-13 irina.arkhipets@gmail.com Issue #462: Tests for weak mode added to nnbd/weak/flow-analysis directory.
2021-01-12 sgrekhov@unipro.ru#978. Weak mode test changes
2021-01-12 irina.arkhipets@gmail.com Issue #462: Tests for weak mode added to nnbd/weak directory.
2021-01-11 sgrekhov@unipro.ruFixes#978. Tests updated according to the "flow analysis boolean variable" feature
2020-12-25 irina.arkhipets@gmail.com Issues #463: Tests for weak mode added.
2020-12-25 irina.arkhipets@gmail.com Issues #462, #463: Moved or added new nnbd tests for weak mode, added new tests for strong mode.
2020-12-24 sgrekhov@unipro.ru#970. Usr correct values for ProcessSignal.sigusr1 and ProcessSignal.sigusr2 on Mac
2020-12-24 irina.arkhipets@gmail.com Issue #462: 1. Added nnbd tests for weak mode: exports_*, expression_typing_*, extension_method_resolution_*, future_flattening_*. 2. Moved and re-factored nnbd extension_method_resolution_*, future_flattening_* tests for weak mode into weak folder. 3. Copyrights updated Issue #463: Two exports* tests for strong mode added.
2020-12-24 sgrekhov@unipro.ruFixes#496. Change tested date to 1 second instead of 1 day to reduce probability to change timezone on DST
2020-12-23 sgrekhov@unipro.ruFixes#473. Remove UtilsHtml directory
2020-12-23 irina.arkhipets@gmail.com Fix for Issue #462: 1. Added nnbd tests for weak mode: assignability_*, const_evaluation_*, const_objects_*, const_type_var_elimination_*. 2. Moved and re-factored nnbd exports_* tests for weak mode into weak folder.
2020-12-10 sgrekhov@unipro.ruFixes#976. Remove obsolete errors expectations
2020-12-10 sgrekhov@unipro.ruFixes#975. Fix wrong expected compile time error type
2020-12-07 sgrekhov@unipro.ru Flag Requirements=nnbd-weak added to the tests that run legacy code
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I69acc5c0a28fd2e7a2d38f6c9062e5a5854bdfa6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180823
Reviewed-by: William Hesse <whesse@google.com>
The analyzer and CFE now report a warning on subclasses of `Struct`
which have no native fields.
Adapted from https://dart-review.googlesource.com/c/sdk/+/180189 to
only deprecate, but not disallow empty structs.
Rolls `package:ffi` forward to migrate `Utf8` and `Utf16` to `Opaque`
to prevent tests from failing on those generating warnings for empty
structs.
Issue: https://github.com/dart-lang/sdk/issues/43974
TEST=tests/ffi/vmspecific_static_checks_test.dart
Change-Id: Ia364e31da66cb195570c2e2b729d03dd261f28a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180361
Reviewed-by: Clement Skau <cskau@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Change-Id: Ib43f27f50a43dea24a9f6bc182cc392fbb846106
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180445
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Change-Id: Icad23bbfc3ca91a3263192a6e98468de76cf76d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180440
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
See also cl/352876453
Change-Id: I8a68d97b8b04b5e38833e637b5dc0b54123acd35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180242
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
There are no formatting changes, so this does not need to be coordinated
with a new pre-built SDK. The only changes are:
- Fix a performance issue in files that contain many constructors with
no initializer lists.
- Fix uses of deprecated analyzer API and List().
- Move from Travis to GitHub actions.
Change-Id: I0ef2e5f841bcd94ec1930e187bc3a4121c190e2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179100
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Flutter needs this to roll to Clang 12
Change-Id: I461be3836c8aab2ab4c9bd6c9233068ec4fefb28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178930
Auto-Submit: Dan Field <dnfield@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Dan Field <dnfield@google.com>
Adds an option `body` and `encoding` argument to `Client.delete()`. This
is breaking for classes which `@override` that method.
Change-Id: I269b2bd9b2ff4df01fb38e9986d7f12ed1f5d245
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178164
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Bumps `package:ffi` to a version using `?`.
Moves `ffi_sample.dart` from `general` to `nnbd` to prevent errors on
the usage of `?` in `package:ffi`.
Change-Id: I8bce1850ce4d144174a2e3705b0ae00523b45c73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178201
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Fixes a bug in the null safety migration which did not allow a null
return from custom watcher factories.
Change-Id: Ia44978bc2b612451257386ab7839f18ffcb8623c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178061
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Changes:
63f1110 Make argument to featureValueOf dynamic (#164)
71eeaee Make the item argument to Match dynamic again (#163)
2071cfd Add types to more parameters (#162)
5d52720 Allow null-safe code to do `same(null)`. (#161)
05db35c Delete .test_config (#160)
e8b4964 remove redundant experiment (#159)
48fe280 Bump SDK constraints for pub (#158)
225cc13 allow the 2.12 prerelease sdks (#157)
b9ce574 Prepare for the 2.11 dev SDKs (#156)
fe4e68a Update .travis.yml
Change-Id: I90c8d9d2f21d6454f1ace977deb9efec0d29d93d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177881
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
included commits:
392a3cb4 Inline all usage of package:package_config (#2821)
fdf7b052 Handle empty version constraint (#2796)
d786b479 Inline package:http_throttle (#2812)
789be3d4 Don't re-precompile if current global installed was same version (#2810)
9851bf64 Simplify reproduction command (#2797)
8eba9cfb Remove unused function (#2808)
a377b5a6 Pass a Uri to package:http APIs (#2794)
12d49078 Fix git not installed test on windows (#2803)
d74520ac Deprecate flutter constraint upper bound (#2780)
Change-Id: Iecff8cc12fe55f12018b4e1f2257886317d2b5cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177603
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Change-Id: I79ac05d92b0b695dd63453d08c5aa9215992d1ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177701
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
Switch to importing by SHA rather than tag and sync before publishing.
Change-Id: Ibf563c4fc28f6b4a08b29feee24d4f7cc234ef27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176920
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jacob Richman <jacobr@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Change-Id: Id05944fbe9f2f202d9349e170b3fc760208c6761
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176244
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Fixes a test for compatibility with google3.
Change-Id: Id85c531b6768b6a59f2f63e991de96dd92ab3232
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175446
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
This brings in the null safe migrated args. It also brings in a new
version of dart2js_info with a tiny change to make it compatible with
the new args.
Change-Id: I280d25c9d5d6bea974206996c5a8c232e728e81d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175020
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
This is a reland of 9906fabaa0
Original change's description:
> Roll the latest args package into the SDK repo.
>
> Change-Id: Ie464e5c01f34a101103d16ff108b6b9eb80fbd4b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174485
> Reviewed-by: Nate Bosch <nbosch@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
> Auto-Submit: Bob Nystrom <rnystrom@google.com>
Change-Id: I5b7b041e02857114c257393cf9d560b6b8b03fd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174701
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
This reverts commit 9906fabaa0.
Reason for revert: Causes regressions in google3 (likely need internal CL to get new args package in third party), see https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/google/3073/overview
Original change's description:
> Roll the latest args package into the SDK repo.
>
> Change-Id: Ie464e5c01f34a101103d16ff108b6b9eb80fbd4b
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174485
> Reviewed-by: Nate Bosch <nbosch@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
> Auto-Submit: Bob Nystrom <rnystrom@google.com>
TBR=rnystrom@google.com,nbosch@google.com
Change-Id: I9d3091d1631a145cd8b37317cc2e381762e5a46a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174646
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Change-Id: I6587b1f543cd838bae02155c34d2f83d474b1846
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173521
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
2020-11-26 sgrekhov@unipro.ru#926. Stdout tests that run process fixed for Windows
2020-11-26 irina.arkhipets@gmail.com Typo in the test corrected.
Cq-Include-Trybots: dart/try:vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I822e64ff5e3ac46ed1c48419d08b0e0cbb413fc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174100
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit ce614d33c4.
Original change's description:
> Revert "update Glob in the sdk, also adds package:file to the sdk"
>
> This reverts commit 18b19db300.
>
> Reason for revert: Breaks Flutter 3H/Golem. Tried making an appropriate patch for 3H that would pull file into its dependencies (see https://dart-review.googlesource.com/c/sdk/+/173960/), but that still failed, so reverting.
>
> Original change's description:
> > update Glob in the sdk, also adds package:file to the sdk
> >
> > Change-Id: Ia8628c28bfaf6343c19eecfef391339968cd57e9
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172063
> > Commit-Queue: Jake Macdonald <jakemac@google.com>
> > Reviewed-by: Nate Bosch <nbosch@google.com>
>
> TBR=jakemac@google.com,nbosch@google.com
>
> Change-Id: I0616e3df7505f348edeefee40cbaf4adc59487cd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173963
> Reviewed-by: Tess Strickland <sstrickl@google.com>
> Commit-Queue: Tess Strickland <sstrickl@google.com>
TBR=jakemac@google.com,nbosch@google.com,sstrickl@google.com
# Not skipping CQ checks because this is a reland.
Change-Id: Ia85fe3b81214ca4ef2bed8e08ecc1b617927a579
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173981
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
2020-11-25 irina.arkhipets@gmail.comFixes#968: missing testing options added back.
2020-11-25 sgrekhov@unipro.ru#969. Line numbers where we expect an error fixed
2020-11-25 sgrekhov@unipro.ru#969. Stdout tests failures on Windows fixed. Don't pass executable arguments to the Process
2020-11-24 irina.arkhipets@gmail.comFixes#968: non-nullable shared option removed.
2020-11-23 sgrekhov@unipro.ru#932. HttpRequest tests fixed to work with cross origin
2020-11-20 sgrekhov@unipro.ru #926.Tryjob failures fixed
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I32eaa75a0fcf4b5b7d8c4855b311a46948afb6f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173964
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit 18b19db300.
Reason for revert: Breaks Flutter 3H/Golem. Tried making an appropriate patch for 3H that would pull file into its dependencies (see https://dart-review.googlesource.com/c/sdk/+/173960/), but that still failed, so reverting.
Original change's description:
> update Glob in the sdk, also adds package:file to the sdk
>
> Change-Id: Ia8628c28bfaf6343c19eecfef391339968cd57e9
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172063
> Commit-Queue: Jake Macdonald <jakemac@google.com>
> Reviewed-by: Nate Bosch <nbosch@google.com>
TBR=jakemac@google.com,nbosch@google.com
Change-Id: I0616e3df7505f348edeefee40cbaf4adc59487cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173963
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Change-Id: Idc84c762539e92705f733a50ccc351a4e65211be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173540
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
Change-Id: I0ef9fc42170f7481f513bb1135cbe38836dbb48e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173520
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
There are no formatting changes in this release, so it doesn't need to
be coordinated with a roll of the pre-built SDK.
Change-Id: I2dc263f2f7b824a4161000dbdfe40c0913b39987
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173141
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2020-11-19 sgrekhov@unipro.ru #926.Add Platform.executableArguments to Process.run() command to not to fail on --enable-assert configuration
2020-11-19 sgrekhov@unipro.ru #926.Add Platform.executableArguments to Process.run() command to not to fail on --enable-assert configuration
2020-11-18 sgrekhov@unipro.ruFixes#966. Move certificates to RawSecureServerSocket directory
2020-11-18 sgrekhov@unipro.ru#926. Fixed test that fail on precompiled environment in a strong mode
2020-11-17 sgrekhov@unipro.ruFixes#951. Remove excessive @static-warning
2020-11-17 irina.arkhipets@gmail.comFixes#946: LanguageFeatures/Instantiate-to-bound/nonfunction_typedef tests updated according to the SDK changes, missing tests added.
2020-11-17 sgrekhov@unipro.ru#932. Some HttpRequest tests fixed to work well with cross origin requests
2020-11-16 sgrekhov@unipro.ru Process kill test fixed to work on different platforms
2020-11-16 sgrekhov@unipro.ru External variable test that expects compile time error on dart2js added
2020-11-13 sgrekhov@unipro.ruFixes#926. Remove "--enable-experiment=non-nullable" option from script that runs another process
2020-11-12 sgrekhov@unipro.ru#926. File lock checking tests rewritten to not to fail on precompiled environment. Second part
2020-11-12 irina.arkhipets@gmail.comFixes#602: Missing issue tags added.
2020-11-11 sgrekhov@unipro.ru#926. File lock checking tests rewritten to not to fail on precompiled environment
2020-11-11 sgrekhov@unipro.ru Issue numbers added
2020-11-11 irina.arkhipets@gmail.comFixes#963: test expected result corrected, test template for all generic typedefs updated.
2020-11-10 sgrekhov@unipro.ru#926. ProcessSignal tests rewritten to not to fail on precompiled environment
2020-11-10 sgrekhov@unipro.ru#926. Process tests rewritten to not to fail on precompiled environment
2020-11-10 sgrekhov@unipro.ru#961. Process tests rewritten to not to use process_test tool
2020-11-10 irina.arkhipets@gmail.comFixes#602: Missing Issue tag added.
2020-11-10 sgrekhov@unipro.ruFixes#960. Null safety execution modes renamed and mentions of obsolete checked mode removed
2020-11-10 sgrekhov@unipro.ru Remove wrong error expectations
2020-11-09 sgrekhov@unipro.ruFixes#962. Change CFE error messages expectations
2020-11-08 irina.arkhipets@gmail.comFixes#602: New tests for least and greatest closures added.
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I7aff067ec96f762490de15daa20c40dff2b0ae96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172940
Reviewed-by: William Hesse <whesse@google.com>
Protobuf and bazel_worker are migrated to null safety, dart2js_info
just broadens dependency version range to be compatible with null safe
protobuf.
Also regenerate test protos in vm test cases and update expected ASTs
and add support for conditional expressions to protobuf aware tree shaker.
Change-Id: I019f0fd6c5688302cc5127e1be8368a3ea600439
TEST= Covered by existing tests
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172646
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
Expand the range allowed by the dep from `package:analyzer`.
Switch dependencies to `any` for the packages which are `publish_to:
none`. The actual constraints aren't useful in these packages since they
are always pinned exactly by DEPS and so we can't trust they are kept up
to date.
Change-Id: Ibd937e8646574d49105f4dd0de2529e7ab30862a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172380
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
New in this revision:
> git log --format="%C(auto) %h %s" b10966c6a8ad7d95c2023b7842fa2697001d2fdf..c00d4b4abf5b4ff265a7ce6282b748551f1b5b1f
c00d4b4a Improve message in `pub outdated` when incompatible versions are found (#2746)
2a177623 outdated --mode=null-safety, resolvable constrained to null-safe vers… (#2739)
3ea2b832 Default language version (#2748)
78865460 Don't allow both --json and --transitive (#2742)
Fixes https://github.com/dart-lang/sdk/issues/44013
Change-Id: I0dc876c5e57777a4724d90662408f91910e2517c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171720
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Change-Id: Ief025612b5f3e14079716460eae030d09f6f5e7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170862
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Change-Id: I6db1a2a5dd4501b16fa947a8fa1c337592947ade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170842
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Change-Id: Ie55532aa1471d2c9df1f32ab9444e977f984f7e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170861
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Change-Id: Ie5ba98ac96c05c4890c4b80fbdfe673f2ad64d96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170860
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
There are no functional differences between the previous and the new
commit. Though it brings in a fix for a test which is required for
further dart->g3 rolls.
Issue b/172649154
Change-Id: I923246aa9db1973e213257a086f0065ad862ca4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170881
Reviewed-by: Clement Skau <cskau@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2020-11-05 irina.arkhipets@gmail.comFixes#602: New tests for least and greatest closures added.
2020-11-05 sgrekhov@unipro.ru#926. Rewrite io/Process/start_A01_t02 test to work on precompiled environment
2020-11-05 sgrekhov@unipro.ru#932. Rewrite HttpRequestUpload/onLoad_A01_t01 test to send correct HttpRequest
2020-11-04 sgrekhov@unipro.ruFixes#956. Don't expect extension invocation on type dynamic
2020-11-04 karlklose@users.noreply.github.com Convert some multi-tests to static error framework (#958)
2020-11-03 irina.arkhipets@gmail.comFixes#602: dynamic tests for least and greatest closures updated.
2020-11-03 irina.arkhipets@gmail.comFixes#602: tests for least and greatest closures added.
2020-10-28 sgrekhov@unipro.ru#926. Fix two Process tests to use 'process_test' tool
2020-10-28 sgrekhov@unipro.ru#926. Rewrite two Process tests to use 'process_test' tool
2020-10-28 sgrekhov@unipro.ruFixes#955. Expect less specific error for typed_data tests
2020-10-26 sgrekhov@unipro.ruFixes#954. Change the line where we expect an error for CFE
2020-10-20 sgrekhov@unipro.ruFixes#912. Abstract variables syntax tests added
2020-10-19 sgrekhov@unipro.ru#912. More external variables syntax tests added
2020-10-17 sgrekhov@unipro.ru External variables syntax test added
2020-10-16 sgrekhov@unipro.ru#912. More test for static analysis of external variables added
2020-10-15 sgrekhov@unipro.ru#912. Test for static analysis of external variables added
2020-10-14 sgrekhov@unipro.ru#912. Test for static analysis if abstract variables added
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: Id9cde784918faa4e891da8c4cb448d415a7a18aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170680
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This includes the following pub commits:
git log --format="%C(auto) %h %s" 5b4df5a6f931c63622ac349602d6ef0367e8070f..fb72c1f774ca27556225b207185c0b6b6ab1c274
fb72c1f7 Make `run` available (but deprecated) in the embedding (#2698)
63b56ea4 Return the exit-code from commands (#2689)
7fc4e273 Deprecate top level (#2694)
Change-Id: I5842b1ecb15fc7844d628e2ad5fb00e3f627dbff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168347
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
This is the first checked-in SDK with null-safety enabled by default.
Change-Id: I8f6fcdfd8856483f4737eb200ed4623a244cb0cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170085
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This does not affect the formatting of any existing code, so is safe to
roll without updating the pre-built SDK.
Change-Id: I2e7fc20d6933d136dc0390f93f6bc72dc340e9ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170141
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
There are no formatting changes in this release. The only change is the
fix for https://github.com/dart-lang/dart_style/issues/964.
Includes corresponding adaptations of dartdev/dart CLI.
Change-Id: I1c97f0b7009b98ae609b258401522453faa35c64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170083
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Flutter uses CIPD packages that are more reliable.
Change-Id: Ic47b2fd9805709a3175376270df0fe52b82f16ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169341
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Bright in dependency pkg:clock
Also removed pkg:quiver entry in package_config – no longer needed
Change-Id: I98f45c2ad107c7613d300783e77c018edefbaa37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168587
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Change-Id: I857e811dea45a718566d13228a659208821b8556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168982
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Change-Id: I41508e224ee2712580752ebb74b98a2fcf295b6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168840
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
