Commit graph

495 commits

Author SHA1 Message Date
nweiz@google.com cc340dc736 Increase the scheduled_test timeout for Git tests on Windows.
Review URL: https://codereview.chromium.org//12668014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20289 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 21:09:17 +00:00
nweiz@google.com 84dd8a51e0 "new Map()" -> "new Map.from()" in pub.
BUG=8511

Review URL: https://codereview.chromium.org//12580008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20265 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 01:03:23 +00:00
nweiz@google.com db9ff1e404 Use scheduled_test for Pub tests.
This was originally committed as r20250. Due to issue 9294, this failed on
Windows. This commit works around that issue.

BUG=8511

Review URL: https://codereview.chromium.org//12437022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20264 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-20 00:50:58 +00:00
nweiz@google.com 32db9c0cf6 Revert "Use scheduled_test for Pub tests."
This reverts r20250, which was failing on Windows.

BUG=8511

Review URL: https://codereview.chromium.org//12782005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20253 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 22:22:55 +00:00
nweiz@google.com 82cbc2db3a Use scheduled_test for Pub tests.
BUG=8511

Review URL: https://codereview.chromium.org//12794007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20250 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 21:58:53 +00:00
nweiz@google.com 83d896d80b Fix a couple broken tests in pub/validator_test.
These tests were marked as test() rather than integration() and so their
schedules weren't getting run at all.

Review URL: https://codereview.chromium.org//12659008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20238 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-19 20:37:03 +00:00
rnystrom@google.com 78a4088f03 Actually make status file do something.
Review URL: https://codereview.chromium.org//12712013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20123 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:17:27 +00:00
rnystrom@google.com 5def0d4962 Disable failing test on Windows until I can fix it.
BUG=https://code.google.com/p/dart/issues/detail?id=9192

Review URL: https://codereview.chromium.org//12422010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20118 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 22:51:16 +00:00
rnystrom@google.com 2f2b30eb0e Handle broken symlinks when creating package dirs.
BUG=https://code.google.com/p/dart/issues/detail?id=8343

Review URL: https://codereview.chromium.org//12772005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20116 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 22:07:18 +00:00
rnystrom@google.com 4a465ef855 Remove support for SDK dependencies.
BUG=https://code.google.com/p/dart/issues/detail?id=6354

Review URL: https://codereview.chromium.org//12790006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20098 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 18:33:05 +00:00
lrn@google.com 844cd39fad Change getRange to sublist. Make getRange deprecated.
This changes the exception behavior of getRange. It used to accept
a length of zero, no matter what start value. Now the start value
must be a valid list index.

Review URL: https://codereview.chromium.org//12817003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20064 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 09:15:39 +00:00
nweiz@google.com a9a8d42063 Add a SafeHttpServer shim to work around issue 9140.
Review URL: https://codereview.chromium.org//12633015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20054 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-14 22:12:19 +00:00
keertip@google.com a455e0d9cd add cache list command to pub
Review URL: https://codereview.chromium.org//12755024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19977 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 22:29:00 +00:00
rnystrom@google.com 0122b2954e Dev dependencies.
BUG=dartbug.com/5358

Review URL: https://codereview.chromium.org//12433014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19966 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 19:40:25 +00:00
floitsch@google.com 482b2f34e8 Move Options to dart:io.
Review URL: https://codereview.chromium.org//12794002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19927 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-13 13:12:00 +00:00
nweiz@google.com 845e550cbb Properly handle errors from the OAuth2 token endpoint in pub.
This also adds more detailed HTTP logging to pub.

BUG=8849

Review URL: https://codereview.chromium.org//12428012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19734 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:57:27 +00:00
nweiz@google.com c71bb58877 Update pub to use the latest dart:io stream APIs.
Review URL: https://codereview.chromium.org//12613010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19729 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 21:46:08 +00:00
floitsch@google.com dd48256fe5 Remove deprecated StringBuffer.add, addAll and addCharCode.
Review URL: https://codereview.chromium.org//12473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19690 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:07:18 +00:00
lrn@google.com bead146749 Renamed StreamSink to EventSink. Renamed signalError to addError.
Review URL: https://codereview.chromium.org//12610006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19683 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:31:19 +00:00
sgjesse@google.com b6096848b1 Make IOSink implement StringSink
Besides adding the StringSink methods I also added writeBytes and
deprecated both add and addString.

To handle the encoding of strings the IOSike has an encoding
property. This property is mutable in situation when it makes sense to
change encoding of what is written. The exception here is for HTTP
where the encoding is determined from the header and the encoding
cannot be changed.

R=ajohnsen@google.com, ager@google.com, nweiz@google.com

BUG=

Review URL: https://codereview.chromium.org//12504006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19676 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 10:06:28 +00:00
rnystrom@google.com b3e5168249 Add a failing test for handling broken symlinks.
BUG=8343

Review URL: https://codereview.chromium.org//12500005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19580 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-06 20:55:53 +00:00
rnystrom@google.com 50d1fc7a99 Delete files synchronously.
BUG=8868

Review URL: https://codereview.chromium.org//12481003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19517 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-05 21:32:35 +00:00
gram@google.com 9b40e6b13e Fix issue with async callbacks that get called synchronously while running test case function causing the test to be marked as complete prematurely.
Added an optional id to completion matchers that can be used in error messages (this was invaluable in tracking down the above problem).

Re-enable pub tests. https://code.google.com/p/dart/issues/detail?id=8862
Review URL: https://codereview.chromium.org//12393017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19339 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 21:49:15 +00:00
ricow@google.com 85b572e7d7 Mark flaky pub tests
Review URL: https://codereview.chromium.org//12377042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19284 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 09:08:20 +00:00
gram@google.com 621650b0e8 Disable breaking tests while I investigate the issue. I don't really want to revert;
I want to understand this as it may indicate some other problem.
Review URL: https://codereview.chromium.org//12387033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19271 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-01 01:38:57 +00:00
nweiz@google.com a903dfd3a4 Remove the wrapStream workaround for issue 8310.
Review URL: https://codereview.chromium.org//12374033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19266 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:24:21 +00:00
nweiz@google.com 2a0c74a18d Make pub warning-clean.
Review URL: https://codereview.chromium.org//12382031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19265 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-28 23:21:58 +00:00
gram@google.com 017d21bdc0 Unit test changes:
- add back KevMoo's assertions now that the bugs they exposed ar efixed
- remove onTestResult methods from a couple of configs; these did nothing other
  than prevent the base class implementation from being called which is wrong.
- fix the TestFunction signature
- change from ExpectException, which is deprecated, to TestFailure.
Review URL: https://codereview.chromium.org//12335113

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19166 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 19:57:40 +00:00
amouravski@google.com edee0d7e8e Updated an error message to inform users that their packages were not installed
when their SDK version does not match.

Review URL: https://codereview.chromium.org//12315059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19026 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-26 03:12:02 +00:00
rnystrom@google.com 1d62e0a077 Disable test on Windows for now.
Review URL: https://codereview.chromium.org//12313114

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19016 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:20:47 +00:00
rnystrom@google.com b88ebea7c3 Handle shared path dependencies.
BUG=https://code.google.com/p/dart/issues/detail?id=8775

Review URL: https://codereview.chromium.org//12335076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19012 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 23:00:16 +00:00
lrn@google.com 3c0ac360e7 Remove deprecated string features.
Make String.codeUnits return a List.

Review URL: https://codereview.chromium.org//12282038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
nweiz@google.com c8f6014ae7 Move pkg/path to pkg/pathos.
Review URL: https://codereview.chromium.org//12316056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18906 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-22 18:45:55 +00:00
rnystrom@google.com df8647c43f Allow whitespace in version constraints.
BUG=http://code.google.com/p/dart/issues/detail?id=7140

Review URL: https://codereview.chromium.org//12310029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18851 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 19:47:44 +00:00
rnystrom@google.com e3e5d46f32 Make sure package names are URL encoded.
If you happen to have a weird package name like "/* blah *?" you
would get a nasty HTTP error when it tried to jam that in a URL.
Instead, this will give you a friendlier 'package "/* blah */" not found error."
BUG=http://code.google.com/p/dart/issues/detail?id=7466

Review URL: https://codereview.chromium.org//12328021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18849 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 18:59:48 +00:00
sgjesse@google.com 488b016a2f Merge IO v2 branch to bleeding edge
R=ager@google.com, ajohnsen@google.com, whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12316036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-21 11:58:11 +00:00
rnystrom@google.com 8b37852e8a Use relative symlinks for self links and secondary "packages" dirs.
This lets you move a package directory without breaking all of those links.
BUG=http://code.google.com/p/dart/issues/detail?id=8342

Review URL: https://codereview.chromium.org//12321020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18785 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:17:16 +00:00
rnystrom@google.com e28a669679 Make some name validation errors warnings.
BUG=http://code.google.com/p/dart/issues/detail?id=8632

Review URL: https://codereview.chromium.org//12313014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18783 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-20 21:11:47 +00:00
nweiz@google.com d64b7d392a Use the correct set of reserved identifiers in pub validations.
We had been using the set listed in the spec as "BUILT_IN_IDENTIFIER", but
apparently those are the built-in identifiers that are valid for user use. Now
we're using the set listed in the spec as "reserved words".

BUG=8628

Review URL: https://codereview.chromium.org//12301032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18716 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:55:40 +00:00
rnystrom@google.com a1702c3578 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010


Review URL: https://codereview.chromium.org//12294039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18715 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-19 19:49:46 +00:00
rnystrom@google.com 5ed85458d1 Revert "Support relative paths in path dependencies."
This reverts commit 0b0da0d44dde213647e7281bf0914c59fc552b27.

BUG=

Review URL: https://codereview.chromium.org//12280019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18606 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 02:00:45 +00:00
rnystrom@google.com 8514e448b7 Support relative paths in path dependencies.
BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18605 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-16 01:45:39 +00:00
rnystrom@google.com b12e27a4d2 Get rid of join() and encapsulate File and Directory in io.dart.
Review URL: https://codereview.chromium.org//12253054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18551 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:13:07 +00:00
rnystrom@google.com 10f7ad94ae Clean up some warnings and deprecated calls.
Review URL: https://codereview.chromium.org//12262056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18550 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 01:10:07 +00:00
rnystrom@google.com ba326cd770 Get rid of old redundant methods in io.dart.
Now that we have pkg/path, we can ditch the old methods in io.dart
that do the same thing.

Review URL: https://codereview.chromium.org//12255016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18500 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 01:14:31 +00:00
rnystrom@google.com 96697d6ecc Fix path tests on windows.
Review URL: https://codereview.chromium.org//12263018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18488 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 22:18:55 +00:00
rnystrom@google.com 76ec804170 Auto-reinstall broken packages in the system cache.
BUG=http://code.google.com/p/dart/issues/detail?id=5939

Review URL: https://codereview.chromium.org//12225149

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18480 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 21:11:12 +00:00
rnystrom@google.com bd0d874a53 Take Sam Elkhateeb's path for "path" dependencies and clean it up some.
BUG=http://code.google.com/p/dart/issues/detail?id=3732

Review URL: https://codereview.chromium.org//12208138

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18465 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 18:47:19 +00:00
whesse@google.com acd03abf83 dart:io: Use PathBuffer class for Directory.list on Windows platform.
BUG=https://code.google.com/p/dart/issues/detail?id=7505

Review URL: https://codereview.chromium.org//12252006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18448 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 15:00:55 +00:00
rnystrom@google.com 7c2e379f89 Add --force to pub lish.
BUG=http://code.google.com/p/dart/issues/detail?id=8487

Review URL: https://codereview.chromium.org//12217156

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18423 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 01:06:29 +00:00
rnystrom@google.com 1b15bef29f Mark oauth2 and pub_uploader as flaky. :(
Review URL: https://codereview.chromium.org//12251008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18416 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 23:46:56 +00:00
keertip@google.com ea861b9bdd add --preview flag to publish command
Review URL: https://codereview.chromium.org//12226077

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18397 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-12 19:52:01 +00:00
floitsch@google.com 3f7146707d Rework Timer interface.
Review URL: https://codereview.chromium.org//12213092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18326 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-11 19:22:16 +00:00
amouravski@google.com c6e2418c89 Added support for 'description' in pubspec.yaml.
Also standardized the way of validating a url.

Also, one test was working, but was not actually testing what it was supposed to be testing.

Review URL: https://codereview.chromium.org//12211097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18290 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-09 00:16:15 +00:00
pquitslund@google.com 90fd9e9c78 Call init test config for generating human-friendly test results.
Review URL: https://codereview.chromium.org//12218062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18234 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 22:11:34 +00:00
rnystrom@google.com 9f21b5324b Make createTempDir() synchronous.
Review URL: https://codereview.chromium.org//12225085

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18231 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 20:46:45 +00:00
rnystrom@google.com ec020bbd99 Handle circular dependencies on the root package when checking SDK constraints.
BUG=dartbug.com/8364

Review URL: https://codereview.chromium.org//12211061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18198 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 00:40:09 +00:00
rnystrom@google.com 12dd25f65b Drain HTTP request input streams before responding.
Review URL: https://codereview.chromium.org//12211052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18185 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 20:50:53 +00:00
rnystrom@google.com fcab5f5adb Fix hosted tests on Windows.
BUG=http://dartbug.com/8264

Review URL: https://codereview.chromium.org//12208006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18113 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 04:32:40 +00:00
rnystrom@google.com cf697141d9 Get most pub IO tests passing on Windows.
The remaining issue now is a hang in dart:io.

BUG=

Review URL: https://codereview.chromium.org//12211004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 04:18:34 +00:00
nweiz@google.com 193eac0d3c Un-mark {pub_{uploader,lish},oauth2}_test as flaky.
We need to see when these go red so they stop bit rotting.

Review URL: https://codereview.chromium.org//12195006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18105 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 01:09:57 +00:00
nweiz@google.com dbb72ee35d Get the pub oauth2 test passing locally.
Review URL: https://codereview.chromium.org//12191008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18103 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 00:57:25 +00:00
rnystrom@google.com 57c9b64975 Wait until file list is available before printing it.
Review URL: https://codereview.chromium.org//12193014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18081 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 22:18:08 +00:00
nweiz@google.com dfb2a2f23d Mark pub hosted tests as flaky on Windows.
BUG=8264

Review URL: https://codereview.chromium.org//12184019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18077 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 20:52:31 +00:00
rnystrom@google.com b6d5dc7f5a Make a bunch of stuff in pub synchronous.
Review URL: https://codereview.chromium.org//12079112

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18019 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-02 00:30:16 +00:00
nweiz@google.com 31c93eeceb Fix a few breakages with Pub's oauth2 test.
Review URL: https://codereview.chromium.org//12150006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18017 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-02 00:11:56 +00:00
rnystrom@google.com 4a9cc0f619 Validate packages against their SDK constraints.
After running pub install or update, it will look at all of the
selected packages and see if their SDK constraints match the
current SDK. If not, it will show a (hopefully) helpful error
message.
BUG=dartbug.com/6285

Review URL: https://codereview.chromium.org//12092080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18014 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 23:45:26 +00:00
nweiz@google.com 342e7a4c1a Don't mark the few passing hosted pub tests as failing.
Review URL: https://codereview.chromium.org//12082127

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18008 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 22:43:23 +00:00
nweiz@google.com 6565bb80ef Stop using cURL in Pub.
BUG=7395

Review URL: https://codereview.chromium.org//12090104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18007 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 22:35:33 +00:00
nweiz@google.com 6c3535dceb Fix the Pub status file.
Review URL: https://codereview.chromium.org//12149006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18006 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 21:55:44 +00:00
nweiz@google.com aac9fcda5a Mark pub hosted tests as failing.
Review URL: https://codereview.chromium.org//12082124

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17997 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 19:55:11 +00:00
nweiz@google.com 18d274df07 Use the dart:async Stream API thoroughly in Pub.
This was originally submitted as r17822, and rolled back in r17867. There are no
changes, but in preparation for the dart:io Stream changes we're applying this
with the intent to mark Windows tests as failing.

BUG=7807

Review URL: https://codereview.chromium.org//12086110

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17996 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 19:42:09 +00:00
nweiz@google.com 474994a5b7 Add a validator that tests the size of pub packages.
BUG=7045

Review URL: https://codereview.chromium.org//12094093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17961 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 02:09:37 +00:00
nweiz@google.com f181fdc8a8 Add a Pub validator for READMEs that are invalid utf-8.
BUG=7045

Review URL: https://codereview.chromium.org//12090081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17948 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 22:39:53 +00:00
nweiz@google.com dd763be6af Add a pub validator for compiled dartdoc output.
BUG=7045

Review URL: https://codereview.chromium.org//12089076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17943 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 21:02:46 +00:00
lrn@google.com 9b23dff467 Reapply "Rename mappedBy to map."
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 15:12:56 +00:00
floitsch@google.com b1a118d5ce Revert "Rename mappedBy to map."
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 14:02:27 +00:00
lrn@google.com 0dc2f4b1ba Rename mappedBy to map.
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 12:37:13 +00:00
ricow@google.com b410b64719 Mark pub/oauth2_test as timeout as well as pass,fail
Review URL: https://codereview.chromium.org//12086078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17885 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 07:26:23 +00:00
rnystrom@google.com b0779d1453 Remove invalid sanity check.
In the presence of setUp() it is possible for stuff to be scheduled
by the time integration() is called.

Review URL: https://codereview.chromium.org//12090075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17870 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 19:47:16 +00:00
nweiz@google.com 8be520740e Roll back Pub stream changes.
These changes are still breaking the Windows bots, so I'm rolling them back
until we figure out what's going on.

TBR

Review URL: https://codereview.chromium.org//12095050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17867 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 19:26:03 +00:00
rnystrom@google.com f73ee270b7 Fix issue where failing pub tests confused unittest.
Review URL: https://codereview.chromium.org//12086052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17861 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 17:45:50 +00:00
nweiz@google.com d56994eb18 Use the dart:async Stream API thoroughly in Pub.
Review URL: https://codereview.chromium.org//12021008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17821 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 01:06:39 +00:00
sigmund@google.com aeca565ae9 Fix build for throwsStateError: remove duplicate definitions in other tests.
Review URL: https://codereview.chromium.org//12088056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17812 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 21:47:05 +00:00
rnystrom@google.com 63eac3fe8b Handle parsing the "version" file better.
Review URL: https://codereview.chromium.org//12087008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17740 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 00:56:07 +00:00
jmesserly@google.com 61c97e7325 Restructure YAML package suitable for pub lish
After this I can use tools/publish_pkg.py upload script to fix dartbug.com/4126

Review URL: https://codereview.chromium.org//11622011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17685 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-26 02:25:43 +00:00
rnystrom@google.com 079402c3ae Get rid of RootSource.
This was a sort of hackish source only used internally during
version solving. But it causes a couple of subtle bugs because it
never gets registered with the SourceRegistry. That in turn makes
toString() fail on any PackageId with that source since it relies
on the Source being registered.

The simplest fix is to just remove the hacked source and have a
null source in PackageId/Ref mean "root" and handle it specially.

Review URL: https://codereview.chromium.org//12047096

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17646 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 18:22:29 +00:00
lrn@google.com 1f05296600 Change singleSubscription/multiSubscription to normal/broadcast.
Also make StreamController not a Stream.

Review URL: https://codereview.chromium.org//12049013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17563 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 13:30:27 +00:00
floitsch@google.com ed938af868 Rename new Uri.fromString to Uri.parse.
Review URL: https://codereview.chromium.org//12052038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17562 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 13:26:18 +00:00
floitsch@google.com fb7b9e3c5c Rename Date to DateTime.
BUG=http://dartbug.com/1424

Review URL: https://codereview.chromium.org//11770004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17549 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 12:16:37 +00:00
rnystrom@google.com 344249b02f Get rid of unneeded Future.immediate() calls.
Future.then() will now implicitly wrap the callback result in a
future if it isn't one, so this manual wrapping can be removed.

Also take advantage of the fact that Future.immediate() is always
async now and remove some workarounds.

Finally, noticed there were two copies of the git-related code
floating around so killed the old one.

Review URL: https://codereview.chromium.org//12042053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17519 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 01:13:36 +00:00
rnystrom@google.com 7ec5b82507 Make pub use the SDK's "version" file for its version.
This includes pub's own version and the implied version of SDK
packages. I also added a little test that verifies that pub can
parse the actual version file generated with the SDK.
BUG=5906,6173,7837

Review URL: https://codereview.chromium.org//12036065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17512 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 23:20:09 +00:00
rnystrom@google.com edf7ca2927 Add support for specifying SDK version constraints in pubspecs.
These constraints don't currently do anything, but these patch
gets them being parsed by pub.

Review URL: https://codereview.chromium.org//12038038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17477 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 17:41:40 +00:00
rnystrom@google.com f053f356ee Clean up code that locates SDK and SDK version.
This is prep work for SDK constraints. It moves the SDK
version-related code out of SdkSource (which will go away at some
point) into its own library.

I also removed the need for the DART_SDK env variable. It will
still be used if set (which the tests need), but if not set, Pub
will locate the SDK.
Clean up a few static warnings.

Review URL: https://codereview.chromium.org//11871028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17433 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 23:52:37 +00:00
hausner@google.com a885f8638b Fix map literals from change 17410
Remove any type arguments from map literals
that had one type argument before change 17410.
Review URL: https://codereview.chromium.org//12045024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17412 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 17:31:29 +00:00
hausner@google.com dc3bf6646a Stop supporting map literals with 1 type argument
To be checked in next week Tue (Jan 22)

Review URL: https://codereview.chromium.org//12021022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17410 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 16:48:00 +00:00
floitsch@google.com 1febeb689a Move some core classes to collection library.
Review URL: https://codereview.chromium.org//11867024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17352 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 13:34:02 +00:00
rnystrom@google.com d160b37a92 Clean up a few static warnings.
Review URL: https://codereview.chromium.org//11867029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17331 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 23:54:38 +00:00
rnystrom@google.com 4573dcd11d Create a unit test config for the pub tests that's prettier.
In particular, it:

- Shows test results incrementally.
- Cleans up the stack traces.
- Doesn't show the failures and their stack traces twice.

Right now, it's opt in. You need to:
- Add initConfig() to the top of a test suite.
- Pass "--human" when you run the test.

At some point, I can add the initConfig() calls to every test suite but I figured we could just add them manually for now.

Review URL: https://codereview.chromium.org//11867012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17313 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 21:11:43 +00:00
rnystrom@google.com 97af32b4d3 Make integration tests a bit cleaner.
Review URL: https://codereview.chromium.org//11943005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17300 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 18:06:22 +00:00