Florian Loitsch
f9cf78a1af
Fix docs for Stream.handleError
.
...
Fixes #27699
BUG= http://dartbug.com/27699
R=lrn@google.com
Review URL: https://codereview.chromium.org/2467453002 .
2016-10-31 16:03:05 +01:00
Jan-Hendrik Dolling
89560c68a0
change "the the" to the
2016-10-28 21:47:50 +02:00
Zachary Anderson
8169499ef8
GN: Format more gn files
...
Missed these on the first pass.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2454703004 .
2016-10-27 04:25:34 -07:00
Vyacheslav Egorov
eb8c24e133
Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork."
...
R=zra@google.com
BUG=
Review URL: https://codereview.chromium.org/2451623006 .
2016-10-27 10:09:22 +02:00
Vyacheslav Egorov
12968edb9c
Revert "Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork.""
...
This reverts commit 4e7a31262e
.
Windows bots are broken now.
R=zra@google.com
BUG=
Review URL: https://codereview.chromium.org/2451893004 .
2016-10-26 17:07:18 +02:00
Vyacheslav Egorov
4e7a31262e
Reland "Merge more Kernel infrastructure from kernel_sdk SDK fork."
...
This relands commit 2fed1c3905
with fixes to ensure that analyzer summaries are correctly created and XARM build does not try to use target binaries on the host.
R=zra@google.com
BUG=
Review URL: https://codereview.chromium.org/2453773002 .
2016-10-26 16:48:28 +02:00
Vyacheslav Egorov
cf7ff42e60
Revert "Merge more Kernel infrastructure from kernel_sdk SDK fork."
...
This reverts commit 2fed1c3905
.
SDK builds are failing
TBR=zra@google.com
Review URL: https://codereview.chromium.org/2455593002 .
2016-10-26 13:06:27 +02:00
Vyacheslav Egorov
2fed1c3905
Merge more Kernel infrastructure from kernel_sdk SDK fork.
...
- bring patched SDK generation scripts and VM patch tweaks that allow VM patch files to be parsed by analyzer front-end;
Patched SDK is an SDK with all VM patches spliced into it. Kernel compiler is based on the analyzer front-end which does
not have any patch files support/model so for it to produce Kernel files that match VM we need to generate a such patched SDKs.
- bring test script modifications that allow to test Kernel pipeline
BUG=
R=asiva@google.com , kmillikin@google.com , whesse@google.com , zra@google.com
Review URL: https://codereview.chromium.org/2434123003 .
2016-10-26 13:02:54 +02:00
Florian Loitsch
6beb1fdd11
Change Set.difference API to accept Set<Object>.
...
Fixes #27573
BUG= http://dartbug.com/27573
R=lrn@google.com
Review URL: https://codereview.chromium.org/2413233002 .
2016-10-20 14:37:15 +02:00
Stephen Adams
50e557d176
Prevent inlining of js_library core.RegExp constructor
...
Inlining was achieving no beneficial effect.
- Enabled GVN of match start.
- Made string quote style uniform.
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2437863002 .
2016-10-19 16:25:11 -07:00
Stephen Adams
1e793c96b2
Properties of flattenString
...
TBR=sigmund@google.com
Review URL: https://codereview.chromium.org/2432993004 .
2016-10-19 13:53:46 -07:00
Stephen Adams
c9c3c203c1
Minor tweaks to dart:html for better dart2js codegen
...
- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.
BUG=
R=alanknight@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org/2422293002 .
2016-10-17 13:35:17 -07:00
Florian Loitsch
8fbd651c49
Emphasize that durations are context independent.
...
Fixes #27597
BUG= http://dartbug.com/27597
R=lrn@google.com
Review URL: https://codereview.chromium.org/2423993002 .
2016-10-17 14:51:00 +02:00
Stephen Adams
790b9d9cb1
Enable GVN on HForeignNew
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2422003002 .
2016-10-14 17:34:07 -07:00
Florian Loitsch
136e476c87
Check for the type of the the spawned function.
...
In general we avoid explicit type-checks, but in this case the error would be only detected in the new isolate making error handling much harder.
Fixes #27185
BUG= http://dartbug.com/27185 .
R=lrn@google.com
Review URL: https://codereview.chromium.org/2414173003 .
2016-10-14 13:27:11 +02:00
John McCutchan
eaea9d58fe
Revert "Give useful message for null derefs"
...
This reverts commit 588fed0368
.
BUG=
Review URL: https://codereview.chromium.org/2403203002 .
2016-10-10 13:11:44 -07:00
John McCutchan
588fed0368
Give useful message for null derefs
...
The exception implements NoSuchMethodError so that code that depends on
the previous exception type still works.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2407603002 .
2016-10-10 12:53:47 -07:00
Kevin Moore
9d9858fa7e
Update recommendations for HTTP server packages
...
R=dgrove@google.com
Review URL: https://codereview.chromium.org/2389833002 .
2016-10-05 21:16:35 -07:00
Stephen Adams
74deaad759
Revert "Add native_testing library to mock @Native classes"
...
Investigating failures.
BUG=
Review URL: https://codereview.chromium.org/2383273002 .
2016-09-30 13:27:09 -07:00
Stephen Adams
ddfc70f164
Add native_testing library to mock @Native classes
...
Convert 114 tests to use native_testing.dart library.
Review URL: https://codereview.chromium.org/2379173002 .
2016-09-30 12:13:52 -07:00
Lasse R.H. Nielsen
9bd4406d4b
Fix bug in _SimpleUri.resolve.
...
In some cases it didn't follow our non-RFC behavior for resolving a relative
path on top of another relative path.
Fixes issue #27447
BUG= http://dartbug.com/27447
R=eernst@google.com
Review URL: https://codereview.chromium.org/2374253004 .
2016-09-29 15:00:42 +02:00
Lasse R.H. Nielsen
9487e107bb
Address shortcomings in documentation on Isolate class.
...
Addresses issued #26597 and #26627 .
BUG= http://dartbug.com/26597 http://dartbug.com/26627
R=eernst@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org/2062683002 .
2016-09-28 10:42:06 +02:00
Lasse R.H. Nielsen
caf208a543
Make StreamIterator not delay pausing between requests.
...
The current implementation of StreamIterator has a one-element buffer which
allows it listen for the next even eagerly, and only pause if consumption
doesn't keep up with production.
However, StreamIterator is also used by both VM and dart2js implementations
of "await for", and according to the specification, the iterated stream
must be paused between loop iterations.
The CL removes the one-element buffer and forces a pause after each event.
R=floitsch@google.com
Review URL: https://codereview.chromium.org/2149893002 .
2016-09-26 09:35:46 +02:00
Stephen Adams
127b419fc1
Add WhereIterable.map
...
This makes some nice code improvements for dart2js. dart2js can't
inline the MappedIterable factory constructor and specialize by
optimization, so specializing by hand removes the test "is
EfficientLength" for code like "x.where(f).map(g)".
R=lrn@google.com
Review URL: https://codereview.chromium.org/2354093002 .
2016-09-22 10:36:16 -07:00
William Hesse
61eee9ee52
Use checked-in .package file for building and testing
...
Stop creating [build dir]/packages directory with symbolic links.
BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com
Committed: 5d3e356ca7
Review URL: https://codereview.chromium.org/1746743002 .
Reverted: 6d238ba197
2016-09-16 15:03:18 +02:00
Stephen Adams
8495283e25
Reuse expensive string in js_rti
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2326943003 .
2016-09-12 17:22:27 -07:00
Alan Knight
42f8ab2d6a
Fix dataTransferItemList indexing
...
BUG=
Review URL: https://codereview.chromium.org/2326113002 .
2016-09-09 12:28:59 -07:00
Stephen Adams
c70952c7bc
dart2js: Pass type information to constructor rather than add later.
...
This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug with the interactions with type optimizations.
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2310573002 .
Committed: 9217be050d
Reverted: cdd6eeb57d
2016-09-07 15:07:54 -07:00
Kevin Moore
ca2285be58
dart:js_util - fix spelling
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/2311563002 .
2016-09-06 09:23:59 -07:00
Florian Loitsch
70c48b9a2e
Don't propagate synchronous Future.wait errors immediately.
...
Fixes #27249 .
R=lrn@google.com
Review URL: https://codereview.chromium.org/2311923002 .
2016-09-06 11:57:43 +02:00
Florian Loitsch
6255638cd0
Return futures on Stream.cancel when possible.
...
Deprecate returning `null`.
Also, fixes cases where transformations on a stream didn't forward the cancel future
Fixes #26777 .
BUG= http://dartbug.com/26777 .
R=lrn@google.com
Review URL: https://codereview.chromium.org/2202533003 .
Committed: 395e7aaa69
Reverted: 99e5328eac
Committed: 1905ddafaa
Reverted: 46a8579c1e
2016-09-05 17:41:22 +02:00
Stephen Adams
921eac74cf
Rename $builtinType to $ti
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2306813003 .
2016-09-02 10:53:26 -07:00
Zachary Anderson
4024fe154a
GN: Relativize occurrances of //dart
...
The Dart root in the Dart tree is at //, not //dart.
But in the Dart tree we can refer to the root with
a relative path.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2301833003 .
2016-09-01 13:35:44 -07:00
Alan Knight
43cb6a4c59
Replace Maps library tour link in Storage template with current URL.
...
BUG=#27150
R=alanknight@google.com
Review URL: https://codereview.chromium.org/2277103002 .
2016-08-26 12:34:53 -07:00
Lasse R.H. Nielsen
99ec987a09
Remove deprecated Resource class from dart:core.
...
BUG=
R=floitsch@google.com , mit@google.com
Review URL: https://codereview.chromium.org/2272373002 .
Committed: f61143153a
Committed: 35437dda1f
2016-08-26 11:58:04 +02:00
Lasse Nielsen
35437dda1f
Remove deprecated Resource class from dart:core.
...
BUG=
R=floitsch@google.com , mit@google.com
Review URL: https://codereview.chromium.org/2272373002 .
Committed: f61143153a
2016-08-26 10:50:58 +02:00
Lasse Nielsen
f61143153a
Remove deprecated Resource class from dart:core.
...
BUG=
R=floitsch@google.com , mit@google.com
Review URL: https://codereview.chromium.org/2272373002 .
2016-08-26 10:31:08 +02:00
Ryan Macnak
0245016792
Fix ArgumentError constructor call.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org/2272703007 .
2016-08-24 17:13:22 -07:00
Ryan Macnak
aa38062a23
Add WebSocket.addUtf8Text to allow sending pre-encoded text without a round-trip UTF-8 conversion.
...
Use it to implement the vm-service, where in particular we are concerned about the space overhead of the conversion leading to the process being killed on iOS.
Closes #27129
R=johnmccutchan@google.com , lrn@google.com
Review URL: https://codereview.chromium.org/2260073002 .
2016-08-24 16:15:07 -07:00
Zachary Anderson
57bff322cd
Ignore non-UTF8 strings in the environment
...
R=asiva@google.com
Review URL: https://codereview.chromium.org/2273053002 .
2016-08-24 10:10:41 -07:00
Florian Loitsch
1971d4c59d
Fix DateTime.timeZoneName comment.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org/2270043002 .
2016-08-24 12:49:17 +02:00
Stephen Adams
266ac1b0bc
Add SSA instructions for reified type information
...
This enables GVN optimizations of type representations, e.g.
var touches, targetTouches, changedTouches, mockTouchList, t1;
touches = H.setRuntimeTypeInfo([], [W.Touch]);
targetTouches = H.setRuntimeTypeInfo([], [W.Touch]);
changedTouches = H.setRuntimeTypeInfo([], [W.Touch]);
mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], [W.Touch]);
--->
var t1, touches, targetTouches, changedTouches, mockTouchList;
t1 = [W.Touch];
touches = H.setRuntimeTypeInfo([], t1);
targetTouches = H.setRuntimeTypeInfo([], t1);
changedTouches = H.setRuntimeTypeInfo([], t1);
mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], t1);
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/2260223002 .
2016-08-19 13:02:18 -07:00
Ryan Macnak
d418dde65b
Reduce copying in sending service responses.
...
Add missing safepoint transitions.
Issue #27092
Likely contributes to Issue #27010
dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with endless recorder)
Before 215M -> 321M
After 182M -> 233M
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2254543006 .
2016-08-18 10:34:50 -07:00
Florian Loitsch
33b7b45252
Deal with synchronous errors in Future.wait.
...
Synchronous errors are caught and piped into the returned future. This makes handling errors in Future.wait uniform.
Fixes #23656
BUG= http://dartbug.com/23656
R=lrn@google.com
Review URL: https://codereview.chromium.org/2252823004 .
2016-08-18 14:09:20 +02:00
Stephen Adams
1381749356
Make Uri._makeQuery easier to analyze
...
In many programs dart2js can tell that [queryParameters] is always null.
It is too hard for dart2js to infer from the previous conditions that
the last test 'query != null' must always be true. By changing the
liveness predicate for the forEach code to be a function of one
variable, we can help dart2js understand that the forEach code is dead
when queryParameters is null.
BUG=
R=lrn@google.com
Review URL: https://codereview.chromium.org/2245323004 .
2016-08-17 10:45:11 -07:00
Lasse R.H. Nielsen
afbbbb97cf
Reapply fast-URI patch.
...
Review URL: https://codereview.chromium.org/2245533004 .
2016-08-17 10:54:24 +02:00
Harry Terkelsen
1d749a2fec
record that Gamepad.buttons creates GamepadButtons
...
This also extends the html generator to be able to generate List implementations with nullable element types
Fixes https://github.com/dart-lang/sdk/issues/27073
R=sra@google.com , terry@google.com
Review URL: https://codereview.chromium.org/2242203002 .
2016-08-16 13:56:32 -07:00
Jacob Richman
b779679721
Switch to @patch annotation from patch.
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org/2233633002 .
2016-08-10 09:31:06 -07:00
John Messerly
1c7aca0d6d
fix #25944 , improve Future.then inference
...
also fixes #25322 , return values of async functions are T | F<T>
R=leafp@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/2208953002 .
2016-08-09 16:04:26 -07:00
Lasse R.H. Nielsen
3502fd5fd7
Revert "Reapply fast-URI patch."
...
Seems to trigger VM bug.
Review URL: https://codereview.chromium.org/2225243003 .
2016-08-09 12:51:58 +02:00