Token position and script reference information are cheap to provide and
make it possible to tie objects to scripts without requiring additional
requests for full objects.
TEST=Existing
Change-Id: I917714149a72a53081fee5626ccad858e86f5313
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201864
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
* This adds a mac amd64 SDK as the arm64 SDK to bootstrap arm64
development on macOS.
Change-Id: I519e5ad2343360bc2e692b52d95c94076bfd9e87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201833
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
# 1.5.0
- (internal) migrated to `SecurityLintCode` instead of deprecated
`SecurityLintCodeWithUniqueName`
- (internal) fixed `avoid_types_as_parameter_names` to skip field formal
parameters
- fixed false positives in `prefer_interpolation_to_compose_strings` where
the left operand is not a String
- fixed false positives in `only_throw_errors` for misidentified type
variables
- new lint: `depend_on_referenced_packages`
- update `avoid_returning_null_for_future` to skip checks for null-safe
libraries
- new lint: `use_test_throws_matchers`
- relax `sort_child_properties_last` to accept closures after child
- performance improvements for `prefer_contains` and `prefer_is_empty`
- new lint: `noop_primitive_operations`
- mark `avoid_web_libraries_in_flutter` as stable
- new lint: `prefer_final_parameters`
- update `prefer_initializing_formals` to allow assignments where identifier
names don't match
Change-Id: I447a9e277a037da30e1c7b5c23d3bb5d1037f26c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201163
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This is a reland of 5c9e37f03c
Following update of `DEPS` in `flutter/engine`:
https://github.com/flutter/engine/pull/26395
New commits include:
```
git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569
def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008)
0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009)
e89d4ab8 Generate GNU-style long file names in tar archives (#3005)
d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006)
492b15ba New binstubs for global activate using `dart pub` (#3002)
e02f23bb fix grammer in .gitignore error message (#2995)
e01e3a41 Use the frontend server to compile pub executables (#2968)
647989c6 Use RetryClient from package:http/retry.dart (#2980)
```
Original change's description:
> Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878
> Auto-Submit: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
Change-Id: I1a0570318c63ec97fd141d79b405f55105111077
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201260
Commit-Queue: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This reverts commit 5c9e37f03c.
Reason for revert: flutter builds on golem somehow broke.
Original change's description:
> Bump pub.
>
> New commits include:
> ```
> git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569
> def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008)
> 0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009)
> e89d4ab8 Generate GNU-style long file names in tar archives (#3005)
> d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006)
> 492b15ba New binstubs for global activate using `dart pub` (#3002)
> e02f23bb fix grammer in .gitignore error message (#2995)
> e01e3a41 Use the frontend server to compile pub executables (#2968)
> 647989c6 Use RetryClient from package:http/retry.dart (#2980)
> ```
>
> Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878
> Auto-Submit: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
TBR=athom@google.com,jonasfj@google.com
Change-Id: I635e1c2db8ae965881359d4969cbd506348b0ed0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201000
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
New commits include:
```
git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569
def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008)
0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009)
e89d4ab8 Generate GNU-style long file names in tar archives (#3005)
d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006)
492b15ba New binstubs for global activate using `dart pub` (#3002)
e02f23bb fix grammer in .gitignore error message (#2995)
e01e3a41 Use the frontend server to compile pub executables (#2968)
647989c6 Use RetryClient from package:http/retry.dart (#2980)
```
Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878
Auto-Submit: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This reverts commit 660e63136c.
Reason for revert: Breaks FFI builds: as: unrecognized option '-EL'
Original change's description:
> [infra] Update to a clang with libc++.a for Mac ARM64.
>
> Bug: https://github.com/dart-lang/sdk/issues/42773
> Change-Id: I24e3e842ffc7b3ac28e3236b1b4ef393762f9c8a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193823
> Reviewed-by: Alexander Thomas <athom@google.com>
> Reviewed-by: William Hesse <whesse@google.com>
> Commit-Queue: Alexander Thomas <athom@google.com>
TBR=whesse@google.com,athom@google.com,rmacnak@google.com
Change-Id: Ib444653411c9053bd2eb81c2bf54dbbd9f3686b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/42773
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200870
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2021-05-11 sgrekhov@unipro.ru Fixes 1089. Fix flaky Process.kill tests
2021-05-06 sgrekhov@unipro.ru 1082. Generator for dynamic generated tests fixed
2021-05-06 sgrekhov@unipro.ru 1082. Update copyright and comments in Subtyping generated tests
2021-05-05 sgrekhov@unipro.ru 1082. Language version added to all co19_2 tests
2021-05-05 sgrekhov@unipro.ru 1082. Missing Copyrights added and documentation fixed to use single-line comments
2021-05-05 sgrekhov@unipro.ru 1082. Copyright and documentation changed to use single-line comments
Change-Id: I47b4af1cde69ea8f1aa9164c8df045f1120550f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200860
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This reverts commit a527411e51.
Reason for revert: depends on package 'devtools_shared' that is not yet migrated.
Original change's description:
> [ package:dds ] Add null safety support
>
> Fixes https://github.com/dart-lang/sdk/issues/45756
>
> TEST=service + DDS tests
>
> Change-Id: I6dd14d7f9fdee479a830c3b053dc3b00aa635202
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199800
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Devon Carew <devoncarew@google.com>
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Icdaef3ac55d7ef302acd3f9c2538a41e52e4253a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200180
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
New commits include:
```
$ git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..00c00e8adf9706bebe8f94483b7663c5f36f59d2
00c00e8a Vendor tar (#2987)
291705ca Being gradual migration to null-safety (#2988)
c5f52a37 Fix CI (#2989)
74040a45 Update to analyzer 1.5.0, migrate from deprecated AnalysisSession.getParsedUnit() (#2975)
ce951d70 Fix dry-run tests for publishing by ensuring there is a server to reject requests (#2978)
018c9650 Update LICENSE (#2944)
2614f15c Revert "Vendor package:tar and package:chunked_stream (#2932)" (#2940)
12d9f457 Handle package:tar cancellations
255a3091 Vendor package:tar and package:chunked_stream (#2932)
86bf8b20 Handle relative git-url-paths correctly when --directory (#2919)
3716a681 Let `pub add` fail if extra arguments are passed (#2927)
a03ac729 Minor cleanup to reduce risk of using path.current (#2924)
e87b7b66 Added null check for name in UserInfo class (#2918)
056a8c9a pub deps --json (#2896)
53a69e27 Fix .packages entries of relative path deps when using --directory (#2916)
d6308efc pub upgrade command shows count of discontinued packages (#2908)
51744805 Upgrade to the null safe versions of all dependencies (#2913)
e0d538c7 Introduce .pubignore (#2787)
79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898)
22463872 `cache clean` (#2904)
11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883)
b6977d50 Remove untrue assert (#2884)
35841f8d Merge branch 'cherry_picks_for_2_12'
0db3255b Don't fail on failed status listing (#2877)
53e8ecca Don't allow outdated taking arguments (#2872)
e83a1dc1 Enable asserts when testing pub (#2754)
178f2edb Add --directory option (#2876)
5aadb70e Don't fail on failed status listing (#2877)
4bf8a927 Remove unused field (#2878)
73ad5426 Don't allow outdated taking arguments (#2872)
9a70949e Use Dart library to read and write tar files (#2817)
2f74230c Do not recommend decativating packages (#2871)
b1697a27 Use full error message string in CommandResolutionFailedException (#2870)
16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859)
6e240ea9 Use cached version listings as heuristic when prefetching (#2851)
58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856)
b1bf9a33 Handle poor package-listing responses robustly. (#2847)
d941bd24 Fix request metadata when overriding dependencyType (#2848)
```
Change-Id: Id7cc4c09e74c02a92bcafe1a9d9bab9431900540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199040
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
This reverts commit 1f9fcfd999.
Reason for revert: Breaks internal tests.
Original change's description:
> Update to the latest shelf and shelf_static
>
> Change-Id: I6b8e4d39de4147d8b27132877ca2fc6a93a96761
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198882
> Reviewed-by: Kevin Moore <kevmoo@google.com>
> Commit-Queue: Kevin Moore <kevmoo@google.com>
> Auto-Submit: Nate Bosch <nbosch@google.com>
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I2aa86c3df68518e1b64598abe5dfa8f053632b0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199120
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Change-Id: I6b8e4d39de4147d8b27132877ca2fc6a93a96761
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198882
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
This reverts commit ef0e4ea107.
Reason for revert: Flutter HHH and golem builds are red. Rolls to Flutter are failing.
TEST=N/A
Original change's description:
> [ VM / DDS / CLI ] Add DevTools support to the standalone VM
>
> Example output on stdout when DevTools is enabled:
>
> Observatory listening on http://127.0.0.1:8181/CzkZzZaONW4=/
> The Dart DevTools debugger and profiler is available at: http://127.0.0.1:8181/devtools/#/?uri=ws%3A%2F%2F127.0.0.1%3A8181%2FCzkZzZaONW4%3D%2Fws
> hello world!
>
> vm-service: isolate(1674461414267555) 'main' has no debugger attached and is paused at exit. Connect to Observatory at http://127.0.0.1:8181/CzkZzZaONW4=/ to debug.
>
> TEST=pkg/dartdev/test/commands/run_test.dart
>
> Change-Id: Icd1afda87ad4a46f228125d53094d10adf8056ec
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188361
> Commit-Queue: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I50e8dc4e592e13b44c2fb980b2029d5c5cc3ad2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198381
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
That way we can pick it up in the Flutter roller in
`src/tools/dart/create_updated_flutter_deps.py`.
Change-Id: I2b64e5790de3737dc0d66069aecdd99b42b7c2c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198042
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2021-05-04 sgrekhov@unipro.ru 993. Fix expected size of the packed struct
2021-04-27 irina.arkhipets@gmail.com Issue 1083: Missing Issue tag added.
2021-04-27 irina.arkhipets@gmail.com Fixes 1084: test expectation corrected for null safety turned on.
2021-04-27 irina.arkhipets@gmail.com Issue 996: More tests for Generic functions as type parameter or bound added, missing shared options added
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-mac-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I809761fb0c7c14538a7c6935a9c9ded67935f268
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198020
Reviewed-by: William Hesse <whesse@google.com>
The previous attempt to upgrade to `2.13.0-211.13.beta` was reverted:
https://github.com/flutter/flutter/issues/81335
Change-Id: Ia358fc2ec4fed3a9b8e3f85cd70a74801298ebc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197721
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Change-Id: I24598f4cce30d3e1dfa775e05fbed0fb8f32bb76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197584
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
