Commit graph

4 commits

Author SHA1 Message Date
Eric Seidel 4c20cedd30 Fix analysis issues in benchmarks/ directory
Now that I'm able to open the entire SDK in VSC, I'm fixing some
of the analysis issues in various files (carefully) without changing
their meaning.

In this case, I removed unnecessary imports from benchmarks.
In regexp_benchmark I ignored one warning which likely would
have changed the behavior of the code.

BUG=https://github.com/dart-lang/sdk/issues/52419

Change-Id: I9a195a4e45121313bd9f065f2579a165c3fec05b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303901
Auto-Submit: Eric Seidel <eric@shorebird.dev>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2023-05-17 09:14:50 +00:00
Martin Kustermann 150635653e Revert accidental change in ObjectHash benchmark
The change in [0] made ObjectHash.hash.5 benchmark accidentally hash one
more value (i.e. 6 instead of 5). This CL reverts that change.

[0] https://dart-review.googlesource.com/c/sdk/+/276161

TEST=ci

Change-Id: Idee8cd445683b89d1a4013beae3ea544a5e3a8e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/277988
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
2023-01-03 09:50:38 +00:00
Lasse R.H. Nielsen ece7da8009 Make final parameter of SystemHash.hashX not be optional.
Issue https://github.com/dart-lang/sdk/issues/50693

Change-Id: Ib587b70bcb57cbd2d16319b7814e2569c7e41213
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276161
Commit-Queue: Lasse Nielsen <lrn@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2023-01-02 12:44:23 +00:00
Stephen Adams b0310477d9 Add benchmark for Object.hash
Change-Id: If13333096b337994fd6ad45804812a3a51b90aae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205020
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2021-06-30 21:06:34 +00:00