languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 22:01:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
47888 commits 11 branches 6011 tags 1.4 GiB
Commit graph

248 commits

Author SHA1 Message Date
Kevin Moore 46110c331b fix doc comments in dart:io and collection types 
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2905013003 .
 2017-05-31 09:08:12 -07:00
Leaf Petersen ccbaabad8d Adjust types in SplayTree implementation and some strong tests to 
avoid relying on fuzzy arrows.

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2877683002 .
 2017-05-11 17:27:32 -07:00
Lasse R.H. Nielsen 953f78d6dd Revert "Change some platform libraries to use part of URI." 
This makes the analyzer generate a variety of odd errors.
Best guess is that it somehow fails to recognize Object as the Object class
(stack overflow while traversing superclasses, cannot assign Foo<T> to
Foo<Object> and similar errors can be explained by that).

Review-Url: https://codereview.chromium.org/2880543002 .
 2017-05-11 11:42:21 +02:00
Lasse R.H. Nielsen 540bb7a0ec Change some platform libraries to use part of URI. 
Use new dart-style. Now needs an SDK built with this checked in as well.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2871123004 .
 2017-05-11 10:56:02 +02:00
Lasse R.H. Nielsen 5a1a1509fc Fix some bad documentation links. 
Addresses some of the cases of issue #29534.
BUG= http://dartbug.com/29534

Review-Url: https://codereview.chromium.org/2856123003 .
 2017-05-03 13:10:46 +02:00
Bob Nystrom 7f7c681893 Fix a batch of DDC SDK compile errors. 
R=floitsch@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2848703003 .
 2017-04-27 17:27:02 -07:00
Jacob Richman c890c487fe Format all files under the sdk/lib directory. 
BUG=
R=floitsch@google.com, terry@google.com

Review-Url: https://codereview.chromium.org/2822303002 .
 2017-04-19 08:16:20 -07:00
Florian Loitsch a382f7845c Revert "Fix some strong mode issues in the core libraries." 
This reverts commit e5c091e048.

Review-Url: https://codereview.chromium.org/2767943002 .
 2017-03-22 16:55:05 +01:00
Florian Loitsch e5c091e048 Fix some strong mode issues in the core libraries. 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2764943002 .
 2017-03-22 15:59:10 +01:00
Jacob Richman ea6991a245 Format all dart: library files 
BUG=
R=floitsch@google.com, sra@google.com

Review-Url: https://codereview.chromium.org/2754013002 .
 2017-03-16 10:22:19 -07:00
Jennifer Messerly 373149e003 fix ListMixin _filter and sort to work in strong mode 
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2715833004 .
 2017-02-28 10:37:28 -08:00
Florian Loitsch 7fa4496e51 Add documentation for mutating operations of unmodifiable maps. 
Simply states that the operation is not supported.

Fixed #28918
BUG= http://dartbug.com/28918
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2722613004 .
 2017-02-28 14:41:38 +01:00
Peter von der Ahé 00bed94e0c Fix various nits in VM patch files. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2705593002 .
 2017-02-17 16:28:57 +01:00
Kevin Moore 1e8558a3a6 fix spelling in core libraries 
Fixes https://github.com/dart-lang/sdk/issues/28490

R=dgrove@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2655883002 .
 2017-01-25 09:36:55 -08:00
Lasse R.H. Nielsen 44594277e1 Make core libraries use generic method syntax. 
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Committed: 68818315b5
Committed: 3f74b8d82e
Review-Url: https://codereview.chromium.org/2529393002 .
 2017-01-03 12:05:40 +01:00
Lasse Reichstein Holst Nielsen 3f74b8d82e Make core libraries use generic method syntax. 
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2529393002 .

Committed: 68818315b5
 2016-12-14 12:24:36 +01:00
Lasse Reichstein Holst Nielsen 68818315b5 Make core libraries use generic method syntax. 
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2529393002 .
 2016-12-14 11:32:16 +01:00
Florian Loitsch 7ee023d2ed Improve document for HashSet. 
See #28083 (http://dartbug.com/28083)

R=lrn@google.com

Review-Url: https://codereview.chromium.org/2567393002 .
 2016-12-13 15:08:58 +01:00
Lasse Reichstein Holst Nielsen 9412b54f1f Fix DoubleLinkedListQueue misbehavior on concurrent modification. 
Documented forEachEntry, firstEntry and lastEntry.
Made forEachEntry more useful by making it compatible with removing and adding
around the current entry, and documented how it interacts.

BUG= http://dartbug.com/27920
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2540993002 .
 2016-12-06 09:27:04 +01:00
Lasse R.H. Nielsen c6412af7bb Don't use [operator==] to refer to [==] in DartDoc. It doesn't work. 
R=eernst@google.com

Review URL: https://codereview.chromium.org/2548433002 .
 2016-12-01 11:00:33 +01:00
Lasse Reichstein Holst Nielsen 7957a1c256 Make EfficientLength extend Iterable. 
This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2467113003 .

Committed: b08fb1373f
 2016-11-28 08:04:04 +01:00
Ryan Macnak 6cf5c3baa3 Revert "Make EfficientLength extend Iterable." 
This reverts commit b08fb1373f.

TBR=lrn@google.com

Review URL: https://codereview.chromium.org/2467283003 .
 2016-11-02 13:20:41 -07:00
Lasse R.H. Nielsen b08fb1373f Make EfficientLength extend Iterable. 
This should help least-upper-bound computations to not think of EfficientLength
as completely separate from Iterable even though they are always used together.

It doesn't solve all problems with the least-upper-bound computation,
but at least some of the more often occuring ones.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/2467113003 .
 2016-11-02 14:05:35 +01:00
Florian Loitsch e1bf3506d1 Make linked-list non-circular. 
This bug was introduced when making the collection library strong-mode clean.

Fixes #26522
BUG= http://dartbug.com/26522
R=lrn@google.com

Review URL: https://codereview.chromium.org/2015513006 .
 2016-06-01 14:19:37 +02:00
Lasse R.H. Nielsen fbf64bb7a5 Make Iterable.toList more efficient if the length is known. 
Add more tests. Fix (some) bugs found by tests.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1999793002.
 2016-05-23 10:00:19 +02:00
Florian Loitsch 2203c54cbb Fix documentation for LinkedHashSet. 
Fixes #26496
BUG= http://dartbug.com/26496

Review URL: https://codereview.chromium.org/1999783002 .
 2016-05-20 14:36:38 +02:00
Florian Loitsch ac0a5ef431 Fix documentation for identity sets/maps. 
Fixes #26503
BUG= http://dartbug.com/26503
R=lrn@google.com

Review URL: https://codereview.chromium.org/2002593002 .
 2016-05-20 14:29:14 +02:00
Florian Loitsch 1e3b98278a Make DoubleLinkedQueueEntry subclassable again. 
Also, add back the `remove` function that was accidentally removed.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1973903005 .
 2016-05-17 12:54:12 +02:00
Florian Loitsch e19addf23e Make dart:collection strong-mode clean. 
R=leafp@google.com

Review URL: https://codereview.chromium.org/1937103002 .
 2016-05-11 16:28:43 +02:00
Florian Loitsch b19e00c2d4 Fix Set.from which still had a generic type on the incoming Iterable. 
Follow-up fix for http://dartbug.com/21731
Also see https://codereview.chromium.org/838463002/

R=lrn@google.com

Review URL: https://codereview.chromium.org/1887883006 .
 2016-04-28 15:01:04 +02:00
Florian Loitsch a96120243a Merge pull request #26330 from sethladd/library-level-import-docs 
add library-level docs to help with importing
 2016-04-27 14:01:01 +02:00
Florian Loitsch 516c09cb1f Fix documentation for identity collections. 
BUG= http://dartbug.com/26326

Review URL: https://codereview.chromium.org/1922083002 .
 2016-04-26 11:35:30 +02:00
Seth Ladd a875749e82 add library-level docs to help with importing 2016-04-25 12:41:24 -07:00
Florian Loitsch 111a794141 Fix documentation for identity hashmap. 
Fixes 26326.
BUG= http://dartbug.com/26326

Review URL: https://codereview.chromium.org/1921663002 .
 2016-04-25 15:56:32 +02:00
Leaf Petersen 92edd907c1 Add generic annotations to more SDK APIs. 
Fixes https://github.com/dart-lang/sdk/issues/25860 .

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1815583002 .
 2016-03-28 17:52:40 -07:00
Vijay Menon 89ccefe462 Add generic method info to ListMixin 
These match those already in iterable.dart

Fixes #25408

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1665463002 .
 2016-02-03 11:26:53 -08:00
Florian Loitsch 1a3853b128 Improve comment in UnmodifiableListView. 
The class already states that the source must have efficient-length, but
the constructor didn't reiterate this requirement.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1510043002 .
 2015-12-09 21:25:55 +01:00
John Messerly 49c24b83da add generic method comments to a few SDK methods 
R=lrn@google.com

Review URL: https://codereview.chromium.org/1462743002 .
 2015-11-24 09:20:49 -08:00
Lasse R.H. Nielsen d4d71dd632 Make MapMixin putIfAbsent use containsKey. 
Fixes issue #24560
BUG= http://dartbug.com/24560
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1390163004.
 2015-10-13 16:12:58 +02:00
Lasse R.H. Nielsen 4e94938f7e Fix some cases where Map.containsValue did not accept Object as argument. 
Add tests.
Also remove a left-over check in SplayTreeMap.

BUG= https://github.com/dart-lang/dev_compiler/issues/344
R=wibling@google.com

Review URL: https://codereview.chromium.org//1360053003 .
 2015-09-23 11:26:55 +02:00
Kevin Millikin 95860326cd Fix a typo in the documentation for HashMap. 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1337873003 .
 2015-09-11 11:28:10 +02:00
Lasse R.H. Nielsen 1b8f3fba14 Make List constructor give better error messages for non-int arguments 
BUG= http://dartbug.com/15986
R=herhut@google.com, iposva@google.com, sra@google.com

Committed: 33c7663826

Review URL: https://codereview.chromium.org//1214723009 .
 2015-08-17 13:01:13 +02:00
Lasse R.H. Nielsen 51fa195f16 Revert "Make List constructor give better error messages for non-int arguments" 
There are VM-only tests that assume exact text of failure.

BUG=

Review URL: https://codereview.chromium.org//1294483003 .
 2015-08-14 15:05:17 +02:00
Lasse R.H. Nielsen 33c7663826 Make List constructor give better error messages for non-int arguments 
BUG= http://dartbug.com/15986
R=herhut@google.com, iposva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1214723009 .
 2015-08-14 13:44:19 +02:00
Seth Ladd b30a7a1750 change param name to match docs 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1287453002 .
 2015-08-11 10:55:16 -07:00
Lasse R.H. Nielsen 6f2dd2552c Fix typo in ListMixin.insertAll. 
Also add test for input iterable being linked to receiver list.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1146163004
 2015-06-02 11:58:35 +02:00
Lasse R.H. Nielsen babcd4e9c0 Revert "Make EfficientLength public, as EfficientLengthIterable." 
It's still not a good solution for detecting an Iterable with an efficient
length. It's not inherited by, e.g., a DelegatingIterable wrapper or similar
generic Iterable transformers.

Keep this as an internal optimization for quickly detecting the most common
efficient-length Iterable classes (List, Set, Queue, Map.keys/values), but
don't make it public.

A *real* solution would be adding a hasEfficientLength getter to Iterable, or
adding an efficientLength getter that may return null if it's not efficient.
This would something that a wrapper can attach to.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1154263003
 2015-05-29 12:52:45 +02:00
lrn@google.com 4d539e4975 Fix typo in EfficientLengthIterable documentation, and improve it slightly. 
R=kustermann@google.com

Review URL: https://codereview.chromium.org//1132503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45586 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-07 10:18:36 +00:00
lrn@google.com 92c526b2a2 Make EfficientLength public, as EfficientLengthIterable. 
R=iposva@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1104063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45556 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-06 09:00:45 +00:00
lrn@google.com b3d466a1ca Update {,Linked}Hash{Set,Map} documentation. 
Now specifies that the default [isValidKey] accepts all values in the
default and identity cases.

BUG= http://dartbug.com/23356
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1130453003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45552 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-06 08:35:23 +00:00