languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-18 21:41:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
47888 commits 11 branches 6011 tags 1.4 GiB
Commit graph

1228 commits

Author SHA1 Message Date
Paul Berry ff15ce7a9e Mark new test utilities_test as slow due to bug #24914 
TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1640403003 .
 2016-01-28 09:45:54 -08:00
Florian Loitsch 66fad1459b Mark another analyzer test as slow. 
Review URL: https://codereview.chromium.org/1629293004 .
 2016-01-25 14:40:29 +01:00
Paul Berry 1883f70d46 Mark new test constant_test as slow due to bug #24914 
TBR=skybrian@google.com

Review URL: https://codereview.chromium.org/1624093003 .
 2016-01-25 08:16:11 -05:00
Florian Loitsch 5db493f5f5 Mark test as slow. 
Review URL: https://codereview.chromium.org/1626323003 .
 2016-01-25 13:44:28 +01:00
Florian Loitsch 8e5328ff6d Mark test as slow. 
Review URL: https://codereview.chromium.org/1633523002 .
 2016-01-25 13:13:25 +01:00
Zachary Anderson 80f358dede Adds targets for simarmv6 and armv6 
related #25562

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1624593002 .
 2016-01-22 13:07:48 -08:00
Paul Berry 1a91d3bc06 Update pkg.status for new strong mode summary tests. 
TBR=scheglov@google.com

Review URL: https://codereview.chromium.org/1614363003 .
 2016-01-22 13:32:00 -05:00
Paul Berry d6a8a2aa88 Fix dart2js status after splitting up summary tests. 
Review URL: https://codereview.chromium.org/1611723002 .
 2016-01-20 14:41:20 -08:00
Paul Berry 3dcef185d6 Fix newline normalization in _PhysicalFile.readAsStringSync(). 
Most clients of _PhysicalFile read the file by translating it into a
Source object using createSource() and then reading it using
FileBasedSource.contentsFromFile, which normalizes newlines using
FileBasedSource.fileReadMode.

However, a few clients read the file directly using
_PhysicalFile.readAsStringSync(), which wasn't doing the
normalization.  This CL adds the normalization to that code path.

One such client was the code generation logic for summaries; this
caused code generation to produce different results on Windows, which
led to a test failure.

Fixes #25470.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1584313010 .
 2016-01-15 12:54:22 -08:00
Konstantin Shcheglov 659c9b44e2 Mark analyzer/test/file_system/physical_resource_provider_test as Pass, Fail. 
R=brianwilkerson@google.com, whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1581963009 .
 2016-01-14 10:28:46 -08:00
William Hesse 84d7fd63f0 Update status of two analyzer tests. 
BUG=https://github.com/dart-lang/sdk/issues/25471
BUG=https://github.com/dart-lang/sdk/issues/25470
R=ricow@google.com

Review URL: https://codereview.chromium.org/1588673005 .
 2016-01-14 17:41:59 +01:00
Paul Berry fb83e3927f Mark some tests as slow due to bug #24914 
TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1577013002 .
 2016-01-11 09:42:35 -08:00
Konstantin Shcheglov 49bc0f4b1d Remove Int64 support from FlatBuffers. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1570193004 .
 2016-01-09 10:20:30 -08:00
Konstantin Shcheglov d9bf185db4 Skip FlatBuffers tests on dart2js bots. 
dart2js does not support Int64.

TBR

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1573613002 .
 2016-01-08 11:39:16 -08:00
Kevin Millikin b5aac5b951 dart2js: Update test status files for the CPS backend. 
After inlining, test expectations have changed.  A few tests have
starting unexpectedly passing --- this could be because inlining
implements the correct semantics, or the could be passing for the
wrong reason.  In any case, the underlying bug in the compiler has not
been fixed.

I will look into all these issues after the Christmas holidays.

BUG=

Review URL: https://codereview.chromium.org/1546943002 .
 2015-12-23 12:25:59 +01:00
Kevin Millikin 044b283a3c dart2js: Initial implementation of inlining. 
Perform a depth-first postorder traversal of the call graph of known
functions.  Make an inlining decision based on the vector of argument
types at the call site, and cache inlining decisions.  For positive
inlining decisions, cache the optimized function body specialized to
the receiver and argument types at the call site.

Future work:
  * Real inlining heuristics.
  * Propagate result types of inlined calls.
  * Specialized for constant arguments when it makes sense.
  * Performance improvements.

R=asgerf@google.com, sra@google.com

Committed: d63053fea8

Review URL: https://codereview.chromium.org/1537663002 .
 2015-12-23 10:12:19 +01:00
Kevin Millikin 75eb350abc Revert "dart2js: Initial implementation of inlining." 
This reverts commit d63053fea8.

Reverted due to test failures for compiler expected output.  Those tests
need to be rebaselined to reflect the effects of inlining.

TBR=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1542003003 .
 2015-12-22 13:48:36 +01:00
Kevin Millikin d63053fea8 dart2js: Initial implementation of inlining. 
Perform a depth-first postorder traversal of the call graph of known
functions.  Make an inlining decision based on the vector of argument
types at the call site, and cache inlining decisions.  For positive
inlining decisions, cache the optimized function body specialized to
the receiver and argument types at the call site.

Future work:
  * Real inlining heuristics.
  * Propagate result types of inlined calls.
  * Specialized for constant arguments when it makes sense.
  * Performance improvements.

R=asgerf@google.com, sra@google.com

Review URL: https://codereview.chromium.org/1537663002 .
 2015-12-22 12:50:23 +01:00
Ivan Posva 21a029f89a - Do not attempt to run dart:io based tests in the browser. 
BUG=

Review URL: https://codereview.chromium.org/1537853002 .
 2015-12-17 15:50:07 -08:00
William Hesse 6485590527 Remove old java-based analyzer from test scripts and status files 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1537653002 .
 2015-12-17 14:44:57 +01:00
Stephen Adams 444499020b More pkg.status tests from analyzer that are slow 
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org/1531973002 .
 2015-12-16 16:15:47 -08:00
Stephen Adams f264e5291c analyzer declaration_resolver_test is slow on dart2js 
It is hovering around 55s, so times out too often.

TBR=sigmund@google.com

Review URL: https://codereview.chromium.org/1528133002 .
 2015-12-15 12:27:10 -08:00
Paul Berry 1e0f112666 Update pkg.status to work around https://github.com/dart-lang/http_parser/issues/6 
TBR=nweiz@google.com

Review URL: https://codereview.chromium.org/1513643011 .
 2015-12-10 11:18:27 -08:00
Paul Berry 1c3fa08ca6 Update pkg.status to account for dart_style roll. 
The dart_style roll fixed the remaining tests that were broken by the
merge of analyzer-breaking-0.27.

Fixes #25173.

TBR=rnystrom@google.com

Review URL: https://codereview.chromium.org/1514553003 .
 2015-12-09 07:10:14 -08:00
Paul Berry b55257975b Update pkg.status file for library_member_contributor_test 
This newly introduced test currently fails on the analyzer buildbot due
to transitive import dependencies on
dart_style/lib/src/dart_formatter.dart and
dart_style/lib/src/source_visitor.dart, which have known warnings.

TBR=danrubel@google.com

Review URL: https://codereview.chromium.org/1504713007 .
 2015-12-08 13:16:25 -08:00
Paul Berry 89f475a5f2 Update pkg.status to account for linter roll. 
The linter roll fixed 7 tests.

See bug #25173.

TBR=pquitslund@google.com

Review URL: https://codereview.chromium.org/1508153002 .
 2015-12-08 11:47:58 -08:00
Paul Berry 2698fb583a Update pkg.status to account for recent analyzer breakages. 
See bug #25173.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1510873003 .
 2015-12-08 10:38:56 -08:00
pq 968617b67a Status file update (vm only tests SkipByDesign). 
Follow-up to https://codereview.chromium.org/1464833002/.

Rather than ignore, mark as `SkipByDesign` as CLI tests are designed for the VM.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1463593003 .
 2015-11-20 10:19:29 -08:00
pq 8b6fb86397 Status file updates (analyzer_cli on dart2js). 
We're hitting an issue that on the surface looks like the one discussed in https://github.com/dart-lang/sdk/issues/24914 (compilation time-outs).

This status file update gets us moving pending further investigation.

Aside: I'm using the big glob hammer here since we're certain to see more failures as we re-enable cli tests moving forward.

R=paulberry@google.com

Review URL: https://codereview.chromium.org/1464833002 .
 2015-11-20 09:18:06 -08:00
William Hesse ebf8830dd2 Mark analyzer summary_test as slow. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1435893005 .
 2015-11-13 17:49:04 +01:00
Paul Berry ca2721b5b4 Disable codegen test on browsers, since it uses dart:io 
TBR=scheglov@google.com

Review URL: https://codereview.chromium.org/1414073006 .
 2015-11-04 13:12:02 -08:00
William Hesse b1ee818ba8 Update status for slow analyzer tests. 
Alphabetize and combine status file sections.

BUG=dartbug.com/21628
R=wibling@google.com

Review URL: https://codereview.chromium.org/1424483003 .
 2015-11-03 11:39:15 +01:00
William Hesse ef5f949c86 Update status for dartium tests. 
BUG=https://github.com/dart-lang/sdk/issues/24795
BUG=https://github.com/dart-lang/sdk/issues/24571
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1407113009 .
 2015-11-02 16:19:59 +01:00
Asger Feldthaus 3634c3998a dart2js: Bugfix for when 'await' occurs in an initializer list. 
If the JS ast contains an initializer list:

  var x = foo(), y = await x;

It would be retained as a single statement and generate invalid output
that awaits 'x' before it has been defined.

CLOSES=23997

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org/1427593003 .
 2015-10-27 11:36:57 +01:00
Paul Berry c5f4af4df6 Rework task model graphing to work on buildbots. 
This CL reworks the task model grapher (formerly at
pkg/analyzer/tool/task_dependency_graph.dart, now at
pkg/analyzer/tool/task_dependency_graph/generate.dart) so that it
works similarly to the code generation in the analysis server.
Namely, the output file is stored in source control
(pkg/analyzer/tool/task_dependency_graph/tasks.dot), and a test run by
the buildbots verifies that it is up to date.  If it is not, the test
outputs the command necessary to update it.

This carries the benefit that:

- Anyone with access to an installation of graphviz can generate the
  task model graph easily from its .dot file.

- Any time a change occurs that affects task model dependencies, a
  test failure will prompt us that we need to generate a new .dot
  file.

- If a change ever occurs that breaks the ability of the task
  dependency grapher to produce the graph, a test failure will prompt
  us.

The downside is that when making a change that affects task model
dependencies, it is now necessary to re-run the script
pkg/analyzer/tool/task_dependency_graph/generate.dart to avoid a test
failure.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1408743006 .
 2015-10-19 09:24:18 -07:00
William Hesse 874a1e0119 Update status for analysis_server tests. 
BUG=https://github.com/dart-lang/sdk/issues/24597
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1402873005 .
 2015-10-15 16:39:58 +02:00
William Hesse 6c8a1a7f87 Increase timeout for analysis_server tests in debug mode. 
BUG=https://github.com/dart-lang/sdk/issues/24596
BUG=https://github.com/dart-lang/sdk/issues/24597
R=ricow@google.com

Review URL: https://codereview.chromium.org/1399243006 .
 2015-10-15 15:08:40 +02:00
Asger Feldthaus c4b418a2c3 dart2js cps: Updated status file for host-checked mode. 
BUG=

Review URL: https://codereview.chromium.org/1402943003 .
 2015-10-13 15:31:40 +02:00
Asger Feldthaus f1a40e23c1 dart2js cps: Status updates and minor fixes for host checked mode. 
CPS should now run the test suite cleanly in host-checked mode. Let's keep it that way.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1377323003 .
 2015-10-02 15:36:21 +02:00
keertip 18b68f7290 remove docgen remnants from repo, update CHANGELOG 
BUG=
R=alanknight@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//1361163002 .
 2015-09-23 10:27:15 -07:00
Karl Klose e28e578731 dart2js cps: Support sync* and yield. 
R=asgerf@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1353843002 .
 2015-09-23 11:01:34 +02:00
Karl Klose d9caf4a725 Move cps-ir section to the end of the file and update test expectations. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1312583008 .
 2015-09-07 15:37:39 +02:00
Sigmund Cherem 1f349aeaef Skip lookup map tests in dartium 
TBR=sra@google.com

Review URL: https://codereview.chromium.org//1323143007 .
 2015-09-04 16:28:29 -07:00
Sigmund Cherem f348b8b01c Add version validation for LookupMap, also add unittest directly in LookupMap (take 2) 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1308993008 .
 2015-09-04 14:24:26 -07:00
Sigmund Cherem 9b8c06d225 Revert "Add version validation for LookupMap, also add unittest directly in LookupMap." 
This reverts commit fc582d7a3d due to lots of redness

TBR=sra@google.com

Review URL: https://codereview.chromium.org//1318003006 .
 2015-09-04 14:05:41 -07:00
Sigmund Cherem fc582d7a3d Add version validation for LookupMap, also add unittest directly in LookupMap. 
R=sra@google.com

Review URL: https://codereview.chromium.org//1312943007 .
 2015-09-04 13:59:50 -07:00
Asger Feldthaus 0216e21efc dart2js cps: Use 'this' instead of receiver-arg when possible. 
This fixes a bug in how intercepted super calls were handled,
and enables the redundant receiver optimization.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1312393002 .
 2015-08-26 16:06:41 +02:00
Karl Klose 6820b95c1c dart2js cps: update test expectations. 
TBR=kmillikin@google.com

Review URL: https://codereview.chromium.org//1303333003 .
 2015-08-24 10:59:15 +02:00
Johnni Winther 6631698ee8 Mark long running analyzer tests as slow for dart2js. 
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1296243006.
 2015-08-18 11:46:59 +02:00
Asger Feldthaus 0210c5c035 dart2js cps: Fix treatment of captured type variables. 
CLOSES=24064
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1286113003.
 2015-08-13 13:35:50 +02:00
Karl Klose bafb8fb191 dart2js cps: Support async/await by rewriting the JavaScript AST. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1253333002 .
 2015-08-07 11:27:40 +02:00
Florian Loitsch 277bfc3355 Update status files. 
Review URL: https://codereview.chromium.org//1269023006 .
 2015-08-04 14:16:14 +02:00
Karl Klose 2a137d16db dart2js cps: Fix performance issues in optimization passes. 
Type propagation, shrinking reductions, and let sinking each took
more than 2 minutes on a stress test, where now they take a few
seconds.

Huge hash tables (Map/Set) were a big problem, especially when used as
worklists.

Let sinking had an issue with a linear-time search for the enclosing
continuation of an expression. This has been replaced with a visitor
state.

The stress test was:

  tests/co19/src/LibTest/collection/ListBase/ListBase_class_A01_t02

This was only slow because negative constants get translated to
intercepted calls. That itself should be fixed, but the IR should
still be able to handle the stress.

The change in shrinking reductions altered the redex priority from
FIFO to LIFO which has a negative effect on code quality in
unwrapException (in any test case with a try/catch). It seems like
an existing issue that has surfaced.

Since I am going on vacation, I ask that someone would please
commit this on my behalf (assuming things are looking good).
--asgerf

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1252883003 .
 2015-07-27 12:12:06 +02:00
Asger Feldthaus 7d8067135c dart2js cps: Support 'on T' clauses without a 'catch'. 
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1247333003.
 2015-07-23 12:39:10 +02:00
Karl Klose 0869c5ca4a dart2js cps: Update test expectations. 
TBR=asgerf@google.com

Review URL: https://codereview.chromium.org//1240253002 .
 2015-07-20 14:40:37 +02:00
Karl Klose 04dacd24f4 Remove functions white-listed for use of try-finally and switch, add JS_SET_CURRENT_ISOLATE. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1237573002 .
 2015-07-14 10:26:38 +02:00
Karl Klose 3fe9309c96 dart2js cps: Implement compilation of redirecting factory constructors for reflection. 
Without reflection, redirecting factory constructor invocations are shortcut at the instantiation site.  With reflection, code like
  reflectClass(Foo).newInstance(const Symbol(''), [])
can hit a redirecting factory constructor and we need to emit a function that does the redirection and type substitution.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1227873004 .
 2015-07-09 14:54:23 +02:00
Florian Loitsch 1b372b8fe5 Mark another analyzer test as slow. 
Review URL: https://codereview.chromium.org//1226043002 .
 2015-07-08 17:03:01 +02:00
Karl Klose 71e2bec0a5 dart2js cps: Support JS_CURRENT_ISOLATE. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1222913003 .
 2015-07-07 15:55:13 +02:00
Asger Feldthaus 34302b1320 dart2js cps: Translate synthesized mixin constructors. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1216593002.
 2015-06-29 15:28:40 +02:00
Asger Feldthaus ec55d46148 dart2js cps: Fix translation of local constants. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1211393003.
 2015-06-29 14:32:49 +02:00
Paul Berry db6c95502a Work around naming conflict in analyzer's Resource class. 
Commit f8ce36df55 introduced an SDK
class called "Resource", causing warnings to appear in any files that
reference the analyzer class with the same name.  (Fortunately there
was no regression in functionality since the spec requires the name
conflict to be resolved in favor of the definition that is outside the
SDK).

As a short term workaround to avoid the warnings, we are explicitly
importing 'dart:core' and hiding the new Resource class.  In a future
CL, we plan to rework analyzer's Resource class in order to make some
changes necessary for ".packages" file support; when that happens we
will probably rename the class to avoid the name conflict.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1215753003.
 2015-06-26 13:00:44 -07:00
Lasse R.H. Nielsen f8ce36df55 Add Resource class. Currently unimplemented. 
R=herhut@google.com, iposva@google.com

Committed: 2890a7a2a9

Review URL: https://codereview.chromium.org//1181663002.
 2015-06-26 11:42:02 +02:00
Asger Feldthaus fceb7f00dc dart2js cps: Handle checks against mutable and extendable lists. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1206873003.
 2015-06-25 15:03:00 +02:00
Kevin Millikin b9192ab9e2 dart2js CPS: Support try/catch/finally. 
Support try/catch/finally by pretending it is macro-expanded into
try/catch and try/finally:

    try S0 catch (ex, st) S1 finally S2
    ==>
    try { try S0 catch (ex, st) S1 } finally S2

The duplicated code for try/catch and try/finally is abstracted into a
function parameterized over translations for all the parts that
differed.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1207703002.
 2015-06-24 17:13:15 +02:00
Kevin Millikin 089ed2965b Implement try/finally by inlining the finally code. 
Try/finally is implemented by inlining.  There is a try/catch to catch
exceptions in the try block.  The catch body contains the finally code
followed by a rethrow.  The code for finally is translated again after the
normal exit of the try block.  Break, continue, and return exits in the try
block have the finally code inlined just before the exit is taken.

Try/catch/finally is not yet supported, it requires some changes to the
assigned variables analysis.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1201983002.
 2015-06-24 10:12:42 +02:00
Asger Feldthaus 56158b54a1 dart2cps: Fix bug in constructors. 
When visiting another constructor, the visitor must use another tree elements mapping (and source file info).

BUG=
R=floitsch@google.com

Committed: 4a1e6c7966

Reverted: 382319fe70

Review URL: https://codereview.chromium.org//1200823002.
 2015-06-23 10:55:02 +02:00
Asger Feldthaus 382319fe70 Revert "dart2cps: Fix bug in constructors." 
This reverts commit 4a1e6c7966.

TBR=floitsch@google.com

BUG=

Review URL: https://codereview.chromium.org//1195393005.
 2015-06-22 19:35:24 +02:00
Asger Feldthaus 4a1e6c7966 dart2cps: Fix bug in constructors. 
When visiting another constructor, the visitor must use another tree elements mapping (and source file info).

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1200823002.
 2015-06-22 17:53:47 +02:00
Kevin Millikin 7a853ca634 Fix a bug in dart2js's shrinking reductions. 
When a term is deleted, the algorithm searches for new redexes created
by the term's deletion.  Continuation beta redexes search up the term
between the redex and the continuation's binding to ensure that the
continuation is not moved into the scope of an exception handler.

This search fails if it first encounters the root of the deleted
subterm (i.e., the newly-created redex is in the deleted term).  Just
ignore the redex in that case, since the term is being deleted.

Also, update some triaged test expectations with their bug numbers.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1196323002.
 2015-06-22 16:50:48 +02:00
Kevin Millikin bf595224d5 Implement simple switch statements as nested if/else. 
Simple switch statements that do not have continue to labeled cases
are compiled into a chain if/else comparisons.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1191193005.
 2015-06-22 11:29:31 +02:00
Karl Klose 3f46181244 cps-ir: Support foreign code. 
R=kmillikin@google.com

Committed: a120ee7c90

Reverted: 40ed0daaaf

Review URL: https://codereview.chromium.org//1185633003.
 2015-06-19 13:44:58 +02:00
Karl Klose 684214af2b Mark more analyzer tests as slow. 
R=whesse@google.com, brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1190313002.
 2015-06-19 13:03:03 +02:00
Karl Klose 40ed0daaaf Revert "cps-ir: Support foreign code." 
This reverts commit a120ee7c90.

TBR=kmillikin@google.com

Review URL: https://codereview.chromium.org//1196443002.
 2015-06-18 13:37:52 +02:00
Karl Klose a120ee7c90 cps-ir: Support foreign code. 
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1185633003.
 2015-06-18 13:09:50 +02:00
Karl Klose e5b0034f69 Mark pkg/analyzer/test/src/context/context_test as Timeout on dart2js. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1193513003.
 2015-06-17 11:03:56 +02:00
Karl Klose bb45376735 Update dart2js-cps_ir status files. 
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1191433002.
 2015-06-15 12:50:58 +02:00
Karl Klose e4b56654ff Update dart2js-cps_ir test expectations with better annotations. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1181613003.
 2015-06-11 10:56:56 +02:00
Karl Klose 6cffe227fe Update dart2js-cps_ir test expectations after bac7481d3d. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1171773004.
 2015-06-09 15:12:18 +02:00
pq 2c5e890fc7 Build fixes. 
Long tail of fixes related to moving out of `pkg_tested`.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1162423002
 2015-06-03 14:03:15 -07:00
Karl Klose 95a46fb177 Adjust cps_ir test expectations. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1167673009
 2015-06-02 11:26:26 +02:00
Asger Feldthaus a498d811e6 Skip analyzer2dart tests. 
BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1151533003
 2015-05-27 14:13:03 +02:00
Karl Klose 36d3e0d0e6 Update cps-ir test expectations. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1152133003
 2015-05-22 09:58:58 +02:00
Natalie Weizenbaum e7a1c3c585 Remove the core library stubbing infrastructure. 
This hasn't been used in a long time. It's just clutter now.

R=ahe@google.com

Review URL: https://codereview.chromium.org//1134583005
 2015-05-18 12:42:36 -07:00
karlklose@google.com 9b32c9e673 Implement raw list checks. 
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1123343008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45762 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-13 11:58:45 +00:00
asgerf@google.com f5f1eb643d dart2js cps: Introduce GetStatic/SetStatic. 
The GetStatic is used for reading static fields and tearing off
static methods.

Invoking a static getter/setter (not from a field) is still an
InvokeStatic, which IMO is the way it should remain.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45735

Reverted: https://code.google.com/p/dart/source/detail?r=45737

Review URL: https://codereview.chromium.org//1134063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45738 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-12 14:19:40 +00:00
asgerf@google.com 961c805398 Revert "dart2js cps: Introduce GetStatic/SetStatic." 
This reverts commit 28e4518df87c72cb8e23fe6d73b7750ad0f2183a.

TBR=karlklose@google.com

BUG=

Review URL: https://codereview.chromium.org//1136523008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45737 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-12 13:53:15 +00:00
asgerf@google.com 2c90643171 dart2js cps: Introduce GetStatic/SetStatic. 
The GetStatic is used for reading static fields and tearing off
static methods.

Invoking a static getter/setter (not from a field) is still an
InvokeStatic, which IMO is the way it should remain.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1134063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45735 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-12 13:35:49 +00:00
karlklose@google.com 0eaa4d4717 cps-ir: Support compilation of methods that use interceptor calling convention. 
This is a modified version of sra@'s CL https://codereview.chromium.org/1020243002/ with kmillikin@'s comments addressed.

R=sigurdm@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1109403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45680 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-11 12:38:14 +00:00
asgerf@google.com 9630163eaf dart2js cps: Handle error cases. 
A new IR node CreateInvocationMirror has been introduced, which is
needed for creating calls to noSuchMethod. The main reason for this node
is that the JS constructor for Invocation objects require the internal
(minified) name of the target, which the builder does not know.
I don't think the IR pipeline should depend on the Namer, so the IR node
is preserved all the way to codegen.

R=floitsch@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1130813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45678 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-11 09:06:12 +00:00
kmillikin@google.com 6ab3c55366 Fix an assertion failure in dart2js. 
In the CPS translation we assert that a mutable variable added to the CPS
term belongs to the function currently being compiled, which is reasonable.
However, in the JS backend this didn't work as written.  The variable
element can report that it belongs to a Dart function, and the function
currently being compiled can be a synthesized .call method of a closure
class representing that Dart function.

The solution presented here is to plumb the mapping from Dart function to
closure class .call methods through to where the mutable variables are
created.  It might be better, but a lot more complicated, to make the
variable elements able to correctly report their owner after closure
conversion.

R=asgerf@google.com, karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//1084413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45636 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-08 08:58:00 +00:00
ricow@google.com e92f697236 Remove dart2dart support from testing scripts and status files 
I will leave it to the dart2js people to remove the support from the dart2js tools (there is also a bunch of comments still in code, do a git grep)

R=kustermann@google.com, floitsch@google.com, kmillikin@google.com
BUG=

Review URL: https://codereview.chromium.org//1126363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45588 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-07 11:29:55 +00:00
kevmoo@google.com cc78dfeaee remove pkg/mock 
Moved to https://github.com/dart-lang/mock

R=ricow@google.com

Review URL: https://codereview.chromium.org//1115483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45442 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-28 20:46:31 +00:00
nweiz@google.com 70a846ad6c Update pubspecs and dependencies to get pkgbuild tests working. 
This also removes the vendored copy of Angular, which was an outdated version of
an unstaffed branch.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1058283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45410 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-24 20:08:53 +00:00
karlklose@google.com e8fa15c30a Update dart2js-cps_ir test expectations. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1091143003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45371 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-23 08:40:49 +00:00
pquitslund@google.com 49d0f16a2a Analyzer CLI removal. 
CLI now lives in dedicated `analyzer_cli` package.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1102613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45362 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-22 20:32:05 +00:00
karlklose@google.com 7dd2608820 Adjust test expectations for dart2js-cps-ir. 
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1092013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45236 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-17 11:45:51 +00:00
zra@google.com 86bfd7cb30 Adds a simarmv5te build and test target. 
Also:
- Removes command line flags to choose simulated arm version.
  I think we should use build targets instead, like in this change,
  to make building and testing more obvious.
- Skips pkg tests on all simulators.

R=regis@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//1077823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45181 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-15 20:44:43 +00:00
karlklose@google.com d839c64766 Establish test expectations for dart2js running with the CPS based backend. 
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45162 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-15 11:44:02 +00:00
zra@google.com 34044a4ca8 Adds armv5 build and test target. 
R=regis@google.com

Review URL: https://codereview.chromium.org//1043263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44828 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-31 23:11:33 +00:00
whesse@google.com 745b6809e9 Update test status for flaky tests. 
BUG=dartbug.com/22695, dartbug.com/22896
R=ricow@google.com

Review URL: https://codereview.chromium.org//1019463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44557 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-18 12:45:50 +00:00
ricow@google.com 2d558d3c79 Skip dart integration tests on vm debug mode 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1005903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44448 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-13 07:50:44 +00:00
johnniwinther@google.com 5130b19fb7 Fix warning in analyzer2dart. 
BUG=http://dartbug.com/22418
R=floitsch@google.com

Review URL: https://codereview.chromium.org//982543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44230 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-04 13:20:48 +00:00
kevmoo@google.com be8aca929d Move more tests to SkipByDesign 
R=whesse@google.com

Review URL: https://codereview.chromium.org//932493004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43977 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-23 21:31:12 +00:00
scheglov@google.com 01126e0213 Issue 22492. Increase number of event pumping cycles. 
I'm not sure if it is going to fix the problem.
I cannot reproduce it with x86 release build on Win7.
But that's the best guess I have.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22492

Review URL: https://codereview.chromium.org//944013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43922 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 18:35:06 +00:00
floitsch@google.com 27a30ee1de dart2js: Support isDeferred on DependencyMirrors. 
BUG= http://dartbug.com/22475
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//924393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43905 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-20 10:37:44 +00:00
iposva@google.com 6bb78fd867 - Mark flaky test. 
Review URL: https://codereview.chromium.org//937113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43881 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-19 16:55:54 +00:00
paulberry@google.com dffb8c8a68 Status updates for issue 22475. 
TBR=rmacnak@google.com

Review URL: https://codereview.chromium.org//938593004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43843 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-18 15:18:39 +00:00
kevmoo@google.com 4cc4e28411 status files: trying out new SkipSlow flag 
and selectively used SkipByDesign in more places

R=whesse@google.com

Review URL: https://codereview.chromium.org//928523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43815 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-17 17:21:39 +00:00
paulberry@google.com d3c4d57a5b Update status file for bug 22418 
TBR=johnniwinther@google.com

Review URL: https://codereview.chromium.org//920043006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43769 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-13 16:55:17 +00:00
paulberry@google.com 6ea61b5686 Partial backport of analyzer async/await fixes to Java. 
Backport of r43613, r43537, r43446, r43427, r43424, r43418, r43403,
r43361 to the Java-based analyzer.  The backport is partial in that
the TypeProvider was not modified to include Future and Stream types
(this would have required substantial additional effort), and
consequently not all static warnings are correctly produced.  However,
all NonErrorResolverTest cases were successfully backported and pass,
meaning that the Java-based analyzer shouldn't produce false positive
warnings for async/await code anymore.

BUG=dartbug.com/22252
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//913623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43655 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-10 16:04:50 +00:00
kustermann@google.com f082c82e46 Mark analyzer/test/enum_test as Slow 
R=floitsch@google.com

It takes close to 1 minute for dart2js to analyze the test.

Review URL: https://codereview.chromium.org//895413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43469 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 15:14:09 +00:00
paulberry@google.com 7865c0f4e7 Mark more dartanalyzer tests as failing due to bug 22252. 
TBR=scheglov@google.com

Review URL: https://codereview.chromium.org//886393007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43450 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-04 00:08:26 +00:00
johnniwinther@google.com 93fef72fb3 Update analyzer and dartium status. 
BUG=

Review URL: https://codereview.chromium.org//900513004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43386 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-03 09:53:31 +00:00
lrn@google.com 66d962870f Update pkg/docgen status file to mark test failing. 
BUG= http://dartbug.com/22233

Review URL: https://codereview.chromium.org//861353004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43351 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-02 09:03:08 +00:00
jwren@google.com a7083c8040 Disable test for windows pkg bots, issue 22180 
R=pquitslund@google.com

Review URL: https://codereview.chromium.org//892673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43342 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-30 17:49:35 +00:00
pquitslund@google.com 20f7af4eb6 Status file update to reflect now passing enum_test (dartbug.com/21323). 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//879013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43200 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 19:14:12 +00:00
scheglov@google.com ebe4a73060 Disable analysis_server tests on dart2js to avoid bug in dart2js. 
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//883543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43167 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 00:51:22 +00:00
whesse@google.com 459a39c7fb Mark 2 analysis server tests as slow. 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//826293005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42997 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-19 15:56:08 +00:00
whesse@google.com 67a09576b0 Update status for co19 tests on safari 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//863443004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42994 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-19 15:06:10 +00:00
floitsch@google.com d052ab5278 Mark analysis test as slow. 
Review URL: https://codereview.chromium.org//863473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42991 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-19 14:42:01 +00:00
whesse@google.com ca69477f4e Update co19 status and timing-out tests. 
BUG=dartbug.com/22050
R=ricow@google.com

Review URL: https://codereview.chromium.org//851683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42803 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 12:24:30 +00:00
whesse@google.com 1a92824c85 Update co19 status on firefox and chrome. 
Update status for two timing out tests, and co19 on Android.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//825353007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42782 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 17:51:08 +00:00
paulberry@google.com c35a4acd9c Fix order of operations dependencies in element_references_test 
It's not safe for a single test to have two overlapping calls to
findElementReferences() because fields in the test class are used to
hold the search results and to keep track of whether more results are
pending.

Fixes a bogus test failure that arose after the relative ordering of
futures and microtasks was changed.

BUG=dartbug.com/22014
R=scheglov@google.com

Review URL: https://codereview.chromium.org//842803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42738 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 16:36:42 +00:00
iposva@google.com 7aa23bdf10 Make pkg tests green. See issue 22014. 
Review URL: https://codereview.chromium.org//836403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42674 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-07 22:44:00 +00:00
sigmund@google.com f883904226 Skip tests for unittest in dartium. These tests are now covered by the package bots and are not meant to be executed in the Dart bots anymore. 
Note that once we fix issue 21949, these tests are not going to be run anyways (tests in
third_party/pkg/ are not executed by the Dart bots). So we can delete this line once we fix that bug.

BUG=

Review URL: https://codereview.chromium.org//819913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42551 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-22 18:54:54 +00:00
nweiz@google.com 4b524e8f21 Pull args, intl, logging, shelf, and source_maps out of the SDK. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//814113004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42537 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-20 00:47:32 +00:00
nweiz@google.com 55d9da7005 Re-add http_server to pkg.status. 
TBR

Review URL: https://codereview.chromium.org//819473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42527 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 21:54:51 +00:00
nweiz@google.com b0009de0d6 Re-apply "Remove unittest and matcher from the repo." 
This was originally submitted as r42497 and reverted by r42498. This CL fixes
the failing isolate test, and https://codereview.chromium.org/814883003/ fixes
the Dartium and Standalone issues.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//807193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42524 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 21:14:56 +00:00
jakemac@google.com f911db978d delete web_components 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//819653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42519 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 18:33:11 +00:00
jakemac@google.com c35b8c5c18 remove code-transformers from the repo 
Review URL: https://codereview.chromium.org//820513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42514 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 17:21:57 +00:00
ricow@google.com efad8e46a1 Revert revision 42497 "Remove unittest and matcher from the repo." 
This broke 80% of the bots


git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42498 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 07:01:50 +00:00
nweiz@google.com 28bced3a0c Remove unittest and matcher from the repo. 
This also cleans up a few lingering unused lines in pkg.status.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//814953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42497 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-19 02:18:47 +00:00
jakemac@google.com 4c4e722480 remove smoke from the repo 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//802703004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 22:38:15 +00:00
jakemac@google.com 05b372ad0e delete observe from the repo 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//817483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42481 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 22:13:41 +00:00
jakemac@google.com 523c0f019b delete template binding from the repo 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//815843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42476 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 20:27:05 +00:00
jakemac@google.com 0c6a36fc67 remove polymer expressions from the repo 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//814073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42475 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 20:15:47 +00:00
nweiz@google.com bfe623d70a Delete a bunch of packages that are now on GitHub. 
This CL doesn't delete barback or http, since their exact location is
used by pub's test runner and build infrastructure respectively. I'll
send out individual CLs for them.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//812253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42467 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 19:00:59 +00:00
sigmund@google.com 4979504845 Delete polymer from the Dart repo. 
Code now lives at: https://github.com/dart-lang/polymer-dart

Bots covering the polymer tests can be seen at:
build.chromium.org/p/client.dart.packages/console

Or to filter just the polymer bots:
build.chromium.org/p/client.dart.packages/console?builder=packages-windows-polymer-dart&builder=packages-linux-polymer-dart&builder=packages-mac-polymer-dart

R=jakemac@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//794473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42461 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 17:22:53 +00:00
johnniwinther@google.com 2b9de73a47 Fix analyzer2dart end2end. 
BUG=http://dartbug.com/21872
R=karlklose@google.com

Review URL: https://codereview.chromium.org//812333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42453 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 10:19:40 +00:00
nweiz@google.com 1f03c49548 Remove pkg/glob from the repo. 
See also https://codereview.chromium.org/812873004/, which adds it via
third_party.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//796933005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42448 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-18 01:14:13 +00:00
floitsch@google.com 28451ab031 analyzer2dart: Update status file. 
Review URL: https://codereview.chromium.org//798233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42357 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-13 17:34:46 +00:00
paulberry@google.com c0d348575c Disable completion_test on debug builds (it times out). 
TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//792463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42211 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-09 17:18:33 +00:00
srdjan@google.com f95a58d882 Revert disabled test (r42196). 
Review URL: https://codereview.chromium.org//786893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42200 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-09 00:48:29 +00:00
srdjan@google.com e718ae0eab Disable failing 'with_test_environment_test' until investigated. 
Review URL: https://codereview.chromium.org//790573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42196 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-08 23:03:22 +00:00
jakemac@google.com 31c524cdca update to polymer js 0.5.1 
BUG= http://dartbug.com/21583
R=sigmund@google.com

Review URL: https://codereview.chromium.org//723393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42114 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-04 17:13:11 +00:00
whesse@google.com 7254f7b649 Update status for Firefox 34. 
BUG=dartbug.com/21787, dartbug.com/21526
R=ricow@google.com

Review URL: https://codereview.chromium.org//752173007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42107 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-04 15:17:59 +00:00
paulberry@google.com c1dc29c378 Mark analyzer's all_the_rest_test as failing on Windows. 
BUG=dartbug.com/21772
TBR=scheglov@google.com

Review URL: https://codereview.chromium.org//771303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42075 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-02 20:53:53 +00:00
alanknight@google.com 051984b521 Update status file for new VM-only tests 
BUG=

Review URL: https://codereview.chromium.org//771293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42074 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-02 20:41:26 +00:00
ricow@google.com 4cf6fb7f33 Mark pkg/analyzer/test/generated/incremental_resolver_test as slow on dart2js targets 
Review URL: https://codereview.chromium.org//752823003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41948 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-25 10:01:34 +00:00
paulberry@google.com 651d589c2f Remove flaky check from reanalyze_concurrent_test. 
This should avoid sporadic false failures with this test.  If in the
future we genuinely regress bug 21448, there is a danger that this
test won't catch it reliably, but that is mitigated by the fact that
(a) even flaky failures do get noticed, and (b) the bug was severe
enough that it probably would be noticed in manual testing.  The extra
risk seems worth it to avoid the sporadic false failures we've been
seeing.

BUG=dartbug.com/21638
R=scheglov@google.com

Review URL: https://codereview.chromium.org//724403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41870 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-20 22:52:30 +00:00
rnystrom@google.com 9a5ad9c7d6 Fix glob list failure on Windows. 
BUG=https://code.google.com/p/dart/issues/detail?id=21622
R=nweiz@google.com

Review URL: https://codereview.chromium.org//738863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41811 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-18 22:19:27 +00:00
scheglov@google.com b8da9bc651 Format and sort analyzer and analysis_server packages. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//725143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41792 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-17 22:23:53 +00:00
nweiz@google.com 29cad5e093 Mark glob/list_test failing on Windows 
R=rnystrom@google.com
BUG=21622

Review URL: https://codereview.chromium.org//730733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41754 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-15 00:36:15 +00:00
ricow@google.com 61da64c332 Skip timing out tests on IE 
R=whesse@google.com

Review URL: https://codereview.chromium.org//724823006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41739 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-14 12:36:40 +00:00
jakemac@google.com ca29633cc2 use shared code transformer, update web_components to remove .map and .concat files 
This is a redo of https://codereview.chromium.org/540633002/ because I had deleted my local branch and didn't know how to recover it.

Review URL: https://codereview.chromium.org//724723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41724 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-13 17:47:20 +00:00
whesse@google.com 89c156d596 Suppress flaky polymer tests on Safari 
BUG=dartbug.com/21434
R=ricow@google.com

Review URL: https://codereview.chromium.org//713283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41666 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-11 14:37:34 +00:00
nweiz@google.com 4a582ba08d Mark the source_span file test as passing. 
R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//700923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41615 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-07 21:11:33 +00:00
whesse@google.com 0198159166 Suppress failing test source_span/test/file_test. 
BUG=dartbug.com/21533
R=lrn@google.com

Review URL: https://codereview.chromium.org//693393005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41593 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-07 08:42:47 +00:00
scheglov@google.com 60f01fdf36 Issue 20436. Restore analysis_server/test/integration/search/get_type_hierarchy_test on Windows. 
I think it is fixed.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//695133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41589 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 22:27:37 +00:00
paulberry@google.com 7225ac4794 Enable asynchrony test. 
This test passes now that dartbug.com/21252 has been fixed.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//700723006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41579 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 19:39:20 +00:00
whesse@google.com eb3c3e9381 Update status for flaky dartium tests. 
BUG=dartbug.com/18931
R=ricow@google.com

Review URL: https://codereview.chromium.org//708503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41567 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-06 16:58:44 +00:00
johnniwinther@google.com 09fbe78e71 Move dart2js from sdk/lib/_internal/compiler to pkg/compiler 
BUG=

Review URL: https://codereview.chromium.org//694353007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41514 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-05 08:51:01 +00:00
johnniwinther@google.com 8637cfd322 Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler" 
This reverts commit r41512.

BUG=

Review URL: https://codereview.chromium.org//693183006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41513 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-05 08:15:26 +00:00
johnniwinther@google.com 2b336e17f0 Move dart2js from sdk/lib/_internal/compiler to pkg/compiler 
BUG=

Review URL: https://codereview.chromium.org//690103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41512 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-05 07:09:04 +00:00
paulberry@google.com d55ac5e968 Disable integration test reanalyze_concurrent_test on debug buildbots. 
It is timing out.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//701563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41463 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-03 18:16:42 +00:00
sigmund@google.com 83cb5a410a Remove deprecated packages from the repo 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//695603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41429 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 22:57:29 +00:00
whesse@google.com 2db6b324e1 Update Safari status files. 
BUG=dartbug.com/21434

Review URL: https://codereview.chromium.org//687353006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41415 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-30 10:17:19 +00:00
whesse@google.com 53264f42c0 Mark tests flaky on Safari 6.2 
BUG=dartbug.com/21434
R=ricow@google.com

Review URL: https://codereview.chromium.org//659173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41393 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-29 10:30:25 +00:00
whesse@google.com aeba67e44e Add builder tag for Safari 6.2 slave. Update status files for Safari 6.2. 
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//679153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41323 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-27 16:09:00 +00:00
paulberry@google.com 7611c5415a Add an integration test to verify that server I/O is asynchronous. 
Currently disabled, since server I/O is currently synchronous.

BUG=dartbug.com/21252
R=danrubel@google.com

Review URL: https://codereview.chromium.org//668953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41246 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-22 15:48:06 +00:00
floitsch@google.com 32ef6273ae Mark some analyzer/analysis_server tests as slow. 
R=ricow@google.com

Review URL: https://codereview.chromium.org//656163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41147 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-16 13:16:09 +00:00
ricow@google.com c416ea097d Mark the analyzer tests slow generally on dart2js 
We are seeing these flake on several bots

Review URL: https://codereview.chromium.org//645063003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41140 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-16 06:31:54 +00:00
floitsch@google.com 5c2ad49d55 Mark analyzer test as slow. 
Review URL: https://codereview.chromium.org//655223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41129 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-15 13:47:50 +00:00
floitsch@google.com 9a8c878d48 Mark analyzer test as failing. 
Add minimal example to lib/mirrors.

R=ricow@google.com

Review URL: https://codereview.chromium.org//655803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41097 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-14 13:44:38 +00:00
paulberry@google.com 69d1c6fb2b Disable test "check_all_test" on debug builds. 
The only purpose of this test is to verify that analysis server code
generation is up to date, so it is sufficient to just run it on the
release buildbots, where is completes more quickly.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//651953005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41086 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-13 21:49:50 +00:00
paulberry@google.com febb8f2e22 Split up large resolver_test.dart file. 
This splits the four largest classes out of resolver_test.dart
and into their own files.  Hopefully this should help prevent
resolver_test.dart from timing out on the buildbots.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//656543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41085 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-13 21:43:33 +00:00
paulberry@google.com 47f8e15878 Mark analyzer "resolver_test" as slow. 
This file contains 1713 unit tests and should be split up into smaller
files.

TBR=scheglov@google.com

Review URL: https://codereview.chromium.org//643303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41052 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-10 20:40:48 +00:00
ricow@google.com aaa40e8855 Mark pkg/analyzer/test/generated/engine_test as skip on dart2js 
It is flaky timing out

R=paulberry@google.com

Review URL: https://codereview.chromium.org//642673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41012 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-09 13:04:16 +00:00
vsm@google.com 314dd6e4f6 Status fix 
TBR=leafp@google.com

Review URL: https://codereview.chromium.org//612173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40791 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-29 22:02:59 +00:00
rnystrom@google.com ffa353e9d9 Fix glob list on Windows. 
BUG=https://code.google.com/p/dart/issues/detail?id=21071
R=nweiz@google.com

Review URL: https://codereview.chromium.org//607963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40732 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-26 19:47:39 +00:00
ricow@google.com 19c691bc30 Mark pkg/glob/test/list_test and two pub tests as failing on windows 
pkg/glob/test/list_test is being tracked in issue 21071

The following two pub tests are being tracked in issue 21086
pub/test/global/binstubs/binstub_runs_executable_test
pub/test/global/binstubs/missing_script_test

Review URL: https://codereview.chromium.org//599163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40668 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-25 05:59:08 +00:00
jakemac@google.com 52ef5fe84e mark as flaky not failing 
Review URL: https://codereview.chromium.org//599093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40647 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-24 20:28:45 +00:00
jakemac@google.com fa6a6c0cb3 mark dartium tests as flaky due to 18931 
Review URL: https://codereview.chromium.org//599183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40636 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-24 17:50:20 +00:00
jakemac@google.com a6f50d735b Update to polymer js version 0.4.1 
BUG= http://dartbug.com/21035
R=sigmund@google.com

Review URL: https://codereview.chromium.org//588373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40631 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-24 16:17:56 +00:00
nweiz@google.com 06017fb841 Add support for listing to the glob package. 
R=rnystrom@google.com
BUG=17093

Review URL: https://codereview.chromium.org//549633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40604 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-23 20:40:16 +00:00
whesse@google.com 90c7a56bdd Update status for Dartium tests. 
BUG=dartbug.com/21012, dartbug.com/21000
R=ricow@google.com

Review URL: https://codereview.chromium.org//584803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40491 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 10:22:04 +00:00
kevmoo@google.com 650012e159 fix win11 bots with status changes 
TBR

Review URL: https://codereview.chromium.org//581273006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40487 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 04:20:24 +00:00
kevmoo@google.com 3d056175bc fix pkg status file for unittest 
TBR

Review URL: https://codereview.chromium.org//587523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40484 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 01:45:28 +00:00
kevmoo@google.com 38d6c15539 pkg/scheduled_test: status tweaks 
BUG= https://code.google.com/p/dart/issues/detail?id=21007
R=nweiz@google.com

Review URL: https://codereview.chromium.org//583053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40483 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 01:36:49 +00:00
kevmoo@google.com 5c6bc92daa pkg/scheduled_test updated status file for jsshell 
R=nweiz@google.com

Review URL: https://codereview.chromium.org//583013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40480 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-19 00:06:00 +00:00
kevmoo@google.com 02e029636b pkg/metatest: adding homepage to metatest pubspec 
TBR

Review URL: https://codereview.chromium.org//585703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40479 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 23:39:45 +00:00
kevmoo@google.com 615819acf9 Sharing metatest logic between unittest and scheduled_test 
R=nweiz@google.com

Review URL: https://codereview.chromium.org//524153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40475 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 22:40:13 +00:00
nweiz@google.com 6ee6d6b110 Mark a bunch of tests as passing now that stack_trace works with the new Firefox. 
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//578383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40474 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 22:38:13 +00:00
jakemac@google.com 8c422a0862 fix findController for non-dart elements 
BUG= http://dartbug.com/20931
R=sigmund@google.com

Review URL: https://codereview.chromium.org//582113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40458 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 20:30:56 +00:00
sethladd@google.com b1ae6d0817 remove serialization. it's moved to github 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org//581243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40456 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 20:07:25 +00:00
sethladd@google.com ba1ab7d8f5 Revert "remove serialization. it's moved to github" 
This reverts commit e06d6fbb470445cdbd7875a7aa24f5ecb6ee04d4.

BUG=

Review URL: https://codereview.chromium.org//584473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40451 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 18:30:25 +00:00
sethladd@google.com ca72cda5b6 remove serialization. it's moved to github 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org//572073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40447 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 17:59:10 +00:00
ricow@google.com acb59f47b1 Mark pkg/analysis_server/test/socket_server_test as slow on jsshell 
R=eernst@google.com

Review URL: https://codereview.chromium.org//579173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40431 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 10:49:18 +00:00
karlklose@google.com c1597202c4 Fix typo in previous CL. 
TBR=johnniwinther@google.com

Review URL: https://codereview.chromium.org//577153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40425 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-18 07:17:08 +00:00