Commit graph

868 commits

Author SHA1 Message Date
Ari Aye 70a7ef3f58 Implement pointer mixture network
Here we can see the mixture network is assigning probability mass
to a new, project-specific name by reference https://i.imgur.com/6Zbs2qf.png.

I also took this opportunity to decrease model size targeting 100M, in line
with our original size goals.

My initial strategy was to implement a separate pointer network
in https://dart-review.googlesource.com/c/sdk/+/117005 but having
a single network that can assign probability mass across local
references and vocabulary lexemes is better since

1) only one network and model file
2) no need to coalesce predictions from multiple models

Change-Id: I23cfc2ece61ce30bb69785149a5a6cf1604af18d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121461
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-10-14 18:25:56 +00:00
Daco Harkes 9f33e8da04 [vm/ffi] Pointer optimize indexed load and store
Follow up of https://dart-review.googlesource.com/c/sdk/+/117547

This gets rid of unnecessary allocations in hot loops with indexed loads and stores.

Issue: https://github.com/dart-lang/sdk/issues/38172

Change-Id: I37a4b1aba00084e465d47cce79bb9963e1afc104
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-dartkb-linux-debug-simarm64-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-dartkb-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-mac-debug-simdbc64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-reload-mac-release-simdbc64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-precomp-mac-release-simarm_x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119645
Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-10-11 15:54:01 +00:00
pq b716137c90 linter 0.1.101
Change-Id: I9a507ecd0d4756f681f31994c2a31dcb4b347309
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-10-10 17:11:17 +00:00
Samir Jindel 63d3012e68 [vm/ffi] Deprecate Pointer.allocate/free.
Fixes https://dart-review.googlesource.com/c/sdk/+/118442.

Also updates untested sample code in samples/ffi.

Change-Id: Id40a7b8fbb35c5d989269646ebb22864cebcfcac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118441
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-10-10 13:17:43 +00:00
Alexander Thomas 8e33090fd0 [co19] Roll co19 to a8f7aa15ab860a309667168243bda01fda0794df
From this roll on forward, co19_2 is tracking the pre-nnbd branch rather than the master branch in
the co19 repo. The master branch (the NNBD fork of co19) will be re-introduced as a different suite
later.

Issues reported:
https://github.com/dart-lang/co19/issues/492 (ShortCircuitOperators_A01_t12 test is wrong)
https://github.com/dart-lang/co19/issues/493 (ShortCircuitOperators_A04_t27 has a syntax error)
https://github.com/dart-lang/co19/issues/494 (ShortCircuitOperators_A03_t12 is an invalid test)

2019-10-04 irina.arkhipets@gmail.com Issue 490: useless constant-update-2018 option removed from the tests.
2019-10-04 irina.arkhipets@gmail.com Issue 490: useless constant-update-2018 option removed from the tests.
2019-10-04 sgrekhov@unipro.ru Fixes 484. Use floating point value which decimal part
2019-10-04 sgrekhov@unipro.ru Fixes 486. Fix test expectations (method call has higher priority than unary minus)
2019-10-04 sgrekhov@unipro.ru Fixes 483. Use List instead of Iterable
2019-10-04 irina.arkhipets@gmail.com Issue 485, 488: test expectations corrected.
2019-09-30 irina.arkhipets@gmail.com Issue 477: More tests for constant short circuit operations added.
2019-09-30 irina.arkhipets@gmail.com Issue 477: More tests for constant short circuit operations added.
2019-09-25 irina.arkhipets@gmail.com Issue 481: Test expanded into A Function(Null) instead of A Function(A) by the instantiate-to-bound algorithm.
2019-09-23 irina.arkhipets@gmail.com Issue 477: tests for Constant-2019-update added.
2019-09-19 sgrekhov@unipro.ru Fixes 480. Use '==' for checking actual type
2019-09-17 irina.arkhipets@gmail.com Issue 477: tests for Constant-2019-update added.
2019-09-17 irina.arkhipets@gmail.com Issue 477: tests for Constant-2019-update added.
2019-09-17 sgrekhov@unipro.ru NNBD tests removed from this legacy branch
2019-09-16 irina.arkhipets@gmail.com Issue 477: tests for short circuit operators added.
2019-09-13 sgrekhov@unipro.ru 466. Subtyping tests for NNBD added.
2019-09-12 sgrekhov@unipro.ru 466. Subtyping tests for NNBDc. Copyright year updated
2019-09-12 sgrekhov@unipro.ru 466. Subtyping tests for NNBDc. Right Object tests added
2019-09-11 sgrekhov@unipro.ru 464. Added tests for legacy type fields
2019-09-11 irina.arkhipets@gmail.com Issue 465: tests for Generics in NNBD added.
2019-09-10 irina.arkhipets@gmail.com Issue 465: test for Generics in NNBD added.
2019-09-10 sgrekhov@unipro.ru 466. Subtyping tests changed according to NNBD spec
2019-09-09 sgrekhov@unipro.ru 466. Subtyping tests changed according to NNBD spec
2019-09-06 irina.arkhipets@gmail.com Issue 465: tests for Generics in NNBD added.
2019-09-06 sgrekhov@unipro.ru More tests for type Never
2019-09-05 irina.arkhipets@gmail.com Issue 465: tests for Generics in NNBD added.
2019-09-05 sgrekhov@unipro.ru Fix using and checking of Never
2019-09-04 sgrekhov@unipro.ru Fixes 464. Legacy-libraries tests added
2019-09-04 irina.arkhipets@gmail.com Fixed Issue 460: tests for Null promotion added, typos corrected.
2019-09-02 sgrekhov@unipro.ru Fixes 458. More null-aware operators tests
2019-09-02 sgrekhov@unipro.ru Fixes 459. Late fields and variables test added
2019-09-02 sgrekhov@unipro.ru 459. Late fields and variables tests added
2019-08-30 sgrekhov@unipro.ru 459. Late fields and variables tests added
2019-08-29 sgrekhov@unipro.ru 459. Late fields and variables tests added
2019-08-29 sgrekhov@unipro.ru 389. Fixed static warnings processing
2019-08-28 sgrekhov@unipro.ru 458. Null-aware operators tests added
2019-08-27 sgrekhov@unipro.ru 458. Null-aware operators tests added
2019-08-27 sgrekhov@unipro.ru Removed covariant final member
2019-08-27 sgrekhov@unipro.ru Typo and order of modifiers fixed
2019-08-23 sgrekhov@unipro.ru 461. A couple of NNBD nested nullable types tests added
2019-08-23 sgrekhov@unipro.ru 389. NNBD static errors tests. Some tests fixed, several tests added (mainly for legacy libraries)
2019-08-23 sgrekhov@unipro.ru Fixes 389. A couple of legacy types tests added
2019-08-23 sgrekhov@unipro.ru Fixes 461.Conditional expression ambiguities tests added
2019-08-23 sgrekhov@unipro.ru 461. Add nested nullable types tests
2019-08-23 sgrekhov@unipro.ru Fixes 475. Modifier 'late' must be before 'final'
2019-08-22 sgrekhov@unipro.ru 389. NNBD static errors tests. Fixed work with legacy libraries and new tests added
2019-08-22 sgrekhov@unipro.ru 461. NNBD syntax tests added for required and null-aware selector

Change-Id: Icd4d0c536f0091100aa0276ff5b836b16db0ff35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120782
Reviewed-by: William Hesse <whesse@google.com>
2019-10-09 10:36:35 +00:00
Janice Collins 2bcaf02582 Update dartdoc to 0.28.7.
Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v0.28.7

Change-Id: Ib886717148fed3afcb2e397815279c39bb3b0f13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120622
Commit-Queue: Janice Collins <jcollins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Janice Collins <jcollins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2019-10-07 20:43:59 +00:00
pq 2ca8125d7a bump to linter 0.1.100
Change-Id: I4c5a1b4298b7d3161ee6f0f062990b4452c3cf24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-10-04 17:53:05 +00:00
Mike Fairhurst 2590d065f1 Update test_reflective_loader, use @SkippedTest
Change-Id: I17f8da88a4587a7ad51038ca796f138231021fe9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119583
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-10-02 00:02:21 +00:00
pq 470c5eab8e bump to linter 0.1.99
Change-Id: I40f4be96d6fc953ae536203f86360dda6139467a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-10-01 14:31:57 +00:00
Alexander Thomas c09c81123d [infra] Update checked in SDKs to 2.6.0-dev.4.0
Update the checked in SDKs to avoid the dartfmt crash in dart_style
1.3.0 (https://github.com/dart-lang/dart_style/issues/855).

TBR=whesse@google.com

Change-Id: If9ab4036fd5691a87174ff2e7121e5c6ec238e34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119337
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2019-10-01 11:29:32 +00:00
Keerti Parthasarathy a46bb7cb5a Update dartdoc version in DEPS, extension methods support
Change-Id: I53a12a5abd1f7e5783c8fed15c9de9728e88c9e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119105
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
2019-09-27 16:13:04 +00:00
Robert Nystrom 403c4af720 Update dart_style to 1.3.1.
Change-Id: Ie737b02eeeb269299f4b249b7b903ffa1217b68b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119066
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2019-09-26 21:41:45 +00:00
Alexander Thomas 88f35f8319 [infra] Update checked in SDKs to 2.6.0-dev.3.0
Change-Id: Ic5cb95b482bbff5433fc5085c68575854b7e7998
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118984
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2019-09-26 15:25:52 +00:00
Robert Nystrom cff2b10a28 Update dart_style to 1.3.0.
The main changes are support for extension methods and NNBD, but a few
other small formatting tweaks are included too.

Change-Id: I0be45438d6b56ae5854c4677e58623ec93acaa60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118900
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-09-26 07:02:18 +00:00
pq 863694b7eb bump to linter 0.1.98
Change-Id: I7f6893038fb55a441ed9d899d2f78518f27aa952
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118468
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-09-23 22:19:00 +00:00
Ryan Macnak 7305ae6c35 Revert "Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce."
This reverts commit 93f1324449.

Reason for revert: asm build failure for ia32 mac (e.g., simarm)

Original change's description:
> Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce.
> 
> Update usage of PKCS12_parse to PKCS12_get_key_and_certs, since the former changed behavior when the PKCS12 has no private key.
> 
> Change-Id: I040c1a17e2994ac66cf03ad1efa80e423136cdbd
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116828
> Reviewed-by: Jonas Termansen <sortie@google.com>
> Reviewed-by: Zach Anderson <zra@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=sortie@google.com,rmacnak@google.com,zra@google.com

Change-Id: I85e9c4e5bd457b72c7df4986a127c169329c178c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117921
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2019-09-18 21:38:18 +00:00
Ryan Macnak 93f1324449 Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce.
Update usage of PKCS12_parse to PKCS12_get_key_and_certs, since the former changed behavior when the PKCS12 has no private key.

Change-Id: I040c1a17e2994ac66cf03ad1efa80e423136cdbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116828
Reviewed-by: Jonas Termansen <sortie@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2019-09-18 20:02:10 +00:00
Alexander Thomas abb606e613 [release] Update checked in SDKs to 2.5.0
TBR=whesse@google.com

Change-Id: I5400225fd7ae00374843e900aac4edcba52aeca9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116580
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2019-09-10 17:21:54 +00:00
Keerti Parthasarathy bfd0190bf0 Update dartdoc rev in DEPS, fix for break in api doc generation
Change-Id: Iadcf89d62c77939774434d9cbb8e162737162487
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115502
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
2019-09-04 21:56:37 +00:00
Keerti Parthasarathy efe256cf6c Update dartdoc in the SDK to 0.28.5
Change-Id: Id22a9d77bb53adbbca380d6e5dedc48cf0249d09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115275
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2019-09-04 18:46:40 +00:00
pq b5db563655 bump to linter 0.1.97+1
Change-Id: Ie2df45e0af255d6a45df5d1383270af1aa945a8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114966
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-08-30 14:38:15 +00:00
Dmitry Stefantsov ab9cd54b1b [cfe] Use cipd for benchmark data instead of the store
Change-Id: I2ec6cf0f76dee490b18bcdb6d4a85e523e068491
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114842
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
2019-08-29 08:52:43 +00:00
Ari Aye 62ec392768 Upgrade to tflite_native@0.2.2
A change to how the TensorFlow output gets copied through FFI into Dart
makes ML code completion speed 4x faster.

This is the upstream change we're picking up: 92d2113591

Change-Id: I004ffb10a735248bd413d2e7be9380bb5adf0ad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114280
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2019-08-23 15:18:39 +00:00
Jonas Termansen 46d5556e56 [co19] Roll co19 to 52daae49d7bff80039ff1eea36a24e98c2b9a837
2019-08-21 sgrekhov@unipro.ru 461. NNBD syntax tests added
2019-08-21 sgrekhov@unipro.ru 389. NNBD static errors tests for variable initialization
2019-08-21 sgrekhov@unipro.ru 389. Fix NNBD static errors tests for X&S types where S is non-nullable
2019-08-20 sgrekhov@unipro.ru 460. Renaming null-promotion tests
2019-08-20 sgrekhov@unipro.ru 460. NNBD null-promotion tests fixed, renamed and wrong ones deleted
2019-08-20 sgrekhov@unipro.ru 460. Fix null-promotion tests
2019-08-20 sgrekhov@unipro.ru 460. Fix null-promotion tests
2019-08-19 irina.arkhipets@gmail.com Fixed Issue 460: tests for Null promotion added.
2019-08-19 sgrekhov@unipro.ru 389. More NNBD static errors tests. Non-Nullable types tests added
2019-08-16 sgrekhov@unipro.ru 389. More NNBD static errors tests. Write to final late variable
2019-08-16 sgrekhov@unipro.ru 389. More NNBD static errors tests. Nullable types tests added
2019-08-15 sgrekhov@unipro.ru 389. Minor code style change
2019-08-15 sgrekhov@unipro.ru 389. More NNBD static errors tests. Type aliases tests added
2019-08-15 sgrekhov@unipro.ru 389. More NNBD static errors tests added
2019-08-14 sgrekhov@unipro.ru 389. More NNBD static errors tests added
2019-08-14 sgrekhov@unipro.ru 389. More NNBD static errors tests added
2019-08-14 sgrekhov@unipro.ru Fixes 474. Use type dynamic to avoid errors
2019-08-13 sgrekhov@unipro.ru Deleted obsolete WebPlatformTests and LayoutTests
2019-08-13 sgrekhov@unipro.ru 389. More NNBD static errors tests added

Change-Id: Ie33b595493b1e646843276e74a5a2ab20c943683
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113990
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-22 09:08:34 +00:00
Jonas Termansen ceaf00ebe6 [co19] Document how co19 rolls are done.
Change-Id: Ie0fecc0ca5c17f0a875988fe90c1b12f6052a975
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107290
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-22 08:16:37 +00:00
Liam Appelbe 0fee296130 [vm] Add wasmer to third_party, and support building rust libraries
This isn't linked in to anything yet, but I've verified that it works.

Bug: https://github.com/dart-lang/sdk/issues/37882
Change-Id: Ib65d7f11aacac1a20d93fc5d4f10ced19ecb1e51
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113263
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
2019-08-20 16:56:10 +00:00
Jens Johansen 10e63b7840 [CFE] Get fragment from default package - use language version if any
Language versioning specifies that an empty-name-entry in .packages
specifies a sort of "default package" that a non-package file should
pretend to be a part of "for any purpose where that matters,
including choosing the default language level."

Change-Id: I16f4b2f5e4d3ca1e82d2189321e2be5c43e3b260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112089
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-08-20 09:06:32 +00:00
Ari Aye 5c438c8d25 Upgrade tflite_native to v0.2.1 for silent tflite dynamic library
Before this version tflite would print a debug message which
triggered an LSP warning coming out of analysis server.

Change-Id: Ida263a69a2c300e9801c61519994a4154d5bdaa4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-08-19 13:59:39 +00:00
Alexander Thomas 02e0b2d229 [co19] Roll co19 to d2c051f7537e6fe47c8ccf0bd7a7e84b02010a2a
2019-08-13 sgrekhov@unipro.ru Fixes 472. Remove relative import from multitest
2019-08-13 sgrekhov@unipro.ru Fixes 471. Change an expected result to Ok and add another test to check that correct extension is exported
2019-08-12 sgrekhov@unipro.ru 389. More NNBD static errors tests added
2019-08-12 sgrekhov@unipro.ru 389. More NNBD static errors tests added
2019-08-09 sgrekhov@unipro.ru 389. More NNBD static errors tests added
2019-08-09 sgrekhov@unipro.ru Fixes 389. More NNBD static semantics tests
2019-08-09 sgrekhov@unipro.ru Fixes 470. Move log to base class
2019-08-08 sgrekhov@unipro.ru 389. More NNBD static errors tests added
2019-08-08 sgrekhov@unipro.ru Fixes 456. Fix constructor name and update export
2019-08-07 irina.arkhipets@gmail.com Fixed Issue 469: get rid of the useless compile-error tag.

Change-Id: Ib723719e3f695b282120a240a55cfb81c3a95bd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112880
Reviewed-by: William Hesse <whesse@google.com>
2019-08-13 11:32:17 +00:00
Alexander Thomas e323684f09 [co19] Roll co19 to a6f62f2024492b2c79b741d4b96e67fce31a9830
2019-08-07 sgrekhov@unipro.ru 389. More NNBD static errors tests added
2019-08-06 sgrekhov@unipro.ru 389. Change NNBD tests to be in accordance with the spec
2019-08-06 irina.arkhipets@gmail.com Fixed Issue 468: typo corrected.
2019-08-06 irina.arkhipets@gmail.com Fixed Issue 467: test updated to throw runtime exception instead of compile time error.
2019-08-02 irina.arkhipets@gmail.com Fixed Issue 457:  added test which checks that static member of an extension cannot be accessed through an extension override.
2019-08-02 sgrekhov@unipro.ru Fixes 428. Make test stronger (choose static types explicitly)
2019-08-01 sgrekhov@unipro.ru Static extension methods: additional check that extension on dynamic has no effect
2019-08-01 irina.arkhipets@gmail.com Fixed Issue 429: more cases for testing added.
2019-08-01 sgrekhov@unipro.ru Fix for 428. Wrong tests renamed, existing one rewritten to test type inference
2019-08-01 sgrekhov@unipro.ru Fixes 456. Use correct tearoff function
2019-08-01 sgrekhov@unipro.ru Fixes 454. Fix typos
2019-08-01 sgrekhov@unipro.ru Fixes 454. Fix typos
2019-08-01 sgrekhov@unipro.ru Fixes 453. Make operator argument covariant
2019-08-01 irina.arkhipets@gmail.com Fixed Issue 452: typo corrected.
2019-08-01 irina.arkhipets@gmail.com Fixed Issue 451: typo corrected.
2019-08-01 irina.arkhipets@gmail.com Fixed Issue 450: typo corrected.

Change-Id: I8837e0c02c96bc2473bb6c6bc19b1e11c5efe5c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112241
Reviewed-by: William Hesse <whesse@google.com>
2019-08-07 11:37:00 +00:00
Ari Aye 98ffe8a7c6 Update dart/language_model rev to EFtZ0Z5T822s4EUOOaWeiXUppRGKp5d9Z6jomJIeQYcC
This version of the dart/language_model CIPD package sets the package attribute
preserve_writable: true and removes the read-only CIPD version file.

Bug: https://github.com/dart-lang/sdk/issues/37698
Change-Id: I3823decf92518dd4e4eb39e8862eb98550fcf2af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111983
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-05 18:28:49 +00:00
pq cd30fa693d bump to linter 0.1.96
Change-Id: Ifd20c2551ef302a7e9e08f823cd1a68ddff75a5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-08-03 00:35:21 +00:00
Sergey G. Grekhov ca2f68e5f5 [co19] co19 roll b0220fc898c32d3944cb8c54cf7b78dd8c7cbadb..796f4de76de460e031bf3b20ce60a52e4ed417d9
t log b0220fc898c32d3944cb8c54cf7b78dd8c7cbadb..796f4de76de460e031bf3b20ce60a52e4ed417d9 --date=short --no-merges --format='%ad %ae %s'

2019-07-31 sgrekhov@unipro.ru Add another test for lexical resolution with conflicting extensions in a library
2019-07-31 sgrekhov@unipro.ru Fix typo and missing import added
2019-07-31 irina.arkhipets@gmail.com typo corrected.
2019-07-30 sgrekhov@unipro.ru Test fixed (listEquals -> iterableEquals)
2019-07-30 sgrekhov@unipro.ru Fix description of the current extension member tests and add new ones testing that instance method has higher priority than extension's one
2019-07-30 sgrekhov@unipro.ru More built-in types added to test on clause
2019-07-30 irina.arkhipets@gmail.com generic parameter inference test corrected, two new tests added.
2019-07-30 sgrekhov@unipro.ru Add test with 'call' method and no most specific extension
2019-07-30 sgrekhov@unipro.ru Change test assertion and rename
2019-07-30 sgrekhov@unipro.ru Change test description and add new one testing 'no most specific extension' case
2019-07-29 sgrekhov@unipro.ru Fix scope tests
2019-07-29 sgrekhov@unipro.ru Change all extensions in the test to not to be 'most specific'
2019-07-29 sgrekhov@unipro.ru Use more strong checking of 'this'
2019-07-29 sgrekhov@unipro.ru Check that it is no compile error if an extension declares a member with the same name as a member of the type it is declared on
2019-07-29 irina.arkhipets@gmail.com new test added, it checks that extension type parameter cannot be higher-order.
2019-07-29 irina.arkhipets@gmail.com test extension is appliedes expected.
2019-07-29 sgrekhov@unipro.ru Use correct checkings
2019-07-29 sgrekhov@unipro.ru Use correct functions call
2019-07-29 sgrekhov@unipro.ru Use correct functions call
2019-07-29 irina.arkhipets@gmail.com test expectations corrected.
2019-07-29 sgrekhov@unipro.ru Remove NNBD tests
2019-07-29 sgrekhov@unipro.ru Obsolete text removed from the test description
2019-07-29 sgrekhov@unipro.ru Use correct function type
2019-07-29 sgrekhov@unipro.ru Use correct function type
2019-07-29 sgrekhov@unipro.ru Use string interpolation
2019-07-27 irina.arkhipets@gmail.com got rid of higher order type variables.
2019-07-27 irina.arkhipets@gmail.com test check a parameter of unrelated type now; new test with implicit downcast added.
2019-07-27 irina.arkhipets@gmail.com expected result of the test corrected.
2019-07-27 irina.arkhipets@gmail.com more informative test description added.
2019-07-27 irina.arkhipets@gmail.com typo corrected.
2019-07-27 irina.arkhipets@gmail.com the test checks that an extension from non-platform libraries is not more or less specific than one from another non-platform library.
2019-07-27 irina.arkhipets@gmail.com the test checks that an extension from non-platform libraries is not more or less specific than one from another non-platform library.
2019-07-27 irina.arkhipets@gmail.com the test checks that an extension from non-platform libraries is not more or less specific than one from another non-platform library.
2019-07-26 sgrekhov@unipro.ru Add another tests with a call getter returning a function
2019-07-25 irina.arkhipets@gmail.com positive test case for the conflicting resolutions added, there should not be errors if members are not called directly.
2019-07-25 irina.arkhipets@gmail.com add a reference to the conflicting extensions.
2019-07-24 sgrekhov@unipro.ru Use correct syntax for unnamed extension with type parameters
2019-07-24 sgrekhov@unipro.ru Use correct syntax for unnamed extension with type parameters
2019-07-24 irina.arkhipets@gmail.com type parameters follow extension names now.
2019-07-24 sgrekhov@unipro.ru Use instance variable, not a class for testing
2019-07-24 sgrekhov@unipro.ru Fix typo (boolean -> bool)
2019-07-24 irina.arkhipets@gmail.com typo in the test corrected.
2019-07-24 irina.arkhipets@gmail.com "on" clause added to the tested extensions.
2019-07-23 irina.arkhipets@gmail.com typo in the test corrected.
2019-07-23 irina.arkhipets@gmail.com tests for Semantics of Invocations (Static extension methods)added.
2019-07-23 irina.arkhipets@gmail.com tests for Semantics of Invocations (Static extension methods)added.
2019-07-23 sgrekhov@unipro.ru Semantics of extension members tests added
2019-07-23 sgrekhov@unipro.ru Object methods test added
2019-07-23 irina.arkhipets@gmail.com tests for Static Members and Member Resolution (Static extension methods)
2019-07-22 irina.arkhipets@gmail.com tests for overriding access in extension methods added.
2019-07-22 irina.arkhipets@gmail.com removed needless @compile-error tags.
2019-07-22 irina.arkhipets@gmail.com added "on" clause to the extension declarations.
2019-07-22 sgrekhov@unipro.ru Static extension methods. Member conflict resolution tests added
2019-07-22 irina.arkhipets@gmail.com getter calls corrected.
2019-07-22 irina.arkhipets@gmail.com expected results of the test cases corrected.
2019-07-22 sgrekhov@unipro.ru Typo fixed
2019-07-22 sgrekhov@unipro.ru Remove wrong type argument
2019-07-22 irina.arkhipets@gmail.com typo in the getter corrected.
2019-07-22 sgrekhov@unipro.ru Typo fixed (Void -> void)
2019-07-22 sgrekhov@unipro.ru Typo fixed
2019-07-19 sgrekhov@unipro.ru Static extension methods. Member conflict resolution test added
2019-07-18 sgrekhov@unipro.ru Extension static methods acess fixed
2019-07-18 sgrekhov@unipro.ru Tearoff tests added and fixed
2019-07-18 sgrekhov@unipro.ru More tearoff tests
2019-07-17 sgrekhov@unipro.ru Tearoff tests added and small fixes
2019-07-15 irina.arkhipets@gmail.com added tests for overriding access in the static extension methods.
2019-07-15 sgrekhov@unipro.ru The call member tests added
2019-07-12 irina.arkhipets@gmail.com tests for extension conflict resolution added.
2019-07-10 irina.arkhipets@gmail.com tests for extension conflict resolution added.
2019-07-04 irina.arkhipets@gmail.com tests for static extension methods added: extension conflict resolution.
2019-07-04 sgrekhov@unipro.ru More extension member resolution tests
2019-07-03 sgrekhov@unipro.ru Typo in test fixed
2019-07-02 sgrekhov@unipro.ru Extension member resolution tests added
2019-07-02 sgrekhov@unipro.ru Covariant parameters test added
2019-07-02 sgrekhov@unipro.ru Typo in multitest fixed
2019-07-01 irina.arkhipets@gmail.com tests for static extension methods added (generic parameter interfaces and extension conflict resolution)
2019-07-01 sgrekhov@unipro.ru Fixes Test for scope completed
2019-07-01 sgrekhov@unipro.ru Fixes Another tests for Scope added
2019-06-28 sgrekhov@unipro.ru Test scope added
2019-06-28 sgrekhov@unipro.ru Ommited extension name test added
2019-06-27 irina.arkhipets@gmail.com tests for generic parameter inference added.
2019-06-27 sgrekhov@unipro.ru Tests for syntax scope added
2019-06-26 irina.arkhipets@gmail.com tests for the issues 32903, 34560 added, some typos fixed.
2019-06-26 sgrekhov@unipro.ru Issue number added to flaky test
2019-06-26 sgrekhov@unipro.ru Member declaration tests added
2019-06-24 sgrekhov@unipro.ru More tests for Static extension methods syntax
2019-06-24 sgrekhov@unipro.ru Added tests for Static extension methods syntax
2019-06-24 irina.arkhipets@gmail.com moved tests for triple-shift into LanguageFeatures/Triple-shift directory.
2019-06-21 sgrekhov@unipro.ru Name and value are mandatory for Cookie now. Also value check added
2019-06-19 sgrekhov@unipro.ru Add more NNBD static semantics tests
2019-06-18 sgrekhov@unipro.ru RGBA and UNSIGNED_BYTE constants were moved to WebGL class. Use them
2019-06-18 sgrekhov@unipro.ru Use approxEquals for math functions with tolerance 1-e15
2019-06-18 sgrekhov@unipro.ru Old multitest syntax replaced by new one
2019-06-17 sgrekhov@unipro.ru Initial commit. Tests for NNBD static errors
2019-06-17 sgrekhov@unipro.ru Revert "Initial commit. Tests for NNBD static errors"
2019-06-17 sgrekhov@unipro.ru Initial commit. Tests for NNBD static errors
2019-06-17 irina.arkhipets@gmail.com added static tests for non-function type aliases with simple bounds. Useless @compile-error tags removed.
2019-06-17 irina.arkhipets@gmail.com added dynamic tests for non-function type aliases with simple bounds.
2019-06-14 sgrekhov@unipro.ru Remove invalid use null from Language tests

Change-Id: I83d5ded8bc97a1b0bf3e8f19af401ae5283411f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111722
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-02 07:39:25 +00:00
Ari Aye 650f32c1b0 Update to tflite_native@0.2.0
This change also copies the platform-appropriate tflite shared object into $SDK/bin/snapshots so that tflite_native running inside the analysis server snapshot will be able to resolve it correctly.

ariaye@ariaye1:~/sdk/sdk$ ./tools/build.py -a x64 -mrelease create_sdk
ariaye@ariaye1:~/sdk/sdk$ ls out/DebugX64/dart-sdk/bin/snapshots/
analysis_server.dart.snapshot  dart2js.dart.snapshot  dartanalyzer.dart.snapshot  dartdevc.dart.snapshot  dartdoc.dart.snapshot  dartfmt.dart.snapshot  kernel-service.dart.snapshot  kernel_worker.dart.snapshot  libtensorflowlite_c-linux64.so  libtensorflowlite_c-mac64.so  libtensorflowlite_c-win64.dll  pub.dart.snapshot  resources

Change-Id: I474a3b676f99feaa84dba9c7723dc867a7a01f52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111669
Reviewed-by: Samir Jindel <sjindel@google.com>
2019-08-01 23:05:45 +00:00
Ari Aye 1e16b74b5b Update cipd dependency dart/language_model to latest version to use copy instead of symlink
Change-Id: I9f5ccfc2ed9db736292038fb2a98e9097ac5eff3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111520
Reviewed-by: Alexander Thomas <athom@google.com>
2019-07-31 18:35:45 +00:00
Jake Ehrlich 773f8d53ed Reland "[llvm] Add initial scaffolding"
This is a reland of b71d2d9996

Original change's description:
> [llvm] Add initial scaffolding
>
> This change adds the gclient and GN changes needed to build
> an executable using LLVM in the Dart tree as well as a basic
> testing framework based on llvm-lit.
>
> Change-Id: I9009a98ff95043cc3754966f31697ba7f1712310
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106434
> Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

Change-Id: I73cd24455c373bcc4d0f5675af6a3b1e0f947f67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110683
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2019-07-30 20:34:31 +00:00
Ari Aye db796d5b96 Fix for bad handling of predict response from model isolate
I also went ahead and updated the CIPD dart/language_model version to the latest model version.

Change-Id: I4522209150a90acfba210885316e78381c2aee45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
2019-07-29 20:41:35 +00:00
lambdabaa a9ebb5c3c8 Enable running language model unit tests on windows
Change-Id: I63457934fcd23510f6a2848fbb00361ebb40a40f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
2019-07-27 20:57:59 +00:00
Ari Aye 5d5a0c0164 Check in token-level language model via tflite ffi
Local test run after running `gclient sync`:

ariaye@ariaye1:~/sdk/sdk$ dart pkg/analysis_server/test/services/completion/dart/language_model_test.dart
00:00 +0: calculates lookback
INFO: Initialized TensorFlow Lite runtime.
00:00 +1: predict with defaults
00:01 +2: predict with confidence scores
00:03 +3: predict when no previous tokens
00:04 +4: All tests passed!


Change-Id: I4181bea09cf8fec74d03bba4f83cd26dac818f30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109662
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-07-25 18:39:51 +00:00
William Hesse 9c2970d17e Update checked-in SDK to 2.5.0-dev.1.0
Bug: https://github.com/dart-lang/sdk/issues/37628
Change-Id: If8f4dcac61f89d8dcc2b669feb662a4541d70381
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110443
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2019-07-25 14:52:54 +00:00
pq f38a719933 linter 0.1.95
Change-Id: I963a55d62c02c8d0d455d110a74ecf4d3e5a6e32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-07-24 16:55:33 +00:00
Daco Harkes fbf13f561f [benchmarks/ffi] Add micro and macro benchmarks for dart:ffi
Adds micro benchmarks to measure low level (1) C memory reads and writes from Dart and (2) calls from Dart into C. This CL also adds a macro benchmark to measure overall performance using BoringSSL to digest data. The shared libraries are precompiled for Linux and live in cipd packages. The benchmarks run on all hardware architectures (with the exception of Linux'es hardfp on Arm32: https://github.com/dart-lang/sdk/issues/36309).

Issue: https://github.com/dart-lang/sdk/issues/36247

Change-Id: I8dfb30cc66a26a2942bb09194c5eb0da0b6ca1b5
Cq-Include-Trybots: luci.dart.try:benchmark-linux-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108724
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
2019-07-19 14:59:57 +00:00
Nate Bosch 6bc8f0ee9b Update to latest package:watcher
The tag 0.9.7+12 was never published on pub. The tag 0.9.7+12-pub is
what is published. The version published on pub contains some internal
style fixes and removes unused code.

Change-Id: Ic196316e83ada99f02f461feeae9215ee3db3701
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109307
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
Commit-Queue: Gary Roumanis <grouma@google.com>
2019-07-18 22:41:15 +00:00
Devon Carew 1f718b2dcf upgrade dartdoc to 0.28.4
Change-Id: I5f6c491a515e6bad3ca07efa2370e01c2eb6b5bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108667
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2019-07-10 20:36:09 +00:00
pq ce79d63c58 bump to linter 0.1.94
Change-Id: Ie6bf9ab156a89cc9ad025ca470f1150ed4f74763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2019-07-10 18:46:18 +00:00
Jonas Termansen 24d57fb745 [benchmark] Add top level benchmarks directory.
Benchmarks are checked in as benchmarks/<Benchmark>/dart/<Benchmark>.dart.
This scheme is compatible with our existing benchmarking infrastructure
and will aid migrating the benchmarks with minimal breakage.

This change adds an Example benchmark to show how it is done.

The benchmarks directory is now added to the Dart benchmarking builds.

Change-Id: I25971ba3b219194fa9cfea6b938372d877477e28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108414
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-07-10 14:51:14 +00:00
Alexander Thomas 2cb5303782 [infra] Update checked in SDKs to 2.4.0
Change-Id: I4c315a0c61a4c5bf8144aaf4d85ab5ae95dec315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108400
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2019-07-09 08:23:22 +00:00
Todd Volkert cab2ca275d Update Socket to be a Stream<Uint8List>
Bug: https://github.com/dart-lang/sdk/issues/36900
Change-Id: I600c28aebbe35f9e650f969adf356dda4eb0cacd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104524
Commit-Queue: Todd Volkert <tvolkert@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2019-07-08 16:42:47 +00:00
Nicholas Shahan ac30ab12ab [dartdevc] Bump pedantic to v1.8.0 and apply new lints
Cleanup violations of:
* `prefer_iterable_whereType`
* `unnecessary_const`
* `unnecessary_new`

Ignore violations in lib/src/js_ast to avoid additional diffs when un-forking.

Change-Id: I7333903422bbf635cd0dea82116372f305f679d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108182
Auto-Submit: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2019-07-03 23:51:51 +00:00
Jonas Finnemann Jensen bbbeb8b509 Pull in latest pub
Change-Id: Ib465146fb3ce7d95599b0615a6fbccb15fa95bda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108100
Auto-Submit: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2019-07-03 09:24:24 +00:00