Daniel Andersson
a410c0f993
Thread-local store buffers, v2
...
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org//1168483003 .
2015-06-09 09:33:36 -07:00
Søren Gjesse
d5a34bd6d2
Resolve the executable path on Mac OS when sym-linked
...
Also resolve its directory if symlinked.
This helps to locate the Dart SDK (if any) from the path of the dart
executable. On Linux the use of /proc/self/exe already takes care of this.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//1160793004
2015-06-09 16:13:00 +02:00
Siva Annamalai
c67f93099f
Fix for issue 23598, add a Dart_CreateLibrarySnapshot entrypoint to the API.
...
BUG=23598
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1168223002 .
2015-06-08 18:05:16 -07:00
Ryan Macnak
304382c1b4
Add TypedData instance kinds.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1157003003 .
2015-06-08 17:30:11 -07:00
John McCutchan
82d3caefc7
Fix code display in Observatory
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1164413002
2015-06-08 14:55:26 -07:00
Ivan Posva
f5e3f94019
Fix http://dartbug.com/23578 :
...
- Complete revamp of isolate-specific flags.
- Associate flags with the isolate on creation.
- Dart_CreateIsolate and associate callback do take an
extra flags argument.
- Make sure to clear IC data array when clearing code.
BUG=23578
Review URL: https://codereview.chromium.org//1162033005
2015-06-07 17:57:34 +02:00
Siva Annamalai
da0363172a
Fix for issue 192 in domokit/mojo
...
Serialize Mint objects as is and at the receving side convert them to Smi or Mints depending on the target architecture.
BUG= 192 from domokit/mojo
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1151573022
2015-06-05 14:45:17 -07:00
Todd Turnidge
676fcddbff
@Int no longer exists
2015-06-04 14:07:03 -07:00
Seth Ladd
8e3bc82c85
Tweak to markdown for link in service protocol spec
2015-06-04 12:47:09 -07:00
Ryan Macnak
6545e8539e
Fix isAssignableTo in VM mirrors to use subtype (<:) rather than moreSpecificThan (<<).
...
BUG=http://dartbug.com/22852
R=gbracha@google.com
Review URL: https://codereview.chromium.org//1156583005
2015-06-04 12:25:59 -07:00
Todd Turnidge
d5dc5ccc56
Add feedback link.
...
BUG=
R=sethladd@google.com
Review URL: https://codereview.chromium.org//1159983007
2015-06-04 10:19:40 -07:00
Todd Turnidge
996f012707
2nd attempt at adding streamListen/streamCancel to the service protocol.
...
This time I am committing the protocol changes first and saving the
Observatory changes for a second cl.
------
We currently support 5 streams: Isolate, Debug, GC, _Echo, and _Graph.
Only generate events when at least one client is listening to the
corresponding event stream.
Only send events to the clients that actually request them.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1166433008
2015-06-04 09:57:22 -07:00
Todd Turnidge
1b59b9ea06
Service cleanups...
...
- Allow for multiple breakpoints in the service protocol.
The info isn't actually provided or used yet.
- Drop index for list elements returned by the protocol. Flatten structure.
- Drop index for context elements. Keep sub-structure so we
can choose to add extra slot info later.
- Errors now have ids and kinds.
- exception and stacktrace move from @Error to Error.
- All heap Objects now include class/size.
- Changed BoundedType.type and TypeRef.type to different names.
Turns out we already have a "type" property that conflicts.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1152753005
2015-06-04 09:09:22 -07:00
Lasse R.H. Nielsen
de68aaa595
Clean up JSON parsing code.
...
Fixes some hard-to-find bugs and warnings.
Improves the layout of all the constants.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//1150033013
2015-06-04 14:55:32 +02:00
Srdjan Mitrovic
b666398745
Fix fix (again)
...
BUG=
Review URL: https://codereview.chromium.org//1153413006
2015-06-03 17:13:27 -07:00
Srdjan Mitrovic
1c18123cea
Fix analyzer run on bot
...
BUG=
Review URL: https://codereview.chromium.org//1162023007
2015-06-03 16:52:20 -07:00
Regis Crelier
a5669190ab
Fixed breakpoint handling at return statement with inlined finally clauses.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1170483002
2015-06-03 15:25:42 -07:00
Ryan Macnak
e13679d393
Fix the profiler.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1152553010
2015-06-03 14:02:07 -07:00
Srdjan Mitrovic
7b04897743
Fix fix
...
BUG=
Review URL: https://codereview.chromium.org//1166523005
2015-06-03 12:39:59 -07:00
Srdjan Mitrovic
12da412110
Fix build
...
BUG=
Review URL: https://codereview.chromium.org//1160623004
2015-06-03 11:22:46 -07:00
Srdjan Mitrovic
c0824e7725
Fix 23563: double unary- operator unstable for NANs
...
BUG=
R=koda@google.com
Review URL: https://codereview.chromium.org//1160453003
2015-06-03 11:00:28 -07:00
Regis Crelier
4bf6db0c25
Adjust context level when required before executing inlined finally clauses.
...
Add regression test.
BUG=23537
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1154823003
2015-06-03 10:31:48 -07:00
Todd Turnidge
4a3b6fe160
Rework the format of the FlagList response.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1149403007
2015-06-03 10:09:15 -07:00
Todd Turnidge
bf17319a3c
Update gypi.
...
BUG=
Review URL: https://codereview.chromium.org//1169513003
2015-06-03 09:13:33 -07:00
Todd Turnidge
6c2ebfcc60
Switch to using SourceLocation universally in service protocol.
...
Add <location-link> and <location-inset> to provide links and insets
for a location.
Make Frame, Message, and SourceLocation first class in service lib.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1150303004
2015-06-03 09:02:40 -07:00
Florian Schneider
63209c93d3
Fix result cid of CompactLinkedHashMap._index native getter.
...
This field can be null when a hash map is deserialized from a snapshot where
the index is regenerated.
BUG=
R=iposva@google.com , koda@google.com
Review URL: https://codereview.chromium.org//1159393003
2015-06-03 17:01:31 +02:00
Lasse R.H. Nielsen
5a843ebbf3
Add "checked" parameter to Isolate.spawnUri.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//1154673004
2015-06-03 12:32:52 +02:00
Srdjan Mitrovic
defec9c960
--check_function_fingerprints is available only in dart_no_snapshot, i.e., it was not tested. Make it default true, catch failure at build time then
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//1166813002
2015-06-02 16:36:54 -07:00
Ivan Posva
63558e911e
- Make sure to properly check for errors from sysctlbyname.
...
BUG=
Review URL: https://codereview.chromium.org//1150173004
2015-06-02 23:22:24 +02:00
Ryan Macnak
a754930be6
Remove unused field map_ from LinkedHashMap::Iterator.
...
TBR=koda@google.com
Review URL: https://codereview.chromium.org//1162363003
2015-06-02 12:33:28 -07:00
Ryan Macnak
eca0d72abe
Provide a logical view of VM-internal maps in Observatory.
...
BUG=http://dartbug.com/20551
BUG=http://dartbug.com/21185
R=koda@google.com
Review URL: https://codereview.chromium.org//1150103005
2015-06-02 11:38:39 -07:00
Daniel Andersson
6090af8f0b
Serialize maps without hashes.
...
Re-generate the indices after deserialization.
This is a more compact representation, and also fixes the issue with identity hash codes not being portable between isolates.
BUG=21675
R=asiva@google.com
Review URL: https://codereview.chromium.org//1151013005
2015-06-02 09:04:37 -07:00
Daniel Andersson
bf8ccee760
Use kSmiBits rather than #ifdef to define hash map constant.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//1160963002
2015-06-02 06:00:28 -07:00
Ryan Macnak
98999e6a02
Misc Observatory patches:
...
- Address some editor hints.
- Place eval box above fields and be much more generous in expanding fields.
- Treat maps as plain instances so their refs aren't blank.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1159783004
2015-06-01 14:59:54 -07:00
Srdjan Mitrovic
b611952ead
Prevent excessive deoptimization when optimistically assuming Smi in typed data stores.
...
Moved ICData ahead of class Function, since class Function needs type ICData::DeoptReasonID.
BUG=
R=fschneider@google.com
Review URL: https://codereview.chromium.org//1149403005
2015-06-01 11:42:42 -07:00
Todd Turnidge
f6d3d4681d
Rename some service protocol errors.
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1164463005
2015-06-01 09:26:54 -07:00
John McCutchan
864f9a3c9b
Cap the number of pending accepts on Windows
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1151753008
2015-06-01 06:38:22 -07:00
Ivan Posva
ccf44becd2
- Use #if defined(DEBUG)
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1152773003
2015-05-29 17:43:36 -07:00
Ryan Macnak
4102b0c446
Canonicalize mixin type during class finalization. Add asserts that most types are canonical.
...
R=regis@google.com
Review URL: https://codereview.chromium.org//1167583002
2015-05-29 15:29:04 -07:00
Ivan Posva
8f1506e817
- Determine whether the simulator is being used in globals.h
...
- Make sure to switch on HOST_ARCH_ and on USING_SIMULATOR
where appropriate.
- Avoid allocating in new generation when running in the VM isolate.
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1156053006
2015-05-29 14:35:29 -07:00
Ryan Macnak
c6ebef9526
Address hints in the Observatory.
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//1161553013
2015-05-29 13:42:31 -07:00
Regis Crelier
601da25b92
Fix issue 23500
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//1146993003
2015-05-29 13:31:16 -07:00
Todd Turnidge
8adf7de6d1
Introduce Instance.kind.
...
Use this instead of subclassing Instance in the service protocol.
Revise many instance property names.
BUG=
R=johnmccutchan@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org//1162133002
2015-05-29 13:02:36 -07:00
Siva Annamalai
7af681ead9
Fix for issue 23547, return an proper ApiError instead of a string when we report outstanding typed data acquire errors.
...
BUG=23547
R=koda@google.com
Review URL: https://codereview.chromium.org//1156993012
2015-05-29 11:13:33 -07:00
Daniel Andersson
092d27cf34
Remove serializer whitelisting for 'dart:collection'
...
Since LinkedHashMap is now VM-internal, this exception is no longer needed.
BUG=22982
R=asiva@google.com
Review URL: https://codereview.chromium.org//1149933007
2015-05-29 09:17:55 -07:00
Srdjan Mitrovic
d7d0d92ec3
Do not eagerly add guarded leaf classes with CHA; do not add them for private names.
...
BUG=
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//1158673004
2015-05-29 08:57:34 -07:00
Lasse R.H. Nielsen
babcd4e9c0
Revert "Make EfficientLength public, as EfficientLengthIterable."
...
It's still not a good solution for detecting an Iterable with an efficient
length. It's not inherited by, e.g., a DelegatingIterable wrapper or similar
generic Iterable transformers.
Keep this as an internal optimization for quickly detecting the most common
efficient-length Iterable classes (List, Set, Queue, Map.keys/values), but
don't make it public.
A *real* solution would be adding a hasEfficientLength getter to Iterable, or
adding an efficientLength getter that may return null if it's not efficient.
This would something that a wrapper can attach to.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//1154263003
2015-05-29 12:52:45 +02:00
Florian Schneider
88d316fbc0
VM: Fix two incorrect function fingerprints.
...
The checking code was broken for a while, so this mismatch was not noticed.
BUG=
R=vegorov@google.com
Review URL: https://codereview.chromium.org//1156423002
2015-05-29 12:20:09 +02:00
Lasse R.H. Nielsen
cf4eaae5a6
Change RangeError instances to use RangeError.range.
...
This avoids using the (sometimes confusing) "[...)" notation for half-open ranges.
Also change argument tests to simpler interval tests, and move error handling to the end of the functions.
Mostly in VM typed-data libraries.
R=sgjesse@google.com , srdjan@google.com
Committed: 932bcc6901
Review URL: https://codereview.chromium.org//1132603003
2015-05-29 10:50:20 +02:00
Todd Turnidge
67adc6102d
Add getVersion and setLibraryDebuggable RPCs to the service protocol.
...
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//1149373006
2015-05-28 13:34:23 -07:00