The idea is that for macro-generated elements navigation point at
a temporary file that contains this generated content, and so name offsets
should be in this file. Elements that were produced from "source" code,
should be in the "source" file, with "source" name offsets.
Change-Id: Iefa105299444fbadfd3d52048c4dfe379b482449
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Previously, the only circumstance in which it was null was during a
few unit tests, and this is easily fixed by creating a
FlowAnalysisHelper object when setting up those tests.
Change-Id: Ida083ec218a2b1ee910bca747a8f5eb320828527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Previously, no optimized TTSes were generated for implemented types, and
so they always fell back to the default TTS, which mostly depends on
calling the runtime and cached checks in SubtypeTestCaches. Now,
optimized TTSes are generated that check for certain compatible
implementing classes before falling back on the runtime/STC.
More specifically, the optimized TTSes for implemented types checks for
the following cases:
1) The implemented type is instantiated and the checked class implements
an instantiated subtype of the implemented type. The only check
required is a class id match.
2) The instance type arguments of the checked class are compatible with
the type arguments of the checked type. That is, given the following
declarations, where Base, Impl1, and Impl2 have the same number of
parent type arguments:
```
case Impl1<K, V> implements Base<K, V>
case Impl2<V> implements Base<String, V>
```
then the generated optimized TTS for Base<S, T>, where S and T are
either type parameters or instantiated types, checks for instances of
Base and Impl1, comparing the type arguments of the instance to S and
T. The generated TTS does not currently check for Impl2, and thus
when given an instance of Impl2, it falls back to the old runtime
checking/SubtypeTestCache behavior.
This compatibility restriction allows us to perform the same checks on
the loaded instance type arguments as is done for non-implemented types,
where the checked classes are subclasses and so naturally compatible in
this manner.
Note that two implementing classes whose instance type arguments are
compatible may store their instance type arguments at different field
offsets. Thus, we also split the classes being checked into groups that
share the same instance type arguments field offset, and load the
instance type arguments differently for each checked group.
This CL also removes now-unused code in the HierarchyInfo class.
TEST=vm/cc/TTS_{Generic,}SubtypeRangeCheck
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-release-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-linux-product-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm_x64-try
Change-Id: I4c3aa23db2e75adbad9c15727b491669b2f3a189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209540
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Don't mark SP as clobbered because newer clang versions
do not like that.
Fixes https://github.com/dart-lang/sdk/issues/46873
TEST=ci
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-release-arm-try,vm-ffi-android-product-arm-try
Change-Id: I5b794e7bb02e62576c4c40b8132f9c798cb7639c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209917
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
* Force depot_tools to use python3 results (USE_PYTHON3=True).
* Fixes the dart format presubmit check.
* Remove broken DOM tools presubmit check.
TEST=Manually provoked errors and ran git cl presubmit -v -f.
Cq-Include-Trybots: luci.dart.try.shared:presubmit-try
Change-Id: I8ba46e2ae1640f1b2f82e18bc8024e0aa4838b2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210123
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: William Hesse <whesse@google.com>
[co19_2] LibTests/typed_data tests skipped for dart2js
Change-Id: I2e8a93f7991b36367b84678bbfebda36babaf96f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209915
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
There's no need to visit these identifiers because they aren't looked
up using the current scope. Previously, we avoided doing these
lookups by doing some `is` and `identical` checks in
visitSimpleIdentifier, but it's more efficient (and more
straightforward) to simply avoid visiting the identifiers altogether.
Change-Id: Ibea28e196b206d88f5ad765d3d64a24c7b0e7d5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209855
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Now that ResolverVisitor no longer deals with scopes,
ScopeResolverVisitor is the only class that inherits from
ScopedVisitor, so we can combine the two. This makes the code a lot
easier to read and reason about, since we don't have to bounce between
the two classes with super calls all the time.
Change-Id: I308edd1a7181001724b89ffb04499b9a3df25cb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209852
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This reverts commit 824bec596f.
Reason for revert: b/196606044
Original change's description:
> [vm] Hide internal implementation List types and expose them as List
>
> When taking a type of an instance with x.runtimeType we can map
> internal classes _List, _ImmutableList and _GrowableList to a
> user-visible List class. This is similar to what we do for
> implementation classes of int, String and Type.
> After that, result of x.runtimeType for built-in lists would be
> compatible with List<T> type literals.
>
> Also, both intrinsic and native implementations of _haveSameRuntimeType
> are updated to agree with new semantic of runtimeType.
>
> TEST=co19/LanguageFeatures/Constructor-tear-offs/type_literal_A01_t01
> TEST=runtime/tests/vm/dart/have_same_runtime_type_test
>
> Fixes https://github.com/dart-lang/sdk/issues/46893
> Issue https://github.com/dart-lang/sdk/issues/46231
>
> Change-Id: Ie24a9f527f66a06118427b7a09e49c03dff93d8e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210066
> Commit-Queue: Alexander Markov <alexmarkov@google.com>
> Reviewed-by: Tess Strickland <sstrickl@google.com>
TBR=rmacnak@google.com,alexmarkov@google.com,sstrickl@google.com
Change-Id: I4c3dddbc358d6ad3b14081706f7aec110a2e0562
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210200
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
* IsInternalOnlyId -> IsInternalOnlyClassId
* Removes constexpr predicate ClassComesBeforeOtherInternalOnlyClasses()
used in only two locations and inlines the returned condition.
* Change IsErrorClassId to check <= kUnwindErrorCid instead of
<= kLastInternalOnlyCid.
TEST=Refactoring, so existing tests.
Change-Id: Ib7dfc89aba16d52733de05687f0ca7055c16e7a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210126
Auto-Submit: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
When taking a type of an instance with x.runtimeType we can map
internal classes _List, _ImmutableList and _GrowableList to a
user-visible List class. This is similar to what we do for
implementation classes of int, String and Type.
After that, result of x.runtimeType for built-in lists would be
compatible with List<T> type literals.
Also, both intrinsic and native implementations of _haveSameRuntimeType
are updated to agree with new semantic of runtimeType.
TEST=co19/LanguageFeatures/Constructor-tear-offs/type_literal_A01_t01
TEST=runtime/tests/vm/dart/have_same_runtime_type_test
Fixes https://github.com/dart-lang/sdk/issues/46893
Issue https://github.com/dart-lang/sdk/issues/46231
Change-Id: Ie24a9f527f66a06118427b7a09e49c03dff93d8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210066
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
Migrate member accesses of the ddc runtime library to the
`runtimeCall()` and `runtimeStatement()` methods. These properly
track the use of the library when compiling in the expression
compiler.
This fixes an issue where the `dart` library top level name could be
missing if an expression doesn't happen to trigger a code path that
tracks the use of the library.
Change-Id: I44e99d1b424059c0ce63f6df21fca804dafdb05c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210064
Reviewed-by: Anna Gringauze <annagrin@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
* Adds IsInternalOnlyCid, which replaces the old `cid < kInstanceCid`
check.
* Adds kFirstInternalOnlyCid and kLastInternalOnlyCid, which should be
used in places that loop over the internal-only cids.
* Adds ObjectComesBeforeOtherInternalOnlyClasses(), which can be used
with COMPILE_ASSERT in places that assume kObjectCid immediately
precedes the other internal-only cids.
* Replaces assumption in IsErrorId() that Instance immediately follows
the internal-only cids with an assumption that the current last error
cid is the same as kLastInternalOnlyCid.
* Separates out CLASS_LIST_NO_OBJECT_NOR_STRING_... into two pieces to
make it clearer where to add new internal-only cids and where to add
new Instance cids:
* CLASS_LIST_INTERNAL_ONLY, which contains class ids for real
classes that are VM internal, except for Object.
* CLASS_LIST_INSTANCE_SINGLETONS, which contains class ids for
subclasses of Instance that are not part of a separately handled
group of cids.
TEST=Refactoring, so existing tests.
Change-Id: I9905d5928a592164d58de1f121b9ce669f2b3ce1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210122
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This is the first time a native arm64 macOS SDK is used for the
checked-in SDK.
Cq-Include-Trybots: luci.dart.try:dart-sdk-mac-arm64-try,vm-kernel-nnbd-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try
Change-Id: I1eb58350bdb351e6fbb978e0849ba40bcdf7e724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210120
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
The test is flakily timing out on dartk-win-debug-ia32. In general it is
a quite large test and should just be given more time.
TEST=Give dart/byte_array_optimized_test more time, avoid flaky timeout
Change-Id: Ifeadc5f777b019ca4c04c5c8e6072fae1c00c0a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210121
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Remove the runtime_kernel target and all uses of it in scripts or
the test matrix. This runtime_kernel target is only an alias for
the runtime target, now that kernel is the default.
BUG=https://github.com/dart-lang/sdk/issues/46892
Change-Id: I00c0ecf8adbd7bff3fd3df48023a2976c5172066
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210000
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: William Hesse <whesse@google.com>
new languge features in 2.14
Change-Id: I731cebcb394ba17cd3a46ac92ae74cc6bf307de0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209916
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
handler
Sockets could be closed from multiple threads (finalizers run during
isolate shutdown and the event handler thread). This leads to potential
racy behavior.
(See https://github.com/dart-lang/sdk/issues/45641)
TEST=ci
Change-Id: I87900117a4194a71433680f68ed9b6dd31977403
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209849
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Change-Id: I459caf39d812d7c9e799617cf59f38c138b14d32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210062
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Add missing checks for FFI types disallowed in isolate messages.
Align error messages with the other serializer and test expectations.
TEST=ci
Change-Id: I3813dd8f26e5122524bdf41f9ce6e0785fdd260b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209840
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
When copying types of parameters from a constructor to a signature of
its tear-off, types should be instantiated to substitute class type
parameters with function type parameters.
For example,
class A<T> {
A(T x);
}
A.new // Should be 'A<S> Function<S>(S x)'
Without instantiation the parameter type would still reference class
type parameter:
A<S> Function<S>(T x)
As a result, Closure::GetInstantiatedSignature would replace
class type parameters with dynamic (as tear-off doesn't have
instantiated type arguments) which is not correct:
A<S> Function<S>(dynamic x)
TEST=co19/LanguageFeatures/Constructor-tear-offs/summary_A01_t01
(after https://github.com/dart-lang/co19/issues/1141 is fixed)
Issue https://github.com/dart-lang/sdk/issues/46231
Change-Id: I0517c400271e2a59ab0496a8cc39be51022768b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209851
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
2021-08-10 irina.arkhipets@gmail.com Issue 1094: tests corrected, missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: I-2-b test corrected.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32x4 tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32x4List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: Utils/tests/Expect tests corrected.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Uint32List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Uint16List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Uint8List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Uint9ClampedList tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int16List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int8List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Float64List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: Missing Issue tag added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Float64List tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Float32x4List tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Float32List tests updated to check expectations correctly for web.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/ByteData tests updated to check expectations correctly for web.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/ByteBuffer tests updated to check expectations correctly for web.
2021-08-10 sgrekhov@unipro.ru 1134. Read Dart --help from stdout on Windows
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes in master moved to pre-nnbd branch for LibTests/math tests.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes in master moved to pre-nnbd branch for LibTests/Isolate.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: LibTests/io/ZlibDecoder, LibTests/io/ZlibDecoder tests corrected.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch for LibTests/io/WebSocket/isEmpty_A01_t01.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch for LibTests/io/SystemEncoding folder.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch for LibTests/io/stdin folder.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch for LibTests/io/RawSecureServerSocket folder.
2021-08-09 irina.arkhipets@gmail.com Merge branch 'pre-nnbd' of https://github.com/dart-lang/co19 into pre-nnbd
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch.
2021-08-09 sgrekhov@unipro.ru 1100. Fix Link.watch() test to avoid flakiness
2021-08-06 sgrekhov@unipro.ru 1127. Expect compile-time errors in CFE for cyclic redirecting factories participating in a loop
2021-08-04 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/ProcessSignal
2021-08-04 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/ProcessResult
2021-08-04 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/Process
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/Link
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io tests: FileSystemModifyEvent, HttpClient, HttpClientBasicCredentials, HttpClientDigestCredentials, HttpClientRequest, HttpClientResponse, HttpServer, IOSink.
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/Directory, LibTests/io/File, LibTests/io/FileStat folder.
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/Cookie folder.
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/core/double, LibTests/core/int folders.
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/core folder.
2021-07-26 irina.arkhipets@gmail.com Issue 1094: changes from master merged, tests corrected in co19_2.
2021-07-23 irina.arkhipets@gmail.com Issue 1094: missing issue tags added, changes frim master merged, tests corrected in co19_2.
2021-07-22 irina.arkhipets@gmail.com Issue 1094: test corrected.
2021-07-22 sgrekhov@unipro.ru Fixes 1123. Expect Syntax errors in multitests and rename these tests to 'syntax*'
2021-07-21 irina.arkhipets@gmail.com Issue 1119: Libraries_and_Scripts test updated in pre-nnbd branch, new tests added.
2021-07-01 irina.arkhipets@gmail.com Issue 1094: tests updated.
2021-06-28 irina.arkhipets@gmail.com Issue 1094: test corrected according to the Issue 42393 evaluation.
2021-06-28 irina.arkhipets@gmail.com Issue 1094: Recent master changes merged into pre-nnbd branch, missing Iuuse tags added,test corrected (Language/Generics).
2021-06-28 irina.arkhipets@gmail.com Issue 1094: Recent master changes merged into pre-nnbd branch, missing Iuuse tags added,test corrected.
Change-Id: I00818cae18d84c3e2e7c628ed4370ff31c52d509
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209919
Reviewed-by: William Hesse <whesse@google.com>
2021-08-12 sgrekhov@unipro.ru Fixes 1144. Use Pointer<Int32> on 32-bit platforms
2021-08-12 sgrekhov@unipro.ru Fixes 1142. Fix tests expectations
2021-08-12 sgrekhov@unipro.ru Fixes 1143. Set called flag to true when constructor called
2021-08-12 sgrekhov@unipro.ru Fixes 1141. Fix typedefs in co19/LanguageFeatures/Constructor-tear-offs/summary_A01_t01 test
2021-08-12 sgrekhov@unipro.ru Fixes 1140. Typo fixed
2021-08-12 sgrekhov@unipro.ru Fixes 1139. Fix typo in test expectations
2021-08-11 sgrekhov@unipro.ru Fixes 1136. Make LanguageFeatures/Constructor-tear-offs/tearing_off_from_typedef_A07_t01 test stronger
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32x4 tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32x4List tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/ByteBuffer tests updated to check expectations correctly for web.
2021-08-10 sgrekhov@unipro.ru 1134. Read Dart --help from stdout on Windows
2021-08-10 sgrekhov@unipro.ru Fixes 1130. Test rewritten to test what is said in description
2021-08-10 sgrekhov@unipro.ru Fixes 1133. Typo in constructor tear-off test fixed
2021-08-10 sgrekhov@unipro.ru Fixes 1132. Typo in test expectations fixed
2021-08-10 sgrekhov@unipro.ru Fixes 1131. Compare lists using 'listEquals'
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-arm64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I6681b0a5c75aad70498e920b2fe47fe56d257853
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209918
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Note that there was a bug fix to `stringContainsInOrder` which does change the behavior.
Change-Id: I2ee39116f2704e6e196d7ab26d924726d4d801d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209844
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
shutdown during initialization
Subtle event queue execution ordering could result in an invalid DDS
instance being returned with the HTTP server instance not yet being
initialized. Calling shutdown() on this instance would cause a
LateInitializationError when trying to cleanup the server.
Fixes https://github.com/flutter/flutter/issues/86361
Change-Id: Idf1f271925d244811af4b61b3161ddcbc05c52eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209846
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
