languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 20:39:38 +00:00
Code Issues Packages Projects Releases Wiki Activity
33135 commits 11 branches 6011 tags 1.4 GiB
Commit graph

33135 commits

This branch
This branch
All branches
Author SHA1 Message Date
Guillermo López-Anglada 3193083293 remove dead code 
Fixes #24037
 2015-08-14 15:32:35 +02:00
Lasse R.H. Nielsen 51fa195f16 Revert "Make List constructor give better error messages for non-int arguments" 
There are VM-only tests that assume exact text of failure.

BUG=

Review URL: https://codereview.chromium.org//1294483003 .
 2015-08-14 15:05:17 +02:00
Asger Feldthaus e1f4ae5482 Revert "dart2js cps: Compile some loops as 'for' loops." 
This reverts commit 296cb0b5b4.

TBR=kmillikin@google.com

BUG=

Review URL: https://codereview.chromium.org//1291333002 .
 2015-08-14 14:34:04 +02:00
Lasse R.H. Nielsen 33c7663826 Make List constructor give better error messages for non-int arguments 
BUG= http://dartbug.com/15986
R=herhut@google.com, iposva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1214723009 .
 2015-08-14 13:44:19 +02:00
Lasse R.H. Nielsen 43f6230376 Make uncaught errors terminating isolates only get printed if nobody is listening. 
If an isolate has an error port attached, then the uncaught error is not printed
when it causes the isolate to terminate.

Fixes issue 24052
BUG= https://github.com/dart-lang/sdk/issues/24052

Review URL: https://codereview.chromium.org//1286163002 .
 2015-08-14 12:48:01 +02:00
Asger Feldthaus 296cb0b5b4 dart2js cps: Compile some loops as 'for' loops. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1287253002 .
 2015-08-14 12:09:32 +02:00
Asger Feldthaus 0e46c8dec9 dart2js cps: Add logical rewriter rules to favor null-aware operators. 
These useful patterns arise with null-aware operators:

x ? y : x  ==>  x && y
x ? x : y  ==>  x || y

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1291073002 .
 2015-08-14 12:07:39 +02:00
Asger Feldthaus c659bda53b dart2js cps: Bugfixes in .push rewrites. 
Two consecutive pushes would sometimes be merged in a way that one of
the arguments could fall out of scope.

List.addAll with a literal list as argument would sometimes be rewritten
to a push, even though the list could be modified before the use.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1286123005 .
 2015-08-14 12:07:11 +02:00
keertip ee089eda75 revert update to dartdoc tag; have to update markdown too. 
Review URL: https://codereview.chromium.org//1288143005 .
 2015-08-13 18:38:40 -07:00
keertip 81832659d8 update dartdoc tag in DEPS 
BUG=
R=sethladd@google.com

Review URL: https://codereview.chromium.org//1292643004 .
 2015-08-13 18:06:06 -07:00
Sigmund Cherem e3fbf44643 dart2js: add function coverage tracking in dart2js output, dumpinfo, and 
coverage recording server

R=sra@google.com

Review URL: https://codereview.chromium.org//1288593002 .
 2015-08-13 16:47:58 -07:00
Ryan Macnak 3851c8c0ed Add Regex isCaseSensitive and isMultiLine to the service protocol and Observatory. 
BUG=http://dartbug.com/24039
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1284063003 .
 2015-08-13 15:50:02 -07:00
John McCutchan 119e72ded2 Improve timeline iterators and tests 
- Refactor TimelineEventBlockIterator
- Add TimelineAnalysisThreadEventIterator
- Add test of TimelineAnalysisThreadEventIterator.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1297443002 .
 2015-08-13 15:44:04 -07:00
Ryan Macnak d47827b88e Port "Add mapping from address to id for runtime functions." 
Delete some out-of-sync DECLAREs.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1288953003 .
 2015-08-13 14:42:31 -07:00
John McCutchan d4fbd8309e Ensure TimelineEventRingRecorder outputs blocks in increasing time order 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1283093004 .
 2015-08-13 14:22:46 -07:00
Srdjan Mitrovic ce439a353c Trace CHA optimizations (where, when, why) 
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1289933002 .
 2015-08-13 13:47:34 -07:00
John Messerly 6417c36b0a [analyzer] remove "auto-generated do not edit" comments 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1291143002 .
 2015-08-13 13:36:02 -07:00
John McCutchan f77bab1c62 Allow TimelineAnalysis to work on any TimelineEventRecorder 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1295563002 .
 2015-08-13 13:18:26 -07:00
Daniel Andersson bc149bf2f5 Migrate most uses of StackZone(Isolate*) to Thread*. 
Also migrate some HANDLESCOPE uses.
This prepares for concurrent compilation.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//1285293004 .
 2015-08-13 13:11:30 -07:00
Daniel Andersson b739b6319f Add NoSafepointScope to ObjectPointerVisitor. 
Also update some uses of NoHandleScope to NoSafepointScope, which basically means "do not risk GC here".

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1292063004 .
 2015-08-13 12:59:32 -07:00
John McCutchan e8d1e85b08 Make TimelineRingRecorder use TimelineEventBlocks 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1287383002 .
 2015-08-13 12:46:40 -07:00
John McCutchan 67a7aeaf12 Add _sdkext support back to analysis server 
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1295463003 .
 2015-08-13 12:24:37 -07:00
Daniel Andersson d9bb318a04 Reduce size of test StackLimitInterrupts to avoid Win timeouts. 
TBR=johnmccutchan@google.com

BUG=

Review URL: https://codereview.chromium.org//1295433003 .
 2015-08-13 12:03:15 -07:00
Siva Annamalai 228e0877a7 Use Object::null_instance and Object::null_function and do not create Handles everytime. 
BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1289813005 .
 2015-08-13 10:57:18 -07:00
Harry Terkelsen 43e6b8b8db dart2js: remove trailing 0 byte when reading .packages 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1290643007.
 2015-08-13 10:11:58 -07:00
John McCutchan b951f92983 Update runtime's VIEW_VC url 
BUG=

Review URL: https://codereview.chromium.org//1290173002 .
 2015-08-13 10:00:10 -07:00
John McCutchan 71d7d7a4de Fix table cpu profile to work properly with non-dart functions 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1283413002 .
 2015-08-13 09:46:44 -07:00
Daniel Andersson e7fb1c8516 Compatible atomics: volatile for LoadRelaxed, replace FetchAndAdd with FetchAndDecrement. 
Using volatile on a word size location will generate a single move instruction without order guarantees and is supported on all compilers.

Replace FetchAndAdd with FetchAndDecrement, since the latter is sufficient and eaiser to implement portably (in particular on some Windows setups).

BUG=https://github.com/dart-lang/sdk/issues/24049
R=iposva@google.com

Review URL: https://codereview.chromium.org//1287853005 .
 2015-08-13 09:21:38 -07:00
Asger Feldthaus 0210c5c035 dart2js cps: Fix treatment of captured type variables. 
CLOSES=24064
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1286113003.
 2015-08-13 13:35:50 +02:00
Florian Loitsch f2d08149fd Don't delay values and errors from async/await functions. 
Fixes issue 23497.

R=hausner@google.com

Review URL: https://codereview.chromium.org//1287673002 .
 2015-08-13 13:00:11 +02:00
Florian Loitsch ad38b75bb2 Forward cancel subscription in stream pipes. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1284223005 .
 2015-08-13 12:57:35 +02:00
Lasse R.H. Nielsen 3134338fce Remove SDK constraint from package_test_data package. 
R=whesse@google.com

Review URL: https://codereview.chromium.org//1291983002 .
 2015-08-13 12:09:49 +02:00
Florian Schneider 00326794d8 VM: Remove obsolete workaround for a GC issue in the deoptimization stub. 
This was part of a temporary fix for issue dartbug.com/14790.
(https://codereview.chromium.org//59073012), but does not seem
necessary: Stub frames are now like regular Dart frames (with a 0 PC marker).

Follow-up fixes for issue 14790 for reference:
https://codereview.chromium.org/63093003/
https://codereview.chromium.org/62953014/

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//1279713002 .
 2015-08-13 11:26:59 +02:00
Asger Feldthaus 75b6bd1e0f dart2js cps: Type a list literal as extendable, not just mutable. 
This would prevent rewriting into .push and .pop.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1286193003.
 2015-08-13 10:48:40 +02:00
Anders Johnsen 54b7e9fec4 Fix arguments passed to FileSystemException from _socketType, when failing to resolve the type. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1293433003 .
 2015-08-13 09:32:26 +02:00
John McCutchan 3dd39ef37c Fix cpu profile table 
- Add back deleted call to buildFunctionCallerAndCallees
- Pass in caller count and not callee count (copy and paste bug)
- Add to isolate drop down

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1288853002 .
 2015-08-12 17:38:34 -07:00
Adam Barth d6ff3530c7 Fix the Mac build 
TBR=asiva@google.com

Review URL: https://codereview.chromium.org//1287883004 .
 2015-08-12 16:54:12 -07:00
Adam Barth bc88578fe1 Add Dart_ListGetRange 
This API lets you get multiple values out of a list at once, saving overhead.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1284633004 .
 2015-08-12 16:46:38 -07:00
John McCutchan cacacfa645 Hide empty CPU profile on class page 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1290023002 .
 2015-08-12 16:39:23 -07:00
Harry Terkelsen 44f890b3c8 dart2js: don't add a trailing slash when reading --packages 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1290903002.
 2015-08-12 16:28:47 -07:00
John McCutchan 2ecf40450c Make function-ref only show a link for Dart functions 
BUG=

Review URL: https://codereview.chromium.org//1289803007 .
 2015-08-12 16:13:26 -07:00
John McCutchan 7af879a084 Fix time span in profiler 
BUG=

Review URL: https://codereview.chromium.org//1287033006 .
 2015-08-12 16:03:27 -07:00
John McCutchan 8e91f1a7c3 Fix heap map 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1291873002 .
 2015-08-12 15:31:17 -07:00
John McCutchan f9944c1c4c Synchronize isolate dropdown with isolate summary 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1285143004 .
 2015-08-12 15:21:06 -07:00
Ryan Macnak 82b4f03dec Fix overly-strict parameter checking of _getCallSiteData. 
Ensure padding between columns in allocation profile.

Desaturate the red used for methods with optimization issues.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1287043007 .
 2015-08-12 15:20:46 -07:00
John McCutchan 10de20f230 Remove load graph from isolate 
BUG=

Review URL: https://codereview.chromium.org//1290643005 .
 2015-08-12 15:13:11 -07:00
John McCutchan 0ae89cf980 Fix MacOS build 
BUG=

Review URL: https://codereview.chromium.org//1286093005 .
 2015-08-12 15:01:21 -07:00
Paul Berry 94471ea0a3 Fix task dependency graph computation. 
Previously, when analyzing the analyzer for task dependency graph
computation, we failed to canonicalize Source URIs into "package:"
URIs.  As a result, we failed to properly connect the classes
representing individual classes with the base class AnalysisTask, so
we couldn't find any task classes and produced an empty graph.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1287003006 .
 2015-08-12 14:46:32 -07:00
Konstantin Shcheglov 7ab954efb5 Remove debug output in getNavigation(). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1288163003 .
 2015-08-12 14:02:07 -07:00
John McCutchan 4511599443 Start TimelineAnalysis utility 
- Add TimelineEventBlockIterator - iterate over TimelineEventBlocks.
- Add TimelineAnalysisThread - All events for a specific thread.
- Add TimelineAnalysis - Utility for analyzing timeline events.
- Add unit test for TimelineAnalysis thread discovery and block sorting.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1284263002 .
 2015-08-12 13:31:31 -07:00