Nate Bosch
94f45c8876
Bring in the latest pub
...
Bug: 32593
Change-Id: I4a8ce82591249968cfb00e9c57ddf75afb760d14
Reviewed-on: https://dart-review.googlesource.com/52700
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-04-26 00:01:35 +00:00
Alexander
9d4514bb9e
[release] Merge changelog from dev branch into master
...
TBR=whesse@google.com
Change-Id: Ib30ca03e2068ebe05a7f00902afcfe62c7ebbc4f
Reviewed-on: https://dart-review.googlesource.com/51663
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-18 18:50:35 +00:00
Natalie Weizenbaum
54531ad4e7
Bring in the latest pub_semver
...
Change-Id: Icb7419e0922c9bf8a794a324c4da15f1da0e3074
Reviewed-on: https://dart-review.googlesource.com/51200
Reviewed-by: Gary Roumanis <grouma@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-04-16 21:14:59 +00:00
Lasse R.H. Nielsen
7cc4d76a30
Add tryParse alternatives to parseFunctions.
...
Deprecate `onError` arguments to parse methods.
Change-Id: Iac1d87416abc8a73ce1853edffab49df8a8cb5fe
Reviewed-on: https://dart-review.googlesource.com/50723
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-04-12 13:16:49 +00:00
Natalie Weizenbaum
7689dc9e06
Bring in the latest pub_semver
...
Change-Id: Ibd772c70d596fdc32c6654a058bf44ef0ab787a0
Reviewed-on: https://dart-review.googlesource.com/49827
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-04-10 01:41:09 +00:00
Devon Carew
6ce79da9a1
Fix windows issues w/ the packages dir handling removal.
...
Change-Id: I78cf4b8787da7449f8a7a2840b9dd91e2342d5ec
Reviewed-on: https://dart-review.googlesource.com/49830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-04-06 16:24:52 +00:00
Devon Carew
7cbd0f55b5
Remove the special casing of 'packages' files from the analyzer and analysis server.
...
Change-Id: I11fa2f73f7cdba8c53478c9002cefe82e58c09d6
Reviewed-on: https://dart-review.googlesource.com/49822
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-04-06 14:57:42 +00:00
Lasse Reichstein Holst Nielsen
8ada18e9a1
Mention removal of defaultValue
parameter on stream methods in changelog.
...
Also remove mentions in documentation.
Change-Id: I51ad3137fff505168acde7f2e21bebc42a49da3b
Reviewed-on: https://dart-review.googlesource.com/49721
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-04-06 10:35:52 +00:00
Natalie Weizenbaum
a0a06e172c
Bring in the latest pub_semver
...
Change-Id: I8ba26694c1b52d47ac335117c863de26b432d084
Reviewed-on: https://dart-review.googlesource.com/49320
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-04-03 23:38:11 +00:00
Terry Lucas
49558b9c4c
Fixed MessageChannel receiveing messages on ports.
...
Removed pkg browser from tests.
Fixes https://github.com/dart-lang/sdk/issues/26351
Fixes https://github.com/dart-lang/sdk/issues/32631
R=kevmoo@google.com
Change-Id: Ib0ef5f933d38b2f748cca1f82de8bcf01702df4d
Reviewed-on: https://dart-review.googlesource.com/48742
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-30 17:16:15 +00:00
Zach Anderson
865f52737a
[dart:io] Adds IOOverrides.socketConnect
...
fixes #32535
Change-Id: I335e3698ec3505114d480ae6179254fa0ade3f7a
Reviewed-on: https://dart-review.googlesource.com/48702
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Todd Volkert <tvolkert@google.com>
2018-03-28 23:07:49 +00:00
Natalie Weizenbaum
d46915d239
Bring in the latest pub
...
Change-Id: If138dd10ebae40bf031c05d9702f166abfb511e5
Reviewed-on: https://dart-review.googlesource.com/48525
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-03-28 21:50:28 +00:00
Sam Rawlins
301b5a1f16
Remove Maps; move _fillMapWith* methods to MapBase
...
Fixes #31843
Bug: https://github.com/dart-lang/sdk/issues/31843
Change-Id: I02c544c921951f4a50421205dc1f25997cbecd6e
Reviewed-on: https://dart-review.googlesource.com/39880
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-03-26 21:23:21 +00:00
Sigmund Cherem
05207c5c87
Remerge changelog: it seems I merged the log with 2.0.0-dev.41, not with the tip
...
of the dev channel.
TBR
Change-Id: Iab49de4007a6fe677417d1b83cd48114a8d73310
Reviewed-on: https://dart-review.googlesource.com/48090
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-23 20:14:10 +00:00
Sigmund Cherem
2ef5bbf853
Add entries to changelog
...
Change-Id: I7f5994fbaf3ca91beb4bae7892cc79075c9cc61e
Reviewed-on: https://dart-review.googlesource.com/48089
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-23 19:22:16 +00:00
Kevin Moore
4905a2da7c
Fix pub issues links from bde48c67ec
...
Change-Id: Id28c8d57c9cede6780e3f83ad4a05e32dfcb3e33
Reviewed-on: https://dart-review.googlesource.com/47722
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-22 01:12:12 +00:00
Kevin Moore
bde48c67ec
Update pub dependency
...
Closes https://github.com/dart-lang/sdk/issues/32622
Change-Id: I5677acf9f069d4786544dfa6b3cd2a05af77e7b2
Reviewed-on: https://dart-review.googlesource.com/47682
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2018-03-22 00:54:36 +00:00
Kevin Moore
95089a2eeb
cleanup CHANGELOG for -dev.39 and -dev.40
...
Change-Id: Id9c52edb419fdbf3dfdbfdc34e5df1759c4a84a6
Reviewed-on: https://dart-review.googlesource.com/47681
Reviewed-by: William Hesse <whesse@google.com>
2018-03-22 00:12:10 +00:00
Terry Lucas
3d34f4d4fe
Updated CHANGELOG with Chrome 63 roll changes and fixed status file test now passes.
...
TBR=whesse@google.com
Change-Id: Ie48a6023cc3c0abecb8347b1a2f3ce774d42681a
Reviewed-on: https://dart-review.googlesource.com/47243
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-20 15:14:38 +00:00
Alexey Knyazev
4f1f5f8167
Reland "Do not return this on RandomAccessFile.close"
...
This is a reland of 44aa9a17fd
Original change's description:
> Do not return this on RandomAccessFile.close
>
> Bug: 32015
> Change-Id: I98508bdad569201afeed91f1287f061b5bb39a31
> Reviewed-on: https://dart-review.googlesource.com/44060
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Bug: 32015
Change-Id: I96d870e083d7862cf0f6ad664364cf7ddef0f598
Reviewed-on: https://dart-review.googlesource.com/46780
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2018-03-19 13:45:25 +00:00
Alexandre Ardhuin
d0f4d7e229
update CHANGELOG for new hints
...
Fixes #32518
Closes #32524
https://github.com/dart-lang/sdk/pull/32524
GitOrigin-RevId: 7779b37697bf522b9d7d1dd3b6cbb9e67191b70c
Change-Id: I15f7cb3cb69e6c3fb6db57943f73f9187b499d1e
Reviewed-on: https://dart-review.googlesource.com/46423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-16 15:43:37 +00:00
Sigmund Cherem
b24a9d8ee6
Roll pub once again: this allows reenables suing the CFE from pub-build
...
Change-Id: Ia1dba48f3b7f74891d30a0e4065ab4ed53187d96
Reviewed-on: https://dart-review.googlesource.com/46821
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-15 22:24:34 +00:00
William Hesse
ca0776ba3c
CHANGELOG: Add section for current dev release changes
...
Change-Id: Iba39c924b6914f569acfec0d197e5a419397a513
Reviewed-on: https://dart-review.googlesource.com/46581
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-15 16:29:46 +00:00
Sigmund Cherem
c438f8b3f4
Dart2js defaults to the new common front-end
...
Change-Id: Id0f69d258b010a746b56e259335185bcca7dafec
Reviewed-on: https://dart-review.googlesource.com/45143
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-13 19:25:59 +00:00
Sigmund Cherem
e5f490fb00
Roll a new version of pub
...
There was only 1 change since the last roll.
Change-Id: I44a8ef56bc16d4bc4616480025125f1ca64beff8
Reviewed-on: https://dart-review.googlesource.com/46221
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-13 15:37:09 +00:00
Lasse R.H. Nielsen
00dae36b47
Add of
constructors to collections.
...
Change-Id: Ic9a180cbb758cf8fe51369d904fa4b51fd1b8e27
Reviewed-on: https://dart-review.googlesource.com/44480
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-13 12:57:49 +00:00
Lasse Reichstein Holst Nielsen
0b5d718489
Change return type of decodeBase64 to Uint8List.
...
Matches base64.decode.
Change-Id: Ida4e2a450940217959089d5bc48b6462b52df755
Reviewed-on: https://dart-review.googlesource.com/46140
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-13 08:12:52 +00:00
Lasse Reichstein Holst Nielsen
414a3318ea
Add jsonDecode, jsonEncode, base64Decode, base64Encode, base64UrlEncode functions.
...
Change-Id: Ic65ada3b107cc8e6c3459459c4bea389feef2168
Reviewed-on: https://dart-review.googlesource.com/23664
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-12 09:16:27 +00:00
Leaf Petersen
4c881188b2
Disable the .whereType method until generic methods are turned on.
...
The whereType method silently does the wrong thing without methods,
so make it throw until we turn them on everywhere.
Change-Id: Id934c8bdb4f682dbc3560d78fbca580e37297e2d
Reviewed-on: https://dart-review.googlesource.com/45744
Reviewed-by: Nate Bosch <nbosch@google.com>
2018-03-08 23:14:22 +00:00
Lasse Reichstein Holst Nielsen
b3c12d4e3a
Dart 2 Libraries Wave 3
...
Add `typeArguments` to Invocation.
Add constructors to Invocation, making it less necessary for users to create their own implementations.
Add tests.
Add Symbol.unaryMinus and Symbol.empty constants.
Change-Id: I70cb3265f9413617cf57fce1297e393a29eeb26a
Reviewed-on: https://dart-review.googlesource.com/40741
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-08 16:36:07 +00:00
Vyacheslav Egorov
675048d0b6
Add pragma class to dart:core.
...
This class can be used to annotate declarations with
tool specific hints.
For example @pragma('vm:extern') can tell that a method is invoked from
outside (e.g. via VM C API), which informs Kernel based tools not to
tree-shake this method.
Design doc (internal) https://docs.google.com/document/d/1yqje8uctBqITcwKxhebb0EHunY1bt0Qd4yZExrTHIW8/edit
Change-Id: Icf2106accfb1167124582466a3a55486d432793d
Reviewed-on: https://dart-review.googlesource.com/43062
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2018-03-07 11:01:57 +00:00
Natalie Weizenbaum
699f7bc1b1
Bring in the latest pub
...
Closes #32030
Bug: 32030
Change-Id: I349bfff94ebd2700f9950ed151da08c0becc9500
Reviewed-on: https://dart-review.googlesource.com/44022
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-02-27 23:49:46 +00:00
Lasse R.H. Nielsen
8d38d94ddb
Add static list methods.
...
Change-Id: I40574d695826a3ed038c7c756ce980fae001325d
Reviewed-on: https://dart-review.googlesource.com/43040
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-02-26 11:34:43 +00:00
Kevin Moore
696a8fcfa9
Changelog updates for SDK APIs through -dev.28
...
Excluding web-specific APIs – for now
Change-Id: I7a1c9b5550e1104d89dc1b338bc485e5324b5cc6
Reviewed-on: https://dart-review.googlesource.com/42889
Reviewed-by: Zach Anderson <zra@google.com>
2018-02-22 04:12:44 +00:00
Kevin Moore
f5a8ac6c95
Update changelog entries for Dart 2 library changes
...
Includes async, cli, collection, convert, and core through -dev.28
Change-Id: I8b8769196e14a7d3952575edf1c79d54d8007523
Reviewed-on: https://dart-review.googlesource.com/42522
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-21 01:36:15 +00:00
Mike Fairhurst
4c402f06da
Add void semantic changes to the changelog, as they are now.
...
Deliberately a bit vague so that it is compliant with various subtle
changes that could still occur. Also, some suggestions to help people
migrate mockito, broadened into more general advice.
Bug: 32117
Change-Id: I93ee5575e85a6fb5f7fc7d2c5806b237a19c0ce4
Reviewed-on: https://dart-review.googlesource.com/40505
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2018-02-12 02:15:58 +00:00
Lasse R.H. Nielsen
f72e327df7
Add new Iterable/List/Set/Map changes to CHANGELOG.md.
...
Change-Id: I3486631d64f37fe66ee38c3f87dfd4e053bc7a30
Reviewed-on: https://dart-review.googlesource.com/39660
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-07 14:58:11 +00:00
Florian Loitsch
3b8e4d41a7
Reapply "Run async functions immediately."
...
Which was reverted in commit 032be73dbe
.
Originally commited in commit 67bac0bce6
.
Original review URL: https://dart-review.googlesource.com/5263
Change-Id: Ic7333c29e502a3924dc6aade8ffa46fc8aa5b04a
Reviewed-on: https://dart-review.googlesource.com/38120
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-02 15:50:16 +00:00
Florian Loitsch
032be73dbe
Revert "Run async functions immediately."
...
This reverts commit 67bac0bce6
.
Reason for revert: broke the bot.
Original change's description:
> Run async functions immediately.
>
> Migrated from https://codereview.chromium.org/2478703003/
>
> Change-Id: I1d678c01ba5876490b12c676c500171328361d31
> Reviewed-on: https://dart-review.googlesource.com/5263
> Commit-Queue: Florian Loitsch <floitsch@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>
> Reviewed-by: William Hesse <whesse@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>
TBR=whesse@google.com ,rnystrom@google.com,vegorov@google.com,kustermann@google.com,zra@google.com,floitsch@google.com,jmesserly@google.com,vsm@google.com,regis@google.com,sigmund@google.com
Change-Id: I20c948057423c3fa5aa8c72843f8f2a17e086ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/37981
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-01 15:01:21 +00:00
Florian Loitsch
67bac0bce6
Run async functions immediately.
...
Migrated from https://codereview.chromium.org/2478703003/
Change-Id: I1d678c01ba5876490b12c676c500171328361d31
Reviewed-on: https://dart-review.googlesource.com/5263
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-02-01 14:08:57 +00:00
Lasse Reichstein Holst Nielsen
0c18b643c6
Add RegExp.escape methods.
...
Fixes 4706
Bug: http://dartbug.com/4706
Change-Id: If635cb0eb7c20405ab0127a443fe51176191b5ad
Reviewed-on: https://dart-review.googlesource.com/35641
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-02-01 09:56:47 +00:00
Leaf Petersen
991753313f
Remove deep future flattening from analyzer and DDC
...
Change-Id: Ic48f29adec3a46744b259ba5b2b8ad7d97caa6c2
Reviewed-on: https://dart-review.googlesource.com/37424
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-01-30 18:11:11 +00:00
Zachary Anderson
c8f1af91a1
[dart:io] Update changelog for ProcessStartMode.INHERIT_STDIO
...
Change-Id: I917152a42c3054021047724d49624dcee77481dc
Reviewed-on: https://dart-review.googlesource.com/36565
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-01-24 16:39:57 +00:00
Alexander Markov
3c3c50e352
Add CHANGELOG entry for fixed-size integers in VM
...
Change-Id: I47fd1aef8765e927899cda164ed5a3764eaaf51c
Reviewed-on: https://dart-review.googlesource.com/36080
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-01-19 21:55:40 +00:00
Natalie Weizenbaum
1065b68388
Update the CHANGELOG to include the latest pub changes
...
Change-Id: Iacdf8023b6d4c429e1e709ef97c874da3a6c78ca
Reviewed-on: https://dart-review.googlesource.com/35814
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-01-19 01:01:24 +00:00
Zachary Anderson
9c40a7e662
Reland: [dart:cli] Adds waitFor(Future)
...
This is a reland of https://dart-review.googlesource.com/#/c/sdk/+/28920/
with the following changes:
- It creates a new library dart:cli
- waitFor(Future) goes in dart:cli instead of dart:io
- Removes a flaky test, and adds a missing precompiler entrypoint
- Adds waitFor(Future)
- Improves doc comments
fixes #31102
Change-Id: I04d2c46fd0afac049dd4fd1353905dc20da18f90
Reviewed-on: https://dart-review.googlesource.com/29449
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-01-18 16:38:54 +00:00
Natalie Weizenbaum
ed431d5a61
Bring in the latest pub
...
Change-Id: I8d2d11394a07cd116147e2ae86f3326c85cfe0f7
Reviewed-on: https://dart-review.googlesource.com/33661
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-01-12 22:47:50 +00:00
Lasse R.H. Nielsen
4dd367c652
Fix return type of Base64Codec.decode
to say Uint8List
.
...
Update some documentation.
Change-Id: I4e05d89e84bd35068ca57917e752af235c62b647
Reviewed-on: https://dart-review.googlesource.com/32762
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-01-08 13:27:02 +00:00
Sam Rawlins
a8de95a55a
Update changelog with analyzer features
...
Change-Id: Ibf8f08d43bd84faad5fad10bf73996273175428b
Reviewed-on: https://dart-review.googlesource.com/32144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2018-01-03 20:51:04 +00:00
Zachary Anderson
0e826ed894
Remove entry from CHANGELOG.md for reverted change
...
Trying to reland here: https://dart-review.googlesource.com/c/sdk/+/29449
Change-Id: Ia823a0e59ac68e169ebd7302d75d3204422c6f31
Reviewed-on: https://dart-review.googlesource.com/31743
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-01-02 17:38:03 +00:00