Place the windows toolchain in the build root so it can be sent to RBE.
Use relative paths in debug symbols when building with Windows clang,
which is needed for remotely building with RBE.
Set the executable bit when invoking clang-cl remotely as it has not
been set on Windows RBE clients.
Stop including .rst files during build commands as @options-from-file
is not supported by rewrapper at this time.
Forward RBE_cfg into the msvc build environment and rewrite the
INCLUDE, LIB, and LIBPATH environment variables to use relative paths
instead of absolute paths.
Don't download reclient on windows-arm64 where there is no cipd
package and the windows-arm64 python lies and says it's x64 because
they actually packaged a x64 python.
Tune the Windows -j performance to match the historic bot performance
as most casual Windows machines won't handle -j 1000 well.
Bug: b/296994239
Change-Id: I2bd1b4478fca796f0a326c062a5f478f16c2c6ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343440
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
The scripts originate from Chromium, this CL syncs Dart's copy with Chromium tip of the tree at 6f8f710079b3e363f4fd7ffe3d848384e4b7c816.
Format toolchain/win/BUILD.gn
Change-Id: Ice7ba48bdd102ffe0e25c6ae6068f83cb14169ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253500
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Pass shell=True when invoking python, without
this flag Windows own python.exe is selected
even though it is shadowed in the PATH by
depot_tools' python.bat.
Change-Id: Ia581853ff5819f97f872761ff7557ba9d6028beb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200875
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
* Migrate to python3; drop python support.
* Update Windows toolchain support.
* Remove some unused methods.
* Python 2.7 is still needed on Windows.
* Update gsutil to a version that supports python3.
Fixes: https://github.com/dart-lang/sdk/issues/28793
TEST=Manually tested common user journeys.
Change-Id: I663a22b237a548bb82dc2e601e399e3bc3649211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192182
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.
Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Visual Studio is at 2017 Update 9 now.
Change-Id: Id577de7bf08e8ebedffbeec4c467f78b0f76adcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108906
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Changes to the canonical are the addition of a comment header and path-setting lines:
```
chrome_src = os.path.abspath(os.path.join(script_dir, os.pardir))
SRC_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
sys.path.insert(0, os.path.join(chrome_src, 'tools'))
```
TBR=aam@google.com
Change-Id: Ia79f6ba6cab1504c2e09370fccc03909862923ea
Reviewed-on: https://dart-review.googlesource.com/c/84630
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Changes to the canonical are only addition of a comment header and path-setting lines:
```
chrome_src = os.path.abspath(os.path.join(script_dir, os.pardir))
SRC_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
sys.path.insert(0, os.path.join(chrome_src, 'tools'))
```
Change-Id: I403c1d7dd56cc45fcddd93142e8929e8cd5ae75f
Reviewed-on: https://dart-review.googlesource.com/76705
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Reland of https://dart-review.googlesource.com/#/c/sdk/+/8168/ following
fixes to bots.
This is mainly to support upcomping changes in BoringSSL, and to keep
our version of MSVC up-to-date with Chromium.
Change-Id: Ibe5dbd97e6750072ff648b3967ac8396ab81bf64
Reviewed-on: https://dart-review.googlesource.com/9001
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This reverts commit 51ee5ce40e.
Reason for revert: The windows vm-product builder is crashing on all tests after this commit. The MSVC 2017 compiler apparently builds a crashing executable for product mode. Failing build is at https://luci-milo.appspot.com/buildbot/client.dart/vm-win-product-x64-be/8697
Original change's description:
> Reland: [Windows] Update toolchain to MSVC 2017
>
> Reland of https://dart-review.googlesource.com/#/c/sdk/+/8168/ following
> fixes to bots.
>
> This is mainly to support upcomping changes in BoringSSL, and to keep
> our version of MSVC up-to-date with Chromium.
>
> Change-Id: I861ee4ab10513b93ea3fb1c357766e0f942afd10
> Reviewed-on: https://dart-review.googlesource.com/8730
> Reviewed-by: William Hesse <whesse@google.com>
TBR=whesse@google.com,vegorov@google.com,zra@google.com,asiva@google.com
Change-Id: I465ad7586a76b27f6a9aa9431efbe0eb3d934b4e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/8800
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This reverts commit 42d93ff083.
Reason for revert: The windows bots don't have the correct authorization file to download our internal copy of MSVC 2017.
Original change's description:
> [Windows] Update toolchain to MSVC 2017
>
> This is mainly to support upcomping changes in BoringSSL, and to keep
> our version of MSVC up-to-date with Chromium.
>
> Change-Id: Id6148b74a7e986147faf721b2923599f148b8b3a
> Reviewed-on: https://dart-review.googlesource.com/8168
> Reviewed-by: William Hesse <whesse@google.com>
TBR=whesse@google.com,vegorov@google.com,zra@google.com,asiva@google.com
Change-Id: I89dd1c8250d997a01bbc8de1a13cd86d5342c316
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/8660
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This is mainly to support upcomping changes in BoringSSL, and to keep
our version of MSVC up-to-date with Chromium.
Change-Id: Id6148b74a7e986147faf721b2923599f148b8b3a
Reviewed-on: https://dart-review.googlesource.com/8168
Reviewed-by: William Hesse <whesse@google.com>
