Commit graph

64 commits

Author SHA1 Message Date
Siva Annamalai 33697f7339 Revert "Reland "[VM/SDK]""
This reverts commit b59583edea.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "[VM/SDK]"
> 
> This is a reland of b4146411d0
> 
> Original change's description:
> > [VM/SDK]
> > 
> > - Switch the kernel isolate to run in Dart2 mode
> > - Refactor build rules so bootstrapping of the front end happens
> >   with a prebuilt dart sdk
> > - Refactor application snapshot build rules so the kernel application
> >   snapshot rule does not get into a cyclic dependency during the
> >   bootstrap stage
> > 
> > Change-Id: Id16b2859e0b299b2d689971d03a247cb94d0aa26
> > Reviewed-on: https://dart-review.googlesource.com/61660
> > Commit-Queue: Siva Annamalai <asiva@google.com>
> > Reviewed-by: Zach Anderson <zra@google.com>
> 
> Change-Id: I2a3fa8ed4f331cf3de89ddff5cf8e478809dae39
> Reviewed-on: https://dart-review.googlesource.com/65841
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=zra@google.com,asiva@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I6077236481bec9089ead881c902036b0817114fc
Reviewed-on: https://dart-review.googlesource.com/66240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2018-07-23 18:07:29 +00:00
asiva b59583edea Reland "[VM/SDK]"
This is a reland of b4146411d0

Original change's description:
> [VM/SDK]
> 
> - Switch the kernel isolate to run in Dart2 mode
> - Refactor build rules so bootstrapping of the front end happens
>   with a prebuilt dart sdk
> - Refactor application snapshot build rules so the kernel application
>   snapshot rule does not get into a cyclic dependency during the
>   bootstrap stage
> 
> Change-Id: Id16b2859e0b299b2d689971d03a247cb94d0aa26
> Reviewed-on: https://dart-review.googlesource.com/61660
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Zach Anderson <zra@google.com>

Change-Id: I2a3fa8ed4f331cf3de89ddff5cf8e478809dae39
Reviewed-on: https://dart-review.googlesource.com/65841
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-07-19 22:04:56 +00:00
Siva Annamalai 7f5334480e Revert "[VM/SDK]"
This reverts commit b4146411d0.

Reason for revert: Seems to have build issues on certain bots

Original change's description:
> [VM/SDK]
> 
> - Switch the kernel isolate to run in Dart2 mode
> - Refactor build rules so bootstrapping of the front end happens
>   with a prebuilt dart sdk
> - Refactor application snapshot build rules so the kernel application
>   snapshot rule does not get into a cyclic dependency during the
>   bootstrap stage
> 
> Change-Id: Id16b2859e0b299b2d689971d03a247cb94d0aa26
> Reviewed-on: https://dart-review.googlesource.com/61660
> Commit-Queue: Siva Annamalai <asiva@google.com>
> Reviewed-by: Zach Anderson <zra@google.com>

TBR=zra@google.com,asiva@google.com

Change-Id: I4fc5b81e0a102bde4e8b4f737af3825e9728be3b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/65840
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2018-07-19 21:20:39 +00:00
asiva b4146411d0 [VM/SDK]
- Switch the kernel isolate to run in Dart2 mode
- Refactor build rules so bootstrapping of the front end happens
  with a prebuilt dart sdk
- Refactor application snapshot build rules so the kernel application
  snapshot rule does not get into a cyclic dependency during the
  bootstrap stage

Change-Id: Id16b2859e0b299b2d689971d03a247cb94d0aa26
Reviewed-on: https://dart-review.googlesource.com/61660
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-07-19 20:48:18 +00:00
Janice Collins 753d95453c Move to dartdoc 0.20.0 and enable preview-dart-2.
Change-Id: I8e1b7957a416644b8c7d02bee60c248e6c6d9827
Reviewed-on: https://dart-review.googlesource.com/57444
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-05-30 19:08:41 +00:00
Ryan Macnak 61b15fede8 [build] Remove unnecessary inputs from uses of application_snapshot.
These dependencies are tracked via a depfile generated along with the snapshot.

Change-Id: I4245a982212a5aff28aea8456d0219808df54af0
Reviewed-on: https://dart-review.googlesource.com/51245
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-04-16 21:13:09 +00:00
Zach Anderson 0394d3a0cf [infra] Begin removing gyp
This CL begins removing gyp from Dart's tree.

Removing gyp will go in three stages:
1. Remove unused .gyp and .gypi files.
2. Translate *_sources.gypi files to *_sources.gni files
3. Remove //third_party/gyp from DEPS

This CL is stage 1.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2992593002 .
2017-08-04 22:19:35 -07:00
Zachary Anderson ccfafee023 Make list_files.py and list_dart_files.py return absolute paths for GN
This makes doing an SDK build in the Fuchsia tree easier.

The previous attempt at this change failed in gyp builds targeting xcode.
They failed because input lists for actions of the same target (e.g. the
actions for dartanalyzer) are merged and de-duped when the lists contain
relative paths, but merged and *not* de-duped when the lists contain
absolute paths. gyp rejects xcode files that it generated itself
when they contain duplicate entries.

This CL works around that bug, by using absolute paths in the GN build
and keeping relative paths in the gyp build.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2567213002 .
2016-12-13 10:01:28 -08:00
Zachary Anderson 90d3962ca3 Don't depend on dart_bootstrap if there is a usable prebuilt sdk
Also replace invoke_dart() with compiled_action(), and some other
cleanups.

fixes #27781

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2493833002 .
2016-11-10 11:16:24 -08:00
Zachary Anderson c1313a5ec7 Format GN files and add a presubmit check that GN is properly formatted
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2451613005 .
2016-10-26 08:50:54 -07:00
Ryan Macnak af7bf4dab0 GN: Build the SDK with app snapshots instead of script snapshots.
R=zra@google.com

Review URL: https://codereview.chromium.org/2442513003 .
2016-10-21 17:40:21 -07:00
Zachary Anderson ee21a2261d Use list_dart_files.py instead of list_files.py in GN build.
To track https://codereview.chromium.org/2391863002/ on the
gyp side, and use it in more places.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2392253002 .
2016-10-05 07:50:40 -07:00
Zachary Anderson 7c784cea9f Linux create_sdk GN build for host
This CL enables GN builds of all targets from dart.gyp
on Linux for the host (i.e. ia32, x64).

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2379803002 .
2016-09-29 13:23:00 -07:00
William Hesse 79b682b885 Add explicit package spec to snapshot build steps
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2372573002 .
2016-09-26 15:52:31 +02:00
William Hesse 0695b1db3a Remove package root target and support scripts
BUG=https://github.com/dart-lang/sdk/issues/23565
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2346163005 .
2016-09-20 13:32:50 +02:00
William Hesse 61eee9ee52 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Committed: 5d3e356ca7

Review URL: https://codereview.chromium.org/1746743002 .

Reverted: 6d238ba197
2016-09-16 15:03:18 +02:00
William Hesse 6d238ba197 Revert "Use checked-in .package file for building and testing"
This reverts commit 5d3e356ca7.

BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2340813004 .
2016-09-15 15:46:49 +02:00
William Hesse 5d3e356ca7 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1746743002 .
2016-09-15 14:50:30 +02:00
William Hesse 0cbe042935 Add .gitignore file for utils/dartdoc.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1307903002 .
2015-08-21 13:50:59 +02:00
keertip 3865dd8748 create dartdoc snapshot, add to dart-sdk. Also add resources needed to run dartdoc from the sdk.
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1295073003 .
2015-08-19 08:02:41 -07:00
rnystrom@google.com 458908f549 Get dartdoc in the SDK and working correctly.
Review URL: https://chromiumcodereview.appspot.com//9555013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4905 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-02 22:28:00 +00:00
sigmund@google.com ee6a907611 isolates refactor: this change introduces 'dart:isolate' as a library. This is a
big global change, so let me explain in more detail. This refactoring CL does
the following:
- moves all the dart code for isolates in a common library (lib/isolate)

- changes frog to understand 'dart:isolate' imoprts by loading the code from the
  location above.

- changes the vm to undernstand 'dart:isolate' imports by creating a separate
  library that is part of the bootstrap. This follows the same code-structure
  that Todd suggested in his CL introducing the mirror library

- changes dartc to use the shared isolate library as the source of truth for
  type checking. I left around some of the internal js code in dartc so that the
  backend continues to work for apps that don't use isolates.

- changes all tests that use isolates to import the library explicitly (this is a large bulk of the files in this CL)

- changes test status for tests we can't fix in this repo (e.g. co19)

- splits the isolate library code to make it possible to preserve some tests
  without exposing internal types (e.g. tests about
  serialization/deserialization)

- changes the create_sdk script to copy the isolate library to the sdk

- includes the isolate library in dartdoc

I'll wait for at least one lgtm from each area (dartc, vm, frog, sdk)

There is one important pending thing this CL doesn't do:
- update test_runner.dart: This should be updated next time we upload the new
  binaries to tool/testing/bin
- dartium specific changes: Vijay, is there anything I need to do for dartium?

Review URL: https://chromiumcodereview.appspot.com//9422019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4647 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-27 22:50:44 +00:00
rnystrom@google.com 6eb0081153 Make dartdoc and apidoc run on the VM instead of node.
Review URL: https://chromiumcodereview.appspot.com//9453031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@4558 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-23 23:56:02 +00:00
rnystrom@google.com 83f745ae61 Correctly sort libraries by name, not key.
Review URL: https://chromiumcodereview.appspot.com//9316050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3825 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-02 00:44:20 +00:00
rnystrom@google.com cfe03739c2 Integrate VM IO libraries and search box into apidoc.
Review URL: https://chromiumcodereview.appspot.com//9319001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3766 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-01 00:35:45 +00:00
rnystrom@google.com a60cd8608d Fix build break in dartdoc.
Review URL: https://chromiumcodereview.appspot.com//9318013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3763 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-31 23:33:46 +00:00
rnystrom@google.com 7abda05053 Integrate MDN content into API documentation.
Most of the code under mdn/ is Jacob's magic with a little extra hackery
on my part.

Review URL: https://chromiumcodereview.appspot.com//9225039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3750 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-31 21:33:41 +00:00
rnystrom@google.com 420b355357 Include subtype information in generated docs.
With this change, dartdoc does a more comprehensive job of letting users
navigate the web of types. For each class, this will show its chain of
superclasses, interfaces it implements, and its immediate subclasses.

For interfaces, it shows superinterfaces, subinterfaces, implementing classes,
and a default class if it has one.

Review URL: https://chromiumcodereview.appspot.com//9271020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3515 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-23 21:51:53 +00:00
rnystrom@google.com 7e2ea12a4c Add a mode to dartdoc to generate the navigation on the client.
Right now, the generated docs are pretty huge (100MB for all of the main libs). This is mainly
because each generated HTML page includes full navigation for each type in the containing
library. For stuff like dart:html, that's tons of HTML. Even after compression, the docs are
9.2MB. Also, they take a long time to generate (30s on my laptop).

This patch adds a mode you can use called "live-nav" (and makes it the default). With that
mode, pages do not include navigation. Instead, we generate a single nav.json file with the
navigation data. Client-side Dart code does an XHR for that and then renders the navigation
on the fly.

This gets the generated docs down to 13.3MB (2MB after compression) and gets doc generation
up to 6.3s for everything.

The two downsides are:

1. There's a visible flash on page load when it renders the nav since it's asynchronous.
2. You can't browse docs locally just using file://. To be able to XHR the nav.json, you
   either need to enable file access in your browser or run a local server.

Review URL: https://chromiumcodereview.appspot.com//9256002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3445 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-19 20:10:51 +00:00
rnystrom@google.com 0201ba42f6 Fix copying dartdoc static files.
Review URL: https://chromiumcodereview.appspot.com//9249006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3385 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-18 04:35:57 +00:00
nweiz@google.com 70bbde3ead Add the ability to link to members and constructors of other classes in Dartdoc.
The syntax is [Class.member] and [new Class], respectively.
[new Class.namedConstructor] also works.

Review URL: http://codereview.chromium.org//9146016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3217 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-12 00:21:27 +00:00
rnystrom@google.com 5bf318ec21 Hook up the dartdoc tests to test.py, test.dart, and frog/presubmit.py.
Review URL: http://codereview.chromium.org//9147058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3207 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-11 21:29:13 +00:00
nweiz@google.com ecc9b0b8e0 Add the dummy test file for the dartdoc tests.
TBR

Review URL: http://codereview.chromium.org//9169002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3127 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-10 02:24:06 +00:00
rnystrom@google.com e1894718ab Display negate operators correctly in dartdoc.
Review URL: http://codereview.chromium.org//9166002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3126 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-10 01:53:07 +00:00
nweiz@google.com eb6b2f9fd7 Naming change for code review.
TBR

Review URL: http://codereview.chromium.org//9153010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3121 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 23:15:27 +00:00
nweiz@google.com df490b9c9c Add some tests for dartdoc name reference resolution.
Currently these just test existing behavior, but the goal is to set the stage
for adding more advanced resolution.

TBR

Review URL: http://codereview.chromium.org//9150011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3117 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 22:39:24 +00:00
nweiz@google.com f67c7c44af Get dartdoc running again.
TBR

Review URL: http://codereview.chromium.org//9152013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3116 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 22:33:48 +00:00
rnystrom@google.com c5dcf9f658 Don't fix up paths that are already absolute.
Fixes the broken api.dartlang.org link the API docs.

Review URL: http://codereview.chromium.org//8958017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2789 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-22 21:56:12 +00:00
rnystrom@google.com a258c29303 Fix typo in dartdoc README.
Review URL: http://codereview.chromium.org//8958013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2779 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-22 19:51:58 +00:00
rnystrom@google.com e66f5a3e6c Hook up favicon, link to main page, and fix process bug.
Review URL: http://codereview.chromium.org//9020028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2735 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-21 23:35:24 +00:00
rnystrom@google.com a2e2ab6d23 Tweak dartdoc look to match dartlang.org a bit more.
Also prepare for adding search box.

Review URL: http://codereview.chromium.org//9019001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2715 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-21 18:46:12 +00:00
rnystrom@google.com f8fbe4dda3 Syntax highlighting on the client.
Instead of having dartdoc bake the syntax highlighting into the generated
HTML, this does that transformation client-side. This makes interact.js
bigger, but reduces the size of the generated HTML.

Contributed by michael.haubenwallner@gmail.com.

Review URL: http://codereview.chromium.org//9004030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2658 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 19:46:53 +00:00
rnystrom@google.com 91218f5967 Move markdown library.
This moves markdown into two places:

- The one under samples/ is intended to be a "real" markdown parser.
  Eventually, it will probably live as a third-party library outside of our
  standard lib but still easily accessible.
- The one inside dartdoc will change to become the parser used to parse
  Gilad's forthcoming dartdoc comment syntax.

Review URL: http://codereview.chromium.org//8953042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2606 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 01:36:07 +00:00
rnystrom@google.com 4354008724 Fix use of now-reserved word "class".
Review URL: http://codereview.chromium.org//9003001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2602 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-20 00:11:28 +00:00
rnystrom@google.com 036681063c Move Nathan's HTML scripts over and rename to apidoc.
Review URL: http://codereview.chromium.org//8973004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2494 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-16 00:06:58 +00:00
rnystrom@google.com c188a720ee Document static members separately from instance ones.
Review URL: http://codereview.chromium.org//8963006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2493 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-15 23:25:22 +00:00
rnystrom@google.com 93324b5405 Refactor dartdoc into a class. Use method overriding to extend.
Review URL: http://codereview.chromium.org//8947005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2477 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-15 21:24:18 +00:00
rnystrom@google.com ce4f2b0d16 Include JSON in generated docs.
Review URL: http://codereview.chromium.org//8912015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2413 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-14 02:30:11 +00:00
rnystrom@google.com 430a969207 In the navigation, list exception types after other types.
Review URL: http://codereview.chromium.org//8885005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2223 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-08 03:31:41 +00:00
rnystrom@google.com 5168cde79f Fix displaying generic types.
Review URL: http://codereview.chromium.org//8888002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@2219 260f80e4-7a28-3924-810f-c04153c831b5
2011-12-08 02:22:55 +00:00