- Updates dependency constraints, primarily package:web to 0.5.1
- Uses named import for package:web as a good practice
- Updates README with a few links to relevant documentation resurces
Change-Id: Id36c27808887e11e0d620b8e3554b5e8333500e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357861
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
The move to URIs introduced a subtle bug here - we would use the mapped URI (which is almost always `file:`) to decide whether to show a file path, instead of doing it only if the unmapped URI was a `file` (eg. it could have been `package:` or `dart:`.
This wasn't caught by any tests here, but was caught in the Flutter roll (https://github.com/flutter/flutter/pull/145235). This fixes it and adds a new test that we verify the Source names for local files, packages, and dart: URIs.
Change-Id: I282bf935b9fa4016abeafd556dfd368950ee9611
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357325
Commit-Queue: Helin Shiah <helinx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Helin Shiah <helinx@google.com>
The VM is by default sound null safe and so it is not necessary to run
the benchmark again with --sound-null-safety flag.
Corresponding changes have been made to the actual benchmark suite.
TEST=ci
Change-Id: Id844da0e0c2e7b6b411a2fcecfdc3d1ec2232c35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357220
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
If search for package config fails, the resolved package config was
being represented as null causing the macro build to go looking for it
again and fail with a confusing error.
Instead, use empty Uri to represent failed search for package config.
The doc comment for the package config Uri says empty Uri means
"no package config", but that doesn't actually work; make it work.
The macro compile will still fail because it needs a package config
to find the macro deps.
R=johnniwinther@google.com
Change-Id: I3a0e3e4a976782f2f5e326537c7e0e6415d5fecf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356082
Auto-Submit: Morgan :) <davidmorgan@google.com>
Commit-Queue: Morgan :) <davidmorgan@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
This disables the running of the .dill for weak mode, in preparation
for the VM ending support for --no-sound-null-safety.
The environment keys are also refactored to be defined in one location.
Change-Id: Ia08177f074673c410c8d92a4832047849f008b4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/358160
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
This stops over-matching which was causing paths to be incorrect when there were multiple errors, breaking the expectation updater.
R=srujzs@google.com
Change-Id: I357d0c96ed2d5bc3658d6cc2eb9ca82f86860818
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357700
Commit-Queue: Morgan :) <davidmorgan@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Auto-Submit: Morgan :) <davidmorgan@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Add `bitops_unsigned_js_test.dart`, testing JS semantics with bit operations, and add `bitops_unsigned_shared_test.dart`, testing the semantics of bit operations in the subdomain (uint32) where the results coincide with webNumbers and with native numbers.
CoreLibraryReviewExempt: Is web specific, does have an area-web review.
Change-Id: I35ad1f78161a282780c3ec73da7823fee05c506c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158014
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
This was causing a bug in Cider where if the VM didn't have a pid set, it defaulted to -1, and killing -1 causes Linux to kill everything that it can.
Bug: https://github.com/dart-lang/sdk/issues/55209
Change-Id: I2dae8cf8ecf718a209df9db33f81cecf6ee48d39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357501
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
Closes https://github.com/dart-lang/sdk/issues/54320
Several improvements to the error reporting:
- Split errors to avoid parametrizing error strings.
- Use one error per member/toJS invocation.
- Highlight the invalid types in the signature.
Extra tests are added to get coverage for things like operators.
Change-Id: I6d8ac3cf0124730e7c2c0dab3a107da5d0263f7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347226
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Currently the immutable bit is a of function of the class. If we start having some instances of a class be immutable and others not, we will need separate clusters like we do for the canonical bit.
TEST=vm/dart/snapshot_immutable_bit_test
Bug: https://github.com/dart-lang/sdk/issues/55136
Cq-Include-Trybots: luci.dart.try:vm-appjit-linux-debug-x64-try
Change-Id: I073f28cabca8293b766aa7c0b224934a62bf9cb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356280
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
For package:collection, computing measures.
Before: 0:01:00.236000
After: 0:00:55.977000
So, about 7% faster.
I think this translates into actual completion speed up.
Change-Id: I45f0c0186d5988e6e1b043d465030668cd61335b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357982
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
For sdk/pkg/analyzer_cli
Before: 0:01:32.542000
After: 0:00:33.254000
So, about 3 times faster.
Change-Id: I8eae44eeefd5624f88a42fe37b8ae1c29427ee49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356310
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This reverts commit 1ab083ae48.
Revert "[vm] Unbreak build with -Wctad-maybe-unsupported"
This reverts commit 734e0735bd.
Revert "[vm, compiler] Account for pair locations in MoveArgumentInstr on riscv32."
This reverts commit 52f7908b27.
Reverting due to https://github.com/dart-lang/sdk/issues/55180: there is mismatch in the calling convention when invoking _IntListMixin.getRange.
R=kustermann@google.com
TEST=this is a revert
Change-Id: Ic3a3013706280ebd80b04d5e6a830e5f56987384
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357881
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
The updates the static error parser for the CFE to avoid capturing
previous messages as part of the path for the subsequent error.
Change-Id: I131f14000a874ff9336244372b47a3913237c939
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357323
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
I recently fixed a bug by adding a `sink.done.ignore()` into library code: https://dart-review.googlesource.com/c/sdk/+/351380
My thinking now is that is a bad idea because it allows errors to pass silently if the sink is not closed or flushed (and the results are awaited!). Instead, we should document this as a general pattern for sinks.
...but that isn't satisfying either. `sink.done.ignore()` really means "I promise that I will handle errors elsewhere" but there is no actual enforcement of that.
Bug:https://github.com/dart-lang/sdk/issues/54707
Change-Id: I92feb43b1b2c57933c2343f4b6d354792cd13d72
CoreLibraryReviewExempt: dart io documentation-only
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352442
Commit-Queue: Brian Quinlan <bquinlan@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
1. Remove all unsound null safety tests on the VM
2. Do not pass the --sound-null-safety flag on VM runs as it is the
default and this option is going to be removed soon.
Change-Id: I33d646cea4b6da8d144f3abe9fbc1b60a20e635b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357741
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`.
dartdoc (89a3b4a..b001a15):
b001a150 2024-03-13 Kallen Tu Remove ModelElementRenderer. (dart-lang/dartdoc#3717)
e8ee7983 2024-03-12 Kallen Tu Remove EnumFieldRenderer. (dart-lang/dartdoc#3716)
ecosystem (49a3cbb..5a900ca):
5a900ca 2024-03-12 Moritz Only check text files for "do not submit" string (dart-lang/ecosystem#243)
http (8da6e0e..5dfea72):
5dfea72 2024-03-11 Derek Xu Add getters to classes (dart-lang/http#1151)
test (ba64bbb..6a4e75a):
6a4e75a6 2024-03-13 Graciliano Monteiro Passos Update the documentation for the `skip` parameter in the `test` (dart-lang/test#2102)
web (51e594b..2f13cd5):
2f13cd5 2024-03-12 Devon Carew fix unresolved dartdoc links (dart-lang/web#200)
686827a 2024-03-12 Srujan Gaddam Remove reference to static interop and point to dart.dev page for JS interop (dart-lang/web#206)
9b7e29d 2024-03-12 Devon Carew Add a 'sourced from mdn docs' line to the MDN sourced dartdoc (dart-lang/web#198)
Change-Id: I99e68e24efda6f0f95ac3b0a51a2c76e0b0971f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357661
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This change may require a codereview from flutter side before moving
forward. See https://github.com/flutter/engine/pull/51072.
This reverts commit 283051acba.
Reason for revert: Redo the change with the similar one in flutter.
After this change, the next dart -> flutter roll needs extra cares
in https://github.com/flutter/engine/pull/51072. It also contains
more details about the reason why it could not be two-way
compatible.
Original change's description:
> Revert "[Fuchsia] Remove the legacy gn build rules for fuchsia"
>
> This reverts commit 094202bb91.
>
> Reason for revert: Break flutter, this change should happen after
> flutter being migrated to the same gn-sdk.
>
> Original change's description:
> > [Fuchsia] Remove the legacy gn build rules for fuchsia
> >
> > The updated test-scripts contains https://crrev.com/c/5341620 which
> > allows to generate fidl apis with an env var controlled location
> > rather than a hard-coded one. So the existing fuchsia gn build rules
> > in dart/sdk become obsolete and can be fully removed in favor of the
> > one in //third_party/fuchsia/gn-sdk/.
> >
> > Meanwhile the gn-sdk has been updated with
> > https://crrev.com/c/5325282 to use api-level version'ed idk but not
> > the ones in arch/.
> >
> > Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-arm64-try,vm-fuchsia-release-x64-try
> > Tested: ^^^^^
> > Bug: 40935282
> > Change-Id: I2ce958e6db1ff8221beef7b7ff953c32bb4525ba
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355283
> > Reviewed-by: Ryan Macnak <rmacnak@google.com>
> > Reviewed-by: Alexander Thomas <athom@google.com>
> > Commit-Queue: Zijie He <zijiehe@google.com>
>
> Bug: 40935282
> Change-Id: I7c455d1d362210523671c97d99ef018ede1743f4
> Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-arm64-try,vm-fuchsia-release-x64-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356307
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Zijie He <zijiehe@google.com>
> Reviewed-by: Derek Xu <derekx@google.com>
> Commit-Queue: Zijie He <zijiehe@google.com>
Bug: 40935282
Change-Id: Id5a9a98013350359037b19f8506f24158c9a3120
Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-arm64-try,vm-fuchsia-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356924
Commit-Queue: Zijie He <zijiehe@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
So that we don't suggest the partially type name as a type parameter.
It is a partial type argument actually.
Bug: https://github.com/dart-lang/sdk/issues/54773
Change-Id: I427d75524f9c6a7c298a8708ab01b362f7a564e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Change-Id: Ib360b96e3c21a337ebbf3a69113f07c73791c50f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357213
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Stop passing `null` as the member parameter of `_emitPropertyGet`.
Avoids the use of one method with multiple code paths and returns
to handle any situation because it becomes very hard to reason
about what original source code leads to each path.
Issue: https://github.com/dart-lang/sdk/issues/54463
Change-Id: I31ada0647816e8c7db2dac56a0a56fd50d9bd0a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357205
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
