languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity
47896 commits 11 branches 6011 tags 1.4 GiB
Commit graph

47896 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Berry
8bb13b8740 Verify that inference ignores setters with function-typed arguments. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2948693002 .
 2017-06-19 15:14:27 -07:00
Paul Berry
a4743540d0 Implement type inference for null-aware property gets. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2944933002 .
 2017-06-19 15:08:56 -07:00
Ben Konyi
9cd36a5b54 Updated failure type for Dartium test 
BUG=
R=sivachandra@google.com

Review-Url: https://codereview.chromium.org/2945893003 .
 2017-06-19 15:06:43 -07:00
Ryan Macnak
c15f6f8d94 Mark language/closure_cycles_test as slow on the arm64 bot. 
Review-Url: https://codereview.chromium.org/2945913002 .
 2017-06-19 14:08:21 -07:00
Paul Berry
fdf77ba36f Implement type inference for if-null expressions (a ?? b). 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2944903002 .
 2017-06-19 13:46:09 -07:00
Ben Konyi
22042b691f Updated language-dartium.status to expect compile time error for Language/Classes/Constructors/Generative_Constructors/initializing_formals_execution_t02 
BUG=
TBR=zra@google.com

Review-Url: https://codereview.chromium.org/2949643002 .
 2017-06-19 13:42:06 -07:00
Vijay Menon
ed8de04f08 Fixes for super tearoff in constructor 
Fixes #29932

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2944003003 .
 2017-06-19 13:39:53 -07:00
Ben Konyi
510c3f02ba Fixed language_analyzer2.status file to skip test until issue 29657 is resolved. 
BUG=

Review-Url: https://codereview.chromium.org/2950593002 .
 2017-06-19 13:36:18 -07:00
Ben Konyi
2cdfc0cdab Updated co19 status file to skip initializing_formals_execution_t02 until it is updated to expect a compilation error when trying to reinitialize a final field: https://github.com/dart-lang/co19/issues/114. 
BUG=

Review-Url: https://codereview.chromium.org/2944073002 .
 2017-06-19 13:14:03 -07:00
Paul Berry
e8131d6f1a Fix ParameterElementImpl.hasImplicitType for function-typed parameters. 
UnlinkedParam.type serves a dual role: for ordinary parameters it is
the declared type; for function-typed parameters it is the declared
return type.  So to determine whether a parameter has an implicit type
it is not sufficient to check whether UnlinkedParam.type is `null`.
We also need to check whether the parameter is function-typed.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2947703002 .
 2017-06-19 13:13:53 -07:00
Ben Konyi
b5cff3f68f Updated parser to produce error when trying to reinitialize final variables in class constructors. Fixes issue #29658. 
BUG=
R=asiva@google.com

Example:
Foo {
  final int x = 10;
  Foo(this.x); // Error
  Foo.named() : x = 42; // Error
}
Review-Url: https://codereview.chromium.org/2939553005 .
 2017-06-19 12:07:37 -07:00
Brian Wilkerson
d30c5070a2 Disable a test to fix the bots (TBR) 
Review-Url: https://codereview.chromium.org/2946763002 .
 2017-06-19 12:02:52 -07:00
Ryan Macnak
72e1775fd1 [arm, arm64] Implemented unaligned scalar float access. 
[arm64] Fix unaligned (u)int64 stores.

Fix unaligned access test to use host endianness.

Issue #22151

R=zra@google.com

Review-Url: https://codereview.chromium.org/2940883008 .
 2017-06-19 10:28:38 -07:00
Brian Wilkerson
eafc070479 Remove ReplacementRange 
R=danrubel@google.com, maxkim@google.com

Review-Url: https://codereview.chromium.org/2946573003 .
 2017-06-19 10:15:36 -07:00
Brian Wilkerson
fe368f956c Mark a test as slow to try to fix the bots 
Review-Url: https://codereview.chromium.org/2943363002 .
 2017-06-19 09:56:45 -07:00
Kevin Millikin
8340cfda55 Revert "Proper sequencing of _asyncStackTraceHelper in Kernel" 
This reverts commit 0489249d29.  The
change causes failures in the front end tests.

BUG=
R=sivachandra@google.com

Review-Url: https://codereview.chromium.org/2949533003 .
 2017-06-19 17:21:22 +02:00
Konstantin Shcheglov
f9dc588a27 Don't compute 'dart:core' LibraryElement during completion. 
AnalysisResult already has TypeProvider, which can give us Object type.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review-Url: https://codereview.chromium.org/2946643002 .
 2017-06-19 08:18:08 -07:00
Brian Wilkerson
e0216fef7f Remove ability to disable new analysis driver 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2937323003 .
 2017-06-19 08:13:14 -07:00
Kevin Millikin
0489249d29 Proper sequencing of _asyncStackTraceHelper in Kernel 
This helper function was being called before its argument was
initialized so it was passing null.  Instead, it should be called
after its argument is initialized.

Because the initialization happens in Kernel code, it is simplest to
insert the call explicitly in Kernel code as well as part of the async
transformation.  This has the consequence that we now call the helper
function even when the flag causal_async_stacks is false.

Fixes #29771.

BUG=
R=aam@google.com, asiva@google.com

Review-Url: https://codereview.chromium.org/2936793003 .
 2017-06-19 16:52:58 +02:00
Peter von der Ahé
69d6e8e55a All strong mode cleaning of dart2js. 
Fixes https://github.com/dart-lang/sdk/issues/29886

Supersedes CLs 2939193003, 2950433002, and 2947583002.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2944843002 .
 2017-06-19 14:06:38 +02:00
Florian Loitsch
4598e15f8b Add a changelog entry for the new part-of syntax. 
R=leafp@google.com

Review-Url: https://codereview.chromium.org/2902163002 .
 2017-06-19 13:40:10 +02:00
William Hesse
2b6fbc7069 Revert co19 roll attempt 
Revert "Status files updated according to buildbot log (#29929)"

This reverts commit 5b7a7958b2.

Revert "Fix Dartium DEPS typo in co19 roll"

This reverts commit 4996568879.

BUG=

Review-Url: https://codereview.chromium.org/2949543002 .
 2017-06-19 13:17:55 +02:00
William Hesse
4996568879 Fix Dartium DEPS typo in co19 roll 
BUG=
TBR=sortie@google.com

Review-Url: https://codereview.chromium.org/2951443002 .
 2017-06-19 13:06:40 +02:00
Sergey G. Grekhov
5b7a7958b2 Status files updated according to buildbot log (#29929) 
* DEPS ans status files updated to the last co19 commit

* Commented lines deleted from .status file

* DEPS ans status files updated to the last co19 commit

* DEPS ans status files updated to the fix of https://github.com/dart-lang/co19/issues/110

* Fix for https://github.com/dart-lang/co19/issues/87 added

* Fix for https://github.com/dart-lang/co19/issues/88 added

* Status files updated according to buildbot log
 2017-06-19 12:55:32 +02:00
Erik Corry
1f7d2d5439 Revert "Reduce copying, redundancy & repetition for codegen of comparison instructions" 
R=kustermann@google.com
BUG=

This reverts commit e25dfc07d1.
Reason: Failure on SIMDBC64
Review-Url: https://codereview.chromium.org/2949513002 .
 2017-06-19 10:28:47 +02:00
Florian Loitsch
dbfaa36728 Add summary command to bot. 
Looks at the latest build results and gives information. For now
just prints, if a bot has an error.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2944653002 .
 2017-06-19 10:22:50 +02:00
Erik Corry
e25dfc07d1 Reduce copying, redundancy & repetition for codegen of comparison instructions 
R=vegorov@google.com
BUG=

Review-Url: https://codereview.chromium.org/2937933002 .
 2017-06-19 09:45:03 +02:00
Paul Berry
7939ea00ef Implement type inference of getters/setters based on inheritance. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2943273002 .
 2017-06-18 16:35:02 -07:00
Terry Lucas
8ab1a87aba Typedefs and IDL file order between platforms could generated different files. 
TBR=alanknight@google.com,vsm@google.com

Review-Url: https://codereview.chromium.org/2948493002 .
 2017-06-18 11:54:29 -07:00
Konstantin Shcheglov
bcf179c9fa Add the 'crossGettersSetters' flag to ClassHierarchy.forEachOverridePair(). 
We need to be able to get 'overrides' of setters with getters and vise
versa to support top-level inference.

R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2941363002 .
 2017-06-17 18:32:44 -07:00
Paul Berry
ba14751f55 Implement override-based inference of instance fields. 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2938423003 .
 2017-06-17 06:27:27 -07:00
Carlo Bernaschina
504125071e Fixed interface documentation 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2941313002 .
 2017-06-16 16:27:35 -07:00
Siva Chandra
7087085505 Fix frontend tests after bac83e0973 
R=nweiz@google.com

Review-Url: https://codereview.chromium.org/2943173002 .
 2017-06-16 14:05:08 -07:00
Konstantin Shcheglov
bf5ea8f593 Using identical(xxx, typeProvider.yyy) is not compatible with Analysis Driver. 
This fixes 8 out of 22 failing tests for DDC using Analysis Driver.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2947443002 .
 2017-06-16 13:38:33 -07:00
Siva Chandra
bac83e0973 Replace the --platform vm_option with --kernel-binaries option. 
This new flag value specifies the directory in which the VM should look
up the platform.dill file. A future change will require the VM to load
another kernel binary from disk. This binary will also live in the same
directory that --kernel-binaries specifies. This way, we avoid adding a
different flag for each of the different binaries.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2933203004 .
 2017-06-16 12:22:31 -07:00
Jennifer Messerly
93a02bf8f9 fix super setters when super is not allowed 
We were generating these incorrectly. This also improves the code structure around super helpers as well as accessors vs fields.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2940323003 .
 2017-06-16 11:49:51 -07:00
Max Kim
382ddb21c3 Refactor: Removed ReplacementRange from test and ReplacementRange from src/. Copied contents of test into lib/utilities and modified test path. 
This is needed to expose ReplacementRange outside of test folder for external plugin users to utilize. Reason discussed further in ticket: https://codereview.chromium.org/2934133002/

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2937093002 .
 2017-06-16 11:19:27 -07:00
Konstantin Shcheglov
f9af4e7ebe Refer the issue for making mixin transformation modular. 
R=paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2942253002 .
 2017-06-16 10:21:55 -07:00
Konstantin Shcheglov
9600dab0e0 Enable 'analysis.implemented' with the new analysis driver. 
It is not very efficient on large files, but works well enough for small
files. I will work on making it more efficient in following CLs.

R=brianwilkerson@google.com, devoncarew@google.com
BUG= https://github.com/dart-lang/sdk/issues/29113

Review-Url: https://codereview.chromium.org/2942753002 .
 2017-06-16 09:13:45 -07:00
Konstantin Shcheglov
8154d623d6 Test for the case when the watch function is null. 
R=paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2936313003 .
 2017-06-16 09:10:03 -07:00
Janice Collins
14bbfa2321 Upgrade dartdoc to v0.12.0. 
Tested manually, can generate SDK and package docs not withstanding https://github.com/dart-lang/dartdoc/issues/1448. All unit tests except the integration test pass (comment docs have changed for some SDK libraries since 0.12.0).

BUG=
R=devoncarew@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2919823002 .
 2017-06-16 07:51:13 -07:00
Johnni Winther
787fb75fc0 Fix dart2js-with-kernel status 
Review-Url: https://codereview.chromium.org/2939323002 .
 2017-06-16 16:32:23 +02:00
Paul Berry
b513e88de8 Fix infer_instance_accessor_ref test 
The test contained a typo which caused `dynamic` to be inferred by
accident.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2945603002 .
 2017-06-16 07:04:14 -07:00
Paul Berry
f5ea0a4403 Remove Kernel*Set classes. 
These classes are no longer needed, since we use
KernelComplexAssignment (and derived classes) to represent
assignments.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2945553002 .
 2017-06-16 06:57:51 -07:00
Johnni Winther
99ff7d2b77 Compile and run Hello World! 
Committed: 1214e6fba6

Reverted: 482502705a
Review-Url: https://codereview.chromium.org/2942863002 .
 2017-06-16 15:37:05 +02:00
Johnni Winther
208744eab7 Towards compiling Hello World! 
R=efortuna@google.com, sigmund@google.com

Committed: 778feb0504

Reverted: 482502705a
Review-Url: https://codereview.chromium.org/2939033002 .
 2017-06-16 14:48:07 +02:00
Florian Loitsch
37291e867f Mark analyzer/task_dependency_grap test as slow. 
Review-Url: https://codereview.chromium.org/2943683002 .
 2017-06-16 14:00:10 +02:00
Johnni Winther
dff4772a01 Add J-elements 
This adds object for a simple 1-to-1 J-element model to test that the codegen doesn't depend on the frontend model.

BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2937203002 .
 2017-06-16 13:48:49 +02:00
Florian Loitsch
71ad537fbf Fix "?." usage in analyze.dart. 
Review-Url: https://codereview.chromium.org/2941123005 .
 2017-06-16 13:29:15 +02:00
Jens Johansen
68bb955b7f Fix bot failure because of missed update of AssertStatement 
BUG=

Review-Url: https://codereview.chromium.org/2943103002 .
 2017-06-16 13:28:49 +02:00