Commit graph

50252 commits

Author SHA1 Message Date
Kevin Moore
8b4322df72 Use tag for pkg/pool in DEPS
Change-Id: Ie9e464ab93498d3783652df360ca902cdecded3e
Reviewed-on: https://dart-review.googlesource.com/7582
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
2017-09-21 16:00:13 +00:00
Zach Anderson
64bf1b49b0 Revert "[dart:io] Moves Http code into a separate library."
Reverting for broken Flutter build and kernel platform compilation test. It looks like the new _http library is missing from various snapshots. Not sure why this didn't fail locally.

This reverts commit ac9ff3f3af.

Change-Id: I7fbc2f842cf1380793e7af9fb869cacd14682885
Reviewed-on: https://dart-review.googlesource.com/7600
Reviewed-by: Zach Anderson <zra@google.com>
2017-09-21 15:57:59 +00:00
Kevin Moore
03dfeb78f5 Update stack_trace in DEPS
Change-Id: I1fe67bd4be6db587cc39bd11aef6d91a4e1772c5
Reviewed-on: https://dart-review.googlesource.com/7520
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
2017-09-21 15:30:47 +00:00
Zachary Anderson
ac9ff3f3af [dart:io] Moves Http code into a separate library.
This moves Http code into dart:_http. dart:io then imports and
re-exports dart:_http. This is the first stage of moving
dart:_http into its own pub package.

Change-Id: Icd33232a97b3d75511ef7ec88b01fd47cdcf5a23
Reviewed-on: https://dart-review.googlesource.com/6420
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-21 15:10:22 +00:00
Zachary Anderson
08f2633022 [Fuchsia] Remove vm service hacks
Change-Id: Ia012ed493dc15f847db2b8798435944dff637c8e
Reviewed-on: https://dart-review.googlesource.com/7441
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2017-09-21 15:00:39 +00:00
Johnni Winther
fae35af7d6 Remove this local from factory constructors
Change-Id: I54a02e519066336aacc9e1729994225c49f856fd
Reviewed-on: https://dart-review.googlesource.com/7263
Reviewed-by: Emily Fortuna <efortuna@google.com>
2017-09-21 14:42:54 +00:00
Brian Wilkerson
a6adcece9c Pull the latest version of isolate into the SDK
Change-Id: Ice7795b335b10084889d66fe9cd606071344b326
Reviewed-on: https://dart-review.googlesource.com/7402
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2017-09-21 14:13:12 +00:00
Samir Jindel
4087297d4a [kernel-coq] Proof for program well-formedness.
Bug:
Change-Id: I614d967fc0386c2c4cb0c56586f7f7c2e50b033a
Reviewed-on: https://dart-review.googlesource.com/7362
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2017-09-21 14:00:43 +00:00
Brian Wilkerson
6edb5d8df7 Add recovery for field formal parameters
Change-Id: I09a1c6627a8fc1d67ffad4010212f2e9511612fe
Reviewed-on: https://dart-review.googlesource.com/7108
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
2017-09-21 13:47:52 +00:00
Paul Berry
291b83b345 Move reload.dart to test directory.
This will allow us to run hot_reload_e2e_test.dart internally.

Change-Id: Ia44b086683ea629a0af15addd652543daa1700ce
Reviewed-on: https://dart-review.googlesource.com/7450
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-09-21 13:43:02 +00:00
Peter von der Ahé
d77e82ea67 Revert "Remove unused import (TBR)"
This reverts commit 0c005a39d2.
Bug:
Change-Id: I7f498cedbe0b2843219341670d9b580f12c37a93
Reviewed-on: https://dart-review.googlesource.com/7551
Reviewed-by: Peter von der Ahé <ahe@google.com>
2017-09-21 13:09:35 +00:00
Peter von der Ahé
9baee97ea2 Revert "Add NamedNode.nameOffset, fill it for constructors, and use in Analyzer."
This reverts commit 9a8621b60a.

Revert "Rework getElement() in resynthesizer."

This reverts commit e4fa080f69.

Revert "Create (empty) initializers for parameters resynthesized from Kernel."

This reverts commit 8df6c79b9d.

Revert "Run NonErrorResolverTest in strong mode. Extract not strong tests."

This reverts commit 9bdda4b1d3.

Revert "Move TypeProvider creation into KernelResynthesizer and create loadLibrary functions."

This reverts commit c59eaf1788.

Revert "Return SimpleIdentifier or PrefixedIdentifier from _buildIdentifier()."

This reverts commit 6d0515f9ca.

Change-Id: I1099ca715ce6287ab56808b7cc3abe0589e939c1
Reviewed-on: https://dart-review.googlesource.com/7550
Reviewed-by: Peter von der Ahé <ahe@google.com>
2017-09-21 12:19:47 +00:00
Johnni Winther
cffa7bc2b7 Handle if statements, is-tests and null-tests
Change-Id: Ia4fa866318b650f41ec75ff674ad233427640a4f
Reviewed-on: https://dart-review.googlesource.com/7269
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-09-21 11:17:26 +00:00
Florian Loitsch
76c5d2f638 Revert "Don't inline if we don't have inlining budget enough to fully inline."
This reverts commit e5aa7158ff.

Change-Id: Icb258421693316158c7af96cf25cbdcadc2780c9
Reviewed-on: https://dart-review.googlesource.com/7548
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-21 11:07:33 +00:00
Morten Krogh-Jespersen
c02d9c821f Adding baseclass for output + fix.
Change-Id: I99000a97055db94b54ded7a8c15d417de4588674
Reviewed-on: https://dart-review.googlesource.com/7542
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-09-21 10:48:08 +00:00
Alexander Thomas
9124b9efd3 Revert "Remove mac-vm-kernel builder from the CQ until we have >4 machines to run it."
This reverts commit f598b4766c.
Root cause fixed in https://chromium-review.googlesource.com/c/chromium/tools/build/+/676844.

Bug:
Change-Id: I73da850638cf677b5fe4c8f8549b3174c34dd828
Reviewed-on: https://dart-review.googlesource.com/7547
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2017-09-21 10:11:18 +00:00
Erik Ernst
c49cbae7f0 Rietveld 2688903004 (spec_parser) migrated to Gerrit.
Change-Id: Iddd1e8a795bfaed0092a30bb9d83070fe62d4a60
Reviewed-on: https://dart-review.googlesource.com/7261
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-21 09:36:10 +00:00
Erik Corry
e5aa7158ff Don't inline if we don't have inlining budget enough to fully inline.
When deciding whether to inline a function that has already been optimized
once, take a look at how many levels of inlining took place when it was
optimized stand-alone. If we don't have that much depth budget left, don't
inline.  This is an attempt to avoid the situation where we inline a function
that was already optimized, and then fail to inline important things that are
in the inner loop.

The benchmarking server shows about a 3% improvement on average when running
the DartJS compiler

This was reviewed and LGTMed at https://codereview.chromium.org/2994283002

Bug:
Change-Id: Ia731c89f32ac4eacd643965a36dcee35f610c141
Reviewed-on: https://dart-review.googlesource.com/7544
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2017-09-21 09:13:28 +00:00
Florian Loitsch
7a110c071f Update status file.
Change-Id: Ib5795d8566d8533c4cf81c69819ef58e73406c8e
Reviewed-on: https://dart-review.googlesource.com/7545
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-21 08:58:42 +00:00
Johnni Winther
81a81c93eb Handle instance field initialization in inferrer
This normalizes `var field = null;` and `var field;` to `var field;` for
both the AST- and IR-based inferences.

Change-Id: I753637c130a9f44ed01d18946c234353048f8971
Reviewed-on: https://dart-review.googlesource.com/6480
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-09-21 08:46:22 +00:00
Florian Loitsch
951e8dad51 Split the mock_writable test into two pieces.
One now contains private symbols. The other doesn't.

Change-Id: I4f7586117731aad1d965060a7ff7b14050713331
Reviewed-on: https://dart-review.googlesource.com/7543
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-21 08:24:15 +00:00
Florian Loitsch
f35d224654 Fix mock_writable_final_field_test and update status file.
Change-Id: Ibe94be244fd4df23701f282e4c4329a5b606db95
Reviewed-on: https://dart-review.googlesource.com/7541
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-21 07:48:23 +00:00
Erik Ernst
cf01c459f3 Updated tests for new treatment of init.formal type annotations
Adjusted lib_2/mirrors/initializing_formals_test.dart to match new rule
for static checking on type annotations of initializing formals.

Added language_2/initializing_formals_type_annotation_test.dart to
check the 4 main situations directly.

Change-Id: Icf763c79c99274645f7967b8c3e3a3c3f6536763
Reviewed-on: https://dart-review.googlesource.com/7268
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
2017-09-21 07:34:58 +00:00
Florian Loitsch
0d2bcc17db Update status files.
Change-Id: Iebfba17da59a161aea16e802787c2b5cf4722845
Reviewed-on: https://dart-review.googlesource.com/7540
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-21 07:22:04 +00:00
Florian Loitsch
9572b5e2ec Update Changelog entry for strong zones.
Change-Id: I15dac60dfec77315dd3701c066c546fe979f3f0a
Reviewed-on: https://dart-review.googlesource.com/7400
Reviewed-by: Kevin Moore <kevmoo@google.com>
2017-09-21 06:56:22 +00:00
Harry Terkelsen
f8d4291164 update status for passing test [TBR]
Change-Id: I9a7a4fda137822fc0b80de9d43332aab610dcc35
Reviewed-on: https://dart-review.googlesource.com/7485
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
2017-09-20 23:06:37 +00:00
William Hesse
f598b4766c Remove mac-vm-kernel builder from the CQ until we have >4 machines to run it.
Bug:
Change-Id: Ibb07ce966bdedb20551f079ce5899d83b7ebb8a6
Reviewed-on: https://dart-review.googlesource.com/7403
Reviewed-by: William Hesse <whesse@google.com>
2017-09-20 22:57:46 +00:00
Vijay Menon
8470c871d6 Enable polyfill in d8 modules
This enables running benchmarks (e.g., DeltaBlue) on d8.  d8 tip (with
es6 modules) appears quite a bit faster than the latest dev nodejs (with common modules).

Change-Id: Iedcc97fac57c48b925ae7c1b6cba4bbedeba4d0b
Reviewed-on: https://dart-review.googlesource.com/7443
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
2017-09-20 22:47:21 +00:00
Bob Nystrom
74e4ccdeb8 Migrate block 120.
Change-Id: Ia5a433e70ab3bdf953a116a0b65de42138125d2b
Reviewed-on: https://dart-review.googlesource.com/6347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-09-20 22:23:58 +00:00
Zachary Anderson
406d59f9bf [sdk] Update version file correctly
fixes #30794

Change-Id: Icd412d36d34dc1da01a6b0fec8107b3a49d03e3a
Reviewed-on: https://dart-review.googlesource.com/7481
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2017-09-20 22:05:27 +00:00
Brian Wilkerson
0c005a39d2 Remove unused import (TBR)
Change-Id: I1f22fb743d2148a485d304920f5a5e2c921cd904
Reviewed-on: https://dart-review.googlesource.com/7460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 21:46:55 +00:00
Konstantin Shcheglov
6d0515f9ca Return SimpleIdentifier or PrefixedIdentifier from _buildIdentifier().
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ifaecb13e6869166deb10c6211cf075761c185100
Reviewed-on: https://dart-review.googlesource.com/7449
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 21:31:20 +00:00
Paul Berry
45521d17c4 Change main functions in test files to take optional args.
This will allow these tests to be run inside google3, where the test
framework calls main with no arguments.

Change-Id: I139a9b100fe3a1eb3003933ec9fef4298706ff5d
Reviewed-on: https://dart-review.googlesource.com/7342
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-09-20 21:07:27 +00:00
Konstantin Shcheglov
c59eaf1788 Move TypeProvider creation into KernelResynthesizer and create loadLibrary functions.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Idabf9baa72de55d9a501a9b91317aad004dcf5dc
Reviewed-on: https://dart-review.googlesource.com/7447
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 20:48:50 +00:00
Brian Wilkerson
2a58b64937 Gardening: Update status file to fix the bots (TBR)
Change-Id: Iaeb9c9c7ca5aee6b4e8ff90f30713e119824b6d0
Reviewed-on: https://dart-review.googlesource.com/7401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 20:46:34 +00:00
Konstantin Shcheglov
9bdda4b1d3 Run NonErrorResolverTest in strong mode. Extract not strong tests.
Plus a tiny fix for not considering a class with a static method
named "call" a Function.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I46c470c9d5dfb9f3cda9d5c5ac432962975f6773
Reviewed-on: https://dart-review.googlesource.com/7444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 20:46:11 +00:00
pq
abfd9594fe dart2js test expectation updates (block 136 continued) [TBR].
More staus file whack-a-mole.

Addresses:

python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/mixin_with_two_implicit_constructors_test
python tools/test.py -m release -c dart2js -r d8 --checked --minified --fast-startup --use-sdk --dart2js-batch --reset-browser-configuration language_2/mock_writable_final_field_test
python tools/test.py -m release -c dart2js -r d8 --host-checked --dart2js-batch --reset-browser-configuration language_2/mock_writable_final_field_test

Bug:
Change-Id: Ia2f44a57b36d2c35dadf3ab4b4d2d9c483d6552c
Reviewed-on: https://dart-review.googlesource.com/7445
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2017-09-20 20:32:59 +00:00
Jennifer Messerly
3224db05be fix #30792 -- fix variables shadowing parameters in an async function
Change-Id: I40667f607450af8695aafc613358d401cd395af2
Reviewed-on: https://dart-review.googlesource.com/7042
Reviewed-by: Vijay Menon <vsm@google.com>
2017-09-20 20:09:25 +00:00
Ben Konyi
fe01ec1d12 Migrated test block 179 to Dart 2.0.
Some changes were required to stream_transformer_test to make it strong
mode clean. Other minor changes involved migrating from unittest->test.

Bug:
Change-Id: Ia21144090710137e4803c651cf9e3fd62e17f5f7
Reviewed-on: https://dart-review.googlesource.com/3707
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-20 19:29:01 +00:00
Emily Fortuna
ac98f741d5 Make JRecordFields not instance members (they were falsely categorized as such because the boxes were "classes").
Bug:
Change-Id: I5ea7ab26e5bb7c52a59b4f81b1489190b2d00fd0
Reviewed-on: https://dart-review.googlesource.com/7220
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-09-20 19:26:08 +00:00
Dan Rubel
7e25f2a336 tests for annotation at EOF
Change-Id: I43aafd04dba8511cb603c6ca31a8135d868f52ef
Reviewed-on: https://dart-review.googlesource.com/7300
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 18:24:24 +00:00
Konstantin Shcheglov
8df6c79b9d Create (empty) initializers for parameters resynthesized from Kernel.
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ifeddbd315b5c8d541c0db9a577d4cbddcfbdeba0
Reviewed-on: https://dart-review.googlesource.com/7380
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 18:04:00 +00:00
Konstantin Shcheglov
e4fa080f69 Rework getElement() in resynthesizer.
So that it is not recursive anymore.

This also fixes a bug with private classes.
There is no library URI qualifier for classes, even if they are private.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Ibeb8bd18fed9b116a40b2f2ff357f97283bc7b0d
Reviewed-on: https://dart-review.googlesource.com/7382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 17:59:57 +00:00
Konstantin Shcheglov
9a8621b60a Add NamedNode.nameOffset, fill it for constructors, and use in Analyzer.
R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com

Bug:
Change-Id: If0f815e86049381e9db3386f243789e9b4f9f5ce
Reviewed-on: https://dart-review.googlesource.com/6780
Reviewed-by: Paul Berry <paulberry@google.com>
2017-09-20 17:54:30 +00:00
pq
0d9032c644 Update test expectations for multiline_strings_test on windows [TBR].
See: https://github.com/dart-lang/sdk/issues/30336

.gitattributes updated.

Bug:
Change-Id: I7481362e64159ba28b8448d19acca5817010739d
Reviewed-on: https://dart-review.googlesource.com/7383
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2017-09-20 17:52:26 +00:00
pq
84ac5aa1c6 Updated test expectations for dart2js d8 (in quest for greenness).
Bug:
Change-Id: I689be0aac6f266ea757eb142fb5d18414f4203f9
Reviewed-on: https://dart-review.googlesource.com/7381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-20 17:40:43 +00:00
Alexander Thomas
c6d1edc4ec Disable co19 WebGL tests unless the builder_tag is set to run_webgl_tests to combat flakiness
Bug: 29961
Change-Id: Ia5c0268a1b27181cef35e679e1410d104c345fc9
Reviewed-on: https://dart-review.googlesource.com/7360
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2017-09-20 17:01:47 +00:00
Florian Loitsch
9f85da73e3 Update status file.
Change-Id: I8f4dc1f933799e8dea6f8d81061b4b07f7fbdc71
Reviewed-on: https://dart-review.googlesource.com/7363
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-20 16:51:34 +00:00
pq
86e4c97346 Re-stage migration of test block 136 to Dart 2.0.
Bug:
Change-Id: I562ceec87bc946bb43467ca118c88991a368657f
Reviewed-on: https://dart-review.googlesource.com/6781
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-09-20 16:23:00 +00:00
Florian Loitsch
bb026e5d29 Fix typing error.
Change-Id: Ib10a42863316ce6f15648345cf980236871c2f01
Reviewed-on: https://dart-review.googlesource.com/7361
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-09-20 16:16:27 +00:00