Commit graph

25 commits

Author SHA1 Message Date
Alexander Thomas
b5c63ce757 [infra] Migrate scripts to python3
* Migrate to python3; drop python support.
* Update Windows toolchain support.
* Remove some unused methods.
* Python 2.7 is still needed on Windows.
* Update gsutil to a version that supports python3.

Fixes: https://github.com/dart-lang/sdk/issues/28793

TEST=Manually tested common user journeys.

Change-Id: I663a22b237a548bb82dc2e601e399e3bc3649211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192182
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2021-04-15 10:10:20 +00:00
Nate Bosch
55f81f2210 Mass format python with yapf
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.

Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-05 20:34:31 +00:00
Martin Kustermann
7e9c56c43b [Gardening] Kill any leaked flutter_tester processes before/after 3-head builder work
Issue https://github.com/dart-lang/sdk/issues/35549

Change-Id: I3dd40b878d7c1c08a6f8c9edb520a276754e77b7
Reviewed-on: https://dart-review.googlesource.com/c/88328
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
2019-01-03 15:30:11 +00:00
asiva
30aa464f77 [VM] Remove 'corelib' and 'dart-io' sources generation into C++ arrays
- Remove all code that generates the corelib and dart:io library sources into C++ arrays and link them into dart_bootstrap
- Remove the executable dart_bootstrap and all uses of it
- Remove bootstrap_nolib.cc and builtin_nocore.cc
- Remove the Dart 1 code in core lib bootstrap path

Change-Id: Ifd33496204285a08b42fe09e39428e7a92b416b6
Reviewed-on: https://dart-review.googlesource.com/c/77241
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-10-02 23:27:05 +00:00
William Hesse
3603bfaebd Remove remaining traces of content_shell and DumpRenderTree
Change-Id: Iae15260fa588b101929095c865807efecfb678a2
Reviewed-on: https://dart-review.googlesource.com/71960
Reviewed-by: Jonas Termansen <sortie@google.com>
2018-08-30 08:15:30 +00:00
Alexander Thomas
7bca1569e5 Correct case of vctip executable
Bug:
Change-Id: I89fa5a8ccdff94d2034ee6366b6c0261d9a2e99e
Reviewed-on: https://dart-review.googlesource.com/5260
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2017-09-12 17:20:31 +00:00
Alexander Thomas
08d4ebc11e Kill VCTIP and mspdbsrv on windows
Don't rely on "non-empty strings are true" semantics.
Stop killing svn, it's already dead.

Bug:
Change-Id: Iab228963535f1a4cf3b778c0353fb7cfd5b04695
Reviewed-on: https://dart-review.googlesource.com/4740
Reviewed-by: William Hesse <whesse@google.com>
2017-09-11 16:04:25 +00:00
William Hesse
8a5cc82e77 Suppress failures from taskkill when killing content_shell on Windows.
BUG=https://github.com/dart-lang/sdk/issues/29599
R=terry@google.com

Review-Url: https://codereview.chromium.org/2875043002 .
2017-05-11 14:45:32 +02:00
Erik Corry
4b9bba55b4 Stoppp using trippple consonants
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2833073002 .
2017-04-21 17:50:13 +02:00
Martin Kustermann
fa36b34887 Add dart_bootstrap/gen_snapshot/dart_precompiled_runtime to task_kill.py (by default)
On Windows we had hanging dart_bootstrap.exe which prevented builds. So
with this change will we ensure to kill these leaked processes if they
occur.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2698943002 .
2017-02-16 12:48:59 +01:00
William Hesse
eb0502e62d Add "Chrome Helper" to taskkill script on macos
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2684993007 .
2017-02-09 20:09:19 +01:00
Martin Kustermann
8347d26d7e Make task_kill.py try to dump stacks of left-over/hanging processes
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2613713004 .
2017-01-04 16:59:54 +01:00
William Hesse
cd21da1d98 Disable taskkill failure when killing dart processes on windows.
There is an outstanding issue with pub hanging and being unkillable on
windows.  Make the taskkill step pass on windows, even if there are
dart processes, until we fix this issue.

BUG=https://github.com/dart-lang/sdk/issues/24086
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1582773002 .
2016-01-13 11:17:18 +01:00
Rico Wind
171ca680ba Upstream change to also kill fletch as part of task_kill.py.
This is to keep the patching of our branch as small as possible (and to guarantee consistency if we share bots between sdk and fletch runners)

R=ahe@google.com, whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1304613002 .
2015-08-20 09:32:59 +02:00
Rico Wind
6d4aea874d Don't fail taskkill on chrome processes alive
It happens quite often that the browser controller fails to kill chrome on the package waterfall.

R=eernst@google.com
BUG=

Review URL: https://codereview.chromium.org//1150543004
2015-06-04 12:43:33 +02:00
ricow@google.com
c53f791e62 Remove editor and java kill script from the taskkill script
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1136233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45731 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-12 10:41:32 +00:00
whesse@google.com
c7d5711688 Build Tools Cleanup
Cleans up Python Code in Build Tools

TEST: build everything and run tests
BUG: https://code.google.com/p/dart/issues/detail?id=19592

R=ricow@google.com

Review URL: https://codereview.chromium.org//350483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38573 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-25 11:47:59 +00:00
messick@google.com
97fda01ba0 Kill java to terminate editor on linux.
The DartEditor process can be killed without causing the editor
to terminate. I believe that in addition to killing it we also
need to stop the jvm. Plus, it needs to be done in order or else
the DartEditor process will display an error dialog when the
jvm is killed.

R=ricow@google.com

Review URL: https://codereview.chromium.org//317423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37099 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 20:18:05 +00:00
ricow@google.com
28719c7c90 Always kill the editor and eggplant if on linux
R=messick@google.com

Review URL: https://codereview.chromium.org//306383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36889 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-02 18:26:19 +00:00
ricow@google.com
1aba267aa7 Add git and svn to task_kill which we run on the bots.
We are occasionally seeing orphaned git processes when running pub tests on windows.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//259963007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35475 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 07:32:45 +00:00
kustermann@google.com
6b219869ec Add content_shell to the list of processes that get killed in the task_kill.py step
R=ricow@google.com

Review URL: https://codereview.chromium.org//131743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31656 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 14:07:20 +00:00
ricow@google.com
0ea1b3ed34 Reenable non-zero exitcode in the task_kill script
BUG:13121

R=kustermann@google.com

Review URL: https://codereview.chromium.org//23714008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27241 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 10:26:13 +00:00
ricow@google.com
6383f784a6 Tempoarily return 0 from taskkill process.
We are seeing hanging firefox instances on windows.

Review URL: https://codereview.chromium.org//23809006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27229 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 07:21:30 +00:00
ricow@google.com
63eaf527ac Update ps command in taskkill to also work on linux
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23946003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27101 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 08:52:20 +00:00
ricow@google.com
18504fde18 Add small util for killing hanging processes.
This will be used on the buildbot to kill any hanging dart or browser
processes. We will print the command line that resulted in the hang to
enable us to track over time what is causing us to hang (at least for
the hanging dart processes).

R=kustermann@google.com

Review URL: https://codereview.chromium.org//23549002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26778 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 11:08:02 +00:00