languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity
41983 commits 11 branches 6011 tags 1.4 GiB
Commit graph

41983 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Berry
8fca9ba968 First cut at a file system abstraction for the front end. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2426773004 .
 2016-10-18 14:10:14 -07:00
Konstantin Shcheglov
19702989a8 Get rid of _inFunction in ApiElementBuilder. 
This visitor does not enter into function bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2430513004 .
 2016-10-18 14:03:42 -07:00
Florian Schneider
7e6d8f5b66 VM: Remove unnecesary load of isolate in some stubs. 
The fast-path allocation can always load the current heap
from the thread object instead.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2427043002 .
 2016-10-18 13:45:53 -07:00
Paul Berry
8c42e56964 Add "not intended to be implemented/extended" warnings to pkg/front_end. 
This ensures that we may safely add methods to the classes in this
package without causing a breaking change.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2431733002 .
 2016-10-18 13:31:40 -07:00
Zachary Anderson
aa79ee775e DBC: Fix intrinsics bug 
Fall-through when allocation fails.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2429723003 .
 2016-10-18 13:07:19 -07:00
Sigmund Cherem
3cdcaeda96 Fix browser test status. 
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .

Committed: 940e498e17
 2016-10-18 12:50:58 -07:00
Sigmund Cherem
2200ee77f7 Revert "Fix browser test status." 
This reverts commit 940e498e17.
 2016-10-18 12:48:15 -07:00
Sigmund Cherem
940e498e17 Fix browser test status. 
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .
 2016-10-18 12:38:45 -07:00
Konstantin Shcheglov
529ebf7be2 Add (shared) tests for ApiElementBuilder and ElementBuilder. 
Also copy API-only tests from the old CL.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2431783002 .
 2016-10-18 12:28:09 -07:00
Brian Wilkerson
0464279ec1 More correction messages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2428733005 .
 2016-10-18 12:22:17 -07:00
Konstantin Shcheglov
13d2420a3d Extract ElementBuilder tests into a separate file. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2430723002 .
 2016-10-18 10:22:45 -07:00
Zach Anderson
df260e5fe7 Fix crashes on debug windows 
Review URL: https://codereview.chromium.org/2426053002 .
 2016-10-18 09:37:04 -07:00
Konstantin Shcheglov
e1f8a0a103 Begin separating API and local element builders. 
I will write separate tests for them and do some more clean up in
separate CLs.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2425853003 .
 2016-10-18 08:22:30 -07:00
Johnni Winther
b262be749e Optimize needNoSuchMethodHandling computation 
This greatly improves the number of lookups needed to establish the relation.
For the two most prolific tests we have:

html/element_test: 44939 -> 6557
html/mirrors_js_typed_interop_test (mirrors+jsinterop!): 1638455 -> 171326

R=sigmund@google.com

Committed: a8b2bfb5eb

Review URL: https://codereview.chromium.org/2428543002 .

Reverted: 5397c5427e
 2016-10-18 16:06:03 +02:00
Johnni Winther
37afcd5197 Change TypeInference to handle super calls as direct invocations. 
This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed: 70159b7418

Review URL: https://codereview.chromium.org/2423953002 .

Reverted: 5397c5427e
 2016-10-18 14:02:55 +02:00
Erik Ernst
b5d2b38aa3 Relaxes treatment of method type parameter in as expressions. 
This CL changes the semantics of `dart2js --generic-method-syntax`
generated code for `e as T` where `T` is a method type parameter.

The old behavior was to raise a `TypeError` at runtime when such an
expression was evaluated. The new behavior is to consider `T` as an
alias for `dynamic`, i.e., `e as T` will then always succeed.

Addresses part of issue 27460, omits a part that is not yet agreed upon.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2388843002 .
 2016-10-18 11:11:44 +02:00
Johnni Winther
5397c5427e Revert "Change TypeInference to handle super calls as direct invocations." and "Optimize needNoSuchMethodHandling computation" 
This reverts commit 70159b7418.
This reverts commit a8b2bfb5eb.

Review URL: https://codereview.chromium.org/2425933002 .
 2016-10-18 11:00:42 +02:00
Johnni Winther
a8b2bfb5eb Optimize needNoSuchMethodHandling computation 
This greatly improves the number of lookups needed to establish the relation.
For the two most prolific tests we have:

html/element_test: 44939 -> 6557
html/mirrors_js_typed_interop_test (mirrors+jsinterop!): 1638455 -> 171326

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2428543002 .
 2016-10-18 10:52:12 +02:00
Johnni Winther
70159b7418 Change TypeInference to handle super calls as direct invocations. 
This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2423953002 .
 2016-10-18 09:46:28 +02:00
Siva Annamalai
bcea09162a Land https://codereview.chromium.org/2423893003/ for viettrungluu 
TBR=zra

Review URL: https://codereview.chromium.org/2426833002 .
 2016-10-17 16:57:02 -07:00
Vijay Menon
a032a4c952 Revert "Fix file name handling on windows" 
This appears to break on bazel.

BUG=
R=nshahan@google.com

Review URL: https://codereview.chromium.org/2422403002 .
 2016-10-17 15:27:48 -07:00
Konstantin Shcheglov
fabb9dbf18 Remove _functionTypesToFix from ElementBuilder. 
We might have needed it in the past, but now
'new FunctionTypeImpl(element)' does not use the enclosing element, at
least until we start calling its methods, which happens after we finish
building the element model.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2422333002 .
 2016-10-17 14:26:38 -07:00
Stephen Adams
c9c3c203c1 Minor tweaks to dart:html for better dart2js codegen 
- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.

BUG=
R=alanknight@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2422293002 .
 2016-10-17 13:35:17 -07:00
Zach Anderson
71a84cfed6 GN: Fix Debug flags. Fix Windows build. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2425043002 .
 2016-10-17 12:58:24 -07:00
Brian Wilkerson
99ce88f8bc (TBR) Fix more failing tests 
Review URL: https://codereview.chromium.org/2426723002 .
 2016-10-17 12:57:56 -07:00
Paul Berry
0753607dea Initial API for the Dart front_end package. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2417043003 .
 2016-10-17 12:36:08 -07:00
Brian Wilkerson
3121296942 (TBR) Fix failing tests 
Review URL: https://codereview.chromium.org/2426703002 .
 2016-10-17 11:55:31 -07:00
John McCutchan
8061bd5a8a Add local variable declaration token position to service protocol 
- [x] Add three public fields to the "BoundVariable" service type: declarationTokenPos, visibleStartTokenPos, and visibleEndTokenPos. (naming suggestions welcome!)
- [x] Extend LocalVarDescriptors to hold the declaration token position (it already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function parameters, and closure captured variables.

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2419013004 .
 2016-10-17 11:18:24 -07:00
Brian Wilkerson
724ac40b8d Improve error messages and add many corrections 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2426583003 .
 2016-10-17 10:40:43 -07:00
Zachary Anderson
c8970d0524 DBC: Fix CheckClass bug. Add some intrinsics 
Flutter layout benchmark 8.5k us -> 6k us.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2418073002 .
 2016-10-17 10:20:56 -07:00
Brian Wilkerson
cbd7a2908e Fixes for tests on windows 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2420413004 .
 2016-10-17 09:39:25 -07:00
Florian Loitsch
8fbd651c49 Emphasize that durations are context independent. 
Fixes #27597
BUG= http://dartbug.com/27597
R=lrn@google.com

Review URL: https://codereview.chromium.org/2423993002 .
 2016-10-17 14:51:00 +02:00
William Hesse
bb91445e7e Update CHANGELOG.md with release dates and patch releases. 
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org/2423973002 .
 2016-10-17 14:04:33 +02:00
Johnni Winther
74b74a13f7 Decouple TypeMask from ClassElement 
- by typing FlatTypeMask.base with Entity
- moving needsNoSuchMethodHandling to ClosedWorld
- and testing needsNoSuchMethodHandling

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2420073002 .
 2016-10-17 09:47:20 +02:00
Zachary Anderson
c1b1151f54 GN: Fix builder test script 
Review URL: https://codereview.chromium.org/2423783002 .
 2016-10-16 15:18:54 -07:00
Vyacheslav Egorov
caa0167457 Don't use in-class initialization of non-static data members. It's a C++11 extension. 
TBR=asiva@google.com

Review URL: https://codereview.chromium.org/2420323002 .
 2016-10-15 23:02:49 +02:00
Vyacheslav Egorov
f67ce21068 VM support for running Kernel binaries. 
BUG=
R=asiva@google.com, fschneider@google.com

Review URL: https://codereview.chromium.org/2411823003 .
 2016-10-15 22:48:46 +02:00
Brian Wilkerson
4f6f05273e Add more summary support to ContextBuilder 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2416243003 .
 2016-10-15 08:40:04 -07:00
Stephen Adams
790b9d9cb1 Enable GVN on HForeignNew 
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2422003002 .
 2016-10-14 17:34:07 -07:00
Sigmund Cherem
997581ccec Fix custom elements in startup emitter 
R=sra@google.com

Review URL: https://codereview.chromium.org/2424553002 .
 2016-10-14 16:58:47 -07:00
Ryan Macnak
572eb0ce7a Apparently co19 tests have their own separate annotation parsing. 
Review URL: https://codereview.chromium.org/2419613007 .
 2016-10-14 16:43:20 -07:00
Ryan Macnak
656964107b Update AOT Android harness for single-file app snapshots. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2419183002 .
 2016-10-14 16:23:19 -07:00
Ryan Macnak
fe04737a77 Add test directive to include other files used by a test in its compiled output directory. 
Fixes #27591

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2423593002 .
 2016-10-14 16:11:25 -07:00
Regis Crelier
0ac91fab5c Minor cleanup: use handle when setting instructions in code object. 
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2416963009 .
 2016-10-14 16:06:59 -07:00
John McCutchan
a43d37be81 Fix reload_sources_test flake 
BUG=

Review URL: https://codereview.chromium.org/2415183005 .
 2016-10-14 15:33:55 -07:00
Sigmund Cherem
ee42a0a0aa Add js-interop support to the fast-startup emitter 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2420173002 .
 2016-10-14 14:22:11 -07:00
Bob Nystrom
60a966605d Remove uses of unittest in the HTML tests where possible. 
This finishes going through the dev_compiler HTML tests and switches
out unittest for minitest wherever possible.

In the process, it gets another 10 tests strong mode clean, and gets
several more passing, and more not skipped. With this CL, we're running
another 50 more HTML tests (though some are expected to fail, mostly
because of #27578).

R=jacobr@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2419863002 .
 2016-10-14 13:44:19 -07:00
Vijay Menon
72e3d13db2 Add ddc resources to the sdk build 
This installs DDC's dart_sdk.js, etc., under:
  dart-sdk/lib/_internal/dev_compiler/

Fixes #27001

R=jakemac@google.com

Review URL: https://codereview.chromium.org/2416783005 .
 2016-10-14 12:34:03 -07:00
Brian Wilkerson
4942f5304a Guard against a hypothetical null pointer dereference 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2421473007 .
 2016-10-14 12:31:11 -07:00
Vijay Menon
852ef37f71 Some mirrors fixes 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2415053004 .
 2016-10-14 12:19:24 -07:00