Commit graph

5164 commits

Author SHA1 Message Date
Alexander Thomas 87483e9058 Revert "[infra] Temporarily remove Windows SDK builder from CQ"
This reverts commit 3e1335edc3.

Reason for revert: crbug.com/836287 is resolved for Windows builders.

Original change's description:
> [infra] Temporarily remove Windows SDK builder from CQ
> 
> TBR=sortie@google.com
> 
> Bug: crbug.com/836287
> Change-Id: I3ec3eb378329f073afca0d1c30e0bd6425e9db00
> Reviewed-on: https://dart-review.googlesource.com/52450
> Reviewed-by: Alexander Thomas <athom@google.com>

TBR=sortie@google.com,athom@google.com

Change-Id: I17a47c053baf9a8e24cd280a28cd05ad9cb0cc66
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: crbug.com/836287
Reviewed-on: https://dart-review.googlesource.com/52480
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-04-24 17:46:58 +00:00
Alexander Thomas 3e1335edc3 [infra] Temporarily remove Windows SDK builder from CQ
TBR=sortie@google.com

Bug: crbug.com/836287
Change-Id: I3ec3eb378329f073afca0d1c30e0bd6425e9db00
Reviewed-on: https://dart-review.googlesource.com/52450
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-24 16:52:24 +00:00
Zach Anderson 3ac1ee9150 [infra] Removes ninja.py
build.py was only forwarding to ninja.py, so this CL just copies
ninja.py over build.py and removes ninja.py.

Change-Id: I7b13c8fb17dbc05825c35b3d806cd950bf1b953e
Reviewed-on: https://dart-review.googlesource.com/51520
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-04-17 17:05:27 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code.
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-04-16 16:11:57 +00:00
Alexander Thomas a60d803913 [infra] Add --no-preview-dart-2 support for the analyzer to test.py
https://github.com/dart-lang/sdk/issues/32609

Change-Id: I5a7009a55a26452eae6e6465aeb78cecab91b476
Reviewed-on: https://dart-review.googlesource.com/50725
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-04-11 15:16:36 +00:00
Terry Lucas 6ab6d1eda9 Suppress fromRect its only available in DOMRect and not in ClientRect - will open bug to fix this issue.
R=sra@google.com

Change-Id: I09b653c7f3987dcf7ce5b235593e4f3140561d5c
Reviewed-on: https://dart-review.googlesource.com/50581
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-04-10 23:25:12 +00:00
William Hesse 2247843f48 Update checked-in SDKs to 2.0.0-dev.47.0
Update the README to say that linux and macos use the 64-bit SDK
and windows uses the 32-bit SDK.

Change-Id: Id98d6aa49ed0a486aa8553b4d08f76a2462fb6b7
Reviewed-on: https://dart-review.googlesource.com/50503
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-10 21:25:41 +00:00
Terry Lucas 34be5de0c7 Fixed _DomRect class to map to both ClientRect and DOMRect for browser backward compat.
R=sra@google.com,sigmund@google.com

Change-Id: I2f5ccae15bcd993ab1e15ab556a25d6e0cd1d450
Reviewed-on: https://dart-review.googlesource.com/50504
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-04-10 21:18:45 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files.
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-04-10 19:03:21 +00:00
Johnni Winther 23c59bd819 Fix compare_failures
+ and --force flag to always analysis past results (slower)

Change-Id: I9df760b61cfb71ecdf9a4b69d256895812f2eff1
Reviewed-on: https://dart-review.googlesource.com/50500
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-10 13:38:41 +00:00
Alexander Thomas 5e23c2843d Revert "[infra] Temporarily disable Windows SDK builder on CQ"
This reverts commit 7594c1543f.

Reason for revert: https://crbug.com/830533 has been fixed and the
windows bots are back again.

Original change's description:
> [infra] Temporarily disable Windows SDK builder on CQ
> 
> TBR=whesse@google.com
> 
> Change-Id: I348d14b021fc7fc859dec39e88de4e3876385c7a
> Reviewed-on: https://dart-review.googlesource.com/50180
> Reviewed-by: Alexander Thomas <athom@google.com>

TBR=whesse@google.com,athom@google.com

Change-Id: I50c24d65a96f8f45b0ee2b821176a00c61998590
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/50241
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-04-09 20:58:17 +00:00
Alexander Thomas cb065a116f [infra] Update checked-in SDK version to 2.0.0-dev.46.0
Change-Id: Ib4e53bba660b01453506d493058f967d13dd259e
Reviewed-on: https://dart-review.googlesource.com/50222
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-04-09 12:52:47 +00:00
Alexander Thomas 7594c1543f [infra] Temporarily disable Windows SDK builder on CQ
TBR=whesse@google.com

Change-Id: I348d14b021fc7fc859dec39e88de4e3876385c7a
Reviewed-on: https://dart-review.googlesource.com/50180
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-09 08:20:30 +00:00
Sigmund Cherem 133cd9d182 Use JavaScriptFunction for _registerCustomElement
"=Object" was inacurate and contradicted the inferred type <Function> in strong mode.

Change-Id: Ibee4351357dde4aaacf95ff7265cd335fc5d06ea
Reviewed-on: https://dart-review.googlesource.com/49832
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-04-06 23:14:13 +00:00
Terry Lucas 3e6b8717fe Fixed GamePadList not working in DDC and hide MessagePort.start operation.
Fixes https://github.com/dart-lang/sdk/issues/31029

R=vsm@google.com

Change-Id: I757538eec1ebcf42204e7de0807a48a4757f3faf
Reviewed-on: https://dart-review.googlesource.com/49740
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-04-05 15:13:17 +00:00
William Hesse 006fda374b Update test matrix with correct path to dart on Mac OS
Change-Id: Ie50148e5519bd4695d547727bb2fdaf3263f01d1
Reviewed-on: https://dart-review.googlesource.com/49641
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-05 11:19:12 +00:00
Alexander Thomas 26423147ab [infra] Add dart2js-chrome to the CQ again
The buildername has changed and the builder is now based on the test matrix.

TBR=whesse@google.com

Change-Id: Iedbabd094fdd8b0e441d726a4c62b9c7894bb59c
Reviewed-on: https://dart-review.googlesource.com/49506
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-04 15:32:39 +00:00
Alexander Thomas e3ace23c87 [infra] Remove dart2js-chrome from the CQ temporarily
TBR=whesse@google.com

Change-Id: I6a2ab361fa16e95c3de895adc3b0d88e89c4ab67
Reviewed-on: https://dart-review.googlesource.com/49503
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-04 15:12:03 +00:00
Alexander Thomas cb08bf287d [infra] Expect certain errors to pass when runtime is "none"
test.py ignores RuntimeError, MissingRuntimeError, and Timeout when the
runtime is "none". Previously, the status update tool would attempt to fix
these "unexpected passes".

Change-Id: I73c15fdc7e18aa29d5553e58b6b4e65ec07c1246
Reviewed-on: https://dart-review.googlesource.com/49461
Reviewed-by: William Hesse <whesse@google.com>
2018-04-04 11:51:25 +00:00
Alexander Thomas 4c6379eaff [infra] Support preview_dart_2 in status update tool
Change-Id: Ib48afe47d22f4c2672139d3ac9946471b41ef89e
Reviewed-on: https://dart-review.googlesource.com/49440
Reviewed-by: William Hesse <whesse@google.com>
2018-04-04 09:42:58 +00:00
Alexander Thomas 1b696eb6f5 [infra] Print variable name for unknown variables
Change-Id: Ib6c21278a0f07c7cdd1ee07532242d7f64cc57bd
Reviewed-on: https://dart-review.googlesource.com/49400
Reviewed-by: William Hesse <whesse@google.com>
2018-04-04 09:42:46 +00:00
Ryan Macnak 5941ebc33b [observatory] Filter platform dil files.
These were ending up in the archive only in Fuchsia tree.

Change-Id: I8979663c596831e99eec764046e9b57bbf15f01b
Reviewed-on: https://dart-review.googlesource.com/48889
Reviewed-by: Zach Anderson <zra@google.com>
2018-03-30 22:48:07 +00:00
Terry Lucas 49558b9c4c Fixed MessageChannel receiveing messages on ports.
Removed pkg browser from tests.

Fixes https://github.com/dart-lang/sdk/issues/26351
Fixes https://github.com/dart-lang/sdk/issues/32631

R=kevmoo@google.com

Change-Id: Ib0ef5f933d38b2f748cca1f82de8bcf01702df4d
Reviewed-on: https://dart-review.googlesource.com/48742
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-30 17:16:15 +00:00
Jenny Messerly c9e9c1d8e9 Remove dart:isolate runtime support in DDC
This disables most runtime features of dart:isolate, similar to dart:io.

For now, this supports `new ReceivePort()` and `ReceivePort.close` as
those are used by async tests to keep the Dart VM alive. Those are
no-ops in DDC. Also removes most of dart:_isolate_helper, except for
the JS API that's used to bootstrap DDC `main()`.

Change-Id: I84eab6cd39d05a70a6afe982e952076ddaaa8c0f
Reviewed-on: https://dart-review.googlesource.com/45754
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-03-28 19:42:08 +00:00
Terry Lucas 8e02ff92db Added @category annotation for Web libraries and removed createCustomUpgrader.
TBR=jcollins@google.com

Change-Id: I151e8d8af4bc647bdf47399c11f83b1625dabcf6
Reviewed-on: https://dart-review.googlesource.com/48523
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-27 23:53:14 +00:00
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json,
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-27 20:45:33 +00:00
William Hesse 1c913801a6 Add third_party packages to dart2js testing shards
The http_server in the test.py scripts uses package_resolver, which
uses 10 packages from third_party/pkg and third_party/pkg_tested.

Change-Id: I1e9ca660b9bd0a6270bcc8e4121da6a3bf9713bd
Reviewed-on: https://dart-review.googlesource.com/47781
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-23 12:56:06 +00:00
Kevin Moore 970b03986d Update homebrew formula to fail with dartium on dev releases
Closes https://github.com/dart-lang/sdk/issues/32642

Change-Id: I221ec3cca7c6965a0feef1dd380160221e1b5fb2
Reviewed-on: https://dart-review.googlesource.com/48000
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
2018-03-23 01:45:34 +00:00
Sigmund Cherem 07d2c9f287 Add server category for dart2js
Change-Id: I077da86aff4420aba1323e98d6cde08ac871f6f1
Reviewed-on: https://dart-review.googlesource.com/47721
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-23 00:40:55 +00:00
Ryan Macnak 38b0825a55 [kernel] Add target for Flutter on Fuchsia.
Change-Id: I7ab8e989e1e2038565e1d04a1c8f8ce880328ed8
Reviewed-on: https://dart-review.googlesource.com/47500
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-03-22 18:21:09 +00:00
Terry Lucas 17a778c9cb Changed AudioScheduledSourceNode.start to start2.
Fixes https://github.com/dart-lang/sdk/issues/32624

TBR=kevmoo@google.com

Change-Id: Ied9494a4b9695ae08ff2ef63c43759ea7951e9fa
Reviewed-on: https://dart-review.googlesource.com/47760
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-22 13:18:37 +00:00
Kevin Moore 179db6dc6a Remove usage of pkg:browser from tools/dart2js/sourceMapViewer
Change-Id: I10011d327173b2c26ef38e8400b8a6c81472323d
Reviewed-on: https://dart-review.googlesource.com/47583
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-21 20:22:10 +00:00
Zach Anderson aac5d04198 [infra] Add optimization_counter_threshold builder tag to the test matrix
related #32619

Change-Id: I0fc20f21cf3a6e231e0f3d962f139fd072acf3ab
Reviewed-on: https://dart-review.googlesource.com/47540
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-03-21 18:39:12 +00:00
Terry Lucas 581c512345 Fixed DOMRectList not having a prototype field.
TBR=vsm@google.com

Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-20 01:08:47 +00:00
William Hesse d9c022184c Pass enable-asserts flag from test.py to VM runtime.
Change-Id: I84223c57dcbc74d9e5ba7d2d977fe9d5f6d686dc
Reviewed-on: https://dart-review.googlesource.com/46900
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-03-19 10:38:05 +00:00
Terry Lucas 60469482f1 Move ClientRect members to DOMRect.
TBR=sigmund@google.com,sra@google.com

Change-Id: I424b087830954329f4399f6b169f572196a4f658
Reviewed-on: https://dart-review.googlesource.com/46948
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 13:27:46 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-18 09:41:04 +00:00
William Hesse bc3b0540f7 Add hash for downloading Linux Chrome to tools/bots/browsers.
Change-Id: Iafacb0d2f1753019878927462e2edd8dfc18b6fe
Reviewed-on: https://dart-review.googlesource.com/45780
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-16 10:35:11 +00:00
Alexander Thomas c8d044e27d [infra] Remove non-strong mode vm kernel tests steps from test matrix
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: I161b13bff4d6b4464d83eb39da9cb8e6d4051374
Reviewed-on: https://dart-review.googlesource.com/46142
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-03-15 16:53:06 +00:00
Alexander Thomas d7ec39dda7 [infra] Enable vm-kernel-legacy builder on the CQ
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: I330824c1ea23b8a0b34d2f5e83874ef67c0994f9
Reviewed-on: https://dart-review.googlesource.com/46802
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-15 16:26:31 +00:00
Alexander Thomas 56e697e728 [infra] Add experimental vm-kernel-legacy builder to the CQ
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: Ie861164cb8e36541691ecb7992c8bdd25f8a531c
Reviewed-on: https://dart-review.googlesource.com/46800
Reviewed-by: Alexander Thomas <athom@google.com>
2018-03-15 16:01:51 +00:00
Alexander Thomas 5c90b1fd98 [infra] Add vm-kernel-legacy builder to the test matrix
https://github.com/dart-lang/sdk/issues/32499

TBR=whesse@google.com

Change-Id: Ia9829fc106162b161e9e31bc918feebc691b3621
Reviewed-on: https://dart-review.googlesource.com/46742
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-03-15 14:31:13 +00:00
Peter von der Ahé 4f2bdff90b Rename Program to Component
Change-Id: I1a3cc03fba9783807fa637a9d42fdbad68ee7686
Reviewed-on: https://dart-review.googlesource.com/31040
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-03-15 12:22:23 +00:00
Martin Kustermann 52c884dc6a Add ExtraSlow status file marker
This is used (at least temporarily) for unblocking other P0 changes.

Change-Id: I002af7cfe6384f8813646d5c488a2cf2e58673a5
Reviewed-on: https://dart-review.googlesource.com/46541
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-03-14 15:49:09 +00:00
Sigmund Cherem c438f8b3f4 Dart2js defaults to the new common front-end
Change-Id: Id0f69d258b010a746b56e259335185bcca7dafec
Reviewed-on: https://dart-review.googlesource.com/45143
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-13 19:25:59 +00:00
Alexander Thomas 019dae1904 [infra] Remove front end unit tests from other builders
The new front end builders will continue to run them.

Change-Id: Iffd5af76bd3a082256ea4fb146981737462938f9
Reviewed-on: https://dart-review.googlesource.com/46042
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-13 12:40:39 +00:00
Peter von der Ahé b0a2e6b9c9 [test.py] Handle Windows file names correctly.
Change-Id: I1b4707826c00144da3190e75e19870b7e39acbf3
Reviewed-on: https://dart-review.googlesource.com/46065
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-03-13 09:16:18 +00:00
Alexander Markov d58887eaf6 [vm/kernel/aot, test tool] Enable global type flow analysis
Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I984869a8cdd9c52cab677cab64b562d002cde490
Reviewed-on: https://dart-review.googlesource.com/46122
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-03-12 22:45:39 +00:00
Alexander Markov ef80524b4f [benchmarks trybot] Add precompiler_entry_points.json
Change-Id: I3edbf7b20f3ab7afce89d7adabd537a6e47133d0
Reviewed-on: https://dart-review.googlesource.com/46005
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-03-12 22:11:10 +00:00
Jonas Termansen e067f7fdfa The dart-dfe target is no longer being benchmarked.
Change-Id: I9188362c0f62e4df50a0b8262d03a183c615eedb
Reviewed-on: https://dart-review.googlesource.com/45703
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2018-03-09 13:31:08 +00:00