Error span you otherwise get with each dartfmt invocation:
find: ‘> bin [’: No such file or directory
Note that the error doesn't occur all times dartfmt is run, only when it is
run from the directory triggered by the presubmit.
BUG=
R=rnystrom@google.com, whesse@google.com
Review-Url: https://codereview.chromium.org/2759333004 .
The finalizer sends the "close" message to the EventHandler for the
file descriptor in the _NativeSocket's native field. To avoid races and
spurious messages, this CL stores a pointer to a wrapper object in the
native field instead of the file descriptor. All messsages about the
_NativeSocket sent to the EventHandler use the wrapper object instead of
the file descriptor. When the EventHandler closes the file, the file
descriptor in the wrapper object is set to -1 so that the finalizer will
instead do nothing.
On Windows, there is another level of indirection since the OS HANDLEs
were already wrapped in various kinds of Handle objects. As an additional
complication, ClientSocket close on Windows is asynchronous, so the
EventHandler may shutdown before all of the ClientSocket Handles can be
destroyed.
related #27898, #28081R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2760293002 .
This is a move towards passing all information through data objects
computed by previous phases rather than pulling it directly from
Backend or Compiler.
This is needed to support a shift from model K to model J between
resolution and codegen.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2777163002 .
This change adds support for executing:
- BlockStatement
- ExpressionStatement
- IfStatement
- VariableDeclaration
Currently only BlockStatement introduces a new environment and
VariableDeclaration modifies the environment.
BUG=
R=kmillikin@google.com
Review-Url: https://codereview.chromium.org/2775293002 .
Relative paths in a depsfile are interpreted by ninja relative to the
current working directory which in a GN build is the root of the build
directory ($root_build_dir in GN terms). When doing a
cross-compilation, this is different from the root of the output
directory ($root_out_dir in GN terms) for all builds other than the
target. This fixes the computation of depsfile entries so that they are
always relative to the current working directory.
Concretely, this means incremental builds in Fuchsia do not always
rerun the patch_sdk step for the host, shaving 12+ seconds off of no-op
builds.
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2776323002 .
This is an alternative to the other CL. It just uses the result of
dart.mixin instead of declaring a new class. That preserves the assumption (at least at runtime) that the mixin class directly inherits from Object.
We were also not declaring interfaces for ClassTypeAliases.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2783443002 .
There are four operations that work on Vectors: Vector creation, looking
up an item in a Vector, assigning a value to an item in a Vector, and
copying a Vector. The first three operations are allowed to only use
integer literals as number operands (length for Vector creation, index
for item lookup and assignment). Corresponding AST nodes are created for
these operations.
Vectors are used to represent contexts in Closure Conversion. The parent
context is stored as item 0 in its children contexts. The "golden" tests
for this transformation are adjusted accordingly.
The support for Vectors is added to ast-to-text, ast-to-binary, and
binary-to-ast transformations.
R=asgerf@google.com, kmillikin@google.com
Review-Url: https://codereview.chromium.org/2767773004 .
For compiling the platform libraries separately and for hot reload, we
will not link canonical names of Kernel libraries, classes, and
members to their Kernel definitions. Those definitions will not be
persistent.
As a first step, change name-based lookup of libraries and classes to
be be based on the canonical name instead of the Kernel definition.
BUG=
R=jensj@google.com, kustermann@google.com
Committed: a15b8c49ea
Review-Url: https://codereview.chromium.org/2762213002 .
In this case we should use a dotted package name, similar to other
packages outside third_party.
Previously, restoreAbsolute() didn't return a package URI at all,
which would result in a relative path being suggested for a
missing import.
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2771323002 .
