This makes it more consistent with other listener calls.
Change-Id: Iae98ae4c37078c15ea785faef1cb21b2ea85bb48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
If we do a type check against a class that isn't generic, then we can
safely ignore all the type arguments - because irrespective of their
values - either the class we test against is in the transitive super
hierarchy of an object's class or not.
Issue https://github.com/dart-lang/sdk/issues/55516
Change-Id: Ibf6950492d4c33d7eaf55d6ce8389ebfac201b00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369461
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
This brings the soft static enforcement that we had before: a producer
that extends ParsedCorrectionProducer cannot access the
ResolvedUnitResult of a ParsedUnitResult.
Also we add some runtime enforcement that the producers used for parse-
only lint rules are ParsedCorrectionProducer.
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: If77fa66ae6fc070de1c7e931eb992a4adc14b68a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369561
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
We talked about migrating these tests to using language version overrides but I lost the plot over the weekend :).
Can you suggest how I'd modify this? How would I opt into this feature with a language version override if there is not version in which we have it enabled?
Change-Id: Ie0411d8f24e7468692a99cc2bc645bdbd3d5a500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369420
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Add `NodeLintRegistry.afterLibrary` API which allows a lint rule to
register a callback to be called after the last CompilationUnit is
visited.
Change-Id: I77bf279412617e6f2c825b6dbeaf34849e515156
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368524
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`.
args (b3608bd..6a5a2e6):
6a5a2e6 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/args#276)
async (f933ddf..4073129):
4073129 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/async#276)
bazel_worker (2ec90c0..c76d7c8):
c76d7c8 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/bazel_worker#93)
benchmark_harness (6fa42b0..f6ef33d):
f6ef33d 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/benchmark_harness#107)
boolean_selector (84467e5..62f82f6):
62f82f6 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/boolean_selector#62)
browser_launcher (0dcf224..7348cea):
7348cea 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/browser_launcher#60)
cli_util (9fe3eeb..c37d5e1):
c37d5e1 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/cli_util#104)
clock (80e70ac..7cbf08e):
7cbf08e 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/clock#65)
collection (fe2e800..586a5e8):
586a5e8 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/collection#346)
convert (056626e..302af1b):
302af1b 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/convert#106)
crypto (3f815ac..0a10171):
0a10171 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/crypto#171)
csslib (141dd65..23c314b):
23c314b 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/csslib#202)
dartdoc (ed97585..45627f9):
45627f92 2024-06-01 dependabot[bot] Bump the github-actions group across 1 directory with 3 updates (dart-lang/dartdoc#3777)
ecosystem (ad9da15..bc25c0c):
bc25c0c 2024-06-01 dependabot[bot] Bump the dependencies group with 4 updates (dart-lang/ecosystem#265)
file (8ce0d13..07cacae):
07cacae 2024-06-03 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (google/file.dart#240)
fixnum (ac892ad..a8157d8):
a8157d8 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 in the github-actions group (dart-lang/fixnum#130)
glob (ee48ea8..eaec6a4):
eaec6a4 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/glob#94)
html (00d3461..3bc803d):
3bc803d 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/html#247)
http (6337ee3..7bfbeea):
7bfbeea 2024-06-01 Anikate De `ok_http`: Add BaseClient Implementation and make asynchronous requests. (dart-lang/http#1215)
http_multi_server (4a791af..25941e2):
25941e2 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/http_multi_server#70)
http_parser (702698a..551e0e4):
551e0e4 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/http_parser#93)
json_rpc_2 (3187f7b..5b1cbd6):
5b1cbd6 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/json_rpc_2#115)
lints (b254c7e..baaaa56):
baaaa56 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (dart-lang/lints#191)
logging (7f722dc..73f043a):
73f043a 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (dart-lang/logging#166)
markdown (c1013dc..3d8d7a8):
3d8d7a8 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/markdown#614)
matcher (4ac4096..0abd405):
0abd405 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/matcher#249)
mime (b01c9a2..8d2d559):
8d2d559 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (dart-lang/mime#124)
package_config (3909676..903a0e5):
903a0e5 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/package_config#155)
path (aea50fa..8fc4c72):
8fc4c72 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/path#167)
pool (1a6f2df..88e4636):
88e4636 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/pool#87)
pub_semver (f57c9c3..a9025f3):
a9025f3 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/pub_semver#104)
shelf (338962c..ea3c983):
ea3c983 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/shelf#434)
source_map_stack_trace (6834af5..96a8213):
96a8213 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/source_map_stack_trace#55)
source_maps (181a41c..caa79c2):
caa79c2 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/source_maps#94)
source_span (e80cb44..59a3903):
59a3903 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/source_span#113)
sse (1bb0a98..7dcde16):
7dcde16 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/sse#111)
stack_trace (4d346f7..ab09060):
ab09060 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/stack_trace#155)
stream_channel (61ad872..b41ff7a):
b41ff7a 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/stream_channel#107)
string_scanner (32468bd..7b37c1b):
7b37c1b 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/string_scanner#75)
sync_http (82553db..7622bdd):
7622bdd 2024-06-03 dependabot[bot] Bump actions/checkout from 4.1.4 to 4.1.6 (dart-lang/sync_http#47)
term_glyph (a46b48b..c86e817):
c86e817 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/term_glyph#53)
test_descriptor (d61bf6c..b23d7cc):
b23d7cc 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/test_descriptor#67)
test_process (4ab3f1c..862eaf3):
862eaf3 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/test_process#59)
test_reflective_loader (f8807e0..816942e):
816942e 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/test_reflective_loader#63)
typed_data (fb1958c..d14f965):
d14f965 2024-06-02 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/typed_data#88)
vector_math (43f2a77..3c03ac3):
3c03ac3 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.2 to 4.1.6 (google/vector_math.dart#325)
watcher (c182cd3..c00fc2a):
c00fc2a 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/watcher#168)
yaml (8fb8147..7873b3f):
7873b3f 2024-06-01 dependabot[bot] Bump actions/checkout from 4.1.5 to 4.1.6 in the github-actions group (dart-lang/yaml#165)
Change-Id: I734de0d6c7013c49b879f927d5ecda4d675b19ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369520
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This fixes https://github.com/dart-lang/sdk/issues/55889 which is repeat of https://github.com/Dart-Code/Dart-Code/issues/3929 (but semantic tokens was not fixed with that CL).
The issue was when the server was initialized with no roots (for example an empty workspace) and then a new file opened with requests being sent immediately before the roots were updated.
The fix changes from directly calling `server.getResolvedUnit` to instead using `requireResolvedUnit` which handles this situation by waiting for any in-progress context changes and retries.
Fixes https://github.com/dart-lang/sdk/issues/55889
Change-Id: Id078947e5c6665b2afb9e31adc244f16987870f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
In 7fa9b814d2
(https://dart-review.googlesource.com/c/sdk/+/369141) a limit was
introduced to prevent OOM.
It however introduced a bug where `available` would be out of sync
(> 0 when it should be 0) causing issues - seemingly an infinite loop
where it continues trying to read even though no data is available - and
e.g. the weekly bot timed out after 12 hours because stuff didn't work.
(I think the issue is `stopRead()` returning false, but isn't sure).
This CL fixes the issue by updating the field before the possible break.
TEST=Hopefully a test will be added in a follow-up.
Change-Id: I722c8868fd7354fc9403e8d2f387914c3fab884a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369243
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
There's no need to make an instance of _TypeUniverse and pass around a
`this` reference to method calls as there's no state.
Issue https://github.com/dart-lang/sdk/issues/55516
Change-Id: I522a3ef677d0301c0a5dcd1d83499a99293618a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369242
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
+ a few other references of 'isNonNullableByDefault'
Change-Id: Ifcd6bf5c2cc5dbbca7dda1576248fc4cd59eed5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369023
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
If HttpResponse is being closed prematurally (e.g. because client
decided to close its request) we need to propagate cancellation
to the stream which is being piped into the response. Otherwise
we will keep that stream forever hanging around and leak underlying
resources.
Fixes https://github.com/dart-lang/sdk/issues/55886
TEST=tests/standalone/io/regress_55886_test.dart
R=kustermann@google.com
Change-Id: I7c294ed19cc7c350fd101b078bd650ce8a6526a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369061
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Previously, this behavior was custom-wired into the Dart analyzer, but
now it is specified with TargetKinds.
In the analyzer we remove special annotation-target-verification for
`mustCallSuper`.
Change-Id: Ibd3ada0a612069c5286facffaad557671c7a85b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
By removing unnecessary references to higher level libraries we
can extract a separate 19 libraries cycle, related to errors. Maybe
later we can break it further.
This reduces the mono-cycle from 295 to 270 libraries.
Change-Id: Id9db12002dba10788b65262d3d7325ad6079ceff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This mixes layers, which I believe one of the ways that cause large
library cycles.
Change-Id: Ie1cf991bcd40b19127a6ade7efc5ad5fd69d0018
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368942
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This mixes layers, which I believe one of the ways that cause large
library cycles.
Change-Id: Id7124b9f4e4bf81838f637255fe04fd28f5fda01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
- Don't convert the result to list: we don't need the result as list so
conversion is not necessary.
- Return empty set instead of null when empty: `null` and empty set
represents the same thing, using just one value is simpler for the
downstream as we don't need to check both the null case and whether
the set is empty.
Change-Id: I925e9bd8962eeb91a4a20ab5b7218a27d263bece
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369021
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
This mixes layers, which I believe one of the ways that cause large
library cycles.
Change-Id: Ic21292f2d831229a3ba444abf3131c66ec9968d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
