Commit graph

7606 commits

Author SHA1 Message Date
Stephen Adams 127b419fc1 Add WhereIterable.map
This makes some nice code improvements for dart2js. dart2js can't
inline the MappedIterable factory constructor and specialize by
optimization, so specializing by hand removes the test "is
EfficientLength" for code like "x.where(f).map(g)".

R=lrn@google.com

Review URL: https://codereview.chromium.org/2354093002 .
2016-09-22 10:36:16 -07:00
William Hesse 61eee9ee52 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Committed: 5d3e356ca7

Review URL: https://codereview.chromium.org/1746743002 .

Reverted: 6d238ba197
2016-09-16 15:03:18 +02:00
Stephen Adams 8495283e25 Reuse expensive string in js_rti
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2326943003 .
2016-09-12 17:22:27 -07:00
Alan Knight 42f8ab2d6a Fix dataTransferItemList indexing
BUG=

Review URL: https://codereview.chromium.org/2326113002 .
2016-09-09 12:28:59 -07:00
Stephen Adams c70952c7bc dart2js: Pass type information to constructor rather than add later.
This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug with the interactions with type optimizations.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2310573002 .

Committed: 9217be050d
Reverted:  cdd6eeb57d
2016-09-07 15:07:54 -07:00
Kevin Moore ca2285be58 dart:js_util - fix spelling
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2311563002 .
2016-09-06 09:23:59 -07:00
Florian Loitsch 70c48b9a2e Don't propagate synchronous Future.wait errors immediately.
Fixes #27249.

R=lrn@google.com

Review URL: https://codereview.chromium.org/2311923002 .
2016-09-06 11:57:43 +02:00
Florian Loitsch 6255638cd0 Return futures on Stream.cancel when possible.
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2202533003 .

Committed: 395e7aaa69
Reverted: 99e5328eac
Committed: 1905ddafaa
Reverted: 46a8579c1e
2016-09-05 17:41:22 +02:00
Stephen Adams 921eac74cf Rename $builtinType to $ti
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2306813003 .
2016-09-02 10:53:26 -07:00
Zachary Anderson 4024fe154a GN: Relativize occurrances of //dart
The Dart root in the Dart tree is at //, not //dart.
But in the Dart tree we can refer to the root with
a relative path.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2301833003 .
2016-09-01 13:35:44 -07:00
Alan Knight 43cb6a4c59 Replace Maps library tour link in Storage template with current URL.
BUG=#27150
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2277103002 .
2016-08-26 12:34:53 -07:00
Lasse R.H. Nielsen 99ec987a09 Remove deprecated Resource class from dart:core.
BUG=
R=floitsch@google.com, mit@google.com

Review URL: https://codereview.chromium.org/2272373002 .

Committed: f61143153a
Committed: 35437dda1f
2016-08-26 11:58:04 +02:00
Lasse Nielsen 35437dda1f Remove deprecated Resource class from dart:core.
BUG=
R=floitsch@google.com, mit@google.com

Review URL: https://codereview.chromium.org/2272373002 .

Committed: f61143153a
2016-08-26 10:50:58 +02:00
Lasse Nielsen f61143153a Remove deprecated Resource class from dart:core.
BUG=
R=floitsch@google.com, mit@google.com

Review URL: https://codereview.chromium.org/2272373002 .
2016-08-26 10:31:08 +02:00
Ryan Macnak 0245016792 Fix ArgumentError constructor call.
R=asiva@google.com

Review URL: https://codereview.chromium.org/2272703007 .
2016-08-24 17:13:22 -07:00
Ryan Macnak aa38062a23 Add WebSocket.addUtf8Text to allow sending pre-encoded text without a round-trip UTF-8 conversion.
Use it to implement the vm-service, where in particular we are concerned about the space overhead of the conversion leading to the process being killed on iOS.

Closes #27129

R=johnmccutchan@google.com, lrn@google.com

Review URL: https://codereview.chromium.org/2260073002 .
2016-08-24 16:15:07 -07:00
Zachary Anderson 57bff322cd Ignore non-UTF8 strings in the environment
R=asiva@google.com

Review URL: https://codereview.chromium.org/2273053002 .
2016-08-24 10:10:41 -07:00
Florian Loitsch 1971d4c59d Fix DateTime.timeZoneName comment.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2270043002 .
2016-08-24 12:49:17 +02:00
Stephen Adams 266ac1b0bc Add SSA instructions for reified type information
This enables GVN optimizations of type representations, e.g.

        var touches, targetTouches, changedTouches, mockTouchList, t1;
        touches = H.setRuntimeTypeInfo([], [W.Touch]);
        targetTouches = H.setRuntimeTypeInfo([], [W.Touch]);
        changedTouches = H.setRuntimeTypeInfo([], [W.Touch]);
        mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], [W.Touch]);
--->
        var t1, touches, targetTouches, changedTouches, mockTouchList;
        t1 = [W.Touch];
        touches = H.setRuntimeTypeInfo([], t1);
        targetTouches = H.setRuntimeTypeInfo([], t1);
        changedTouches = H.setRuntimeTypeInfo([], t1);
        mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], t1);

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2260223002 .
2016-08-19 13:02:18 -07:00
Ryan Macnak d418dde65b Reduce copying in sending service responses.
Add missing safepoint transitions.

Issue #27092
Likely contributes to Issue #27010

dart2js hello
Peak RSS at first Observatory visit -> Peak RSS after visiting timeline (with endless recorder)
Before 215M -> 321M
After 182M -> 233M

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2254543006 .
2016-08-18 10:34:50 -07:00
Florian Loitsch 33b7b45252 Deal with synchronous errors in Future.wait.
Synchronous errors are caught and piped into the returned future. This makes handling errors in Future.wait uniform.

Fixes #23656
BUG= http://dartbug.com/23656
R=lrn@google.com

Review URL: https://codereview.chromium.org/2252823004 .
2016-08-18 14:09:20 +02:00
Stephen Adams 1381749356 Make Uri._makeQuery easier to analyze
In many programs dart2js can tell that [queryParameters] is always null.

It is too hard for dart2js to infer from the previous conditions that
the last test 'query != null' must always be true. By changing the
liveness predicate for the forEach code to be a function of one
variable, we can help dart2js understand that the forEach code is dead
when queryParameters is null.

BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org/2245323004 .
2016-08-17 10:45:11 -07:00
Lasse R.H. Nielsen afbbbb97cf Reapply fast-URI patch.
Review URL: https://codereview.chromium.org/2245533004 .
2016-08-17 10:54:24 +02:00
Harry Terkelsen 1d749a2fec record that Gamepad.buttons creates GamepadButtons
This also extends the html generator to be able to generate List implementations with nullable element types

Fixes https://github.com/dart-lang/sdk/issues/27073

R=sra@google.com, terry@google.com

Review URL: https://codereview.chromium.org/2242203002 .
2016-08-16 13:56:32 -07:00
Jacob Richman b779679721 Switch to @patch annotation from patch.
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org/2233633002 .
2016-08-10 09:31:06 -07:00
John Messerly 1c7aca0d6d fix #25944, improve Future.then inference
also fixes #25322, return values of async functions are T | F<T>

R=leafp@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/2208953002 .
2016-08-09 16:04:26 -07:00
Lasse R.H. Nielsen 3502fd5fd7 Revert "Reapply fast-URI patch."
Seems to trigger VM bug.

Review URL: https://codereview.chromium.org/2225243003 .
2016-08-09 12:51:58 +02:00
Lasse R.H. Nielsen 99e94db85b Reapply fast-URI patch.
R=whesse@google.com

Review URL: https://codereview.chromium.org/2220373002 .
2016-08-09 09:38:47 +02:00
John McCutchan a67b9c82ee Support devFS writes via HTTP PUT
- [x] Allow DevFS writes over HTTP PUT with a gzip compressed payload.
- [x] Add service test for http put writes.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2225583002 .
2016-08-08 10:35:29 -07:00
Florian Loitsch 46a8579c1e Revert "Return futures on Stream.cancel when possible."
This reverts commit 1905ddafaa.

Review URL: https://codereview.chromium.org/2223133002 .
2016-08-08 19:31:04 +02:00
Florian Loitsch 1905ddafaa Return futures on Stream.cancel when possible.
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Committed: 395e7aaa69

Review URL: https://codereview.chromium.org/2202533003 .

Reverted: 99e5328eac
2016-08-08 17:30:36 +02:00
Søren Gjesse f9404b969b Handle HTTP header parameters with empty values better
This handles the null issue reported.

Closes #26598

BUG= https://github.com/dart-lang/sdk/issues/26958
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2225003002 .
2016-08-08 16:35:15 +02:00
Stan Manilov 0648e2622b Add example int doc for Iterable.expand
The expand function is not trivial and an example helps flesh out its
behaviour.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org/2154933002 .
2016-08-05 10:34:38 -07:00
Florian Loitsch 99e5328eac Revert "Return futures on Stream.cancel when possible."
This reverts commit 395e7aaa69.

Review URL: https://codereview.chromium.org/2213193004 .
2016-08-05 14:32:14 +02:00
Florian Loitsch 395e7aaa69 Return futures on Stream.cancel when possible.
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2202533003 .
2016-08-05 13:58:45 +02:00
Sigmund Cherem 0eee4027a6 Delete dart_backend from compiler.
R=sra@google.com

Review URL: https://codereview.chromium.org/2213673002 .
2016-08-04 15:57:04 -07:00
Todd Turnidge 74ad64038a Allow weird characters (like ?) to appear in devfs filenames.
Closes #27011

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2208223002 .
2016-08-03 15:43:37 -07:00
Jacob Richman 36c9514f04 Use Point<num> in dart:html for strong mode
Strong mode is (as of recently) inferring a stricter type (e.g., Point<double>) and causing breaking changes.

patch from issue 2211493003 at patchset 1 (http://crrev.com/2211493003#ps1)

BUG=

Review URL: https://codereview.chromium.org/2211563002 .
2016-08-03 14:09:10 -07:00
Jacob Richman 7f2950916e Fix so that logic to enable private user define @JS classes does not impact codegen for dart:html native classes where private classes are not an issue.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2195453002 .
2016-08-03 14:03:39 -07:00
Danny Tuppeny e76537e4eb Fix formatting of comment in HttpHeaders class (#26937) 2016-07-27 19:44:20 +02:00
Jacob Richman a711a35021 Fix missing line for js_util in dart_server.platform
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/2181403002 .
2016-07-26 10:26:29 -07:00
Jacob Richman 31f1f9caf3 TBR. Shouldn't have referenced JSObject in dart2js. Accidentally left it in porting code from dartium.
BUG=

Review URL: https://codereview.chromium.org/2186433002 .
2016-07-25 18:55:31 -07:00
Devon Carew e0e96ad99a Fix some markdown issues in library docs (related to https://github.com/dart-lang/dartdoc/issues/968).
BUG=
R=keertip@google.com

Review URL: https://codereview.chromium.org/2175293004 .
2016-07-25 11:01:27 -07:00
Jacob Richman 96ca5db7e5 Add JSNative utility class with static methods methods to efficiently manipulate typed JSInterop objects in cases where the member name is not known statically. These methods would be extension methods on JSObject if Dart supported extension methods. Update package js to export these methods. Implement in Dart2JS. Implement JS$ in dart2js.
BUG=
R=alanknight@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2150313003 .
2016-07-25 09:59:01 -07:00
William Hesse ca49303576 Revert "Add fast-mode Uri class."
This reverts commit 00090a0c72.

Revert "Add fast-mode Uri class."

This reverts commit 323ca7e410.

Revert "Fix regression for the one case where we deliberately don't follow the RFC."

This reverts commit b39e048c4b.

Revert "Cache hashCode in Uri implementations to improve performance when used as, e.g., Map key."

This reverts commit a11ad27723.

BUG=https://github.com/dart-lang/sdk/issues/26917
TBR=keertip@google.com

Review URL: https://codereview.chromium.org/2167663002 .
2016-07-20 14:32:52 +02:00
Harry Terkelsen faaff39aa9 Record that MediaStream creates MediaStreamTracks
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2168473002 .
2016-07-19 17:00:04 -07:00
Jacob Richman e010460709 Utility class of static methods to efficiently manipulate typed JSInterop objects in a dynamic manner. Fix for @JS classes that are _private. Bug #25038 @JS on a _Private class in Dartium
Tests are in the separate Dart2JS CL

BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2158493003 .
2016-07-19 10:37:20 -07:00
William Hesse bde8d3efc6 Revert "Don't call _ensureRequestAnimationFrame in Dartium."
This reverts commit bf8eeef6a0.

Revert "Fix animationFrameRequest for dartium."

This reverts commit 3daaf3849f.

BUG=https://github.com/dart-lang/sdk/issues/26906

Review URL: https://codereview.chromium.org/2159183003 .
2016-07-19 13:56:36 +02:00
Keerti Parthasarathy 69a8b11f67 Fix for uri replace whene uri has fragment. Was adding a second '#'.
BUG=
R=het@google.com

Review URL: https://codereview.chromium.org/2158933003 .
2016-07-18 16:31:43 -07:00
Alan Knight 30b489578d Revert "Reapply zone tasks."
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
2016-07-18 13:12:36 -07:00