Brian Wilkerson
74686371b3
Add support for getting the sessionId from instrumentation and sending it to the client
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2359233002 .
2016-09-22 10:26:13 -07:00
Konstantin Shcheglov
7343da76ba
Issue 27078. Describe RefactoringProblemSeverity values.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27078
Review URL: https://codereview.chromium.org/2312073003 .
2016-09-06 17:46:24 -07:00
Konstantin Shcheglov
f4186fb463
Issue 27244. Add 'isDeprecated' to HoverInformation.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27244
Review URL: https://codereview.chromium.org/2310153002 .
2016-09-06 11:31:11 -07:00
Devon Carew
cd0a81ddf5
Update the styles for the analysis server specification.
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2296023002 .
2016-08-30 15:42:27 -07:00
pq
270695fc31
Adds PID to server.connected
notification ( #26744 ).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/2088663004 .
Fixes: https://github.com/dart-lang/sdk/issues/26744 .
2016-06-21 16:00:27 -07:00
pq
e7e205f00b
Add error codes to server protocol ( #25958 ).
...
See: https://github.com/dart-lang/sdk/issues/25958
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1774913006 .
2016-03-09 10:44:03 -08:00
Dan Rubel
9fe92127e5
update setAnalysisRoots to accept package spec file
...
As part of addressing https://github.com/dartino/atom-dartino/issues/13 ,
this CL updates the setAnalysisRoots API to allow package spec files
in the packageRoots map.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1711353003 .
2016-02-19 10:57:16 -05:00
Konstantin Shcheglov
7c5e03435b
Deprecate UNIT_TEST_GROUP and UNIT_TEST_TEST.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1570003002 .
2016-01-07 20:03:39 -08:00
Konstantin Shcheglov
1f5973e24e
Explicitly specify that FilePath is not just absolute, but also a normalized path.
...
It was implied, and every client I know of uses absolute and normalized paths.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1506323002 .
2015-12-09 11:30:54 -08:00
pq
2fdcb1bd74
Promote diagnostic.getDiagnostics()
( #25061 ).
...
* removes rolling average support
* removes "experimental" tag
* bumps API version
Fixes #25061 .
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org/1509033003 .
2015-12-09 09:29:26 -08:00
pq
43f027fc05
Analysis request getReachableSources
( #24893 ).
...
Implements a new request to get reachable sources.
This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").
More context here: https://github.com/dart-lang/sdk/issues/24893
R=brianwilkerson@google.com , devoncarew@google.com
Review URL: https://codereview.chromium.org/1491013002 .
2015-12-02 13:26:35 -08:00
pq
82e83bb34d
Experimental getDiagnostics
request ( #24480 ).
...
* Adds `getDiagnostics` request with *very* provisional diagnostics payload (primary goal here is to plumb this fully through and iterate).
* Updates codegenerator to skip doc generation for experimental APIs.
Additional context here: https://github.com/dart-lang/sdk/issues/24480 .
BUG=24480
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1416093007 .
2015-11-05 15:05:21 -08:00
Konstantin Shcheglov
069ba985de
Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths.
...
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org/1407333006 .
2015-11-03 10:19:41 -08:00
Konstantin Shcheglov
c0d68a5437
DAS specification changes - spelling and ElementKind.FILE addition.
...
ElementKind.FILE will be used in search.findElementReferences
1. In the 'element' field of responce when a URI is at the given offset.
2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1409333002 .
2015-10-17 10:03:03 -07:00
Konstantin Shcheglov
b107dec41a
Spec change: include covering expressions into Extract Local protocol.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1388783003 .
2015-10-05 14:44:32 -07:00
pq
8697392367
AnalysisError hasFix
attr (Implements #23874 ).
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org/1385523002 .
2015-10-05 09:46:17 -07:00
Konstantin Shcheglov
9d48af9ee3
Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1375163003 .
2015-10-01 09:53:20 -07:00
Konstantin Shcheglov
da29a447c4
New analysis.implemented notification specification.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1372623004 .
2015-09-25 09:57:29 -07:00
Konstantin Shcheglov
173cb44a85
Add '<!doctype html>' to spec.
...
The new task model's HTML parser reports an error otherwise.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1351323004 .
2015-09-21 10:10:57 -07:00
Konstantin Shcheglov
c67b274852
Explicitly document that NavigationRegion.targets cannot be empty.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1328273002 .
2015-09-08 13:16:43 -07:00
Konstantin Shcheglov
58f5005cb1
Add the optional 'superOnly' request parameter for 'search.getTypeHierarchy'.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1325543006 .
2015-09-03 13:03:01 -07:00
Paul Berry
03a156c891
Plumb "enableSuperMixins" option through analysis server (implements DEP 34).
...
Partially addresses #23772 .
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1301533003 .
2015-08-20 09:47:26 -07:00
guillermooo
c4aa865c69
include generated doc file for analysis server api
2015-08-06 23:07:15 +02:00
Konstantin Shcheglov
aa30cad380
Proposal for the 'edit.organizeDirectives' request.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23921
Review URL: https://codereview.chromium.org//1258563008 .
2015-08-03 07:59:26 -07:00
Paul Berry
e93b52a66f
Deprecate option "enableNullAwareOperators" in analysis server.
...
As of analyzer version 0.25.2, this option is no longer needed;
null-aware operators are always enabled.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1255113005 .
2015-07-28 11:31:03 -07:00
Konstantin Shcheglov
c4652486b4
Fix for a copy/paste problem in GET_NAVIGATION_INVALID_FILE.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1243073004 .
2015-07-21 08:46:55 -07:00
Konstantin Shcheglov
a049c5aba0
Update DAS protocol version to 1.9.0
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1241213002 .
2015-07-20 12:24:37 -07:00
Konstantin Shcheglov
55cb93b422
Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1241193002 .
2015-07-20 10:37:46 -07:00
Brian Wilkerson
2ffa8de794
Add notification of analyzed files
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1232393005 .
2015-07-13 15:07:33 -07:00
Brian Wilkerson
10b7db100f
Revert "Update Analysis Server highlight API and implementation."
...
This reverts commit 739847402b
.
Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1236433003 .
2015-07-13 09:49:55 -07:00
Konstantin Shcheglov
d7c2f4550b
Issue 23640. Implement 'analysis.getNavigation' request.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640
Review URL: https://codereview.chromium.org//1232683003 .
2015-07-10 15:31:25 -07:00
Konstantin Shcheglov
739847402b
Update Analysis Server highlight API and implementation.
...
I think this is a good enough compromise between the existing and IDEA granilarity.
Eclipse plugin CL will follow.
(IN)VALID_STRING_ESCAPE are not implemented yet.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1227143003 .
2015-07-09 11:19:44 -07:00
Brian Wilkerson
07dd6b7649
Add lineLength parameter to edit.format request (issue 23519)
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1154303005
2015-06-01 09:39:02 -07:00
brianwilkerson@google.com
4e0bb57118
Update specification version number
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//1096693006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45297 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 21:07:29 +00:00
brianwilkerson@google.com
4422b7c01e
Fix error handling for formatting and update the spec
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1099633004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45296 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 20:57:33 +00:00
danrubel@google.com
f117f67660
add optional importUri to completion suggestion
...
BUG=dartbug.com/23175
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1097083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45288 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:32:54 +00:00
paulberry@google.com
4af80fc1e7
Add an analysis server option to enable null-aware-operator support.
...
The option may be enabled in editor by setting the tracing option
"experimental/nullAwareOperators" (in com.google.dart.tools.core) to
true.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1063613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44909 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 14:53:00 +00:00
brianwilkerson@google.com
b396bc4c96
Support refresh of individual analysis roots (issue 22254)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1047733004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44791 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-30 21:07:23 +00:00
danrubel@google.com
a8eb426282
add UNKNOWN_SOURCE error code and remove 2 unused legacy error codes
...
BUG=dartbug.com/23039
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1042403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44787 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-30 20:12:29 +00:00
jwren@google.com
38ff63c77d
Anchor and create a link near Notifications and Requests definitions in the Analysis Server Spec
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1033473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44641 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 18:15:34 +00:00
scheglov@google.com
0c21dc284c
Add 'containingClassDescription' to HoverInformation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1003193005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44483 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 22:05:05 +00:00
scheglov@google.com
2e77fcdd11
Add an optional 'typeParameters' to Element.
...
Also use it in Editor, e.g. in Outline.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//990343002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44349 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 22:02:44 +00:00
scheglov@google.com
1183b3b35a
When a closure is extracted as a method, it does not have any return type.
...
But it should not be returned as 'void'.
It should be an empty string, as any other method with unknown return type.
I guess we could improve this in the future, e.g. promote type of a returned expression into the signature.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//970063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44177 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 16:17:33 +00:00
brianwilkerson@google.com
3750ba067f
Return version with connected notification
...
R=jwren@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//943723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43892 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 20:45:01 +00:00
scheglov@google.com
6a78250c64
Issue 22476. Outline for enums.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22476
Review URL: https://codereview.chromium.org//934353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43853 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 21:37:27 +00:00
jwren@google.com
89219a623f
Fix build, address comments from Brian in previous email.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//931833003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43820 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 20:26:09 +00:00
jwren@google.com
a46fc6016d
Addition of the --no-index flag to the analysis server spec.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//932883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43816 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 17:55:00 +00:00
brianwilkerson@google.com
f473ae15a3
Spec changes for issue 22254
...
Review URL: https://codereview.chromium.org//882643004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43565 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 19:35:40 +00:00
brianwilkerson@google.com
4468038300
Rework requests in execution domain
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//904733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43556 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 15:49:44 +00:00
brianwilkerson@google.com
fcd7fdb93a
Fix ambiguous description
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//901063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43493 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 01:31:09 +00:00