languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-22 02:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
35095 commits 11 branches 6011 tags 1.4 GiB
Commit graph

1664 commits

Author SHA1 Message Date
danrubel 79a8654e5f (TBR) increase pumpEventQueue to finish analysis 
Review URL: https://codereview.chromium.org/1508523002 .
 2015-12-06 17:26:27 -05:00
danrubel 372cb6be58 fix combinator contributor 
gracefully degrade given partially element information
better reporting of exceptions during testing

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1506623002 .
 2015-12-06 15:34:19 -05:00
danrubel 53f777162e (TBR) get completion tests passing 
Review URL: https://codereview.chromium.org/1505443002 .
 2015-12-04 20:55:09 -05:00
pq 80dfbafe28 Context-specific configuration status reporting. 
* Fixes status page to show options per-context.
* Adds lints and error filter reporting.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1495303002 .
 2015-12-04 15:50:00 -08:00
Konstantin Shcheglov 2be2c5e55c Fix for navigation reginos for instance creations with import prefixes. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1498163003 .
 2015-12-04 14:24:09 -08:00
Dan Rubel a5e4c81b7f move combinator contributor to new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1503463002 .
 2015-12-04 15:48:21 -05:00
Konstantin Shcheglov dd9ad7e015 Skip assignments and argument lists. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1496363002 .
 2015-12-04 11:43:39 -08:00
danrubel 9f033a9d94 convert uri contributor to use new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1498733005 .
 2015-12-04 07:49:31 -05:00
danrubel 7b5a756b0f extract ReplacementRange for use in tests 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1499003002 .
 2015-12-03 20:59:29 -05:00
Konstantin Shcheglov 767b57bafd Extract Local refactoring: skip method names in invocations. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1498523005 .
 2015-12-03 15:19:36 -08:00
danrubel 4379efb6b4 rework ArgListContributor to use new task model 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1500793003 .
 2015-12-03 18:00:50 -05:00
Brian Wilkerson 090459ca08 Report targets will null entries (prevents an NPE) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1497083003 .
 2015-12-03 13:46:48 -08:00
danrubel 6fd2fba704 hookup new CompletionContributorFactory 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1500723002 .
 2015-12-03 13:34:35 -05:00
Konstantin Shcheglov 93072d7825 Include tokens of Function/MethodDeclaration into AST view. 
It helped to identify the "The null object does not have a getter 'variable'" problem.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1493893006 .
 2015-12-03 10:00:05 -08:00
danrubel c2b70c9054 improve annotation argument completion - from https://github.com/dart-lang/sdk/pull/25099 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1497773002 .
 2015-12-03 10:34:00 -05:00
danrubel ac63bc8fe4 update completion extension point to use CompletionContributorFactory 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1495933002 .
 2015-12-03 10:02:04 -05:00
danrubel e1f6fc7c95 move dart completion contributor instantiation 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1497523004 .
 2015-12-03 07:46:00 -05:00
Konstantin Shcheglov 5f49df1644 Issue 25095. Add 'Change X to Y type annotation' Quick Fix. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25095

Review URL: https://codereview.chromium.org/1492053004 .
 2015-12-02 18:50:41 -08:00
pq 43f027fc05 Analysis request getReachableSources (#24893). 
Implements a new request to get reachable sources.

This solves a specific issue for flutter (e.g., inferring execution type by checking the transitive closure of reachabe sources for `dart:flutter`) but can be more generallly useful for other client-side smarts (e.g., "is this a web entry point?" or "is this a test?").

More context here: https://github.com/dart-lang/sdk/issues/24893

R=brianwilkerson@google.com, devoncarew@google.com

Review URL: https://codereview.chromium.org/1491013002 .
 2015-12-02 13:26:35 -08:00
Konstantin Shcheglov bf54a3bef6 Don't attempt to create a file for non-Dart imports. 
This should help to fix the following exception:

Dart analysis server, SDK version 1.13.0-dev.7.12, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
Bad state: No element

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1492843003 .
 2015-12-02 09:28:58 -08:00
Konstantin Shcheglov cfc8ee30b7 Fix for exception in FixProcessor._addFix_illegalAsyncReturnType. 
This fixes the following reported exception.

Dart analysis server, SDK version 1.13.0, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
The null object does not have a getter 'offset'.

NoSuchMethodError: method not found: 'offset'
Receiver: null
Arguments: []

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1487683006 .
 2015-12-01 14:37:11 -08:00
Konstantin Shcheglov 50d9ec3161 Check types in '_addFix_createConstructorSuperExplicit'. 
I was not able to reproduce the problem.
But this might fix the following exception.

Dart analysis server, SDK version 1.13.0, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor
type 'MethodInvocation' is not a subtype of type 'ConstructorDeclaration' in type cast.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1489823003 .
 2015-12-01 13:40:46 -08:00
pq c84ea322ff Fix rolling averages in diagnostic status. 
* updates sampler to return `num`s
* migrates status get_handler to one shared handler for diagnostics

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1490623002 .
 2015-11-30 21:24:10 -08:00
Konstantin Shcheglov 5b2ad27b06 Issue 25048. Ignore inner analysis roots which are already managed by outer roots. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25048

Review URL: https://codereview.chromium.org/1487903002 .
 2015-11-30 15:01:33 -08:00
pq 723dfb2c88 Diagnostic status reporting (#24932). 
Adds a status page for Diagnostic data; notably with timing info which will be handy for getting an informal handle on perf issues (https://github.com/dart-lang/sdk/issues/24932).

BUG=24932
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1489583003 .
 2015-11-30 13:02:31 -08:00
danrubel 6fb4f45d6b - move completion contributor extension into new DartCompletionPlugin 
- change DartCompletionContributorFactor to return single contributor rather than list of contributors
- remove server field from completion request
- update comments per prior review

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1484853002 .
 2015-11-30 13:53:22 -05:00
Brian Wilkerson 86216e5154 Consistently use implements when one interface inherits from another interface 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1481273002 .
 2015-11-30 07:58:10 -08:00
Konstantin Shcheglov 1933891bad Issue 25057. A static member cannot be implemented. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25057

Review URL: https://codereview.chromium.org/1488443002 .
 2015-11-29 19:20:25 -08:00
Brian Wilkerson 29b3e53207 Remove duplicated stack trace from error notifications 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1480663002 .
 2015-11-25 09:15:47 -08:00
Konstantin Shcheglov 6859412fac Issue 24865. Quick Fix 'Create Method' should create named parameters. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24865

Review URL: https://codereview.chromium.org/1475743003 .
 2015-11-24 14:55:39 -08:00
Konstantin Shcheglov c302b65584 Use async/await in all analysis domain tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1478513002 .
 2015-11-24 14:18:37 -08:00
Konstantin Shcheglov 67e4b7d081 Convert all 'wrong' test to 'BAD'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1469333003 .
 2015-11-24 14:02:01 -08:00
Konstantin Shcheglov cfb7d61a9c Issue 25034. Record only the target source's errors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25034

Review URL: https://codereview.chromium.org/1477553002 .
 2015-11-24 14:00:00 -08:00
danrubel d176336e59 remove redundant CompletionRequestImpl class 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1469393003 .
 2015-11-24 16:17:51 -05:00
danrubel 0168336439 create new Dart specific completion contributor extension point 
and modify DartCompletionManager to use it

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1470373002 .
 2015-11-24 16:12:55 -05:00
Konstantin Shcheglov c0c11daa15 Disable merging of 'if' statements when there are other staments in the outer one. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1473513003 .
 2015-11-24 13:06:20 -08:00
danrubel b9ad8a15e4 hook new DartCompletionContributor API into existing framework 
and convert KeywordContributor to use new DartCompletionContributor API

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1471173003 .
 2015-11-24 12:03:44 -05:00
danrubel 594183e0db Rework contribution sorter to use futures 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1470863003 .
 2015-11-23 21:35:52 -05:00
Konstantin Shcheglov 670db50707 Generate separate navigation regions for 'super' and optional 'name'. 
Also support for navigation regions for RedirectingConstructorInvocation.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1465303003 .
 2015-11-23 14:27:03 -08:00
Konstantin Shcheglov 0ae251793f Make index provisional API. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1471073002 .
 2015-11-23 12:54:55 -08:00
Brian Wilkerson 0a64b0694c Make change builder provisional API 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1468133002 .
 2015-11-23 10:18:58 -08:00
danrubel 2cbd3d3803 rename file to prevent bots from running it as a test 
Review URL: https://codereview.chromium.org/1468143002 .
 2015-11-23 13:16:57 -05:00
danrubel 38cec67d03 step toward new completion API 
- separate new CompletionContributor and DartCompletionContributor APIs
- revise new APIs and implementations to be Futures based
- revise InheritedContributor to use new Futures based contributor API
- remove unused classes

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1467023002 .
 2015-11-23 12:50:12 -05:00
Konstantin Shcheglov 1e05c35650 Issue 25021. Fix for adding new required parameters when optional exist. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25021

Review URL: https://codereview.chromium.org/1468913004 .
 2015-11-23 09:21:11 -08:00
Konstantin Shcheglov ac24bd115c Don't run 'pub list-package-dirs' if there is no pubpsec.lock file. 
This should help on DAS startup - if we don't have to run Pub, this saves as much as 400ms for each pubspec.yaml file.
Without pubspec.yaml we won't get any results anyway.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1470793002 .
 2015-11-23 09:19:10 -08:00
danrubel 6ce9b7faeb (TBR) fix completion test 
Review URL: https://codereview.chromium.org/1469963002 .
 2015-11-23 12:09:52 -05:00
danrubel 85334bed8a (TBR) update completion test to expect pass now that this is fixed #23001 
Review URL: https://codereview.chromium.org/1465143003 .
 2015-11-23 11:15:22 -05:00
danrubel b091bb0b18 general completion contributor cleanup 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1465013002 .
 2015-11-23 11:03:01 -05:00
Konstantin Shcheglov 53e9cce24d Quick assist for converting block documentation comments into line ones. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1470753002 .
 2015-11-22 19:57:03 -08:00
Konstantin Shcheglov 8c324a5b8d Propagate types of final/const top-level variables and fields. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23001

Review URL: https://codereview.chromium.org/1460213005 .
 2015-11-21 09:40:37 -08:00